wongi-engine 0.3.6 → 0.3.7

data/lib/wongi-engine/filter/asserting_test.rb

@@ -1,20 +1,17 @@
 module Wongi::Engine
-
   class AssertingTest < FilterTest
-
-    def initialize *vars, &body
+    def initialize(*vars, &body)
+      super()
       @vars = vars
       @body = body
     end
 
-    def passes? token
+    def passes?(token)
       if @vars.empty?
         @body.call token
       else
-        @body.call *( @vars.map { |var| token[var] } )
+        @body.call(*(@vars.map { |var| token[var] }))
       end
     end
-
   end
-
 end

data/lib/wongi-engine/filter/equality_test.rb

@@ -1,36 +1,33 @@
 module Wongi::Engine
-
   class EqualityTest < FilterTest
-
     attr_reader :x, :y
 
-    def initialize x, y
-      @x, @y = x, y
+    def initialize(x, y)
+      super()
+      @x = x
+      @y = y
     end
 
-    def passes? token
-
+    def passes?(token)
       x = if Template.variable? @x
-        token[@x]
-      else
-        @x
-      end
+            token[@x]
+          else
+            @x
+          end
 
       y = if Template.variable? @y
-        token[@y]
-      else
-        @y
-      end
+            token[@y]
+          else
+            @y
+          end
 
       return false if x == :_ || y == :_
-      return x == y
 
+      x == y
     end
 
-    def == other
+    def ==(other)
       super && x == other.x && y == other.y
     end
-
   end
-
 end

data/lib/wongi-engine/filter/filter_test.rb

@@ -1,18 +1,15 @@
 module Wongi::Engine
-
   class FilterTest
-
-    def passes? token
+    def passes?(_token)
       raise "#{self.class} must implement #passes?"
     end
 
-    def compile context
+    def compile(context)
       context.tap { |c| c.filter_node(self) }
     end
 
-    def == other
+    def ==(_other)
       false
     end
   end
-
 end

data/lib/wongi-engine/filter/greater_than_or_equal_test.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
+
 module Wongi::Engine
   class GreaterThanOrEqualTest < FilterTest
     attr_reader :x, :y
 
     def initialize(x, y)
+      super()
       @x = x
       @y = y
     end
@@ -13,15 +15,16 @@ module Wongi::Engine
             token[@x]
           else
             @x
-      end
+          end
 
       y = if Template.variable? @y
             token[@y]
           else
             @y
-      end
+          end
 
       return false if x == :_ || y == :_
+
       x >= y
     end
 

data/lib/wongi-engine/filter/greater_than_test.rb

@@ -1,36 +1,33 @@
 module Wongi::Engine
-
   class GreaterThanTest < FilterTest
-
     attr_reader :x, :y
 
-    def initialize x, y
-      @x, @y = x, y
+    def initialize(x, y)
+      super()
+      @x = x
+      @y = y
     end
 
-    def passes? token
-
+    def passes?(token)
       x = if Template.variable? @x
-        token[@x]
-      else
-        @x
-      end
+            token[@x]
+          else
+            @x
+          end
 
       y = if Template.variable? @y
-        token[@y]
-      else
-        @y
-      end
+            token[@y]
+          else
+            @y
+          end
 
       return false if x == :_ || y == :_
-      return x > y
 
+      x > y
     end
 
-    def == other
+    def ==(other)
       super && x == other.x && y == other.y
     end
-
   end
-
 end

data/lib/wongi-engine/filter/inequality_test.rb

@@ -1,36 +1,33 @@
 module Wongi::Engine
-
   class InequalityTest < FilterTest
-
     attr_reader :x, :y
 
-    def initialize x, y
-      @x, @y = x, y
+    def initialize(x, y)
+      super()
+      @x = x
+      @y = y
     end
 
-    def passes? token
-
+    def passes?(token)
       x = if Template.variable? @x
-        token[@x]
-      else
-        @x
-      end
+            token[@x]
+          else
+            @x
+          end
 
       y = if Template.variable? @y
-        token[@y]
-      else
-        @y
-      end
+            token[@y]
+          else
+            @y
+          end
 
       return false if x == :_ || y == :_
-      return x != y
 
+      x != y
     end
 
-    def == other
+    def ==(other)
       super && x == other.x && y == other.y
     end
-
   end
-
 end

data/lib/wongi-engine/filter/less_than_or_equal_test.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
+
 module Wongi::Engine
   class LessThanOrEqualTest < FilterTest
     attr_reader :x, :y
 
     def initialize(x, y)
+      super()
       @x = x
       @y = y
     end
@@ -13,15 +15,16 @@ module Wongi::Engine
             token[@x]
           else
             @x
-      end
+          end
 
       y = if Template.variable? @y
             token[@y]
           else
             @y
-      end
+          end
 
       return false if x == :_ || y == :_
+
       x <= y
     end
 

data/lib/wongi-engine/filter/less_than_test.rb

@@ -1,36 +1,33 @@
 module Wongi::Engine
-
   class LessThanTest < FilterTest
-
     attr_reader :x, :y
 
-    def initialize x, y
-      @x, @y = x, y
+    def initialize(x, y)
+      super()
+      @x = x
+      @y = y
     end
 
-    def passes? token
-
+    def passes?(token)
       x = if Template.variable? @x
-        token[@x]
-      else
-        @x
-      end
+            token[@x]
+          else
+            @x
+          end
 
       y = if Template.variable? @y
-        token[@y]
-      else
-        @y
-      end
+            token[@y]
+          else
+            @y
+          end
 
       return false if x == :_ || y == :_
-      return x < y
 
+      x < y
     end
 
-    def == other
+    def ==(other)
       super && x == other.x && y == other.y
     end
-
   end
-
 end

data/lib/wongi-engine/filter.rb

@@ -5,4 +5,4 @@ require 'wongi-engine/filter/asserting_test'
 require 'wongi-engine/filter/less_than_test'
 require 'wongi-engine/filter/greater_than_test'
 require 'wongi-engine/filter/less_than_or_equal_test'
-require 'wongi-engine/filter/greater_than_or_equal_test'
+require 'wongi-engine/filter/greater_than_or_equal_test'

data/lib/wongi-engine/graph.rb

@@ -1,16 +1,13 @@
 module Wongi::Engine
-
   class Graph
-
-    def initialize rete
+    def initialize(rete)
       @rete = rete
     end
 
-    def dot io, opts = { }
-
+    def dot(io, opts = {})
       @seen_betas = []
 
-      if String === io
+      if io.is_a?(String)
         File.open io, "w" do |actual_io|
           dot actual_io
         end
@@ -25,49 +22,45 @@ module Wongi::Engine
       dump_betas(opts)
 
       @io.puts "}"
-
     ensure
       @io = nil
     end
 
     private
 
-    def print_hash h
-      h.to_s.gsub /-/, '_'
+    def print_hash(h)
+      h.to_s.gsub(/-/, '_')
     end
 
-    def dump_alphas opts
+    def dump_alphas(_opts)
       @io.puts "subgraph cluster_alphas {"
-      @rete.alphas.select { |alpha| not alpha.betas.empty? }.each do |alpha|
-        @io.puts "node#{print_hash alpha.object_id} [shape=box label=\"#{alpha.template.to_s.gsub /"/, "\\\""}\"];"
+      @rete.alphas.reject { |alpha| alpha.betas.empty? }.each do |alpha|
+        @io.puts "node#{print_hash alpha.object_id} [shape=box label=\"#{alpha.template.to_s.gsub(/"/, '"')}\"];"
       end
       @io.puts "};"
     end
 
-    def dump_betas opts
+    def dump_betas(opts)
       dump_beta @rete.beta_top, opts
     end
 
-    def dump_beta beta, opts
+    def dump_beta(beta, opts)
       return if @seen_betas.include? beta
+
       @seen_betas << beta
       @io.puts "node#{print_hash beta.object_id} [label=\"#{beta.class.name.split('::').last}\"];"
       if beta.is_a? NccNode
         @io.puts "node#{print_hash beta.partner.object_id} -> node#{print_hash beta.object_id};"
         @io.puts "{ rank=same; node#{print_hash beta.partner.object_id} node#{print_hash beta.object_id} }"
       end
-      if beta.respond_to? :alpha and opts[:alpha] != false
+      if beta.respond_to?(:alpha) && opts[:alpha] != false
         alpha = beta.alpha
-        if alpha
-          @io.puts "node#{print_hash alpha.object_id} -> node#{print_hash beta.object_id};"
-        end
+        @io.puts "node#{print_hash alpha.object_id} -> node#{print_hash beta.object_id};" if alpha
       end
       beta.children.each do |child|
         @io.puts "node#{print_hash beta.object_id} -> node#{print_hash child.object_id};"
         dump_beta child, opts
       end
     end
-
   end
-
 end

data/lib/wongi-engine/network/collectable.rb

@@ -1,12 +1,10 @@
 module Wongi::Engine
   module NetworkParts
-
     module Collectable
-
-      def collectors name = nil
-        @collectors ||= { }
+      def collectors(name = nil)
+        @collectors ||= {}
         if name
-          @collectors[name] ||= [ ]
+          @collectors[name] ||= []
         else
           @collectors
         end
@@ -16,27 +14,25 @@ module Wongi::Engine
         collectors :error
       end
 
-      def add_collector collector, name
-        collectors( name ) << collector
+      def add_collector(collector, name)
+        collectors(name) << collector
       end
 
       def add_error_collector
         add_collector collector, :error
       end
 
-      def collection name
-        collectors( name ).map( &:default_collect ).flatten.uniq
+      def collection(name)
+        collectors(name).map(&:default_collect).flatten.uniq
       end
 
       def errors
-        error_collectors.map( &:errors ).flatten
+        error_collectors.map(&:errors).flatten
       end
 
-      def collected_tokens name
-        collectors( name ).map { |collector| collector.production.tokens }.flatten
+      def collected_tokens(name)
+        collectors(name).map { |collector| collector.production.tokens }.flatten
       end
-
     end
-
   end
 end

data/lib/wongi-engine/network/debug.rb

@@ -1,25 +1,21 @@
 module Wongi::Engine
-
   module NetworkParts
-
     module Debug
-
       def full_wme_dump
         @timeline.each_with_index do |slice, index|
-          puts "time #{ index - @timeline.length }"
-          slice.each do |key, alpha|
-            puts "\t#{alpha.template} -> [#{alpha.wmes.map(&:to_s).join ", "}]"
+          puts "time #{index - @timeline.length}"
+          slice.each do |_key, alpha|
+            puts "\t#{alpha.template} -> [#{alpha.wmes.map(&:to_s).join ', '}]"
           end
           puts ""
         end
         puts "time 0"
-        alpha_hash.each do |key, alpha|
-          puts "\t#{alpha.template} -> [#{alpha.wmes.map(&:to_s).join ", "}]"
+        alpha_hash.each do |_key, alpha|
+          puts "\t#{alpha.template} -> [#{alpha.wmes.map(&:to_s).join ', '}]"
         end
       end
 
-      def full_dump io = $stdout
-
+      def full_dump(io = $stdout)
         alpha_hash.each_value do |alpha|
           io.puts "ALPHA #{alpha.template}"
           alpha.wmes.each do |wme|
@@ -27,12 +23,11 @@ module Wongi::Engine
           end
         end
         dump_beta beta_top, io
-
       end
 
       private
 
-      def token_lineage token
+      def token_lineage(token)
         result = []
         while token.parent
           result << token.parent
@@ -41,14 +36,14 @@ module Wongi::Engine
         result
       end
 
-      def dump_wme wme, io
+      def dump_wme(wme, io)
         io.puts "\tWME: #{wme.object_id} #{wme}"
         wme.tokens.each { |token| io.puts "\t\tTOKEN #{token.object_id}" }
         io.puts "\tGENERATING:" unless wme.generating_tokens.empty?
         wme.generating_tokens.each { |token| io.puts "\t\tTOKEN #{token.object_id}" }
       end
 
-      def dump_beta beta, io
+      def dump_beta(beta, io)
         case beta
         when BetaMemory
           dump_beta_memory beta, io
@@ -58,28 +53,25 @@ module Wongi::Engine
           io.puts "BETA #{beta.object_id} #{beta.class} : TODO"
 
         end
-        io.puts "\tCHILDREN: #{beta.children.map(&:object_id).join ", "}"
+        io.puts "\tCHILDREN: #{beta.children.map(&:object_id).join ', '}"
         beta.children.each { |child| dump_beta child, io } unless beta.children.empty?
       end
 
-      def dump_beta_memory beta, io
+      def dump_beta_memory(beta, io)
         io.puts "BETA MEMORY #{beta.object_id}"
         beta.tokens.each { |token|
-          io.puts "\tTOKEN #{token.object_id} [#{token_lineage(token).map(&:object_id).map(&:to_s).join(" - ")}]"
-          token.wmes.each { |wme| io.puts "\t\tWME " + wme.object_id.to_s }
+          io.puts "\tTOKEN #{token.object_id} [#{token_lineage(token).map(&:object_id).map(&:to_s).join(' - ')}]"
+          token.wmes.each { |wme| io.puts "\t\tWME #{wme.object_id}" }
         }
       end
 
-      def dump_ncc beta, io
+      def dump_ncc(beta, io)
         io.puts "NCC #{beta.object_id}"
         beta.tokens.each { |token|
-          io.puts "\tTOKEN #{token.object_id} [#{token_lineage(token).map(&:object_id).map(&:to_s).join(" - ")}]"
-          token.wmes.each { |wme| io.puts "\t\tWME " + wme.object_id.to_s }
+          io.puts "\tTOKEN #{token.object_id} [#{token_lineage(token).map(&:object_id).map(&:to_s).join(' - ')}]"
+          token.wmes.each { |wme| io.puts "\t\tWME #{wme.object_id}" }
         }
       end
-
     end
-
   end
-
 end