wongi-engine 0.0.17 → 0.1.0.alpha1

data/spec/bug_specs/issue_4_spec.rb

@@ -56,7 +56,8 @@ describe "issue 4" do
 
   end
 
-  it "should correctly retract later items from within a rule" do
+  # cascaded processing affects this
+  it "should not retract later items from within a rule", :debug do
 
     engine = Wongi::Engine.create
 
@@ -74,7 +75,7 @@ describe "issue 4" do
             engine.retract [number, :is_number, true]
             engine.retract [number + 1, :is_number, true]
           else
-            # this should never be reached
+            # this is not reached without cascades
             engine << [number, :is_odd, true]
           end
         }
@@ -86,8 +87,8 @@ describe "issue 4" do
     odds = engine.select :_, :is_odd, true
 
     expect(numbers).to be_empty
-    expect(evens.length).to eq(5)
-    expect(odds).to be_empty
+    expect(evens).to have(5).items
+    expect(odds).to have(5).items
 
   end
 

data/spec/filter_specs/assert_test_spec.rb

@@ -28,7 +28,7 @@ describe "ASSERT test" do
       }
     }
 
-    expect(production.size).to eq(1)
+    expect(production).to have(1).token
     
   end
 
@@ -42,7 +42,7 @@ describe "ASSERT test" do
       }
     }
 
-    expect(production.size).to eq(0)
+    expect(production).to have(0).tokens
 
   end
 
@@ -59,11 +59,28 @@ describe "ASSERT test" do
 
     engine << ["resistance", "is", "futile"]
 
-    expect(production.size).to eq(1)
+    expect(production).to have(1).token
     expect(production.tokens.first[:X]).to eq("resistance")
 
   end
 
+  it "should be retractable" do
+
+    test_rule {
+      forall {
+        has :X, "is", :Y
+        assert { |token|
+          token[:X] == "resistance"
+        }
+      }
+    }
+
+    engine << ["resistance", "is", "futile"]
+    engine.retract ["resistance", "is", "futile"]
+    expect(production).to have(0).tokens
+
+  end
+
   it "should use individual variables with arguments" do
 
     test_rule {
@@ -77,7 +94,7 @@ describe "ASSERT test" do
 
     engine << ["resistance", "is", "futile"]
 
-    expect(production.size).to eq(1)
+    expect(production).to have(1).token
     expect(production.tokens.first[:X]).to eq("resistance")
 
   end

data/spec/network_spec.rb

@@ -0,0 +1,182 @@
+require 'spec_helper'
+
+describe Wongi::Engine::Network do
+
+  let( :engine ) { Wongi::Engine.create }
+  subject { engine }
+
+  it 'should assert facts' do
+    subject << [1,2,3]
+    expect( subject.select( :_, 2, :_) ).to have(1).item
+  end
+
+  it 'should retract facts' do
+    subject << [1,2,3]
+    subject.retract [1,2,3]
+    expect( subject.select( :_, 2, :_) ).to be_empty
+  end
+
+  it 'asserted facts end up in productions' do
+
+    prod = subject << rule { forall { has :X, 2, :Z } }
+    subject << [1,2,3]
+    expect( prod ).to have(1).tokens
+
+  end
+
+  it 'retracted facts are removed from productions' do
+
+    prod = subject << rule { forall { has :X, 2, :Z } }
+    subject << [1,2,3]
+    subject.retract [1,2,3]
+    expect( prod ).to have(0).tokens
+
+  end
+
+  it 'retracted facts should trigger deactivation' do
+
+    activated_z = nil
+    deactivated_z = nil
+
+    prod = subject << rule {
+      forall { has :X, 2, :Z }
+      make {
+        action activate: ->(token) { activated_z = token[:Z] },
+               deactivate: ->(token) { deactivated_z = token[:Z] }
+      }
+    }
+    subject << [1,2,3]
+    expect( activated_z ).to be == 3
+
+    subject.retract [1,2,3]
+    expect( deactivated_z ).to be == 3
+
+  end
+
+  it 'retracted facts should propagate through join chains' do
+
+    deactivated = nil
+
+    prod = engine << rule {
+      forall {
+        has :X, :is, :Y
+        has :Y, :is, :Z
+      }
+      make {
+        action deactivate: ->(token) { deactivated = token }
+      }
+    }
+
+    engine << [1, :is, 2]
+    engine << [2, :is, 3]
+
+    expect( prod ).to have(1).tokens
+
+    engine.retract [1, :is, 2]
+    expect( prod ).to have(0).tokens
+    expect( deactivated[:X] ).to be == 1
+    expect( deactivated[:Y] ).to be == 2
+    expect( deactivated[:Z] ).to be == 3
+
+  end
+
+  it 'retraction should reactivate neg nodes' do
+
+    prod = engine << rule { forall { neg 1, 2, 3} }
+
+    expect( prod ).to have(1).tokens
+
+    engine << [1, 2 ,3]
+    expect( prod ).to have(0).tokens
+
+    engine.retract [1, 2, 3]
+    expect( prod ).to have(1).tokens
+
+  end
+
+  describe 'retraction with neg nodes lower in the chain' do
+
+    def expect_tokens n
+      expect( prod ).to have(n).tokens
+    end
+
+    before :each do
+
+      engine << rule('retract') {
+        forall {
+          has :x, :u, :Y
+          neg :Y, :w, :_
+        }
+      }
+
+    end
+
+    let( :prod ) { engine.productions['retract'] }
+
+    specify 'case 1' do
+
+      engine << [:x, :u, :y]
+      expect_tokens 1
+
+      engine << [:y, :w, :z]
+      expect_tokens 0
+
+      engine.retract [:y, :w, :z]
+      expect_tokens 1
+
+      engine.retract [:x, :u, :y]
+      expect_tokens 0
+
+    end
+
+    specify 'case 2' do
+
+      engine << [:x, :u, :y]
+      expect_tokens 1
+
+      engine << [:y, :w, :z]
+      expect_tokens 0
+
+      engine.retract [:x, :u, :y]
+      expect_tokens 0
+
+      engine.retract [:y, :w, :z]
+      expect_tokens 0
+
+    end
+
+    specify 'case 3' do
+
+      engine << [:y, :w, :z]
+      expect_tokens 0
+
+      engine << [:x, :u, :y]
+      expect_tokens 0
+
+      engine.retract [:x, :u, :y]
+      expect_tokens 0
+
+      engine.retract [:y, :w, :z]
+      expect_tokens 0
+
+    end
+
+    specify 'case 4' do
+
+      engine << [:y, :w, :z]
+      expect_tokens 0
+
+      engine << [:x, :u, :y]
+      expect_tokens 0
+
+      engine.retract [:y, :w, :z]
+      expect_tokens 1
+
+      engine.retract [:x, :u, :y]
+      expect_tokens 0
+
+    end
+
+  end
+
+end

data/spec/rule_specs/assign_spec.rb

@@ -2,25 +2,11 @@ require 'spec_helper'
 
 describe "ASSIGN rule" do
 
-  before :each do
-    @engine = Wongi::Engine.create
-  end
-
-  def engine
-    @engine
-  end
-
-  def production
-    @production
-  end
-
-  def test_rule &block
-    @production = ( engine << rule( 'test-rule', &block ) )
-  end
+  let( :engine ) { Wongi::Engine.create }
 
   it "should assign simple expressions" do
 
-    test_rule {
+    production = engine << rule {
       forall {
         assign :X do
           42
@@ -34,7 +20,7 @@ describe "ASSIGN rule" do
 
   it "should be able to access previous assignments" do
 
-    test_rule {
+    production = engine << rule {
       forall {
         has 1, 2, :X
         assign :Y do |token|
@@ -48,4 +34,22 @@ describe "ASSIGN rule" do
 
   end
 
+  it 'should be deactivatable', :debug do
+
+    prod = engine << rule {
+      forall {
+        has 1, 2, :X
+        assign :Y do |token|
+          token[:X] * 2
+        end
+      }
+    }
+
+    engine << [1, 2, 5]
+    engine.retract [1, 2, 5]
+
+    expect( prod ).to have(0).tokens
+
+  end
+
 end

data/spec/rule_specs/maybe_rule_spec.rb

@@ -2,24 +2,19 @@ require "spec_helper"
 
 describe "MAYBE rule" do
 
-  before :each do
-    @engine = Wongi::Engine.create
-  end
-
-  def engine
-    @engine
-  end
-
-  it "should pass with existing facts" do
-
-    engine << rule('test') do
+  let( :engine ) { Wongi::Engine.create }
+  let( :maybe_rule ) {
+    rule {
       forall {
         has 1, 2, :X
         maybe :X, 4, :Y
       }
-    end
+    }
+  }
 
-    production = engine.productions['test']
+  it "should pass with existing facts" do
+
+    production = engine << maybe_rule
 
     engine << [1, 2, 3]
     engine << [3, 4, 5]
@@ -33,14 +28,7 @@ describe "MAYBE rule" do
 
   it "should pass with missing facts" do
 
-    engine << rule('test') do
-      forall {
-        has 1, 2, :X
-        maybe :X, 4, :Y
-      }
-    end
-
-    production = engine.productions['test']
+    production = engine << maybe_rule
 
     engine << [1, 2, 3]
 
@@ -55,14 +43,7 @@ describe "MAYBE rule" do
 
     engine << [1, 2, 3]
 
-    engine << rule('test') do
-      forall {
-        has 1, 2, :X
-        maybe :X, 4, :Y
-      }
-    end
-
-    production = engine.productions['test']
+    production = engine << maybe_rule
 
     expect(production.size).to eq(1)
 
@@ -71,4 +52,50 @@ describe "MAYBE rule" do
 
   end
 
+  it 'should pass with retracted facts', :debug do
+
+    prod = engine << maybe_rule
+
+    engine << [1, 2, 3]
+    engine << [3, 4, 5]
+    engine.retract [3, 4, 5]
+
+    expect(prod.size).to eq(1)
+
+    expect(prod.tokens.first[:X]).to eq(3)
+    expect(prod.tokens.first[:Y]).to be_nil
+
+  end
+
+  it 'should work with repeated activations' do
+
+    prod = engine << maybe_rule
+
+    engine << [1, 2, 3]
+    engine << [3, 4, 5]
+    engine.retract [3, 4, 5]
+
+    10.times {
+      engine << [3, 4, 5]
+      expect(prod.size).to eq(1)
+      expect(prod.tokens.first[:Y]).to be == 5
+
+      engine.retract [3, 4, 5]
+      expect(prod.size).to eq(1)
+      expect(prod.tokens.first[:Y]).to be_nil
+    }
+
+  end
+
+  it 'should handle retracted parent tokens' do
+    prod = engine << maybe_rule
+
+    engine << [1, 2, 3]
+    engine << [3, 4, 5]
+    engine.retract [1, 2, 3]
+
+    expect(prod).to have(0).tokens
+    expect(engine.find(3,4,5).opt_join_results).to be_empty
+  end
+
 end

data/spec/rule_specs/ncc_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "NCC rule" do
+describe Wongi::Engine::NccNode do
 
   before :each do
     @engine = Wongi::Engine.create
@@ -42,15 +42,15 @@ describe "NCC rule" do
 
     engine << ["base", "is", 1]
 
-    expect(production.size).to eq(1)
+    expect(production).to have(1).token
 
     engine << [1, 2, 3]
 
-    expect(production.size).to eq(1)
+    expect(production).to have(1).token
 
     engine << [3, 4, 5]
 
-    expect(production.size).to eq(0)
+    expect(production).to have(0).token
 
   end
 
@@ -63,13 +63,13 @@ describe "NCC rule" do
     engine << [1, 2, 3]
     engine << [3, 4, 5]
 
-    expect(production.size).to eq(0)
+    expect(production).to have(0).tokens
 
     engine.retract [3, 4, 5]
     expect( production ).to have(1).token
 
     engine.retract ["base", "is", 1]
-    expect(production.size).to eq(0)
+    expect(production).to have(0).tokens
 
   end
 

data/spec/spec_helper.rb

@@ -1,3 +1,2 @@
 require 'wongi-engine'
 require 'rspec/collection_matchers'
-require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wongi-engine
 version: !ruby/object:Gem::Version
-  version: 0.0.17
+  version: 0.1.0.alpha1
 platform: ruby
 authors:
 - Valeri Sokolov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-26 00:00:00.000000000 Z
+date: 2015-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -16,48 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.2'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.2'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +60,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".hgtags"
 - ".ruby-gemset"
 - ".travis.yml"
 - Gemfile
@@ -150,6 +131,7 @@ files:
 - spec/filter_specs/assert_test_spec.rb
 - spec/filter_specs/less_test_spec.rb
 - spec/high_level_spec.rb
+- spec/network_spec.rb
 - spec/rule_specs/any_rule_spec.rb
 - spec/rule_specs/assign_spec.rb
 - spec/rule_specs/assuming_spec.rb
@@ -160,7 +142,6 @@ files:
 - spec/simple_action_spec.rb
 - spec/spec_helper.rb
 - spec/wme_spec.rb
-- wongi-engine.gemspec
 homepage: https://github.com/ulfurinn/wongi-engine
 licenses:
 - MIT
@@ -176,9 +157,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5
@@ -193,6 +174,7 @@ test_files:
 - spec/filter_specs/assert_test_spec.rb
 - spec/filter_specs/less_test_spec.rb
 - spec/high_level_spec.rb
+- spec/network_spec.rb
 - spec/rule_specs/any_rule_spec.rb
 - spec/rule_specs/assign_spec.rb
 - spec/rule_specs/assuming_spec.rb

data/wongi-engine.gemspec

@@ -1,23 +0,0 @@
-# -*- encoding: utf-8 -*-
-require File.expand_path('../lib/wongi-engine/version', __FILE__)
-
-Gem::Specification.new do |gem|
-  gem.authors       = ["Valeri Sokolov"]
-  gem.email         = ["ulfurinn@ulfurinn.net"]
-  gem.description   = %q{A rule engine.}
-  gem.summary       = %q{A forward-chaining rule engine in pure Ruby.}
-  gem.homepage      = "https://github.com/ulfurinn/wongi-engine"
-  gem.licenses      = %w(MIT)
-
-  gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name          = "wongi-engine"
-  gem.require_paths = ["lib"]
-  gem.version       = Wongi::Engine::VERSION
-
-  gem.add_development_dependency 'rake', '~> 10'
-  gem.add_development_dependency 'pry', '~> 0.10'
-  gem.add_development_dependency 'rspec', '~> 3.1', '< 3.2'
-  gem.add_development_dependency 'rspec-collection_matchers', '~> 1.1'
-end