wongi-engine 0.0.14 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba0f7c9c09df2f3f379bc1983b32807770014d54
-  data.tar.gz: 12b8b964c0b03c205ac0e44cdcfe8f10f14c7f34
+  metadata.gz: 685d73d3400c03903114505a66f2bb6ca6ca8ba2
+  data.tar.gz: ac0de44ac50ad33b7a040bcc786e82f50fa16946
 SHA512:
-  metadata.gz: 3e5ea34e087ef89954e1f5543d394883c2c2173c02d4764e816d97c9b764b6f73eed2b247f08033edab3127f752e7417686d0b61853250c533145274304126f7
-  data.tar.gz: 59c4f2e6af5b95a8d607f5c0bee99885fff6d302fef96f3d45320bada13ae2f5548788196b82cc83f6e3ada93a02c0c966eceaeaf29d8f75f1561c2f3459422e
+  metadata.gz: 6d9402a2c69eda4a5262b66fefdba7212c20e62f5a98a3b9290e0279de58ec7d0a0631ee71cf106bc0dbfd0545302d3665bf4e233f630a1ff907b22203d91933
+  data.tar.gz: 231b6574013f60209ea5debf67bc81afa575fa112861d9afc1a78ef9b098af16985c9fff9f0ca73393e474abba3e263b44f3a6b219dc051b8229ea36ff8619ac

data/.travis.yml

@@ -0,0 +1,8 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.5
+  - 2.2.0
+  - rbx-2.4.1
+  - jruby-19mode

data/README.md

@@ -2,19 +2,11 @@
 
 This library contains a rule engine written in Ruby. It's based on the [Rete algorithm](http://en.wikipedia.org/wiki/Rete_algorithm) and uses a DSL to express rules in a readable way.
 
-## Installation
+[![Build Status](https://travis-ci.org/ulfurinn/wongi-engine.svg?branch=master)](https://travis-ci.org/ulfurinn/wongi-engine) (MRI 1.9.3, 2.0, 2.1, 2.2, Rubinius, JRuby)
 
-Add this line to your application's Gemfile:
+## Word of caution
 
-    gem 'wongi-engine'
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install wongi-engine
+This is complex and fragile machinery, and there may be subtle bugs that are only revealed with nontrivial usage. Please test your rules extensively and report any behaviour that is not consistent with your expectations.
 
 ## Tutorial
 

data/lib/wongi-engine/beta/beta_memory.rb

@@ -29,13 +29,11 @@ module Wongi::Engine
 
     def beta_activate token, wme, assignments
       dp "MEMORY beta-activated with #{wme} #{wme.object_id}"
-      t = Token.new( token, wme, assignments)
-      t.node = self
-      existing = @tokens.find { |et| et.duplicate? t }
+      existing = @tokens.reject(&:deleted?).find { |et| et.duplicate? self, token, wme, assignments }
       if existing
         t = existing
       else
-        dp "generated token #{t}"
+        t = Token.new( token, wme, assignments)
         t.node = self
         @tokens << t
       end
@@ -46,6 +44,7 @@ module Wongi::Engine
           child.beta_activate t
         end
       end
+      t
     end
 
     def refresh_child child

data/lib/wongi-engine/beta/beta_node.rb

@@ -135,6 +135,11 @@ module Wongi::Engine
       @tokens.empty?
     end
 
+    def size
+      @tokens.size
+    end
+    alias_method :length, :size
+
     private
 
     def propagate_activation token, wme, assignments

data/lib/wongi-engine/beta/neg_node.rb

@@ -1,94 +1,92 @@
-module Wongi
-  module Engine
-
-    NegJoinResult = Struct.new :owner, :wme
-
-    class NegNode < BetaNode
-
-      attr_reader :tokens, :alpha, :tests
-
-      def initialize parent, tests, alpha, unsafe
-        super(parent)
-        @tests, @alpha, @unsafe = tests, alpha, unsafe
-        @tokens = []
-      end
-
-      def alpha_activate wme
-        self.tokens.each do |token|
-          if matches?( token, wme ) && ( @unsafe || ! token.generated?( wme ) )# feedback loop protection
-            # order matters for proper invalidation
-            make_join_result(token, wme)
-            token.delete_children #if token.neg_join_results.empty? # TODO why was this check here? it seems to break things
-          end
-        end
-      end
-
-      def beta_activate token, newwme, assignments
-        t = Token.new( token, newwme, assignments)
-        t.node = self
-        existing = @tokens.find { |et| et.duplicate? t }
-        if existing
-          t = existing
-        else
-          dp "generated token #{t}"
-          t.node = self
-          @tokens << t
-        end
-        @alpha.wmes.each do |wme|
-          if matches?( t, wme )
-            make_join_result(t, wme)
-          end
-        end
-        if t.neg_join_results.empty?
-          self.children.each do |child|
-            child.beta_activate t, nil, {}
-          end
-        end
-      end
-
-      def refresh_child child
-        safe_tokens.each do |token|
-          if token.neg_join_results.empty?
-            child.beta_activate token, nil, {}
-          end
-        end
-        alpha.wmes.each do |wme|
-          alpha_activate wme
-        end
-      end
-
-      def delete_token token
-        tokens.delete token
-        token.neg_join_results.each do |njr|
-          njr.wme.neg_join_results.delete njr if njr.wme
-        end
-        token.neg_join_results.clear
-      end
-
-      protected
-
-      def matches? token, wme
-        puts "matching #{wme} against #{token}" if debug?
-        @tests.each do |test|
-          return false unless test.matches?( token, wme )
-        end
-        true
-      end
-
-      def make_join_result token, wme
-        njr = NegJoinResult.new token, wme
-        token.neg_join_results << njr
-        wme.neg_join_results << njr
-      end
-
-      def safe_tokens
-        Enumerator.new do |y|
-          @tokens.dup.each do |token|
-            y << token unless token.deleted?
-          end
-        end
-      end
-
-    end
-  end
-end
+module Wongi
+  module Engine
+
+    NegJoinResult = Struct.new :owner, :wme
+
+    class NegNode < BetaNode
+
+      attr_reader :tokens, :alpha, :tests
+
+      def initialize parent, tests, alpha, unsafe
+        super(parent)
+        @tests, @alpha, @unsafe = tests, alpha, unsafe
+        @tokens = []
+      end
+
+      def alpha_activate wme
+        self.tokens.each do |token|
+          if matches?( token, wme ) && ( @unsafe || ! token.generated?( wme ) )# feedback loop protection
+            # order matters for proper invalidation
+            make_join_result(token, wme)
+            token.delete_children #if token.neg_join_results.empty? # TODO why was this check here? it seems to break things
+          end
+        end
+      end
+
+      def beta_activate token, newwme, assignments
+        existing = @tokens.find { |et| et.duplicate? self, token, newwme, assignments }
+        if existing
+          t = existing
+        else
+          t = Token.new( token, newwme, assignments)
+          t.node = self
+          @tokens << t
+        end
+        @alpha.wmes.each do |wme|
+          if matches?( t, wme )
+            make_join_result(t, wme)
+          end
+        end
+        if t.neg_join_results.empty?
+          self.children.each do |child|
+            child.beta_activate t, nil, {}
+          end
+        end
+      end
+
+      def refresh_child child
+        safe_tokens.each do |token|
+          if token.neg_join_results.empty?
+            child.beta_activate token, nil, {}
+          end
+        end
+        alpha.wmes.each do |wme|
+          alpha_activate wme
+        end
+      end
+
+      def delete_token token
+        tokens.delete token
+        token.neg_join_results.each do |njr|
+          njr.wme.neg_join_results.delete njr if njr.wme
+        end
+        token.neg_join_results.clear
+      end
+
+      protected
+
+      def matches? token, wme
+        puts "matching #{wme} against #{token}" if debug?
+        @tests.each do |test|
+          return false unless test.matches?( token, wme )
+        end
+        true
+      end
+
+      def make_join_result token, wme
+        njr = NegJoinResult.new token, wme
+        token.neg_join_results << njr
+        wme.neg_join_results << njr
+      end
+
+      def safe_tokens
+        Enumerator.new do |y|
+          @tokens.dup.each do |token|
+            y << token unless token.deleted?
+          end
+        end
+      end
+
+    end
+  end
+end

data/lib/wongi-engine/beta/production_node.rb

@@ -12,8 +12,7 @@ module Wongi
       end
 
       def beta_activate token, wme, assignments
-        super
-        generated = @tokens.last
+        generated = super
         @actions.each do |action|
           # @tokens.each do |t|
           #  action.execute t

data/lib/wongi-engine/dsl/actions/statement_generator.rb

@@ -1,55 +1,55 @@
-module Wongi::Engine
-  class StatementGenerator < Action
-
-    def initialize template
-      @template = template
-    end
-
-    def execute token
-
-      subject = if Template.variable?( @template.subject )
-        v = token[ @template.subject ]
-        raise "Unbound variable #{@template.subject} in token #{token}" if v.nil?
-        v
-      else
-        @template.subject
-      end
-
-      predicate = if Template.variable?( @template.predicate )
-        v = token[ @template.predicate ]
-        raise "Unbound variable #{@template.predicate} in token #{token}" if v.nil?
-        v
-      else
-        @template.predicate
-      end
-
-      object = if Template.variable?( @template.object )
-        v = token[ @template.object ]
-        raise "Unbound variable #{@template.object} in token #{token}" if v.nil?
-        v
-      else
-        @template.object
-      end
-
-      # link to rete here to ensure proper linking with token
-      wme = WME.new subject, predicate, object, rete
-
-      production.tracer.trace( action: self, wme: wme ) if production.tracer
-      if existing = rete.exists?( wme )
-        generated = existing.generating_tokens.size
-        if generated > 0 && ! token.generated_wmes.include?( existing )
-          token.generated_wmes << existing
-          existing.generating_tokens << token
-        end
-      else
-        token.generated_wmes << wme
-        wme.generating_tokens << token
-        # this MUST be done after we link the wme and the token
-        # in order for neg rule invalidation to work
-        rete << wme
-      end
-
-    end
-
-  end
-end
+module Wongi::Engine
+  class StatementGenerator < Action
+
+    def initialize template
+      @template = template
+    end
+
+    def execute token
+
+      subject = if Template.variable?( @template.subject )
+        v = token[ @template.subject ]
+        raise "Unbound variable #{@template.subject} in token #{token}" if v.nil?
+        v
+      else
+        @template.subject
+      end
+
+      predicate = if Template.variable?( @template.predicate )
+        v = token[ @template.predicate ]
+        raise "Unbound variable #{@template.predicate} in token #{token}" if v.nil?
+        v
+      else
+        @template.predicate
+      end
+
+      object = if Template.variable?( @template.object )
+        v = token[ @template.object ]
+        raise "Unbound variable #{@template.object} in token #{token}" if v.nil?
+        v
+      else
+        @template.object
+      end
+
+      # link to rete here to ensure proper linking with token
+      wme = WME.new subject, predicate, object, rete
+
+      production.tracer.trace( action: self, wme: wme ) if production.tracer
+      if existing = rete.exists?( wme )
+        generated = existing.generating_tokens.size
+        if generated > 0 && ! token.generated_wmes.include?( existing )
+          token.generated_wmes << existing
+          existing.generating_tokens << token
+        end
+      else
+        token.generated_wmes << wme
+        wme.generating_tokens << token
+        # this MUST be done after we link the wme and the token
+        # in order for neg rule invalidation to work
+        rete << wme
+      end
+
+    end
+
+  end
+end