with_transactional_lock 2.0.1 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1ce902a567cad70abdbda27991f1237e06c41a2bf7c28c85d48560ecb01ccb5
-  data.tar.gz: '018ee632496ea69c1cb860a22143415105321a0150cd87cf975e585f2c3b2e99'
+  metadata.gz: 5e23e87e0f583421cd8059c2357cb938189754803f981411f6dac9111ba128df
+  data.tar.gz: 7294f251168099acfad4122609c6a0d5b2debb17edb6a66ebc65e5ea87f1efdb
 SHA512:
-  metadata.gz: 5817b5fde890a9f9ca5bf8857bbc01fa6f540ed12394b472cd1a743f9441faee31cb829d570f9ab0f6b352f3f751c3c4a774b941eb492939a3caf41ad5ee793d
-  data.tar.gz: 4a3a791d02758d6fe27ad4d7bc64282e50b5a0dd3e3711197bb89d2e5566adb3ee6f3013b5809a7489aa6c72c27d1045e12a2ee23d35ba433e45985519004622
+  metadata.gz: 1e4984a3ea1ceda7c6a163b99eff34f6364ab37038da8a26e15ed01d5527a8775ac70b33db4c6dcbb8a8385528a62bdadb39a2983e05036a269f630a94b72338
+  data.tar.gz: 7f1a85d1c4372eaee6406cb95a8c3c7b45bd35b8ac3248d321c212e06b37f033a4628a4d29ce358d6fcef200e90a671405c9537b3bcf791f0f56f3d787aa5a0b

data/README.md

@@ -1,7 +1,5 @@
 # with_transactional_lock
 
-[![Build Status](https://travis-ci.com/Betterment/with_transactional_lock.svg?token=6b6DErRMUHX47kEoBZ3t&branch=master)](https://travis-ci.com/Betterment/with_transactional_lock)
-
 A simple extension to ActiveRecord for performing advisory locking on
 MySQL and PostgreSQL.
 
@@ -102,12 +100,6 @@ with the name that you provided. Your block is free to execute its
 critical work. Upon completion of your transaction, the lock will be 
 released.
 
-### Publishing the gem
-
-If you make changes to this gem, you will need to publish the changes to a new version on Github Packages, where the private Betterment RubyGems registry is. 
-
-For instructions on how to publish this gem, read this article on ["Publishing Internal Gems" from the Betterment Engineering Wiki](https://betterconfluence.atlassian.net/wiki/spaces/BetterEng/pages/2840952833/Publishing+Internal+Gems).
-
 ## Supported databases
 
 ### PostgreSQL

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -30,12 +32,13 @@ if (Rails.env.development? || Rails.env.test?) && defined? Dummy
 
   task(:default).clear
   if ENV['APPRAISAL_INITIALIZED'] || ENV['CI']
+    tasks = [:spec]
     tasks += [:rubocop] unless ENV['CI']
 
-    task default: tasks
+    task default: tasks # rubocop:disable Rake/DuplicateTask
   else
     require 'appraisal'
     Appraisal::Task.new
-    task default: :appraisal
+    task default: :appraisal # rubocop:disable Rake/DuplicateTask
   end
 end

data/lib/generators/with_transactional_lock/install/install_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails/generators/base'
 require 'rails/generators/active_record'
 
@@ -27,7 +29,7 @@ module WithTransactionalLock
       private
 
       def mysql?
-        ActiveRecord::Base.connection.adapter_name.downcase =~ /mysql/
+        ActiveRecord::Base.connection.adapter_name.downcase.include?('mysql')
       end
     end
   end

data/lib/generators/with_transactional_lock/install/templates/db/migrate/create_transactional_advisory_locks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateTransactionalAdvisoryLocks < ActiveRecord::Migration
   def change
     create_table :transactional_advisory_locks, id: false do |t|

data/lib/with_transactional_lock/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WithTransactionalLock
   class Engine < ::Rails::Engine
   end

data/lib/with_transactional_lock/mixin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/concern'
 
 module WithTransactionalLock
@@ -6,8 +8,8 @@ module WithTransactionalLock
     delegate :with_transactional_lock, to: :class
 
     module ClassMethods
-      def with_transactional_lock(lock_name, &block)
-        _advisory_lock_class.new(connection, lock_name).yield_with_lock(&block)
+      def with_transactional_lock(lock_name, &)
+        _advisory_lock_class.new(connection, lock_name).yield_with_lock(&)
       end
 
       private
@@ -21,12 +23,12 @@ module WithTransactionalLock
       def self.locate(connection)
         adapter = connection.adapter_name.downcase.to_sym
         case adapter
-          when :mysql, :mysql2
-            MySqlAdvisoryLock
-          when :postgresql
-            PostgresAdvisoryLock
-          else
-            raise "adapter not supported: #{adapter}"
+        when :mysql, :mysql2
+          MySqlAdvisoryLock
+        when :postgresql
+          PostgresAdvisoryLock
+        else
+          raise "adapter not supported: #{adapter}"
         end
       end
     end
@@ -57,7 +59,8 @@ module WithTransactionalLock
       private
 
       def acquire_lock
-        connection.execute("insert into transactional_advisory_locks values (#{connection.quote(db_lock_name)}) on duplicate key update lock_id = lock_id")
+        connection.execute("insert into transactional_advisory_locks values (#{connection.quote(db_lock_name)}) \
+        on duplicate key update lock_id = lock_id")
       end
     end
 

data/lib/with_transactional_lock/my_sql_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WithTransactionalLock
   class MySqlHelper
     def self.cleanup(klass = ActiveRecord::Base)

data/lib/with_transactional_lock/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WithTransactionalLock
-  VERSION = "2.0.1"
+  VERSION = "2.3.0"
 end

data/lib/with_transactional_lock.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "with_transactional_lock/engine"
 
 module WithTransactionalLock
@@ -6,6 +8,4 @@ module WithTransactionalLock
   autoload :MySqlHelper
 end
 
-ActiveSupport.on_load :active_record do
-  ActiveRecord::Base.include WithTransactionalLock::Mixin
-end
+ActiveSupport.on_load(:active_record) { include WithTransactionalLock::Mixin }

metadata

@@ -1,65 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: with_transactional_lock
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.3.0
 platform: ruby
 authors:
 - Sam Moore
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-12 00:00:00.000000000 Z
+date: 2024-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.0
-  type: :development
+        version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.2'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.2'
 - !ruby/object:Gem::Dependency
-  name: betterlint
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
-  name: database_cleaner
+  name: betterlint
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -73,7 +79,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mime-types
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -116,20 +122,6 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: rspec-retry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -143,21 +135,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sprockets
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: travis
+  name: rspec-retry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -183,7 +161,6 @@ files:
 - lib/generators/with_transactional_lock/install/install_generator.rb
 - lib/generators/with_transactional_lock/install/templates/README
 - lib/generators/with_transactional_lock/install/templates/db/migrate/create_transactional_advisory_locks.rb
-- lib/tasks/with_transactional_lock_tasks.rake
 - lib/with_transactional_lock.rb
 - lib/with_transactional_lock/engine.rb
 - lib/with_transactional_lock/mixin.rb
@@ -192,7 +169,9 @@ files:
 homepage: https://github.com/Betterment/with_transactional_lock
 licenses:
 - MIT
-metadata: {}
+metadata:
+  allowed_push_host: https://rubygems.org
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -201,14 +180,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.5.23
 signing_key:
 specification_version: 4
 summary: Transactional advisory locks for ActiveRecord

data/lib/tasks/with_transactional_lock_tasks.rake

@@ -1,4 +0,0 @@
-# desc "Explaining what the task does"
-# task :with_transactional_lock do
-#   # Task goes here
-# end