with_model 2.1.7 → 2.3.0

data/test/sti_test.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+# Stands in for an application's own model, the usual reason to want single table
+# inheritance: its table is created once and outlives every test here, so a
+# with_model child's rows cannot be disposed of by dropping the table.
+module AppModels
+  class Cupboard < ActiveRecord::Base
+  end
+end
+
+ActiveRecord::Base.connection.create_table AppModels::Cupboard.table_name, force: true do |t|
+  t.string "type"
+  t.string "name"
+end
+
+# A with_model parent and an STI child in the same test case. The child's
+# superclass is resolved per-example, so this only works if the parent is
+# created before the child and destroyed after it.
+class StiTest < Minitest::Test
+  with_model :Vehicle do
+    table do |t|
+      t.string "type"
+      t.string "name"
+    end
+  end
+
+  with_model :Truck, superclass: -> { Vehicle } do
+    table(false)
+  end
+
+  with_model :Chest, superclass: "AppModels::Cupboard" do
+    table(false)
+  end
+
+  def test_the_child_shares_the_parents_table
+    assert_equal Vehicle.table_name, Truck.table_name
+  end
+
+  def test_the_child_stores_its_own_type
+    truck = Truck.create!(name: "Ford F-150")
+
+    assert_equal "Truck", truck.reload.type
+    assert_instance_of Truck, Vehicle.first
+  end
+
+  # Rows in a table the child does not own have to be deleted when it goes away,
+  # since nothing else will: Cupboard's table is still standing afterwards, and a
+  # row naming a class that no longer exists makes it unloadable. Both tests write
+  # one and first insist the table is empty, so whichever minitest happens to run
+  # second fails if the rows survived teardown - whatever order the seed picks.
+  def test_the_childs_rows_do_not_outlive_it
+    assert_empty AppModels::Cupboard.all, "a previous test's rows outlived it"
+
+    Chest.create!(name: "sideboard")
+
+    assert_equal 1, AppModels::Cupboard.count
+  end
+
+  def test_the_childs_rows_leave_the_superclass_loadable
+    assert_empty AppModels::Cupboard.all, "a previous test's rows outlived it"
+
+    Chest.create!(name: "wardrobe")
+
+    assert_instance_of Chest, AppModels::Cupboard.first
+  end
+end

data/test/test_helper.rb

@@ -1,28 +1,19 @@
 # frozen_string_literal: true
 
-$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
+$LOAD_PATH.unshift File.expand_path("../lib", __dir__)
 
-# Workaround for JRuby CI failure https://github.com/jruby/jruby/issues/6547#issuecomment-774104996
-if RUBY_ENGINE == 'jruby'
-  require 'i18n/backend'
-  require 'i18n/backend/simple'
-end
-
-require 'with_model'
-require 'minitest/autorun'
+require "with_model"
+require "minitest/autorun"
 
 WithModel.runner = :minitest
 
-module MiniTest
-  class Test
-    extend WithModel
-  end
-end
+WithModel.deprecator.behavior = :raise
 
-is_jruby = RUBY_PLATFORM == 'java'
-adapter = is_jruby ? 'jdbcsqlite3' : 'sqlite3'
+Minitest::Test.class_eval do
+  extend WithModel
+end
 
 # WithModel requires ActiveRecord::Base.connection to be established.
 # If ActiveRecord already has a connection, as in a Rails app, this is unnecessary.
-require 'active_record'
-ActiveRecord::Base.establish_connection(adapter: adapter, database: ':memory:')
+require "active_record"
+ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")

data/test/with_model_test.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require 'test_helper'
+require "test_helper"
 
-class WithModelTest < MiniTest::Test
+class WithModelTest < Minitest::Test
   with_model :BlogPost do
     table do |t|
-      t.string 'title'
-      t.text 'content'
+      t.string "title"
+      t.text "content"
       t.timestamps null: false
     end
 
@@ -17,13 +17,13 @@ class WithModelTest < MiniTest::Test
     end
   end
 
-  def test_it_should_act_like_a_normal_active_record_model # rubocop:disable Minitest/MultipleAssertions
-    record = BlogPost.create!(title: 'New blog post', content: 'Hello, world!')
+  def test_it_should_act_like_a_normal_active_record_model
+    record = BlogPost.create!(title: "New blog post", content: "Hello, world!")
 
     record.reload
 
-    assert_equal 'New blog post', record.title
-    assert_equal 'Hello, world!', record.content
+    assert_equal "New blog post", record.title
+    assert_equal "Hello, world!", record.content
     assert record.updated_at
 
     record.destroy
@@ -34,6 +34,6 @@ class WithModelTest < MiniTest::Test
   end
 
   def test_it_has_the_methods_defined_in_its_model_block
-    assert_equal 'Title: New blog post', BlogPost.new(title: 'New blog post').fancy_title
+    assert_equal "Title: New blog post", BlogPost.new(title: "New blog post").fancy_title
   end
 end

data/with_model.gemspec

@@ -1,24 +1,24 @@
 # frozen_string_literal: true
 
-$LOAD_PATH.push File.expand_path('lib', __dir__)
-require 'with_model/version'
+$LOAD_PATH.push File.expand_path("lib", __dir__)
+require "with_model/version"
 
 Gem::Specification.new do |spec|
-  spec.name        = 'with_model'
-  spec.version     = WithModel::VERSION
-  spec.authors     = ['Case Commons, LLC', 'Grant Hutchins', 'Andrew Marshall']
-  spec.email       = %w[casecommons-dev@googlegroups.com gems@nertzy.com andrew@johnandrewmarshall.com]
-  spec.homepage    = 'https://github.com/Casecommons/with_model'
-  spec.summary     = 'Dynamically build a model within an RSpec context'
+  spec.name = "with_model"
+  spec.version = WithModel::VERSION
+  spec.authors = ["Case Commons, LLC", "Grant Hutchins", "Andrew Marshall"]
+  spec.email = %w[casecommons-dev@googlegroups.com gems@nertzy.com andrew@johnandrewmarshall.com]
+  spec.homepage = "https://github.com/Casecommons/with_model"
+  spec.summary = "Dynamically build a model within an RSpec context"
   spec.description = spec.summary
-  spec.license     = 'MIT'
-  spec.metadata['rubygems_mfa_required'] = 'true'
+  spec.license = "MIT"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
+  spec.files = `git ls-files -z`.split("\x0")
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = '>= 2.7'
+  spec.required_ruby_version = ">= 3.3"
 
-  spec.add_dependency 'activerecord', '>= 6.0'
+  spec.add_dependency "activerecord", ">= 7.2"
 end

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: with_model
 version: !ruby/object:Gem::Version
-  version: 2.1.7
+  version: 2.3.0
 platform: ruby
 authors:
 - Case Commons, LLC
 - Grant Hutchins
 - Andrew Marshall
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-15 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -18,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.2'
 description: Dynamically build a model within an RSpec context
 email:
 - casecommons-dev@googlegroups.com
@@ -41,27 +40,34 @@ files:
 - ".gitignore"
 - ".jrubyrc"
 - ".rspec"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
 - ".yardopts"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - lib/with_model.rb
 - lib/with_model/constant_stubber.rb
+- lib/with_model/descendants_tracker.rb
+- lib/with_model/invalid_superclass.rb
 - lib/with_model/methods.rb
+- lib/with_model/missing_superclass.rb
 - lib/with_model/model.rb
 - lib/with_model/model/dsl.rb
+- lib/with_model/null_table.rb
 - lib/with_model/table.rb
 - lib/with_model/version.rb
-- spec/.rubocop.yml
 - spec/active_record_behaviors_spec.rb
 - spec/constant_stubber_spec.rb
+- spec/descendants_tracking_spec.rb
 - spec/readme_spec.rb
 - spec/spec_helper.rb
+- spec/table_false_spec.rb
 - spec/with_model_spec.rb
+- test/declaration_order_test.rb
+- test/spec_dsl_test.rb
+- test/sti_test.rb
 - test/test_helper.rb
 - test/with_model_test.rb
 - with_model.gemspec
@@ -70,7 +76,6 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -78,15 +83,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
-signing_key:
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Dynamically build a model within an RSpec context
 test_files: []

data/.rubocop.yml

@@ -1,33 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-require:
-  - rubocop-rake
-  - rubocop-rspec
-  - rubocop-minitest
-
-AllCops:
-  NewCops: enable
-  TargetRubyVersion: 2.7
-  Exclude:
-    - 'bin/**/*'
-    - 'vendor/bundle/**/*'
-
-Metrics/BlockLength:
-  Exclude:
-    - 'spec/**/*'
-    - 'with_model.gemspec'
-
-Bundler/OrderedGems:
-  Enabled: false
-
-Bundler/DuplicatedGem:
-  Enabled: false
-
-RSpec/Be:
-  Enabled: false
-
-RSpec/BeforeAfterAll:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false

data/.rubocop_todo.yml

@@ -1,78 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2020-11-22 01:30:26 UTC using RuboCop version 1.3.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 6
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/active_record_behaviors_spec.rb'
-    - 'spec/with_model_spec.rb'
-
-# Offense count: 6
-# Configuration parameters: IgnoredMetadata.
-RSpec/DescribeClass:
-  Exclude:
-    - 'spec/active_record_behaviors_spec.rb'
-    - 'spec/readme_spec.rb'
-    - 'spec/with_model_spec.rb'
-
-# Offense count: 5
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Exclude:
-    - 'spec/active_record_behaviors_spec.rb'
-    - 'spec/readme_spec.rb'
-    - 'spec/with_model_spec.rb'
-
-# Offense count: 7
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/active_record_behaviors_spec.rb'
-
-# Offense count: 2
-RSpec/LeakyConstantDeclaration:
-  Exclude:
-    - 'spec/readme_spec.rb'
-    - 'spec/with_model_spec.rb'
-
-# Offense count: 2
-# Configuration parameters: .
-# SupportedStyles: have_received, receive
-RSpec/MessageSpies:
-  EnforcedStyle: receive
-
-# Offense count: 1
-RSpec/MultipleDescribes:
-  Exclude:
-    - 'spec/readme_spec.rb'
-
-# Offense count: 13
-RSpec/MultipleExpectations:
-  Max: 5
-
-# Offense count: 4
-# Configuration parameters: IgnoreSharedExamples.
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/with_model_spec.rb'
-
-# Offense count: 2
-RSpec/NestedGroups:
-  Max: 4
-
-# Offense count: 4
-RSpec/RepeatedExample:
-  Exclude:
-    - 'spec/with_model_spec.rb'
-
-# Offense count: 2
-RSpec/SubjectStub:
-  Exclude:
-    - 'spec/with_model_spec.rb'

data/spec/.rubocop.yml

@@ -1,5 +0,0 @@
-inherit_from:
-  - ../.rubocop.yml
-
-Lint/ConstantDefinitionInBlock:
-  Enabled: false