with_model 2.1.6 → 2.2.0

data/spec/descendants_tracking_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Descendants tracking" do
+  with_model :BlogPost do
+    model do
+      def self.inspect
+        "BlogPost class #{object_id}"
+      end
+    end
+  end
+
+  def blog_post_classes
+    ActiveRecord::Base.descendants.select do |c|
+      c.table_name == BlogPost.table_name
+    end
+  end
+
+  shared_examples "clearing descendants between test runs" do
+    it "includes the correct model class in descendants on the first test run" do
+      expect(blog_post_classes).to eq [BlogPost]
+    end
+
+    it "includes the correct model class in descendants on the second test run" do
+      expect(blog_post_classes).to eq [BlogPost]
+    end
+  end
+
+  context "with ActiveSupport::DescendantsTracker (cache_classes: true)" do
+    before do
+      expect(ActiveSupport::DescendantsTracker.clear_disabled).to be_falsey
+      expect { ActiveSupport::DescendantsTracker.clear([]) }.not_to raise_exception
+    end
+
+    include_examples "clearing descendants between test runs"
+  end
+
+  context "without ActiveSupport::DescendantsTracker (cache_classes: false)" do
+    before do
+      ActiveSupport::DescendantsTracker.disable_clear!
+      expect(ActiveSupport::DescendantsTracker.clear_disabled).to be_truthy
+      expect { ActiveSupport::DescendantsTracker.clear([]) }.to raise_exception(RuntimeError)
+    end
+
+    include_examples "clearing descendants between test runs"
+  end
+end

data/spec/readme_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
-describe 'A blog post' do
+describe "A blog post" do
   before do
-    stub_const('MyModule', Module.new)
+    stub_const("MyModule", Module.new)
   end
 
   with_model :BlogPost do
@@ -21,11 +21,11 @@ describe 'A blog post' do
       validates_presence_of :title
 
       def self.some_class_method
-        'chunky'
+        "chunky"
       end
 
       def some_instance_method
-        'bacon'
+        "bacon"
       end
     end
   end
@@ -43,46 +43,46 @@ describe 'A blog post' do
     end
   end
 
-  it 'can be accessed as a constant' do
+  it "can be accessed as a constant" do
     expect(BlogPost).to be
   end
 
-  it 'has the module' do
-    expect(BlogPost.include?(MyModule)).to eq true
+  it "has the module" do
+    expect(BlogPost.include?(MyModule)).to be true
   end
 
-  it 'has the class method' do
-    expect(BlogPost.some_class_method).to eq 'chunky'
+  it "has the class method" do
+    expect(BlogPost.some_class_method).to eq "chunky"
   end
 
-  it 'has the instance method' do
-    expect(BlogPost.new.some_instance_method).to eq 'bacon'
+  it "has the instance method" do
+    expect(BlogPost.new.some_instance_method).to eq "bacon"
   end
 
-  it 'can do all the things a regular model can' do
+  it "can do all the things a regular model can" do
     record = BlogPost.new
     expect(record).not_to be_valid
-    record.title = 'foo'
+    record.title = "foo"
     expect(record).to be_valid
-    expect(record.save).to eq true
+    expect(record.save).to be true
     expect(record.reload).to eq record
-    record.comments.create!(text: 'Lorem ipsum')
+    record.comments.create!(text: "Lorem ipsum")
     expect(record.comments.count).to eq 1
   end
 
   # with_model classes can have inheritance.
-  class Car < ActiveRecord::Base
+  class Car < ActiveRecord::Base # standard:disable Lint/ConstantDefinitionInBlock
     self.abstract_class = true
   end
 
   with_model :Ford, superclass: Car
 
-  it 'has a specified superclass' do
-    expect(Ford < Car).to eq true
+  it "has a specified superclass" do
+    expect(Ford < Car).to be true
   end
 end
 
-describe 'with_model can be run within RSpec :all hook' do
+describe "with_model can be run within RSpec :all hook" do
   with_model :BlogPost, scope: :all do
     table do |t|
       t.string :title
@@ -93,26 +93,26 @@ describe 'with_model can be run within RSpec :all hook' do
     BlogPost.create # without scope: :all these will fail
   end
 
-  it 'has been initialized within before(:all)' do
+  it "has been initialized within before(:all)" do
     expect(BlogPost.count).to eq 1
   end
 end
 
-describe 'another example group' do
-  it 'does not have the constant anymore' do
+describe "another example group" do
+  it "does not have the constant anymore" do
     expect(defined?(BlogPost)).to be_falsy
   end
 end
 
-describe 'with table options' do
+describe "with table options" do
   with_model :WithOptions do
     table id: false do |t|
-      t.string 'foo'
+      t.string "foo"
       t.timestamps null: false
     end
   end
 
-  it 'respects the additional options' do
-    expect(WithOptions.columns.map(&:name)).not_to include('id')
+  it "respects the additional options" do
+    expect(WithOptions.columns.map(&:name)).not_to include("id")
   end
 end

data/spec/spec_helper.rb

@@ -1,16 +1,7 @@
 # frozen_string_literal: true
 
-# Workaround for JRuby CI failure https://github.com/jruby/jruby/issues/6547#issuecomment-774104996
-if RUBY_ENGINE == 'jruby'
-  require 'i18n/backend'
-  require 'i18n/backend/simple'
-end
-
-require 'simplecov'
-SimpleCov.start
-
-require 'bundler/setup'
-require 'with_model'
+require "bundler/setup"
+require "with_model"
 
 RSpec.configure do |config|
   config.extend WithModel
@@ -26,24 +17,21 @@ RSpec.configure do |config|
   end
 end
 
-is_jruby = RUBY_PLATFORM == 'java'
-adapter = is_jruby ? 'jdbcsqlite3' : 'sqlite3'
-
 # WithModel requires ActiveRecord::Base.connection to be established.
 # If ActiveRecord already has a connection, as in a Rails app, this is unnecessary.
-require 'active_record'
-ActiveRecord::Base.establish_connection(adapter: adapter, database: ':memory:')
+require "active_record"
+ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
 
 I18n.enforce_available_locales = true if defined?(I18n) && I18n.respond_to?(:enforce_available_locales=)
 
-if ENV['LOGGER']
-  require 'logger'
+if ENV["LOGGER"]
+  require "logger"
   ActiveRecord::Base.logger = Logger.new($stdout)
 end
 
 module SpecHelper
   module RailsTestCompatibility
-    require 'minitest'
+    require "minitest"
     include Minitest::Assertions
 
     def assertions