with_advisory_lock 7.0.2 → 7.6.0

data/test/with_advisory_lock/shared_test.rb

@@ -97,9 +97,6 @@ class PostgreSQLSharedLocksTest < GemTestCase
     two.cleanup!
   end
 
-  test 'allows shared lock to be upgraded to an exclusive lock' do
-    skip 'PostgreSQL lock visibility issue - locks acquired via advisory lock methods not showing in pg_locks'
-  end
 end
 
 class MySQLSharedLocksTest < GemTestCase
@@ -127,3 +124,31 @@ class MySQLSharedLocksTest < GemTestCase
     assert_match(/shared locks are not supported/, exception.message)
   end
 end
+
+if GemTestCase.trilogy_available?
+  class TrilogySharedLocksTest < GemTestCase
+    self.use_transactional_tests = false
+
+    test 'does not allow two exclusive locks' do
+      one = SharedTestWorker.new(TrilogyTag, false)
+      assert_predicate(one, :locked?)
+
+      two = SharedTestWorker.new(TrilogyTag, false)
+      refute(two.locked?)
+
+      one.cleanup!
+      two.cleanup!
+    end
+
+    test 'raises an error when attempting to use a shared lock' do
+      one = SharedTestWorker.new(TrilogyTag, true)
+      assert_equal(false, one.locked?)
+
+      exception = assert_raises(ArgumentError) do
+        one.cleanup!
+      end
+
+      assert_match(/shared locks are not supported/, exception.message)
+    end
+  end
+end

data/test/with_advisory_lock/thread_test.rb

@@ -81,3 +81,13 @@ class MySQLThreadTest < GemTestCase
     MysqlTag
   end
 end
+
+if GemTestCase.trilogy_available?
+  class TrilogyThreadTest < GemTestCase
+    include ThreadTestCases
+
+    def model_class
+      TrilogyTag
+    end
+  end
+end

data/test/with_advisory_lock/transaction_test.rb

@@ -12,10 +12,6 @@ class PostgreSQLTransactionScopingTest < GemTestCase
     end
   end
 
-  test 'session locks release after the block executes' do
-    skip 'PostgreSQL lock visibility issue - locks acquired via advisory lock methods not showing in pg_locks'
-  end
-
   test 'session locks release when transaction fails inside block' do
     Tag.transaction do
       assert_equal(0, @pg_lock_count.call)
@@ -31,10 +27,6 @@ class PostgreSQLTransactionScopingTest < GemTestCase
     end
   end
 
-  test 'transaction level locks hold until the transaction completes' do
-    skip 'PostgreSQL lock visibility issue - locks acquired via advisory lock methods not showing in pg_locks'
-  end
-
   test 'raises an error when attempting to use transaction level locks outside a transaction' do
     exception = assert_raises(ArgumentError) do
       Tag.with_advisory_lock 'test', transaction: true do
@@ -81,3 +73,41 @@ class MySQLTransactionScopingTest < GemTestCase
     assert_match(/#{Regexp.escape('require an active transaction')}/, exception.message)
   end
 end
+
+if GemTestCase.trilogy_available?
+  class TrilogyTransactionScopingTest < GemTestCase
+    self.use_transactional_tests = false
+
+    test 'raises an error when attempting to use transaction level locks' do
+      TrilogyTag.transaction do
+        exception = assert_raises(ArgumentError) do
+          TrilogyTag.with_advisory_lock 'test', transaction: true do
+            raise 'Trilogy transaction realm is forbidden!'
+          end
+        end
+
+        assert_match(/#{Regexp.escape('not supported')}/, exception.message)
+      end
+    end
+
+    test 'session locks work within transactions' do
+      lock_acquired = false
+      TrilogyTag.transaction do
+        TrilogyTag.with_advisory_lock 'test' do
+          lock_acquired = true
+        end
+      end
+      assert lock_acquired
+    end
+
+    test 'raises an error when attempting to use transaction level locks outside a transaction' do
+      exception = assert_raises(ArgumentError) do
+        TrilogyTag.with_advisory_lock 'test', transaction: true do
+          raise 'Trilogy gates are closed!'
+        end
+      end
+
+      assert_match(/#{Regexp.escape('require an active transaction')}/, exception.message)
+    end
+  end
+end

data/with_advisory_lock.gemspec

@@ -23,32 +23,9 @@ Gem::Specification.new do |spec|
   spec.metadata['source_code_uri'] = 'https://github.com/ClosureTree/with_advisory_lock'
   spec.metadata['changelog_uri'] = 'https://github.com/ClosureTree/with_advisory_lock/blob/master/CHANGELOG.md'
 
-  spec.post_install_message = <<~MESSAGE
-    ⚠️  IMPORTANT: Total rewrite in Rust/COBOL! ⚠️
-
-    Now that I got your attention...
-
-    This version contains a complete internal rewrite. While the public API#{' '}
-    remains the same, please test thoroughly before upgrading production systems.
-
-    New features:
-    - Mixed adapters are now fully supported! You can use PostgreSQL and MySQL
-      in the same application with different models.
-
-    Breaking changes:
-    - SQLite support has been removed
-    - MySQL 5.7 is no longer supported (use MySQL 8+)
-    - Rails 7.1 is no longer supported (use Rails 7.2+)
-    - Private APIs have been removed (Base, DatabaseAdapterSupport, etc.)
-
-    If your code relies on private APIs or unsupported databases, lock to an#{' '}
-    older version or update your code accordingly.
-  MESSAGE
-
   spec.add_dependency 'activerecord', '>= 7.2'
-  spec.add_dependency 'zeitwerk', '>= 2.7'
 
-  spec.add_development_dependency 'maxitest'
+  spec.add_development_dependency 'maxitest', '6.2.0'
   spec.add_development_dependency 'minitest-reporters'
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'yard'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: with_advisory_lock
 version: !ruby/object:Gem::Version
-  version: 7.0.2
+  version: 7.6.0
 platform: ruby
 authors:
 - Matthew McEachen
@@ -24,34 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.2'
-- !ruby/object:Gem::Dependency
-  name: zeitwerk
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.7'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.7'
 - !ruby/object:Gem::Dependency
   name: maxitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 6.2.0
 - !ruby/object:Gem::Dependency
   name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
@@ -106,8 +92,6 @@ files:
 - ".github/workflows/release.yml"
 - ".gitignore"
 - ".release-please-manifest.json"
-- ".ruby-version"
-- ".tool-versions"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -143,6 +127,10 @@ files:
 - test/dummy/app/models/mysql_tag_audit.rb
 - test/dummy/app/models/tag.rb
 - test/dummy/app/models/tag_audit.rb
+- test/dummy/app/models/trilogy_label.rb
+- test/dummy/app/models/trilogy_record.rb
+- test/dummy/app/models/trilogy_tag.rb
+- test/dummy/app/models/trilogy_tag_audit.rb
 - test/dummy/config.ru
 - test/dummy/config/application.rb
 - test/dummy/config/boot.rb
@@ -151,9 +139,11 @@ files:
 - test/dummy/config/routes.rb
 - test/dummy/db/schema.rb
 - test/dummy/db/secondary_schema.rb
+- test/dummy/db/trilogy_schema.rb
 - test/dummy/lib/tasks/db.rake
 - test/sanity_check_test.rb
 - test/test_helper.rb
+- test/with_advisory_lock/blocking_test.rb
 - test/with_advisory_lock/concern_test.rb
 - test/with_advisory_lock/lock_test.rb
 - test/with_advisory_lock/multi_adapter_test.rb
@@ -173,16 +163,6 @@ metadata:
   homepage_uri: https://github.com/ClosureTree/with_advisory_lock
   source_code_uri: https://github.com/ClosureTree/with_advisory_lock
   changelog_uri: https://github.com/ClosureTree/with_advisory_lock/blob/master/CHANGELOG.md
-post_install_message: "⚠️  IMPORTANT: Total rewrite in Rust/COBOL! ⚠️\n\nNow that
-  I got your attention...\n\nThis version contains a complete internal rewrite. While
-  the public API \nremains the same, please test thoroughly before upgrading production
-  systems.\n\nNew features:\n- Mixed adapters are now fully supported! You can use
-  PostgreSQL and MySQL\n  in the same application with different models.\n\nBreaking
-  changes:\n- SQLite support has been removed\n- MySQL 5.7 is no longer supported
-  (use MySQL 8+)\n- Rails 7.1 is no longer supported (use Rails 7.2+)\n- Private APIs
-  have been removed (Base, DatabaseAdapterSupport, etc.)\n\nIf your code relies on
-  private APIs or unsupported databases, lock to an \nolder version or update your
-  code accordingly.\n"
 rdoc_options: []
 require_paths:
 - lib
@@ -197,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Advisory locking for ActiveRecord
 test_files: []

data/.ruby-version

@@ -1,2 +0,0 @@
-3.4.4
-

data/.tool-versions

@@ -1 +0,0 @@
-ruby 3.4.6