wisper 2.0.0 → 3.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 62cd6c2948137446de8f7f515bcbebd11c14092d
-  data.tar.gz: dfbc3b2d28c9023edc9f8308a6c406887c20efed
+SHA256:
+  metadata.gz: 051745d94baf4c2ba328de627fde2f5bea42ed5081e2c830520b5ee33bef9c28
+  data.tar.gz: b069da8aa786e36d2fe0f51f90030295a9a918f5b8733341515e5c93dca92d7b
 SHA512:
-  metadata.gz: d82be662081f118b83ce5f01f87a0760be1bbc9d711163fc76ac303db689ba307ec453afb9edfb374fa1b23e92ab6a684a2c3857580d3f6a29195c75c8d6f754
-  data.tar.gz: 9395fbd3e0d2b925d31dc06682aa573ad66b0f4ee980533b1671e497ce7f2b8b82019840c7f8eb15c7f52b7bdae73934592ae0e5634729b4ad99f2c068bcae3e
+  metadata.gz: 4c84a5d089a16c2588a3cf2d1c83100ff5bc0a7db191c63e47251a4c7e3c8214ddca68a6f2a06e4b155077f88fb3f78e94537c4fe4e0fd68c5ff72cad929a66c
+  data.tar.gz: 628455d61676ea7618979695ef6a5babe5654db083162f3c5db9aa5dd833b4ff351b4e27f23730b19b7fb07fb4c440fc51857147657657bde941b37465164a91

checksums.yaml.gz.sig

@@ -0,0 +1,3 @@
+��1��eA	�%Sz�c�W�E7�^���G����S�؁`�|���M��B�9s7!���\e
+;t�b��������0�t��?Ň{ �Ƹ
+�)��W+t_G��7ƞ�&���f�N*;���؟��/�Ѳu�8h�g���

data/.github/workflows/test.yml

@@ -0,0 +1,17 @@
+name: Run unit tests
+on: [push, pull_request]
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+        ruby: ["2.7", "3.0", "3.1", "3.2", "jruby"]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rspec spec

data/.gitignore

@@ -4,6 +4,7 @@
 .bundle
 .config
 .yardoc
+.tool-versions
 Gemfile.lock
 InstalledFiles
 _yardoc

data/CHANGELOG.md

@@ -1,10 +1,41 @@
 ## HEAD (unreleased)
 
-## 2.0.0 (7th Mar 2017)
+## 3.0.0.rc1 (6th July 2023)
+
+Authors: Keith Bennett, doits, jstoks, merringtion, thirunjuguna
+
+* fix: exclude bin directory from gem #181
+* Adds: Support for Ruby 3.0 keyword arguments
+* Removes: Support for Ruby 2.6 and lower [breaking change]
+
+## 2.0.1 (29th Aug 2019)
 
-Authors: Sergey Mostovoy
+Authors: David Wilkie, hosseintoussi, Maxim Polunin, Tristan
+Harmer, Bartosz Żurkowski, Kris Leech
+
+* fix: support nested temporary global listeners
+* docs: add threadsafe notes to README for global and temporary listeners
+* docs: fix spelling mistakes in README
+* fix: safely get signing key in gemspec when HOME is not set
+* adds: add console to aid experiments and REPL driven development
+* adds: Latest Ruby to CI
+
+## 2.0.0 (7th Mar 2017)
 
-* fix: logger raises exception if hash is passed as an argument to a listener
+Authors: Sergey Mostovoy, Andrew Kozin, Kyle Tolle, Martin, Rob Miller, Mike
+Dalto, orthographic-pedant, Drew Ulmer, Mikey Hogarth, Attila Domokos, Josh
+Miltz, Pascal Betz, Vasily Kolesnikov, Julien Letessier, Kris Leech
+
+* Fix: logger raises exception if hash is passed as an argument to a listener #133, #136
+* Fix: deprecation warnings #120
+* Doc improvements: #106, #111, #116, #122, #128, #130, #147, #149, #150, #151
+* Adds: Allow configuration of default prefix when using `prefix: true`. #105
+* Adds: Allow unsubscribing of global listeners #118
+* Adds: Helpful error message when passing a block to `#subscribe` of `#on` #125
+* Adds: raise an error message when `#on` is not passed a block #146
+* Adds: Support for JRuby 9.x #148
+* Adds: Support for MRI 2.4.0 #155
+* Refactor specs #126, #131
 
 ## 2.0.0.rc1 (17 Dec 2014)
 

data/CONTRIBUTING.md

@@ -28,10 +28,6 @@ appropriate as an extension to Wisper.
 
 We also have a [Gitter channel](https://gitter.im/krisleech/wisper) if you wish to discuss your ideas.
 
-## Backlog /  Roadmap
-
-The backlog for Wisper and related gems is on [Waffle](https://waffle.io/krisleech/wisper).
-
 ## Questions
 
 Try the [Wiki](https://github.com/krisleech/wisper/wiki) first, the examples
@@ -43,7 +39,7 @@ Feel free to ping me the URL on [Twitter](https://twitter.com/krisleech).
 
 ## Pull requests
 
-* Fork the project, create a new branch from `v1` or `master`.
+* Fork the project, create a new branch `master`.
 * Squash commits which are related.
 * Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
 * Documentation only changes should have `[skip ci]` in the commit message
@@ -58,4 +54,4 @@ not backwards compatible.
 The `v1` branch is a long lived branch and you should
 branch from this if you wish to fix an issue in version `~> 1.0`.
 
-The `master` branch will target the next version of Wisper.
+Otherwise branch from `master` branch.

data/Gemfile

@@ -2,8 +2,8 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rake',  '~> 10.3.0'
-gem 'rspec', '~> 3.4.0'
+gem 'rake'
+gem 'rspec'
 gem 'coveralls', require: false
 
 group :extras do

data/README.md

@@ -4,22 +4,27 @@
 
 [![Gem Version](https://badge.fury.io/rb/wisper.svg)](http://badge.fury.io/rb/wisper)
 [![Code Climate](https://codeclimate.com/github/krisleech/wisper.svg)](https://codeclimate.com/github/krisleech/wisper)
-[![Build Status](https://travis-ci.org/krisleech/wisper.svg?branch=master)](https://travis-ci.org/krisleech/wisper)
+[![Build Status](https://github.com/krisleech/wisper/actions/workflows/test.yml/badge.svg)](https://github.com/krisleech/wisper/actions)
 [![Coverage Status](https://coveralls.io/repos/krisleech/wisper/badge.svg?branch=master)](https://coveralls.io/r/krisleech/wisper?branch=master)
 
 * Decouple core business logic from external concerns in Hexagonal style architectures
 * Use as an alternative to ActiveRecord callbacks and Observers in Rails apps
 * Connect objects based on context without permanence
-* React to events synchronously or asynchronously
+* Publish events synchronously or asynchronously
 
 Note: Wisper was originally extracted from a Rails codebase but is not dependant on Rails.
 
+Please also see the [Wiki](https://github.com/krisleech/wisper/wiki) for more additional information and articles.
+
+**For greenfield applications you might also be interested in
+[WisperNext](https://gitlab.com/kris.leech/wisper_next) and [Ma](https://gitlab.com/kris.leech/ma).**
+
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'wisper', '2.0.0'
+gem 'wisper', '~3.0'
 ```
 
 ## Usage
@@ -74,7 +79,7 @@ class OrderNotifier
   def cancel_order_successful(order_id)
     order = Order.find_by_id(order_id)
 
-    # notify someone ...    
+    # notify someone ...
   end
 end
 ```
@@ -118,8 +123,9 @@ cancel_order.subscribe(OrderNotifier.new, async: true)
 Wisper has various adapters for asynchronous event handling, please refer to
 [wisper-celluloid](https://github.com/krisleech/wisper-celluloid),
 [wisper-sidekiq](https://github.com/krisleech/wisper-sidekiq),
-[wisper-activejob](https://github.com/krisleech/wisper-activejob), or
-[wisper-que](https://github.com/joevandyk/wisper-que).
+[wisper-activejob](https://github.com/krisleech/wisper-activejob),
+[wisper-que](https://github.com/joevandyk/wisper-que) or
+[wisper-resque](https://github.com/bzurkowski/wisper-resque).
 
 Depending on the adapter used the listener may need to be a class instead of an object. In this situation, every method corresponding to events should be declared as a class method, too. For example:
 
@@ -131,7 +137,7 @@ class OrderNotifier
   def self.cancel_order_successful(order_id)
     order = Order.find_by_id(order_id)
 
-    # notify someone ...    
+    # notify someone ...
   end
 end
 ```
@@ -191,9 +197,17 @@ This is useful for cross cutting concerns such as recording statistics, indexing
 Wisper.subscribe(MyListener.new)
 ```
 
-In a Rails app you might want to add your global listeners in an initalizer.
+In a Rails app you might want to add your global listeners in an initializer like:
+
+```ruby
+# config/initializers/listeners.rb
+Rails.application.reloader.to_prepare do
+  Wisper.subscribe(MyListener.new)
+end
+```
+
+Global listeners are threadsafe. Subscribers will receive events published on all threads.
 
-Global listeners are threadsafe.
 
 ### Scoping by publisher class
 
@@ -231,7 +245,7 @@ listeners.
 
 This is useful for capturing events published by objects to which you do not have access in a given context.
 
-Temporary Global Listeners are threadsafe.
+Temporary Global Listeners are threadsafe. Subscribers will receive events published on the same thread.
 
 ## Subscribing to selected events
 
@@ -291,7 +305,7 @@ You could also alias the method within your listener, as such
 
 ## Testing
 
-Testing matchers and stubs are in seperate gems.
+Testing matchers and stubs are in separate gems.
 
 * [wisper-rspec](https://github.com/krisleech/wisper-rspec)
 * [wisper-minitest](https://github.com/digitalcuisine/wisper-minitest)
@@ -315,9 +329,7 @@ Got a specific question, try the
 
 ## Compatibility
 
-Tested with MRI 2.x, JRuby and Rubinius.
-
-See the [build status](https://travis-ci.org/krisleech/wisper) for details.
+See the [build status](https://github.com/krisleech/wisper/actions) for details.
 
 ## Running Specs
 
@@ -339,6 +351,7 @@ Please read the [Contributing Guidelines](https://github.com/krisleech/wisper/bl
 
 * gem releases are [signed](http://guides.rubygems.org/security/) ([public key](https://github.com/krisleech/wisper/blob/master/gem-public_cert.pem))
 * commits are GPG signed ([public key](https://pgp.mit.edu/pks/lookup?op=get&search=0x3ABC74851F7CCC88))
+* My [Keybase.io profile](https://keybase.io/krisleech)
 
 ## License
 

data/gem-public_cert.pem

@@ -1,21 +1,19 @@
 -----BEGIN CERTIFICATE-----
-MIIDeDCCAmCgAwIBAgIBATANBgkqhkiG9w0BAQUFADBBMRMwEQYDVQQDDAprcmlz
-LmxlZWNoMRUwEwYKCZImiZPyLGQBGRYFZ21haWwxEzARBgoJkiaJk/IsZAEZFgNj
-b20wHhcNMTQxMTA1MTEwMzQ4WhcNMTUxMTA1MTEwMzQ4WjBBMRMwEQYDVQQDDApr
-cmlzLmxlZWNoMRUwEwYKCZImiZPyLGQBGRYFZ21haWwxEzARBgoJkiaJk/IsZAEZ
-FgNjb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCtW0/UtrFK/tSm
-uq5HnCUkZAQjnSaZ/h1Tby9s30CDJjDUdizPRdLQCplLDAMHFsAfTyD0Mc+Ez8o9
-CdTh8EZ4TSf+nokL+SUprpdR6qm6OWU03Ntd+bDCP0+rdqCX82g3N3mnvjR9aD3a
-+hd9Fhp0WuEyqTNjQ7IlopeUPDW7eYfSwI4bjfRHxsDR1GuZ3j0npxCAgAIN41WH
-MSTTZhdo0vKEiKZEtMMnT6w6fG/c3XIhVVPGnqy5+IZqBL0SYC+WJL3vC6yUBgqB
-nrpA/q+b3M69W+q+TkGv0qOnrxln0O7J2pykjoGIxUhhRkiGEldEhy9dxQWubffr
-hVJ4F0wLAgMBAAGjezB5MAkGA1UdEwQCMAAwCwYDVR0PBAQDAgSwMB0GA1UdDgQW
-BBSzq+x8mwj0ldvNkvjOl44OJG354jAfBgNVHREEGDAWgRRrcmlzLmxlZWNoQGdt
-YWlsLmNvbTAfBgNVHRIEGDAWgRRrcmlzLmxlZWNoQGdtYWlsLmNvbTANBgkqhkiG
-9w0BAQUFAAOCAQEAF5M2Md3DcNCrQrDRDLaIzHaMM+RTgfbpgmZ6tU0iEowES18g
-QWQgrAbFuvQRPETJ2gbL5AC35fEqN80nU+3GhgW/bDYhII5D3PGLMorxhFw1JYLI
-0Fd7MCE0sImc2rPybYUdpZ6TxvqgPKp+8CzM8vBUrdYd+dSHXit1piViWBcZcJb+
-EL5Ze4IodjkCPAeHvu2MQieieViLyfB4eG1syvfkxvAXCjFHeQoIFP16vVtcljdF
-k5cHH/4SGeMuGrSLRsqVvltxVV3AbQAfH8WUos2brjYHsoH5tVPrJ7UcFhzP95oU
-pEfFMW42smiNTOXpzG6JoIpA11szEHFT5ZS+UQ==
+MIIC/jCCAeagAwIBAgIBAjANBgkqhkiG9w0BAQsFADAlMSMwIQYDVQQDDBprcmlz
+LmxlZWNoL0RDPWdtYWlsL0RDPWNvbTAeFw0yMzA3MDYxNTI0MDdaFw0yNDA3MDUx
+NTI0MDdaMCUxIzAhBgNVBAMMGmtyaXMubGVlY2gvREM9Z21haWwvREM9Y29tMIIB
+IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA8gg/iZE6RFkl6GjisJJf9wQl
+5Tog+mrGqtylNpe9QKeyQS1fKLNR3Cqmv6sT3f3GlU8hhG+802MXmlJo7VyENs+s
+HdMy85fBnYwhS/szhTzBqduXw43RAAGqB0VaHAoHdufTZBkmFSXET5c0/jUqQrPL
+Zxsm2i0NV8cVpvrZlQcsW4Kf97DG1ZFNncS0IfCDqnluh21qMSgVAuiKHGoVKCYG
+Igey486VuuJ8j6axwW3ii8HoBOxjF8Ka/rJ/t4sB9Ql/p6RHR4RhxP5xIS9geCpI
+dsPGnCSleTW1EnXGHLdOdJpVmJXueYJEQJ1Rh/rR+9PeqAT3RA0D/dxSGIVtrQID
+AQABozkwNzAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHQ4EFgQUyupX2gb3
++isBRwf4/fhgLnh02sYwDQYJKoZIhvcNAQELBQADggEBABdaC++ZW0a2N7oLen4+
+i/4JKdVqa2+BKCQtJdaFsejjGURcudXaY5wqEhgP4ADQ8ANOFF0dCDPPsEn6qMhf
+cNEbRQhMexbe5xQTRVey+20i6vvnJ/kwqnftxAm28Jc3QMMsPk+iM2HZiOsBzICj
+b7k2mPBUf3M6aj8i2fRo6H79PsAN3y7AyU9/KhgkcwHQhr+k7kFpnXKMNlw02ctg
+nzy6xfYdDTzcw47twNBWr53COJTJMgdmlVupROoNjQsJTvuSfUiuy5JFGqS0fijB
+tiGTXMVCk/fOTj04HvFZi/P11KUmQ6HsevziemEgQOnG2lCp+BkyNN0Y4XVW/mno
+x7Y=
 -----END CERTIFICATE-----

data/lib/wisper/broadcasters/logger_broadcaster.rb

@@ -8,9 +8,9 @@ module Wisper
         @broadcaster = broadcaster
       end
 
-      def broadcast(listener, publisher, event, args)
-        @logger.info("[WISPER] #{name(publisher)} published #{event} to #{name(listener)} with #{args_info(args)}")
-        @broadcaster.broadcast(listener, publisher, event, args)
+      def broadcast(listener, publisher, event, *args, **kwargs)
+        @logger.info("[WISPER] #{name(publisher)} published #{event} to #{name(listener)} with #{args_info(args)} and #{kwargs_info(kwargs)}")
+        @broadcaster.broadcast(listener, publisher, event, *args, **kwargs)
       end
 
       private
@@ -32,6 +32,10 @@ module Wisper
           arg_string
         end.join(', ')
       end
+
+      def kwargs_info(kwargs)
+        kwargs.empty? ? 'no keyword arguments' : "keyword arguments #{kwargs.inspect}"
+      end
     end
   end
 end

data/lib/wisper/broadcasters/send_broadcaster.rb

@@ -1,8 +1,8 @@
 module Wisper
   module Broadcasters
     class SendBroadcaster
-      def broadcast(listener, publisher, event, args)
-        listener.public_send(event, *args)
+      def broadcast(listener, publisher, event, *args, **kwargs)
+        listener.public_send(event, *args, **kwargs)
       end
     end
   end

data/lib/wisper/global_listeners.rb

@@ -13,12 +13,10 @@ module Wisper
       @mutex         = Mutex.new
     end
 
-    def subscribe(*listeners)
-      options = listeners.last.is_a?(Hash) ? listeners.pop : {}
-
+    def subscribe(*listeners, **options)
       with_mutex do
         listeners.each do |listener|
-          @registrations << ObjectRegistration.new(listener, options)
+          @registrations << ObjectRegistration.new(listener, **options)
         end
       end
       self
@@ -45,8 +43,8 @@ module Wisper
       with_mutex { @registrations.clear }
     end
 
-    def self.subscribe(*listeners)
-      instance.subscribe(*listeners)
+    def self.subscribe(*listeners, **options)
+      instance.subscribe(*listeners, **options)
     end
 
     def self.unsubscribe(*listeners)

data/lib/wisper/publisher.rb

@@ -10,9 +10,9 @@ module Wisper
     #   my_publisher.subscribe(MyListener.new)
     #
     # @return [self]
-    def subscribe(listener, options = {})
+    def subscribe(listener, **options)
       raise ArgumentError, "#{__method__} does not take a block, did you mean to call #on instead?" if block_given?
-      local_registrations << ObjectRegistration.new(listener, options)
+      local_registrations << ObjectRegistration.new(listener, **options)
       self
     end
 
@@ -38,9 +38,9 @@ module Wisper
     #   end
     #
     # @return [self]
-    def broadcast(event, *args)
+    def broadcast(event, *args, **kwargs)
       registrations.each do | registration |
-        registration.broadcast(clean_event(event), self, *args)
+        registration.broadcast(clean_event(event), self, *args, **kwargs)
       end
       self
     end
@@ -55,8 +55,8 @@ module Wisper
       # @example
       #   MyPublisher.subscribe(MyListener.new)
       #
-      def subscribe(listener, options = {})
-        GlobalListeners.subscribe(listener, options.merge(:scope => self))
+      def subscribe(listener, **options)
+        GlobalListeners.subscribe(listener, **options.merge(:scope => self))
       end
     end
 

data/lib/wisper/registration/block.rb

@@ -2,9 +2,9 @@
 
 module Wisper
   class BlockRegistration < Registration
-    def broadcast(event, publisher, *args)
+    def broadcast(event, publisher, *args, **kwargs)
       if should_broadcast?(event)
-        listener.call(*args)
+        listener.call(*args, **kwargs)
       end
     end
   end

data/lib/wisper/registration/object.rb

@@ -4,18 +4,18 @@ module Wisper
   class ObjectRegistration < Registration
     attr_reader :with, :prefix, :allowed_classes, :broadcaster
 
-    def initialize(listener, options)
-      super(listener, options)
+    def initialize(listener, **options)
+      super(listener, **options)
       @with   = options[:with]
       @prefix = ValueObjects::Prefix.new options[:prefix]
       @allowed_classes = Array(options[:scope]).map(&:to_s).to_set
       @broadcaster = map_broadcaster(options[:async] || options[:broadcaster])
     end
 
-    def broadcast(event, publisher, *args)
+    def broadcast(event, publisher, *args, **kwargs)
       method_to_call = map_event_to_method(event)
       if should_broadcast?(event) && listener.respond_to?(method_to_call) && publisher_in_scope?(publisher)
-        broadcaster.broadcast(listener, publisher, method_to_call, args)
+        broadcaster.broadcast(listener, publisher, method_to_call, *args, **kwargs)
       end
     end
 

data/lib/wisper/registration/registration.rb

@@ -4,7 +4,7 @@ module Wisper
   class Registration
     attr_reader :on, :listener
 
-    def initialize(listener, options)
+    def initialize(listener, **options)
       @listener = listener
       @on = ValueObjects::Events.new options[:on]
     end

data/lib/wisper/temporary_listeners.rb

@@ -4,22 +4,22 @@
 
 module Wisper
   class TemporaryListeners
-
-    def self.subscribe(*listeners, &block)
-      new.subscribe(*listeners, &block)
+    def self.subscribe(*listeners, **options, &block)
+      new.subscribe(*listeners, **options, &block)
     end
 
     def self.registrations
       new.registrations
     end
 
-    def subscribe(*listeners, &block)
-      options = listeners.last.is_a?(Hash) ? listeners.pop : {}
+    def subscribe(*listeners, **options, &_block)
+      new_registrations = build_registrations(*listeners, **options)
+
       begin
-        listeners.each { |listener| registrations << ObjectRegistration.new(listener, options) }
+        registrations.merge new_registrations
         yield
       ensure
-        clear
+        registrations.subtract new_registrations
       end
       self
     end
@@ -30,8 +30,8 @@ module Wisper
 
     private
 
-    def clear
-      registrations.clear
+    def build_registrations(*listeners, **options)
+      listeners.map { |listener| ObjectRegistration.new(listener, **options) }
     end
 
     def key

data/lib/wisper/version.rb

@@ -1,3 +1,3 @@
 module Wisper
-  VERSION = "2.0.0"
+  VERSION = "3.0.0.rc1"
 end

data/lib/wisper.rb

@@ -27,11 +27,11 @@ module Wisper
   #     # ..
   #   end
   #
-  def self.subscribe(*args, &block)
+  def self.subscribe(*args, **kwargs, &block)
     if block_given?
-      TemporaryListeners.subscribe(*args, &block)
+      TemporaryListeners.subscribe(*args, **kwargs, &block)
     else
-      GlobalListeners.subscribe(*args)
+      GlobalListeners.subscribe(*args, **kwargs)
     end
   end
 

data/spec/lib/integration_spec.rb

@@ -15,7 +15,7 @@ describe Wisper do
 
   it 'subscribes object to all published events' do
     listener = double('listener')
-    expect(listener).to receive(:success).with('hello')
+    expect(listener).to receive(:success).with('hello', **{})
 
     command = MyCommand.new
 
@@ -27,8 +27,8 @@ describe Wisper do
   it 'maps events to different methods' do
     listener_1 = double('listener')
     listener_2 = double('listener')
-    expect(listener_1).to receive(:happy_days).with('hello')
-    expect(listener_2).to receive(:sad_days).with('world')
+    expect(listener_1).to receive(:happy_days).with('hello', **{})
+    expect(listener_2).to receive(:sad_days).with('world', **{})
 
     command = MyCommand.new
 

data/spec/lib/simple_example_spec.rb

@@ -11,8 +11,8 @@ end
 describe 'simple publishing' do
   it 'subscribes listener to events' do
     listener = double('listener')
-    expect(listener).to receive(:foo).with instance_of MyPublisher
-    expect(listener).to receive(:bar).with instance_of MyPublisher
+    expect(listener).to receive(:foo).with((instance_of MyPublisher), **{})
+    expect(listener).to receive(:bar).with((instance_of MyPublisher), **{})
 
     my_publisher = MyPublisher.new
     my_publisher.subscribe(listener)

data/spec/lib/temporary_global_listeners_spec.rb

@@ -32,6 +32,42 @@ describe Wisper::TemporaryListeners do
       publisher.instance_eval { broadcast(:failure) }
     end
 
+    it 'globally subscribes listeners for duration of nested block' do
+
+      expect(listener_1).to receive(:success)
+      expect(listener_1).to receive(:failure)
+
+      expect(listener_2).to receive(:success)
+      expect(listener_2).to_not receive(:failure)
+
+      Wisper::TemporaryListeners.subscribe(listener_1) do
+        Wisper::TemporaryListeners.subscribe(listener_2) do
+          publisher.instance_eval { broadcast(:success) }
+        end
+        publisher.instance_eval { broadcast(:failure) }
+      end
+    end
+
+    it 'clears registrations for the block which exits' do
+
+      # listener_1 is subscribed twice hence it's supposed to get the message twice
+      expect(listener_1).to receive(:success).twice
+      expect(listener_1).to receive(:failure)
+      expect(listener_1).to_not receive(:ignored)
+
+      expect(listener_2).to receive(:success)
+      expect(listener_2).to_not receive(:failure)
+      expect(listener_2).to_not receive(:ignored)
+
+      Wisper::TemporaryListeners.subscribe(listener_1) do
+        Wisper::TemporaryListeners.subscribe(listener_1, listener_2) do
+          publisher.instance_eval { broadcast(:success) }
+        end
+        publisher.instance_eval { broadcast(:failure) }
+      end
+      publisher.instance_eval { broadcast(:ignored) }
+    end
+
     it 'is thread safe' do
       num_threads = 20
       (1..num_threads).to_a.map do

data/spec/lib/wisper/broadcasters/logger_broadcaster_spec.rb

@@ -8,10 +8,34 @@ module Wisper
         let(:listener)  { double }
         let(:logger)    { double.as_null_object }
 
-        it 'broadcasts the event to the listener' do
-          publisher.subscribe(listener, :broadcaster => LoggerBroadcaster.new(logger, Wisper::Broadcasters::SendBroadcaster.new))
-          expect(listener).to receive(:it_happened).with(1, 2)
-          publisher.send(:broadcast, :it_happened, 1, 2)
+        context 'with only positional arguments' do
+          it 'broadcasts the event to the listener' do
+            publisher.subscribe(listener, :broadcaster => LoggerBroadcaster.new(logger, Wisper::Broadcasters::SendBroadcaster.new))
+            if RUBY_VERSION < '3.0'
+              # Ruby 2.7 receives **{} as a positional argument
+              expect(listener).to receive(:it_happened).with(1, 2, {})
+            else
+              # Ruby 3.0 doesn't pass **empty_hash
+              expect(listener).to receive(:it_happened).with(1, 2)
+            end
+            publisher.send(:broadcast, :it_happened, 1, 2)
+          end
+        end
+
+        context 'with only keyword arguments' do
+          it 'broadcasts the event to the listener' do
+            publisher.subscribe(listener, :broadcaster => LoggerBroadcaster.new(logger, Wisper::Broadcasters::SendBroadcaster.new))
+            expect(listener).to receive(:it_happened).with(key: 'value')
+            publisher.send(:broadcast, :it_happened, key: 'value')
+          end
+        end
+
+        context 'with positional and keyword arguments' do
+          it 'broadcasts the event to the listener' do
+            publisher.subscribe(listener, :broadcaster => LoggerBroadcaster.new(logger, Wisper::Broadcasters::SendBroadcaster.new))
+            expect(listener).to receive(:it_happened).with(1, 2, key: 'value')
+            publisher.send(:broadcast, :it_happened, 1, 2, key: 'value')
+          end
         end
       end
 
@@ -27,38 +51,41 @@ module Wisper
         describe '#broadcast' do
           context 'without arguments' do
             let(:args) { [] }
+            let(:kwargs) { {} }
 
             it 'logs published event' do
-              expect(logger).to receive(:info).with('[WISPER] Publisher#1 published thing_created to Listener#2 with no arguments')
-              subject.broadcast(listener, publisher, event, args)
+              expect(logger).to receive(:info).with('[WISPER] Publisher#1 published thing_created to Listener#2 with no arguments and no keyword arguments')
+              subject.broadcast(listener, publisher, event, *args, **kwargs)
             end
 
             it 'delegates broadcast to a given broadcaster' do
-              expect(broadcaster).to receive(:broadcast).with(listener, publisher, event, args)
-              subject.broadcast(listener, publisher, event, args)
+              expect(broadcaster).to receive(:broadcast).with(listener, publisher, event, *args, **kwargs)
+              subject.broadcast(listener, publisher, event, *args, **kwargs)
             end
           end
 
           context 'with arguments' do
             let(:args) { [arg_double(id: 3), arg_double(id: 4)] }
+            let(:kwargs) { {x: :y} }
 
             it 'logs published event and arguments' do
-              expect(logger).to receive(:info).with('[WISPER] Publisher#1 published thing_created to Listener#2 with Argument#3, Argument#4')
-              subject.broadcast(listener, publisher, event, args)
+              expect(logger).to receive(:info).with("[WISPER] Publisher#1 published thing_created to Listener#2 with Argument#3, Argument#4 and keyword arguments {:x=>:y}")
+              subject.broadcast(listener, publisher, event, *args, **kwargs)
             end
 
             it 'delegates broadcast to a given broadcaster' do
-              expect(broadcaster).to receive(:broadcast).with(listener, publisher, event, args)
-              subject.broadcast(listener, publisher, event, args)
+              expect(broadcaster).to receive(:broadcast).with(listener, publisher, event, *args, **kwargs)
+              subject.broadcast(listener, publisher, event, *args, **kwargs)
             end
 
             context 'when argument is a hash' do
               let(:args) { [hash] }
               let(:hash) { {key: 'value'} }
+              let(:kwargs) { {x: :y} }
 
               it 'logs published event and arguments' do
-                expect(logger).to receive(:info).with("[WISPER] Publisher#1 published thing_created to Listener#2 with Hash##{hash.object_id}: #{hash.inspect}")
-                subject.broadcast(listener, publisher, event, args)
+                expect(logger).to receive(:info).with("[WISPER] Publisher#1 published thing_created to Listener#2 with Hash##{hash.object_id}: #{hash.inspect} and keyword arguments {:x=>:y}")
+                subject.broadcast(listener, publisher, event, *args, **kwargs)
               end
             end
 
@@ -67,8 +94,17 @@ module Wisper
               let(:number) { 10 }
 
               it 'logs published event and arguments' do
-                expect(logger).to receive(:info).with("[WISPER] Publisher#1 published thing_created to Listener#2 with #{number.class.name}##{number.object_id}: 10")
-                subject.broadcast(listener, publisher, event, args)
+                expect(logger).to receive(:info).with("[WISPER] Publisher#1 published thing_created to Listener#2 with #{number.class.name}##{number.object_id}: 10 and keyword arguments {:x=>:y}")
+                subject.broadcast(listener, publisher, event, *args, **kwargs)
+              end
+            end
+
+            context 'when only keyword arguments are present' do
+              let(:args) { [] }
+
+              it 'logs published event and arguments' do
+                expect(logger).to receive(:info).with("[WISPER] Publisher#1 published thing_created to Listener#2 with no arguments and keyword arguments {:x=>:y}")
+                subject.broadcast(listener, publisher, event, *args, **kwargs)
               end
             end
           end

data/spec/lib/wisper/broadcasters/send_broadcaster_spec.rb

@@ -6,20 +6,60 @@ module Wisper
 
       describe '#broadcast' do
         context 'without arguments' do
+          it 'sends event to listener without any arguments' do
+            if RUBY_VERSION < '3.0'
+              expect(listener).to receive(event).with({})
+            else
+              expect(listener).to receive(event).with(no_args)
+            end
+            subject.broadcast(listener, anything, event)
+          end
+        end
+
+        context 'with empty arguments' do
           let(:args) { [] }
 
           it 'sends event to listener without any arguments' do
-            expect(listener).to receive(event).with(no_args())
-            subject.broadcast(listener, anything, event, args)
+            if RUBY_VERSION < '3.0'
+              expect(listener).to receive(event).with({})
+            else
+              expect(listener).to receive(event).with(no_args)
+            end
+            subject.broadcast(listener, anything, event, *args)
           end
         end
 
         context 'with arguments' do
-          let(:args) { [1,2,3] }
+          context 'with only positional arguments' do
+            let(:args) { [1,2,3] }
+
+            it 'sends event to listener with arguments' do
+              if RUBY_VERSION < '3.0'
+                expect(listener).to receive(event).with(1, 2, 3, {})
+              else
+                expect(listener).to receive(event).with(1, 2, 3)
+              end
+              subject.broadcast(listener, anything, event, *args)
+            end
+          end
+
+          context 'with only keyword arguments' do
+            let(:kwargs) { { key: 'value' } }
+
+            it 'sends event to listener with arguments' do
+              expect(listener).to receive(event).with({key: 'value'})
+              subject.broadcast(listener, anything, event, **kwargs)
+            end
+          end
+
+          context 'with positional and keyword arguments' do
+            let(:args) { [1,2,3] }
+            let(:kwargs) { { key: 'value' } }
 
-          it 'sends event to listener with arguments' do
-            expect(listener).to receive(event).with(*args)
-            subject.broadcast(listener, anything, event, args)
+            it 'sends event to listener with arguments' do
+              expect(listener).to receive(event).with(1,2,3, {key: 'value'})
+              subject.broadcast(listener, anything, event, *args, **kwargs)
+            end
           end
         end
       end

data/spec/lib/wisper/registrations/object_spec.rb

@@ -2,7 +2,7 @@ describe Wisper::ObjectRegistration do
 
   describe 'broadcaster' do
     it 'defaults to SendBroadcaster' do
-      subject = Wisper::ObjectRegistration.new(double('listener'), {})
+      subject = Wisper::ObjectRegistration.new(double('listener'))
       expect(subject.broadcaster).to be_instance_of(Wisper::Broadcasters::SendBroadcaster)
     end
 

data/wisper.gemspec

@@ -17,15 +17,16 @@ Gem::Specification.new do |gem|
   gem.homepage      = "https://github.com/krisleech/wisper"
   gem.license       = "MIT"
 
-  signing_key = File.expand_path('~/.ssh/gem-private_key.pem')
+  gem.required_ruby_version = '>= 2.7'
+
+  signing_key = File.expand_path(ENV['HOME'].to_s + '/.ssh/gem-private_key.pem')
 
   if File.exist?(signing_key)
     gem.signing_key = signing_key
     gem.cert_chain  = ['gem-public_cert.pem']
   end
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.files         = `git ls-files`.split($/).reject { |f| f.split('/').first == 'bin' }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 end

metadata

@@ -1,14 +1,34 @@
 --- !ruby/object:Gem::Specification
 name: wisper
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.0.rc1
 platform: ruby
 authors:
 - Kris Leech
-autorequire: 
+autorequire:
 bindir: bin
-cert_chain: []
-date: 2017-03-07 00:00:00.000000000 Z
+cert_chain:
+- |
+  -----BEGIN CERTIFICATE-----
+  MIIC/jCCAeagAwIBAgIBAjANBgkqhkiG9w0BAQsFADAlMSMwIQYDVQQDDBprcmlz
+  LmxlZWNoL0RDPWdtYWlsL0RDPWNvbTAeFw0yMzA3MDYxNTI0MDdaFw0yNDA3MDUx
+  NTI0MDdaMCUxIzAhBgNVBAMMGmtyaXMubGVlY2gvREM9Z21haWwvREM9Y29tMIIB
+  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA8gg/iZE6RFkl6GjisJJf9wQl
+  5Tog+mrGqtylNpe9QKeyQS1fKLNR3Cqmv6sT3f3GlU8hhG+802MXmlJo7VyENs+s
+  HdMy85fBnYwhS/szhTzBqduXw43RAAGqB0VaHAoHdufTZBkmFSXET5c0/jUqQrPL
+  Zxsm2i0NV8cVpvrZlQcsW4Kf97DG1ZFNncS0IfCDqnluh21qMSgVAuiKHGoVKCYG
+  Igey486VuuJ8j6axwW3ii8HoBOxjF8Ka/rJ/t4sB9Ql/p6RHR4RhxP5xIS9geCpI
+  dsPGnCSleTW1EnXGHLdOdJpVmJXueYJEQJ1Rh/rR+9PeqAT3RA0D/dxSGIVtrQID
+  AQABozkwNzAJBgNVHRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHQ4EFgQUyupX2gb3
+  +isBRwf4/fhgLnh02sYwDQYJKoZIhvcNAQELBQADggEBABdaC++ZW0a2N7oLen4+
+  i/4JKdVqa2+BKCQtJdaFsejjGURcudXaY5wqEhgP4ADQ8ANOFF0dCDPPsEn6qMhf
+  cNEbRQhMexbe5xQTRVey+20i6vvnJ/kwqnftxAm28Jc3QMMsPk+iM2HZiOsBzICj
+  b7k2mPBUf3M6aj8i2fRo6H79PsAN3y7AyU9/KhgkcwHQhr+k7kFpnXKMNlw02ctg
+  nzy6xfYdDTzcw47twNBWr53COJTJMgdmlVupROoNjQsJTvuSfUiuy5JFGqS0fijB
+  tiGTXMVCk/fOTj04HvFZi/P11KUmQ6HsevziemEgQOnG2lCp+BkyNN0Y4XVW/mno
+  x7Y=
+  -----END CERTIFICATE-----
+date: 2023-07-06 00:00:00.000000000 Z
 dependencies: []
 description: |2
       A micro library providing objects with Publish-Subscribe capabilities.
@@ -20,9 +40,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
@@ -61,7 +81,7 @@ homepage: https://github.com/krisleech/wisper
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -69,16 +89,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: A micro library providing objects with Publish-Subscribe capabilities
 test_files:

metadata.gz.sig

@@ -0,0 +1,3 @@
+]�gg��c�~�i�V��H+M�1��z�d9�ɱ�e4�
+s��V�/R!m/;�'B0<t��wNҠ�Bp��r�hu����d��ȶ���-8)��	O/s�g\��?u��P_!4�g�*"��
c���ݷtꁊ��E�N�_,Z�[$�
+����G��.

data/.travis.yml

@@ -1,22 +0,0 @@
-language: ruby
-before_install:
-  - gem update --system
-  - gem update bundler
-bundler_args: --without=extras
-script: rspec spec
-sudo: false
-rvm:
-  - '2.1.10'
-  - '2.2.6'
-  - '2.3.3'
-  - '2.4.0'
-  - jruby-9.1.6.0
-  # - rbx-2
-  ### ALLOWED FAILURES ###
-  # see how compatible we are with dev versions, but do not fail the build
-  - ruby-head
-  - jruby-head
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: jruby-head