wisper 1.1.0 → 1.2.0

data/README.md

@@ -202,7 +202,7 @@ However it means that when looking at the code it will not be obvious that the
 global listeners are being executed in additional to the regular listeners.
 
 ```ruby
-Wisper::GlobalListeners.add_listener(MyListener.new)
+Wisper.add_listener(MyListener.new)
 ```
 
 In a Rails app you might want to add your global listeners in an initalizer.

data/lib/wisper.rb

@@ -16,4 +16,8 @@ module Wisper
   def self.with_listeners(*args, &block)
     TemporaryListeners.with(*args, &block)
   end
+
+  def self.add_listener(listener)
+    GlobalListeners.add(listener)
+  end
 end

data/lib/wisper/global_listeners.rb

@@ -11,7 +11,7 @@ module Wisper
       @mutex         = Mutex.new
     end
 
-    def add_listener(listener, options = {})
+    def add(listener, options = {})
       with_mutex { @registrations << ObjectRegistration.new(listener, options) }
       self
     end
@@ -28,8 +28,8 @@ module Wisper
       with_mutex { @registrations.clear }
     end
 
-    def self.add_listener(listener, options = {})
-      instance.add_listener(listener, options)
+    def self.add(listener, options = {})
+      instance.add(listener, options)
     end
 
     def self.registrations
@@ -44,6 +44,12 @@ module Wisper
       instance.clear
     end
 
+    # remain backwards compatible
+    def self.add_listener(listener, options = {})
+      warn "[DEPRECATION] use `add` instead of `add_listener`"
+      add(listener, options)
+    end
+
     private
 
     def with_mutex

data/lib/wisper/publisher.rb

@@ -17,8 +17,8 @@ module Wisper
     end
 
     # sugar
-    def respond_to(event, &block)
-      add_block_listener({:on => event}, &block)
+    def respond_to(*events, &block)
+      add_block_listener({:on => events}, &block)
     end
 
     alias :on :respond_to

data/lib/wisper/version.rb

@@ -1,3 +1,3 @@
 module Wisper
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/lib/global_subscribers_spec.rb

@@ -5,18 +5,16 @@ describe Wisper::GlobalListeners do
   let(:local_listener)   { double('listener') }
   let(:publisher)        { publisher_class.new }
 
-  after(:each) { Wisper::GlobalListeners.clear }
-
-  describe '.add_listener' do
+  describe '.add' do
     it 'adds given listener to every publisher' do
-      Wisper::GlobalListeners.add_listener(global_listener)
+      Wisper::GlobalListeners.add(global_listener)
       global_listener.should_receive(:it_happened)
       publisher.send(:broadcast, :it_happened)
     end
 
     it 'works along side local listeners' do
       # global listener
-      Wisper::GlobalListeners.add_listener(global_listener)
+      Wisper::GlobalListeners.add(global_listener)
 
       # local listener
       publisher.add_listener(local_listener)
@@ -31,7 +29,7 @@ describe Wisper::GlobalListeners do
       num_threads = 100
       (1..num_threads).to_a.map do
         Thread.new do
-          Wisper::GlobalListeners.add_listener(Object.new)
+          Wisper::GlobalListeners.add(Object.new)
           sleep(rand) # a little chaos
         end
       end.each(&:join)
@@ -42,7 +40,7 @@ describe Wisper::GlobalListeners do
 
   describe '.listeners' do
     it 'returns collection of global listeners' do
-      Wisper::GlobalListeners.add_listener(global_listener)
+      Wisper::GlobalListeners.add(global_listener)
       Wisper::GlobalListeners.listeners.should == [global_listener]
     end
 
@@ -53,8 +51,18 @@ describe Wisper::GlobalListeners do
   end
 
   it '.clear clears all global listeners' do
-    Wisper::GlobalListeners.add_listener(global_listener)
+    Wisper::GlobalListeners.add(global_listener)
     Wisper::GlobalListeners.clear
     Wisper::GlobalListeners.listeners.should be_empty
   end
+
+  describe 'backwards compatibility' do
+    it '.add_listener adds a listener' do
+      silence_warnings do
+        Wisper::GlobalListeners.add_listener(global_listener)
+        global_listener.should_receive(:it_happened)
+        publisher.send(:broadcast, :it_happened)
+      end
+    end
+  end
 end

data/spec/lib/wisper/publisher_spec.rb

@@ -90,6 +90,19 @@ describe Wisper::Publisher do
         publisher.send(:broadcast, 'something_happened')
         publisher.send(:broadcast, 'and_so_did_this')
       end
+
+      it '.add_block_listener subscribes block to all listed events' do
+        insider.should_receive(:it_happened).twice
+
+        publisher.add_block_listener(
+          :on => ['something_happened', 'and_so_did_this']) do
+          insider.it_happened
+        end
+
+        publisher.send(:broadcast, 'something_happened')
+        publisher.send(:broadcast, 'and_so_did_this')
+        publisher.send(:broadcast, 'but_not_this')
+      end
     end
 
     it 'returns publisher so methods can be chained' do
@@ -99,8 +112,9 @@ describe Wisper::Publisher do
   end
 
   describe '.on (alternative block syntax)' do
+    let(:insider) { double('insider') }
+
     it 'subscribes given block to an event' do
-      insider = double('insider')
       insider.should_receive(:it_happened)
 
       publisher.on(:something_happened) do
@@ -109,12 +123,24 @@ describe Wisper::Publisher do
 
       publisher.send(:broadcast, 'something_happened')
     end
+
+    it 'subscribes given block to multiple events' do
+      insider.should_receive(:it_happened).twice
+
+      publisher.on(:something_happened, :and_so_did_this) do
+        insider.it_happened
+      end
+
+      publisher.send(:broadcast, 'something_happened')
+      publisher.send(:broadcast, 'and_so_did_this')
+      publisher.send(:broadcast, 'but_not_this')
+    end
   end
 
   describe '.broadcast' do
     it 'does not publish events which cannot be responded to' do
       listener.should_not_receive(:so_did_this)
-      listener.stub(:respond_to?, false)
+      listener.stub(:respond_to? => false)
 
       publisher.add_listener(listener, :on => 'so_did_this')
 

data/spec/lib/wisper_spec.rb

@@ -22,12 +22,10 @@ describe Wisper do
 
     publisher.send(:broadcast, 'not_here')
   end
-end
 
-# prevents deprecation warning showing up in spec output
-def silence_warnings
-  original_verbosity = $VERBOSE
-  $VERBOSE = nil
-  yield
-  $VERBOSE = original_verbosity
+  it '.add_listener adds a global listener' do
+    listener = double('listener')
+    Wisper.add_listener(listener)
+    Wisper::GlobalListeners.listeners.should == [listener]
+  end
 end

data/spec/spec_helper.rb

@@ -8,9 +8,18 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'
+  config.after(:each) { Wisper::GlobalListeners.clear }
 end
 
 # returns an anonymous wispered class
 def publisher_class
   Class.new { include Wisper::Publisher }
 end
+
+# prevents deprecation warning showing up in spec output
+def silence_warnings
+  original_verbosity = $VERBOSE
+  $VERBOSE = nil
+  yield
+  $VERBOSE = original_verbosity
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wisper
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-07 00:00:00.000000000 Z
+date: 2013-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake