wisper-activerecord 0.3.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: abf0ef394a173a3870dc882787c583c98d5c78f5
-  data.tar.gz: 6183077725919d5ce4e5e3b1f917c79c847f77c0
+  metadata.gz: fad745a4966f059933058249bf4d591d34e409fc
+  data.tar.gz: ff536bef647c1446b384739b90f39412edb39e93
 SHA512:
-  metadata.gz: 8053b1a558f92f4ccfa5e138122956a4266715852b7f89702111071dbc3fc8675856f7fad35ee36fbbbbce6eee795a084be4e8142813360c64744f400d16d8cb
-  data.tar.gz: 9aaadc00d223e96a5b66055697ce762f2e7eb17a688a9bc32f68d59e9d127563f0e8bc8a6c562b31801ce83b81ece3e90655e2a2dbbd52bc684c40d559624aa9
+  metadata.gz: 83206ee20a2f334129eabf67766f7598fb841d838875364ffc6b5722e15fff1f54b7f78490da89e9d112942da8dc0dfae226deeafe3e765e9727b1bf1a2a2d79
+  data.tar.gz: 2da651ee69588854c1a809b651e08c63ff7215d1284aade3d6c1dc6dd93d936f3a727a50d442dfaa8aa6f7d02d68aeac6d286e1e186ff43eb35f4c5934ad7b7b

data/.ruby-version

@@ -0,0 +1 @@
+2.4

data/.travis.yml

@@ -1,11 +1,25 @@
 language: ruby
 bundler_args: --without=metrics
 script: bundle exec rspec spec
+sudo: false
 gemfile:
   - gemfiles/activerecord-3.0
   - gemfiles/activerecord-4.0
+  - gemfiles/activerecord-5.0
 rvm:
-  - '1.9.3'
-  - '2.1.1'
+  - 1.9.3
+  - 2.4.0
   - jruby
   - rbx-2
+matrix:
+  exclude:
+    - rvm: 1.9.3
+      gemfile: gemfiles/activerecord-5.0
+    - rvm: jruby
+      gemfile: gemfiles/activerecord-5.0
+    - rvm: rbx-2
+      gemfile: gemfiles/activerecord-5.0
+    - rvm: 2.4.0
+      gemfile: gemfiles/activerecord-3.0
+  allow_failures:
+    - rvm: rbx-2

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## unreleased
+
+## 1.0.0 (19/May/2017)
+
+Authors: Kris Leech, robwilliams
+
+* Remove deprecated #commit method (breaking change)
+* Update to Wisper 2.0 (non-breaking, but we will released a major anyway)
+* fixed README example
+* document fixes 
+
 ## 0.3.0 (5 Feb 2015)
 
 * Fixed README (Thomas Brus / thomasbrus)

data/README.md

@@ -61,6 +61,7 @@ Please refer to the [Wisper README](https://github.com/krisleech/wisper) for ful
 The events which are automatically broadcast are:
 
 * `after_create`
+* `after_update`
 * `after_destroy`
 * `create_<model_name>_{successful, failed}`
 * `update_<model_name>_{successful, failed}`
@@ -92,9 +93,9 @@ class MeetingsController < ApplicationController
 
   def create
     @meeting = Meeting.new(params[:meeting])
-    @meeting.subscribe(Auditor.instance)
-    @meeting.on(:meeting_create_successful) { redirect_to meeting_path }
-    @meeting.on(:meeting_create_failed)     { render action: :new }
+    @meeting.subscribe(Auditor.new)
+    @meeting.on(:create_meeting_successful) { redirect_to meeting_path }
+    @meeting.on(:create_meeting_failed)     { render action: :new }
     @meeting.save
   end
 
@@ -104,9 +105,9 @@ class MeetingsController < ApplicationController
 
   def update
     @meeting = Meeting.find(params[:id])
-    @meeting.subscribe(Auditor.instance)
-    @meeting.on(:meeting_update_successful) { redirect_to meeting_path }
-    @meeting.on(:meeting_update_failed)     { render :action => :edit }
+    @meeting.subscribe(Auditor.new)
+    @meeting.on(:update_meeting_successful) { redirect_to meeting_path }
+    @meeting.on(:update_meeting_failed)     { render :action => :edit }
     @meeting.update_attributes(params[:meeting])
   end
 end
@@ -121,13 +122,6 @@ you can still use `if @meeting.save` if you prefer.
 
 ```ruby
 class Auditor
-  include Singleton
-
-  attr_accessor :audit
-
-  def initialize
-    @audit = []
-  end
 
   def after_create(subject)
     push_audit_for('create', subject)
@@ -142,13 +136,13 @@ class Auditor
   end
 
   def self.audit
-    instance.audit
+    @audit ||= []
   end
 
   private
 
   def push_audit_for(action, subject)
-    audit.push(audit_for(action, subject))
+    self.class.audit.push(audit_for(action, subject))
   end
 
   def audit_for(action, subject)
@@ -179,9 +173,18 @@ meeting.save
 Auditor.audit # => [...]
 ```
 
+## Notes on Testing 
+
+### ActiveRecord <= 4.0
+
+This gem makes use of ActiveRecord's `after_commit` lifecycle hook to broadcast
+events, which will create issues when testing with transactional fixtures.
+Unless you also include the [test_after_commit gem](https://github.com/grosser/test_after_commit)
+ActiveRecord models will not broadcast any lifecycle events within your tests.
+
 ## Compatibility
 
-Tested on 1.9.3, 2.x, Rubinius and JRuby for ActiveRecord ~> 3.0 and ~> 4.0
+Tested on CRuby, Rubinius and JRuby for ActiveRecord ~> 3.0, ~> 4.0, and ~> 5.0.
 
 See the CI [build status](https://travis-ci.org/krisleech/wisper-activerecord) for more information.
 

data/gemfiles/activerecord-5.0

@@ -0,0 +1,12 @@
+source 'https://rubygems.org'
+
+gem 'rubysl', '~> 2.0', :platforms => :rbx
+
+gem 'rspec'
+
+gem "sqlite3",                          :platform => :ruby
+gem "activerecord-jdbcsqlite3-adapter", :platform => :jruby
+
+gem 'activerecord', '~> 5.0'
+
+gemspec :path => '../'

data/lib/wisper/active_record/publisher.rb

@@ -1,3 +1,5 @@
+require 'wisper'
+
 module Wisper
   module ActiveRecord
     module Publisher
@@ -14,19 +16,6 @@ module Wisper
         after_rollback   :after_rollback_broadcast
       end
 
-      def commit(_attributes = nil)
-        warn "[DEPRECATED] use save, create, update_attributes as usual"
-        assign_attributes(_attributes) if _attributes.present?
-        save
-      end
-
-      module ClassMethods
-        def commit(_attributes = nil)
-          warn "[DEPRECATED] use save, create, update_attributes as usual"
-          new(_attributes).save
-        end
-      end
-
       private
 
       def after_validation_broadcast
@@ -54,11 +43,6 @@ module Wisper
         broadcast("#{broadcast_model_name_key}_committed", self)
       end
 
-      def after_commit_broadcast
-        broadcast(:after_commit, self)
-        broadcast("#{broadcast_model_name_key}_committed", self)
-      end
-
       def after_rollback_broadcast
         broadcast(:after_rollback, self)
       end

data/lib/wisper/active_record/version.rb

@@ -1,5 +1,5 @@
 module Wisper
   module ActiveRecord
-    VERSION = "0.3.0"
+    VERSION = "1.0.0"
   end
 end

data/spec/wisper/activerecord_spec.rb

@@ -9,48 +9,6 @@ describe 'ActiveRecord' do
     expect(Wisper.model).to eq Wisper::ActiveRecord::Publisher
   end
 
-  describe '.commit' do # DEPRECATED
-    describe 'when creating' do
-      context 'and model is valid' do
-        it 'publishes create_<model_name>_successful event to listener' do
-          expect(listener).to receive(:create_meeting_successful).with(instance_of(model_class))
-          model_class.subscribe(listener)
-          model_class.commit
-        end
-      end
-
-      context 'and model is not valid' do
-        it 'publishes create_<model_name>_failed event to listener' do
-          expect(listener).to receive(:create_meeting_failed).with(instance_of(model_class))
-          model_class.subscribe(listener)
-          model_class.commit(title: nil)
-        end
-      end
-    end
-
-    describe 'when updating' do
-      before { model_class.create! }
-
-      let(:model) { model_class.first }
-
-      context 'and model is valid' do
-        it 'publishes update_<model_name>_successful event to listener' do
-          expect(listener).to receive(:update_meeting_successful).with(instance_of(model_class))
-          model_class.subscribe(listener)
-          model.commit(title: 'foo')
-        end
-      end
-
-      context 'and model is not valid' do
-        it 'publishes update_<model_name>_failed event to listener' do
-          expect(listener).to receive(:update_meeting_failed).with(instance_of(model_class))
-          model_class.subscribe(listener)
-          model.commit(title: nil)
-        end
-      end
-    end
-  end
-
   describe 'create' do
     it 'publishes an after_create event to listener' do
       expect(listener).to receive(:after_create).with(instance_of(model_class))

data/wisper-activerecord.gemspec

@@ -19,6 +19,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.required_ruby_version = ">= 1.9.3"
 
-  spec.add_dependency "wisper", "~> 1.3"
+  spec.add_dependency "wisper", "~> 2.0"
   spec.add_dependency "activerecord", ">= 3.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wisper-activerecord
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Kris Leech
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-05 00:00:00.000000000 Z
+date: 2017-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: wisper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -47,6 +47,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -55,6 +56,7 @@ files:
 - Rakefile
 - gemfiles/activerecord-3.0
 - gemfiles/activerecord-4.0
+- gemfiles/activerecord-5.0
 - lib/wisper/active_record.rb
 - lib/wisper/active_record/publisher.rb
 - lib/wisper/active_record/version.rb
@@ -85,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Subscribe to changes on ActiveRecord models