wirecard_sepa 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb017d5a1e8c8565f687f384e591a0ca1737a8d6
-  data.tar.gz: 23e29f839adc122359effceb2a3b89ea2bada6f4
+  metadata.gz: 6f4973b11b84922100635e24a2b0602ee0ccecbf
+  data.tar.gz: 0cf6f83b49abfcce56cc7d6f5fc31a1567ad11a2
 SHA512:
-  metadata.gz: b9c765cde9e57257c36dd2acb98cac536b77e5bbc6a49ead825af81b1d5388abcf9a9f600174945b81393eb7f0f974c69b3fc089c3701e72e1501051e717ffe5
-  data.tar.gz: 8977336242a25b11482a41b17d7666b499f8e285546207c4573770b13f68710c9f92d9fa610a7b7305101f52db1083af036b200cbcedfef4458b8932a011b701
+  metadata.gz: 857ffa44477f0804c427497103fd83944e7a3f85458d87c2e77b8309b11b6ee602be8e8e4c73f0acc131432f782e0267be599028986846e5a832997e9014a95c
+  data.tar.gz: 8abd6bf8c09e3fc355217edade3a2a87ec583c3b5e14ad9aae2b562d4137e61d60345d821423b0cd9687b077eff4aa19a59afbe6d71dc35b0b181a17f85c025f

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.1.2] - 2015-09-09
+### Fixed
+- Params for a debit return may now contain special chars without leading to a malformed XML doc.
+  E.g. having "&" or "<" in a param lead to a malformed XML doc.
+
 ## [0.1.1] - 2015-09-08
 ### Changed
 - All response objects implement `to_s` which returns the actual response xml string

data/lib/wirecard_sepa/utils/template.rb

@@ -1,3 +1,5 @@
+require 'rexml/text'
+
 module WirecardSepa
   module Utils
     class Template
@@ -16,7 +18,7 @@ module WirecardSepa
 
       def request_params
         params_without_custom_fields.each_with_object({}) do |(k,v), h|
-          h["{{#{k.upcase}}}"] = v
+          h["{{#{k.upcase}}}"] = REXML::Text.new(v.to_s)
         end.merge('{{CUSTOM_FIELDS}}' => custom_fields_xml)
       end
 

data/lib/wirecard_sepa/version.rb

@@ -1,3 +1,3 @@
 module WirecardSepa
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/lib/wirecard_sepa/direct_debit/request_spec.rb

@@ -30,15 +30,22 @@ describe WirecardSepa::DirectDebit::Request do
   end
 
   describe '#to_xml' do
+    let(:xsd)    { Nokogiri::XML::Schema(read_support_file('payment.xsd')) }
+    let(:doc)    { Nokogiri::XML(subject.to_xml) { |config| config.strict } }
+    let(:errors) { xsd.validate(doc) }
+
     it 'builds the correct xml' do
       expected_xml = read_support_file('direct_debit/success/request_with_custom_fields.xml')
       expect(subject.to_xml).to eq expected_xml
     end
 
     it 'builds a valid request' do
-      xsd = Nokogiri::XML::Schema(read_support_file('payment.xsd'))
-      doc = Nokogiri::XML(subject.to_xml)
-      errors = xsd.validate(doc)
+      expect(errors).to be_empty
+    end
+
+    it 'can handle special chars' do
+      params[:account_holder_first_name] = 'Firma'
+      params[:account_holder_last_name]  = 'Muscle Line Poerschke © & Rez Gbr.'
       expect(errors).to be_empty
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wirecard_sepa
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - betterplace developers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-08 00:00:00.000000000 Z
+date: 2015-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus