win32-taskscheduler 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10db6c303493c5c308511397a042a8595eeb63da
-  data.tar.gz: 3d8cca5c8168f5232c6cbfb1ffa0924dac6d81d9
+  metadata.gz: 73d17d442fa2fa10b337a907dd0c2831b722cf56
+  data.tar.gz: 60051a6eb63417dce9a9dd9e2428b32e6afc21c1
 SHA512:
-  metadata.gz: 435915b83d71f4f2fb45222d530be067ea6a36d1fb7d4584cd67ef72b7f6f83af677e73b31c03186fb41568c68c5ce0d674c065a9c5dfa50cadf852f19ec8a6e
-  data.tar.gz: 1c0a7dbe1185f14cbb897510ffe1fa4d99299d2de655ec0e639c00a55fa91976d3b08533e4af3cd2dcdd906afe7c8e2c3fb3d9c8f6ef6f6af4c720d5d87bd914
+  metadata.gz: 0b84db2f85f3703e0f60f435d77736100169b20bbc5dd43dcd3ee3a43c6869aa7f8db0bc8fcfc9fd934040e716fbad262e62b1c00b78290df512289a33459e18
+  data.tar.gz: 9dcbf5dfd9bca8b15f52741c913d602dacf31ae706c89dda1cb6e25362ca65d98434a8f0e172c33edfe1d8cc9bcce2a087ef5183bb7cf00b3edad1f36374df86

data/CHANGES

@@ -1,3 +1,8 @@
+== 0.3.1 - 6-Jul-2014
+* Added FFI as a dependency. Thanks go to Maxime Lapointe for the spot.
+* Some updates to the win_error helper method. Thanks go to Ethan J. Brown
+  for the suggestions.
+
 == 0.3.0 - 15-Jan-2014
 * Rewritten to use Win32OLE instead of using wrapping the C API. Benefits
   include working on Windows Vista or later, and working with JRuby.

data/Rakefile

@@ -17,9 +17,9 @@ namespace 'gem' do
   end
 
   desc 'Install the win32-taskscheduler library as a gem'
-  task :install => [:build] do
+  task :install => [:create] do
     file = Dir['win32-taskscheduler*.gem'].first
-    sh "gem install #{file}"
+    sh "gem install -l #{file}"
   end
 end
 

data/lib/win32/taskscheduler.rb

@@ -12,7 +12,7 @@ module Win32
     include Windows::Helper
 
     # The version of the win32-taskscheduler library
-    VERSION = '0.3.0'
+    VERSION = '0.3.1'
 
     # The Error class is typically raised if any TaskScheduler methods fail.
     class Error < StandardError; end

data/lib/win32/windows/helper.rb

@@ -4,18 +4,27 @@ module Windows
   module Helper
     extend FFI::Library
 
+    FORMAT_MESSAGE_IGNORE_INSERTS = 0x00000200
+    FORMAT_MESSAGE_FROM_SYSTEM    = 0x00001000
+    FORMAT_MESSAGE_MAX_WIDTH_MASK = 0x000000FF
+
     ffi_lib :kernel32
 
     attach_function :FormatMessage, :FormatMessageA,
     [:ulong, :pointer, :ulong, :ulong, :pointer, :ulong, :pointer], :ulong
 
     def win_error(function, err=FFI.errno)
-      flags = 0x00001000 | 0x00000200
       buf = FFI::MemoryPointer.new(:char, 1024)
 
-      FormatMessage(flags, nil, err , 0x0409, buf, 1024, nil)
+      flags = FORMAT_MESSAGE_IGNORE_INSERTS |
+              FORMAT_MESSAGE_FROM_SYSTEM |
+              FORMAT_MESSAGE_MAX_WIDTH_MASK
+
+      # 0x0409 == MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)
+      # We use English for errors because Ruby uses English for errors.
+      len = FormatMessage(flags, nil, err , 0x0409, buf, buf.size, nil)
 
-      function + ': ' + buf.read_string.strip
+      function + ': ' + buf.read_string(len).strip
     end
 
     def ole_error(function, err)

data/test/test_taskscheduler.rb

@@ -41,7 +41,7 @@ class TC_TaskScheduler < Test::Unit::TestCase
   end
 
   test "version constant is set to expected value" do
-    assert_equal('0.3.0', TaskScheduler::VERSION)
+    assert_equal('0.3.1', TaskScheduler::VERSION)
   end
 
   test "account_information method basic functionality" do

data/win32-taskscheduler.gemspec

@@ -2,7 +2,7 @@ require 'rubygems'
 
 Gem::Specification.new do |spec|
   spec.name       = 'win32-taskscheduler'
-  spec.version    = '0.3.0'
+  spec.version    = '0.3.1'
   spec.authors    = ['Park Heesob', 'Daniel J. Berger']
   spec.license    = 'Artistic 2.0'
   spec.email      = 'djberg96@gmail.com'
@@ -13,6 +13,7 @@ Gem::Specification.new do |spec|
 
   spec.rubyforge_project = 'win32utils'
 
+  spec.add_dependency('ffi')
   spec.add_dependency('structured_warnings')
 
   spec.add_development_dependency('test-unit')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: win32-taskscheduler
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Park Heesob
@@ -9,8 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-15 00:00:00.000000000 Z
+date: 2014-07-06 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: ffi
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: structured_warnings
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: win32utils
-rubygems_version: 2.2.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A library for the Windows task scheduler