win32-open3 0.2.9-x86-mswin32-60 → 0.3.0-x86-mswin32-60

data/CHANGES

@@ -1,3 +1,10 @@
+== 0.3.0 - 22-Jun-2009
+* Fixed an issue where the block form of the Open3.popen3 method did not
+  return the exit value.
+* Fixed the version number.
+* Added a test to validate the exit value in block form.
+* Updated the gemspec description.
+
 == 0.2.9 - 8-Mar-2009
 * Fixed a bug within an internal function that could cause an exception.
   Thanks go to Ross Bunker for the spot and patch.

data/MANIFEST

@@ -8,4 +8,4 @@
 * ext/extconf.rb
 * ext/win32/open3.c
 * ext/win32/open3.h
-* test/tc_open3.rb
+* test/test_win32_open3.rb

data/doc/open3.txt

@@ -0,0 +1,75 @@
+= Description
+   An open3 library for MS Windows.
+	
+= Synopsis
+   require 'win32/open3'
+	
+   Open3.popen3('ver'){ |io_in, io_out, io_err|
+      error = io_err.gets
+      if error
+         puts "Error: " + error.chomp
+         exit
+      end
+      puts "Result: " + io_out.readlines.last.chomp
+   }
+
+= Module functions
+Open3.popen3(command, mode='t', show=false)
+
+Open3.popen3(command, mode='t', show=false){ |io_in, io_out, io_err| ... }
+
+   Executes 'command', returning an array of three IO handles representing
+   STDIN, STDOUT and STDERR, respectively.  In block form these IO handles
+   are yielded back to the block and automatically closed at the end of the
+   block.
+	
+   You may optionally pass a mode flag of 't' (text, the default) or 'b'
+   (binary) to this method.
+	
+   If the 'show' variable is set to true, then a console window is shown.
+
+Open4.popen4(command, mode='t', show=false)
+
+Open4.popen4(command, mode='t', show=false){ |io_in, io_out, io_err, pid| ... }
+   
+   Executes 'command', returning an array consisting of three IO handles,
+   representing STDIN, STDOUT and STDERR, respectively, as well as the PID
+   of the newly generated process.  In block form these IO handles and pid
+   are yielded back to the block and automatically closed at the end of the
+   block.
+	
+   You may optionally pass a mode flag of 't' (text, the default) or 'b'
+   (binary) to this method.
+	
+   If the 'show' variable is set to true, then a console window is shown.
+	
+= Notes
+   This is a remake of Park Heesob's win32_popen package.  It has been reworked
+   in order to make the API (nearly) identical to the Open3 package currently
+   included in the Ruby standard library.
+	
+   For now only the popen3 and popen4 methods have been included.  In later
+   releases we will probably add the popen2 and posix_popen methods back in.
+
+= Acknowledgements
+   Thanks go to Samuel Tesla and John-Mason Shackelford for their patches that
+   enabled us to set Process::Status.
+	
+= Known Bugs  
+   None that I know of.  Please log any other bug reports on the RubyForge
+   project page at http://www.rubyforge.net/projects/win32utils.
+      
+= License
+   Ruby's
+        
+= Copyright
+   (C) 2003-2009 Daniel J. Berger, All Rights Reserved .
+       
+= Warranty
+   This package is provided "as is" and without any express or
+   implied warranties, including, without limitation, the implied
+   warranties of merchantability and fitness for a particular purpose.
+		
+= Authors
+   Park Heesob
+   Daniel J. Berger

data/ext/win32/open3.c

@@ -136,8 +136,7 @@ static VALUE win32_popen3(int argc, VALUE *argv, VALUE klass)
 
    // Ensure handles are closed in block form
    if(rb_block_given_p()){
-      rb_ensure(rb_yield_splat, v_port, io_close, v_port);
-      return win32_last_status;
+      return rb_ensure(rb_yield_splat, v_port, io_close, v_port);
    }
 
    return v_port;

data/test/test_win32_open3.rb

@@ -17,11 +17,12 @@ class TC_Win32_Open3 < Test::Unit::TestCase
       @stdin    = nil
       @stdout   = nil
       @stderr   = nil
+      @value    = nil
    end
 
    def test_open3_version
-      assert_equal('0.2.8', Open3::WIN32_OPEN3_VERSION)
-      assert_equal('0.2.8', Open4::WIN32_OPEN3_VERSION)
+      assert_equal('0.3.0', Open3::WIN32_OPEN3_VERSION)
+      assert_equal('0.3.0', Open4::WIN32_OPEN3_VERSION)
    end
    
    def test_open3_basic
@@ -94,8 +95,19 @@ class TC_Win32_Open3 < Test::Unit::TestCase
       assert_nil(fout.gets)
    end
    
+   def test_exit_status_in_block_form_popen4
+      assert_nothing_raised{ @value = Open3.popen3('dir'){ |x,y,z| 1 } }
+      assert_equal(1, @value)
+   end
+   
+   def test_exit_status_in_block_form_popen4
+      assert_nothing_raised{ @value = Open4.popen4('dir'){ |x,y,z,a| 1 } }
+      assert_equal(1, @value)
+   end
+   
    def teardown
       @good_cmd = nil
       @bad_cmd  = nil
+      @value    = nil
    end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: win32-open3
 version: !ruby/object:Gem::Version 
-  version: 0.2.9
+  version: 0.3.0
 platform: x86-mswin32-60
 authors: 
 - Park Heesob
@@ -10,11 +10,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-03-07 23:00:00 -07:00
+date: 2009-06-22 00:00:00 -06:00
 default_executable: 
 dependencies: []
 
-description: Provides an Open3.popen3 implementation for MS Windows
+description: "         The win32-open3 library provides a working implemetation of the open3\n         library for MS Windows. In addition, it provides the Open4 class, which\n         also returns pid information.\n      \n         Note that this library is largely unnecessary with Ruby 1.9.x because of\n         its support for native threads.\n"
 email: djberg96@gmail.com
 executables: []
 
@@ -24,6 +24,7 @@ extra_rdoc_files:
 - README
 - CHANGES
 - MANIFEST
+- doc/open3.txt
 - ext/win32/open3.c
 files: 
 - lib/win32/open3.so
@@ -31,9 +32,12 @@ files:
 - README
 - CHANGES
 - MANIFEST
+- doc/open3.txt
 - ext/win32/open3.c
 has_rdoc: true
 homepage: http://www.rubyforge.org/projects/win32utils
+licenses: []
+
 post_install_message: 
 rdoc_options: []
 
@@ -54,9 +58,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: win32utils
-rubygems_version: 1.3.1
+rubygems_version: 1.3.4
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: Provides an Open3.popen3 implementation for MS Windows
 test_files: 
 - test/test_win32_open3.rb