win32-open3 0.2.8-x86-mswin32-60 → 0.2.9-x86-mswin32-60

data/CHANGES

@@ -1,10 +1,15 @@
-== 0.2.8 - 27-Feb-2008
+== 0.2.9 - 8-Mar-2009
+* Fixed a bug within an internal function that could cause an exception.
+  Thanks go to Ross Bunker for the spot and patch.
+* Fixed the release dates for 0.2.7 and 0.2.8 (2009, not 2008).
+
+== 0.2.8 - 27-Feb-2009
 * Fixed a potential bug where nil might be returned instead of an actual
   Process::Status object. Thanks go to Benny Bach for the spot.
 * The 'test' Rake task now runs the 'clean' task after the fact.
 * Some updates to the README about precompiled binaries.
 
-== 0.2.7 - 11-Jan-2008
+== 0.2.7 - 11-Jan-2009
 * Fixed a bug that could cause exitstatus to return bogus information. Thanks
   go to Roman Zawada for the spot.
 * Added a 'build_binary_gem' Rake task.

data/ext/win32/open3.c

@@ -74,7 +74,7 @@ static char* rb_io_modenum_mode(int flags, char* mode){
       }
       else{
          mode[1] = 'b'; mode[2] = '\0';
-      }      
+      }
    }
 #endif
    return mode;
@@ -96,15 +96,15 @@ static VALUE io_close(VALUE val) {
  * call-seq:
  *    Open3.popen3(cmd, mode='t', show=false)
  *    Open3.popen3(cmd, mode='t', show=false){ |io_in, io_out, io_err| ... }
- * 
+ *
  * Executes 'command', returning an array of three IO handles representing
  * STDIN, STDOUT and STDERR, respectively.  In block form these IO handles
  * are yielded back to the block and automatically closed at the end of the
  * block.
- *  
+ *
  * You may optionally pass a mode flag of 't' (text, the default) or 'b'
  * (binary) to this method.
- *  
+ *
  * If the 'show' variable is set to true, then a console window is shown.
  */
 static VALUE win32_popen3(int argc, VALUE *argv, VALUE klass)
@@ -133,13 +133,13 @@ static VALUE win32_popen3(int argc, VALUE *argv, VALUE klass)
       tm = _O_BINARY;
 
    v_port = ruby_popen(StringValuePtr(v_name), tm, v_show_window);
-   
+
    // Ensure handles are closed in block form
    if(rb_block_given_p()){
       rb_ensure(rb_yield_splat, v_port, io_close, v_port);
       return win32_last_status;
    }
-   
+
    return v_port;
 }
 
@@ -168,7 +168,7 @@ static BOOL RubyCreateProcess(char *cmdstring, HANDLE hStdin, HANDLE hStdout,
 
       ++comshell;
 
-      // Windows 95, 98 and ME are not supported      
+      // Windows 95, 98 and ME are not supported
       if(GetVersion() < 0x80000000 && _stricmp(comshell, "command.com") != 0){
          x = i + strlen(s3) + strlen(cmdstring) + 1;
          s2 = ALLOCA_N(char, x);
@@ -246,7 +246,7 @@ static BOOL RubyCreateProcess(char *cmdstring, HANDLE hStdin, HANDLE hStdout,
    rb_raise(rb_eRuntimeError, "CreateProcess() failed: %s",
       ErrorDescription(GetLastError())
    );
-   
+
    return FALSE;
 }
 
@@ -281,9 +281,9 @@ static void win32_pipe_finalize(OpenFile *file, int noraise)
 
    if(pid_handle != NULL){
       GetExitCodeProcess(pid_handle, &status);
-      CloseHandle(pid_handle);
 
       if(status != STILL_ACTIVE){
+    	 CloseHandle(pid_handle);
          pid_handle = NULL;
          win32_set_last_status(status, file->pid);
       }
@@ -522,7 +522,7 @@ static VALUE ruby_popen(char *cmdstring, int mode, VALUE v_show_window)
          ErrorDescription(GetLastError())
       );
    }
-   
+
    return port;
 }
 
@@ -533,15 +533,15 @@ static VALUE ruby_popen(char *cmdstring, int mode, VALUE v_show_window)
 void Init_open3()
 {
    VALUE mOpen3 = rb_define_module("Open3");
-   
+
    VALUE mOpen4 = rb_define_module("Open4");
 
    rb_define_module_function(mOpen3, "popen3", win32_popen3, -1);
    rb_define_module_function(mOpen4, "popen4", win32_popen3, -1);
-   
-   /* 0.2.8: The version of this library */
+
+   /* 0.2.9: The version of this library */
    rb_define_const(mOpen3, "WIN32_OPEN3_VERSION", rb_str_new2(WIN32_OPEN3_VERSION));
-   
-   /* 0.2.8: The version of this library */
+
+   /* 0.2.9: The version of this library */
    rb_define_const(mOpen4, "WIN32_OPEN3_VERSION", rb_str_new2(WIN32_OPEN3_VERSION));
 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: win32-open3
 version: !ruby/object:Gem::Version 
-  version: 0.2.8
+  version: 0.2.9
 platform: x86-mswin32-60
 authors: 
 - Park Heesob
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-02-27 00:00:00 -07:00
+date: 2009-03-07 23:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -54,7 +54,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: win32utils
-rubygems_version: 1.3.0
+rubygems_version: 1.3.1
 signing_key: 
 specification_version: 2
 summary: Provides an Open3.popen3 implementation for MS Windows