win32-open3 0.2.7 → 0.2.8

data/CHANGES

@@ -1,3 +1,9 @@
+== 0.2.8 - 27-Feb-2008
+* Fixed a potential bug where nil might be returned instead of an actual
+  Process::Status object. Thanks go to Benny Bach for the spot.
+* The 'test' Rake task now runs the 'clean' task after the fact.
+* Some updates to the README about precompiled binaries.
+
 == 0.2.7 - 11-Jan-2008
 * Fixed a bug that could cause exitstatus to return bogus information. Thanks
   go to Roman Zawada for the spot.

data/README

@@ -47,11 +47,13 @@
    This appears to be an issue between VC++ 6 (which the installer was built
    with) and VC++ 7.0. Your best solution is to either upgrade your C
    compiler or to rebuild Ruby from scratch rather than using the installer.
+   
+= Precompiled binaries
 
-   You can also download a precompiled binary from the project site. Look for a
-   file called 'open3-x.y.z-vc6.so' on the 'files' page, where 'x.y.z' is a
-   version number, if you want a binary that's compatible with Curt Hibbs one
-   click installer.
+   If you do a typical "gem install win32-open3" you will get a precompiled
+   binary appropriate for your platform. If you want to build from source,
+   go the project page and download, download the .zip file, and run the
+   'install' Rake task from the command line.
    
 = Future Plans
    Replace the current implementation with a pure Ruby version.

data/doc/open3.txt

@@ -63,7 +63,7 @@ Open4.popen4(command, mode='t', show=false){ |io_in, io_out, io_err, pid| ... }
    Ruby's
         
 = Copyright
-   (C) 2003-2008 Daniel J. Berger, All Rights Reserved .
+   (C) 2003-2009 Daniel J. Berger, All Rights Reserved .
        
 = Warranty
    This package is provided "as is" and without any express or

data/ext/win32/open3.c

@@ -270,22 +270,23 @@ static void win32_pipe_finalize(OpenFile *file, int noraise)
    int status;
 
    if(file->f){
-   	fclose(file->f);
-   	file->f = NULL;
+      fclose(file->f);
+      file->f = NULL;
    }
 
    if(file->f2){
-   	fclose(file->f2);
-   	file->f2 = NULL;
+      fclose(file->f2);
+      file->f2 = NULL;
    }
 
    if(pid_handle != NULL){
       GetExitCodeProcess(pid_handle, &status);
       CloseHandle(pid_handle);
-      pid_handle = NULL;
 
-      if(status != STILL_ACTIVE)
- 	      win32_set_last_status(status, file->pid);
+      if(status != STILL_ACTIVE){
+         pid_handle = NULL;
+         win32_set_last_status(status, file->pid);
+      }
    }
 }
 
@@ -538,9 +539,9 @@ void Init_open3()
    rb_define_module_function(mOpen3, "popen3", win32_popen3, -1);
    rb_define_module_function(mOpen4, "popen4", win32_popen3, -1);
    
-   /* 0.2.6: The version of this library */
+   /* 0.2.8: The version of this library */
    rb_define_const(mOpen3, "WIN32_OPEN3_VERSION", rb_str_new2(WIN32_OPEN3_VERSION));
    
-   /* 0.2.6: The version of this library */
+   /* 0.2.8: The version of this library */
    rb_define_const(mOpen4, "WIN32_OPEN3_VERSION", rb_str_new2(WIN32_OPEN3_VERSION));
 }

data/ext/win32/open3.h

@@ -1,4 +1,4 @@
-#define WIN32_OPEN3_VERSION "0.2.7"
+#define WIN32_OPEN3_VERSION "0.2.8"
 #define MAX_STRING 512
 
 static VALUE io_alloc _((VALUE));

data/test/test_win32_open3.rb

@@ -1,5 +1,5 @@
 ###########################################################################
-# tc_open3.rb
+# test_win32_open3.rb
 #
 # Test suite for the win32-open3 library.  Except for the
 # 'test_open3_with_arguments' test and Open4 tests, this suite passes
@@ -20,8 +20,8 @@ class TC_Win32_Open3 < Test::Unit::TestCase
    end
 
    def test_open3_version
-      assert_equal('0.2.7', Open3::WIN32_OPEN3_VERSION)
-      assert_equal('0.2.7', Open4::WIN32_OPEN3_VERSION)
+      assert_equal('0.2.8', Open3::WIN32_OPEN3_VERSION)
+      assert_equal('0.2.8', Open4::WIN32_OPEN3_VERSION)
    end
    
    def test_open3_basic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: win32-open3
 version: !ruby/object:Gem::Version 
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors: 
 - Park Heesob
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-11 00:00:00 -07:00
+date: 2009-02-27 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -30,14 +30,6 @@ files:
 - doc/open3.txt
 - test/test_win32_open3.rb
 - ext/extconf.rb
-- ext/Makefile
-- ext/mkmf.log
-- ext/open3-i386-mswin32.def
-- ext/open3-i386-mswin32.exp
-- ext/open3-i386-mswin32.lib
-- ext/open3-i386-mswin32.pdb
-- ext/open3.obj
-- ext/vc60.pdb
 - ext/win32
 - ext/win32/open3.c
 - ext/win32/open3.h
@@ -66,7 +58,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: win32utils
-rubygems_version: 1.3.1
+rubygems_version: 1.3.0
 signing_key: 
 specification_version: 2
 summary: Provides an Open3.popen3 implementation for MS Windows

data/ext/Makefile

@@ -1,181 +0,0 @@
-
-SHELL = /bin/sh
-
-#### Start of system configuration section. ####
-
-srcdir = win32
-topdir = C:/Ruby/lib/ruby/1.8/i386-mswin32
-hdrdir = $(topdir)
-VPATH = $(srcdir);$(topdir);$(hdrdir)
-
-DESTDIR = C:
-prefix = $(DESTDIR)/Ruby
-exec_prefix = $(prefix)
-sitedir = $(prefix)/lib/ruby/site_ruby
-rubylibdir = $(libdir)/ruby/$(ruby_version)
-archdir = $(rubylibdir)/$(arch)
-sbindir = $(exec_prefix)/sbin
-datadir = $(prefix)/share
-includedir = $(prefix)/include
-infodir = $(prefix)/info
-sysconfdir = $(prefix)/etc
-mandir = $(prefix)/man
-libdir = $(exec_prefix)/lib
-sharedstatedir = $(DESTDIR)/etc
-oldincludedir = $(DESTDIR)/usr/include
-sitearchdir = $(sitelibdir)/$(sitearch)
-localstatedir = $(DESTDIR)/var
-bindir = $(exec_prefix)/bin
-sitelibdir = $(sitedir)/$(ruby_version)
-libexecdir = $(exec_prefix)/libexec
-
-CC = cl -nologo
-LIBRUBY = $(RUBY_SO_NAME).lib
-LIBRUBY_A = $(RUBY_SO_NAME)-static.lib
-LIBRUBYARG_SHARED = $(LIBRUBY)
-LIBRUBYARG_STATIC = $(LIBRUBY_A)
-
-RUBY_EXTCONF_H = 
-CFLAGS   =  -MD -Zi -O2b2xg- -G6 
-INCFLAGS = -I. -I$(topdir) -I$(hdrdir) -I$(srcdir)
-DEFS     = 
-CPPFLAGS = -DHAVE_TYPE_RB_PID_T 
-CXXFLAGS = $(CFLAGS) 
-DLDFLAGS =  -link -incremental:no -debug -opt:ref -opt:icf -dll $(LIBPATH) -def:$(DEFFILE) -implib:$(*F:.so=)-$(arch).lib -pdb:$(*F:.so=)-$(arch).pdb 
-LDSHARED = cl -nologo -LD
-AR = lib -nologo
-EXEEXT = .exe
-
-RUBY_INSTALL_NAME = ruby
-RUBY_SO_NAME = msvcrt-ruby18
-arch = i386-mswin32
-sitearch = i386-msvcrt
-ruby_version = 1.8
-ruby = C:/Ruby/bin/ruby
-RUBY = $(ruby:/=\)
-RM = $(RUBY) -run -e rm -- -f
-MAKEDIRS = @$(RUBY) -run -e mkdir -- -p
-INSTALL = @$(RUBY) -run -e install -- -vp
-INSTALL_PROG = $(INSTALL) -m 0755
-INSTALL_DATA = $(INSTALL) -m 0644
-COPY = copy > nul
-
-#### End of system configuration section. ####
-
-preload = 
-
-libpath = . $(libdir)
-LIBPATH =  -libpath:"." -libpath:"$(libdir)"
-DEFFILE = $(TARGET)-$(arch).def
-
-CLEANFILES = mkmf.log
-DISTCLEANFILES = vc*.pdb $(DEFFILE)
-
-extout = 
-extout_prefix = 
-target_prefix = /win32
-LOCAL_LIBS = 
-LIBS = $(LIBRUBYARG_SHARED)  oldnames.lib user32.lib advapi32.lib shell32.lib ws2_32.lib  
-SRCS = open3.c
-OBJS = open3.obj
-TARGET = open3
-DLLIB = $(TARGET).so
-EXTSTATIC = 
-STATIC_LIB = 
-
-RUBYCOMMONDIR = $(sitedir)$(target_prefix)
-RUBYLIBDIR    = $(sitelibdir)$(target_prefix)
-RUBYARCHDIR   = $(sitearchdir)$(target_prefix)
-
-TARGET_SO     = $(DLLIB)
-CLEANLIBS     = $(TARGET).so $(TARGET).il? $(TARGET).tds $(TARGET).map
-CLEANOBJS     = *.obj *.lib *.s[ol] *.pdb *.exp *.bak
-
-all:		$(DLLIB)
-static:		$(STATIC_LIB)
-
-clean:
-		@-$(RM) $(CLEANLIBS:/=\) $(CLEANOBJS:/=\) $(CLEANFILES:/=\)
-
-distclean:	clean
-		@-$(RM) Makefile $(RUBY_EXTCONF_H) conftest.* mkmf.log
-		@-$(RM) core ruby$(EXEEXT) *~ $(DISTCLEANFILES:/=\)
-
-realclean:	distclean
-install: install-so install-rb
-
-install-so: $(RUBYARCHDIR)
-install-so: $(RUBYARCHDIR)/$(DLLIB)
-$(RUBYARCHDIR)/$(DLLIB): $(DLLIB)
-	$(INSTALL_PROG) $(DLLIB:/=\) $(RUBYARCHDIR:/=\)
-install-rb: pre-install-rb install-rb-default
-install-rb-default: pre-install-rb-default
-pre-install-rb: Makefile
-pre-install-rb-default: Makefile
-$(RUBYARCHDIR):
-	$(MAKEDIRS) $@
-
-site-install: site-install-so site-install-rb
-site-install-so: install-so
-site-install-rb: install-rb
-
-.SUFFIXES: .c .m .cc .cxx .cpp .obj
-
-{$(srcdir)}.cc{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(topdir)}.cc{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(hdrdir)}.cc{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-.cc.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(srcdir)}.cxx{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(topdir)}.cxx{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(hdrdir)}.cxx{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-.cxx.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(srcdir)}.cpp{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(topdir)}.cpp{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(hdrdir)}.cpp{}.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-.cpp.obj:
-	$(CXX) $(INCFLAGS) $(CXXFLAGS) $(CPPFLAGS) -c -Tp$(<:\=/)
-
-{$(srcdir)}.c{}.obj:
-	$(CC) $(INCFLAGS) $(CFLAGS) $(CPPFLAGS) -c -Tc$(<:\=/)
-
-{$(topdir)}.c{}.obj:
-	$(CC) $(INCFLAGS) $(CFLAGS) $(CPPFLAGS) -c -Tc$(<:\=/)
-
-{$(hdrdir)}.c{}.obj:
-	$(CC) $(INCFLAGS) $(CFLAGS) $(CPPFLAGS) -c -Tc$(<:\=/)
-
-.c.obj:
-	$(CC) $(INCFLAGS) $(CFLAGS) $(CPPFLAGS) -c -Tc$(<:\=/)
-
-$(DLLIB): $(DEFFILE) $(OBJS)
-	@-$(RM) $@
-	$(LDSHARED) -Fe$(@) $(OBJS) $(LIBS) $(LOCAL_LIBS) $(DLDFLAGS)
-
-
-
-$(DEFFILE): 
-	$(RUBY) -e "puts 'EXPORTS', 'Init_$(TARGET)'"  > $@
-
-$(OBJS): {.;$(srcdir);$(topdir);$(hdrdir)}ruby.h {.;$(srcdir);$(topdir);$(hdrdir)}defines.h

data/ext/mkmf.log

@@ -1,19 +0,0 @@
-have_type: checking for rb_pid_t in ruby.h... -------------------- yes
-
-"cl -nologo -I. -IC:/Ruby/lib/ruby/1.8/i386-mswin32 -I.  -MD -Zi -O2b2xg- -G6   -c conftest.c"
-conftest.c
-checked program was:
-/* begin */
-1: #define WIN32_LEAN_AND_MEAN
-2: #define WIN32
-3: #include <winsock2.h>
-4: #include <windows.h>
-5: #include <ruby.h>
-6: 
-7: /*top*/
-8: typedef rb_pid_t conftest_type;
-9: static conftest_type conftestval[sizeof(conftest_type)?1:-1];
-/* end */
-
---------------------
-

data/ext/open3-i386-mswin32.def

@@ -1,2 +0,0 @@
-EXPORTS
-Init_open3