win32-open3 0.2.7-x86-mswin32-60 → 0.2.8-x86-mswin32-60

data/CHANGES

@@ -1,3 +1,9 @@
+== 0.2.8 - 27-Feb-2008
+* Fixed a potential bug where nil might be returned instead of an actual
+  Process::Status object. Thanks go to Benny Bach for the spot.
+* The 'test' Rake task now runs the 'clean' task after the fact.
+* Some updates to the README about precompiled binaries.
+
 == 0.2.7 - 11-Jan-2008
 * Fixed a bug that could cause exitstatus to return bogus information. Thanks
   go to Roman Zawada for the spot.

data/README

@@ -47,11 +47,13 @@
    This appears to be an issue between VC++ 6 (which the installer was built
    with) and VC++ 7.0. Your best solution is to either upgrade your C
    compiler or to rebuild Ruby from scratch rather than using the installer.
+   
+= Precompiled binaries
 
-   You can also download a precompiled binary from the project site. Look for a
-   file called 'open3-x.y.z-vc6.so' on the 'files' page, where 'x.y.z' is a
-   version number, if you want a binary that's compatible with Curt Hibbs one
-   click installer.
+   If you do a typical "gem install win32-open3" you will get a precompiled
+   binary appropriate for your platform. If you want to build from source,
+   go the project page and download, download the .zip file, and run the
+   'install' Rake task from the command line.
    
 = Future Plans
    Replace the current implementation with a pure Ruby version.

data/ext/win32/open3.c

@@ -270,22 +270,23 @@ static void win32_pipe_finalize(OpenFile *file, int noraise)
    int status;
 
    if(file->f){
-   	fclose(file->f);
-   	file->f = NULL;
+      fclose(file->f);
+      file->f = NULL;
    }
 
    if(file->f2){
-   	fclose(file->f2);
-   	file->f2 = NULL;
+      fclose(file->f2);
+      file->f2 = NULL;
    }
 
    if(pid_handle != NULL){
       GetExitCodeProcess(pid_handle, &status);
       CloseHandle(pid_handle);
-      pid_handle = NULL;
 
-      if(status != STILL_ACTIVE)
- 	      win32_set_last_status(status, file->pid);
+      if(status != STILL_ACTIVE){
+         pid_handle = NULL;
+         win32_set_last_status(status, file->pid);
+      }
    }
 }
 
@@ -538,9 +539,9 @@ void Init_open3()
    rb_define_module_function(mOpen3, "popen3", win32_popen3, -1);
    rb_define_module_function(mOpen4, "popen4", win32_popen3, -1);
    
-   /* 0.2.6: The version of this library */
+   /* 0.2.8: The version of this library */
    rb_define_const(mOpen3, "WIN32_OPEN3_VERSION", rb_str_new2(WIN32_OPEN3_VERSION));
    
-   /* 0.2.6: The version of this library */
+   /* 0.2.8: The version of this library */
    rb_define_const(mOpen4, "WIN32_OPEN3_VERSION", rb_str_new2(WIN32_OPEN3_VERSION));
 }

data/test/test_win32_open3.rb

@@ -1,5 +1,5 @@
 ###########################################################################
-# tc_open3.rb
+# test_win32_open3.rb
 #
 # Test suite for the win32-open3 library.  Except for the
 # 'test_open3_with_arguments' test and Open4 tests, this suite passes
@@ -20,8 +20,8 @@ class TC_Win32_Open3 < Test::Unit::TestCase
    end
 
    def test_open3_version
-      assert_equal('0.2.7', Open3::WIN32_OPEN3_VERSION)
-      assert_equal('0.2.7', Open4::WIN32_OPEN3_VERSION)
+      assert_equal('0.2.8', Open3::WIN32_OPEN3_VERSION)
+      assert_equal('0.2.8', Open4::WIN32_OPEN3_VERSION)
    end
    
    def test_open3_basic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: win32-open3
 version: !ruby/object:Gem::Version 
-  version: 0.2.7
+  version: 0.2.8
 platform: x86-mswin32-60
 authors: 
 - Park Heesob
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-11 00:00:00 -07:00
+date: 2009-02-27 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -54,7 +54,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: win32utils
-rubygems_version: 1.3.1
+rubygems_version: 1.3.0
 signing_key: 
 specification_version: 2
 summary: Provides an Open3.popen3 implementation for MS Windows