win32-file-stat 1.2.5 → 1.2.6

data/CHANGES

@@ -1,3 +1,12 @@
+== 1.2.6 - 29-Sep-2007
+* Minor tweak to the way I handle redefining the initialize method. The
+  old_init alias is now removed.
+* Now handles a potential failure in getting the atime, ctime and mtime,
+  caused by the underlying filesystem, e.g. Samba. If it fails, these
+  fields are set to the epoch. Thanks go an anonymous user for the spot.
+* Added a Rakefile that includes tasks for installation and testing.
+* Removed the install.rb file. That has been inlined into the Rakefile.
+
 == 1.2.5 - 5-Apr-2007
 * Now runs -w clean.
 

data/MANIFEST

@@ -1,7 +1,7 @@
 * CHANGES
 * README
 * MANIFEST
-* install.rb
+* Rakefile
 * win32-file-stat.gemspec
 * lib/win32/file/stat.rb
 * test/sometestfile.exe

data/README

@@ -2,28 +2,20 @@
 A redefinition of the File::Stat class for MS Windows.
 
 = Prerequisites
-Ruby 1.8.0 or later.
-windows-pr 0.4.0 or later.
+* Ruby 1.8.0 or later.
+* windows-pr 0.6.0 or later.
 
-= Installation, pure Ruby
-== Manual Installation
-ruby test/tc_file_stat.rb (optional)
-ruby install.rb
-   
-== Gem Installation
-=== Local
-ruby test/tc_file_stat.rb (Unix, optional)
-gem install win32-file-stat-<version>.gem
-=== Remote
-gem install win32-file-stat
+= Installation
+rake install (non-gem) OR rake install_gem (gems)
 
 = Synopsis
-require 'win32/file/stat' # Don't do this in practice - see below
+   # Don't 'require' like this in practice - see 'Known Issues' below
+   require 'win32/file/stat'
 
-stat = File::Stat.new('file.txt')
-stat.size
-stat.readonly?
-stat.hidden?
+   stat = File::Stat.new('file.txt')
+   stat.size
+   stat.readonly?
+   stat.hidden?
 
 = Differences between Ruby's File::Stat and this version:
 * The File::Stat#blksize method returns a meaningful value.

data/Rakefile

@@ -0,0 +1,30 @@
+require 'rake'
+require 'rake/testtask'
+require 'rbconfig'
+include Config
+
+desc 'Install the win32-file-stat package (non-gem)'
+task :install do
+   sitelibdir = CONFIG['sitelibdir']
+   installdir = sitelibdir + '/win32/file'
+   basedir = File.dirname(installdir)
+   file = 'lib\win32\file\stat.rb'
+   
+   Dir.mkdir(basedir) unless File.exists?(basedir)
+   Dir.mkdir(installdir) unless File.exists?(installdir)
+   FileUtils.cp(file, installdir, :verbose => true)
+end
+
+desc 'Install the win32-file-stat package as a gem'
+task :install_gem do
+   ruby 'win32-file-stat.gemspec'
+   file = Dir["win32-file-stat*.gem"].first
+   sh "gem install #{file}"
+end
+
+Rake::TestTask.new do |t|
+   t.libs << 'test'
+   t.verbose = true
+   t.warning = true
+   t.test_files = FileList['test/tc_file_stat.rb']
+end

data/lib/win32/file/stat.rb

@@ -21,17 +21,15 @@ class File::Stat
    include Windows::Volume
    include Comparable
    
-   VERSION = '1.2.5'
+   VERSION = '1.2.6'
 
    # Defined in Ruby's win32.h.  Not meant for public consumption.
    S_IWGRP = 0020
    S_IWOTH = 0002
    
-   # This is the only way to avoid a -w warning for initialize
-   private
-   alias old_init initialize
-   
-   public
+   # This is the only way to avoid a -w warning for initialize. We remove
+   # it later, after we've defined our initialize method.
+   alias old_init initialize # :nodoc:
    
    # Make this package -w clean
    undef_method(:atime, :blksize, :blockdev?, :blocks, :chardev?, :ctime)
@@ -78,9 +76,18 @@ class File::Stat
       @gid   = stat_buf[12, 2].unpack('s').first # Always 0
       @rdev  = stat_buf[16, 4].unpack('I').first # Same as dev
       @size  = stat_buf[24, 8].unpack('Q').first # Size of file in bytes
-      @atime = Time.at(stat_buf[32, 8].unpack('Q').first) # Access time
-      @mtime = Time.at(stat_buf[40, 8].unpack('Q').first) # Modification time
-      @ctime = Time.at(stat_buf[48, 8].unpack('Q').first) # Creation time
+      
+      # This portion can fail in rare, FS related instances. If it does, set
+      # the various times to Time.at(0).
+      begin
+         @atime = Time.at(stat_buf[32, 8].unpack('Q').first) # Access time
+         @mtime = Time.at(stat_buf[40, 8].unpack('Q').first) # Mod time
+         @ctime = Time.at(stat_buf[48, 8].unpack('Q').first) # Creation time
+      rescue
+         @atime = Time.at(0)
+         @mtime = Time.at(0)
+         @ctime = Time.at(0)
+      end
       
       @mode = 33188 if @chardev
 
@@ -151,6 +158,9 @@ class File::Stat
    
    ## Miscellaneous
    
+   # Returns whether or not the file is a block device. For MS Windows a
+   # block device is a removable drive, cdrom or ramdisk.
+   # 
    def blockdev?
       @blockdev
    end
@@ -511,6 +521,9 @@ class File::Stat
       }
    end
    
+   # Since old_init was added strictly to avoid a warning, we remove it now.
+   remove_method(:old_init)
+   
    private
    
    # Returns the file system's block size.

data/test/tc_file_stat.rb

@@ -36,14 +36,14 @@ class TC_Win32_File_Stat < Test::Unit::TestCase
    end
    
    def test_version
-      assert_equal('1.2.5', File::Stat::VERSION)
+      assert_equal('1.2.6', File::Stat::VERSION)
    end
    
    # One or more tests will fail if the archive attribute on @file is not set.
    def test_archive
       assert_respond_to(@stat, :archive?)
       assert_nothing_raised{ @stat.archive? }
-      assert(@stat.archive?)
+      assert(@stat.archive?, '- May fail: ignore -')
    end
    
    def test_atime

data/win32-file-stat.gemspec

@@ -2,7 +2,7 @@ require "rubygems"
 
 spec = Gem::Specification.new do |gem|
    gem.name        = "win32-file-stat"
-   gem.version     = "1.2.5"
+   gem.version     = "1.2.6"
    gem.author      = "Daniel J. Berger"
    gem.email       = "djberg96@gmail.com"
    gem.homepage    = "http://www.rubyforge.org/projects/win32utils"

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.2
+rubygems_version: 0.9.4
 specification_version: 1
 name: win32-file-stat
 version: !ruby/object:Gem::Version 
-  version: 1.2.5
-date: 2007-04-05 00:00:00 -06:00
+  version: 1.2.6
+date: 2007-09-29 00:00:00 -06:00
 summary: A File::Stat class tailored to MS Windows
 require_paths: 
 - lib
@@ -32,9 +32,9 @@ files:
 - lib/win32/file/stat.rb
 - CHANGES
 - CVS
-- install.rb
 - lib
 - MANIFEST
+- Rakefile
 - README
 - test
 - win32-file-stat.gemspec

data/install.rb

@@ -1,12 +0,0 @@
-require 'rbconfig'
-require 'fileutils'
-include Config
-
-sitelibdir = CONFIG['sitelibdir']
-installdir = sitelibdir + '/win32/file'
-basedir = File.dirname(installdir)
-file = 'lib\win32\file\stat.rb'
-
-Dir.mkdir(basedir) unless File.exists?(basedir)
-Dir.mkdir(installdir) unless File.exists?(installdir)
-FileUtils.cp(file, installdir, :verbose => true)