wikidata_position_history 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '08b127d4fefeb6c622042af063ab7574afb3b54f0c1c6dc3cb5329304b6b7c84'
-  data.tar.gz: 72f0be64974066b3b8988f23ac5dde2e5897b8aaa611ff379997053f890b3011
+  metadata.gz: 8f9b65df015932c64b9995789de132f401400b8641fe6da6d34529ee08a897f7
+  data.tar.gz: 8eb66f80771e638a76e477db20e48c20cf10aa69843e20660c49a995e7040126
 SHA512:
-  metadata.gz: c914cfaa9abc6412f04e0482b91facf33d52db8f4b49adea721bbdb5cb7dcd31c9e404f87bd58a09e7843ee8d985f2c2cd30f89953fdeffb54dc3b2749e11e85
-  data.tar.gz: 131ef009d921f4fa974411295f913b8b9df0800f326caf9125e7524d60e627e29e3bf8f7d7303e1a4b258dca4a679568ea3f17944795bd4d68e408c4f8c023c0
+  metadata.gz: 84464bf1eb62fad5dfe9287baa7988ed1e27024b3dce9ceefd1b2a74a79b7ea4fe472151c9b04bc10ed8bba846694553e929ce6f0bd316cff86aee4f09806ec4
+  data.tar.gz: 1b8813db12384488d4719a6858fa31b3dd69b9692b2df9c62c4d861a7c46ab533715fc374bd5b7fd2441b07108257cd782369175318e89afdbb7f5cdea106945

data/CHANGELOG.md

@@ -1,7 +1,25 @@
 # Changelog
 
+# [2.2.0] 2020-09-18
+
+## Enhancements
+
+* Every position came into existence at _some_ point, and so should have
+  a P571 inception date. If that's missing, a warning will now be
+  displayed.
+
+## Improvements
+
+* When a position has more than one successor or prdecessor, those will
+  now be displayed as a proper Mediawiki list, rather than one long line
+  of text. As these are in a table cell, this should stop those growing
+  unnecessarily wide, and should generally make everything look a little
+  nicer.
+
 # [2.1.0] 2020-09-16
 
+## Enhancements
+
 * When displaying a list of members for a constituency, also include
   a 'parliamentary group' (P4100) column, and if there's a
   'parliamentary term' (P2937) qualifier, use it for the ordinal.

data/lib/wikidata_position_history/output_row.rb

@@ -112,7 +112,10 @@ module WikidataPositionHistory
       def position
         return if implied_list.empty?
 
-        (implied_list.direct.map(&:qblink) + implied_list.indirect_only.map(&:qblink_i)).join(', ')
+        list = (implied_list.direct.map(&:qblink) + implied_list.indirect_only.map(&:qblink_i))
+        return list.first if list.count == 1
+
+        list.map { |item| "\n* #{item}" }.join
       end
 
       def warnings

data/lib/wikidata_position_history/template.rb

@@ -33,8 +33,8 @@ module WikidataPositionHistory
         <% end -%>
         <% if metadata.successor.position -%>
         |-
-        | colspan="2" style="border: none; background: #fff; font-size: 1.15em; text-align: right;" | '''Replaced by''':
-        | style=" border: none; background: #fff; text-align: left;" | <%= metadata.successor.position %>
+        | colspan="2" style="border: none; background: #fff; font-size: 1.15em; vertical-align: baseline; text-align: right;" | '''Replaced by''':
+        | style=" border: none; background: #fff; vertical-align: baseline; text-align: left;" | <%= metadata.successor.position %>
         | style=" border: none; background: #fff; text-align: left;" | \
         <% metadata.successor.warnings.each do |warning| -%>
         <span style="display: block">[[File:Pictogram voting comment.svg|15px|link=]]&nbsp;<span style="color: #d33; font-weight: bold; vertical-align: middle;"><%= warning.headline %></span>&nbsp;<ref><%= warning.explanation %></ref></span>\
@@ -63,7 +63,7 @@ module WikidataPositionHistory
         | colspan="3" style="padding:0.5em; border: none; background: #fff"> |&nbsp;
         | colspan="1" style="padding:0.5em; border: none; background: #fff"> |&nbsp;
         <% end -%>
-        <% if metadata.inception.date -%>
+        <% if metadata.inception.date || metadata.inception.warnings.any? -%>
         |-
         | colspan="2" style="border: none; background: #fff; font-size: 1.15em; text-align: right;" | '''Position created''':
         | style="border: none; background: #fff; text-align: left;" | <%= metadata.inception.date %>

data/lib/wikidata_position_history/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module WikidataPositionHistory
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wikidata_position_history
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Tony Bowden
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-16 00:00:00.000000000 Z
+date: 2020-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mediawiki-replaceable-content