wikidata_position_history 1.10.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d45377b5ba871d76f191e7dafe516f308c4f1b17f166b19d0658ee15fff98745
-  data.tar.gz: ede75c366b3cf99a417ab402f5151880a477b3aa1fc10ff0d4261fb7b7fc0d44
+  metadata.gz: 43d866e3ec1ab0f61a2d8d66d46757dff7ecfd66f4c39bb7a1f90125befb3586
+  data.tar.gz: 9ac67f8d608c4ce7cc746b4e035664cfed07c5501f117d075fb3ab11444a4a69
 SHA512:
-  metadata.gz: 141397d38a5a771e8b2cb159bcd8db327d50f157ba93539b09bb08ff23a64a60e6aa4bdac2bf1a45bdd65dc2f8d343e1a4737a89fc939eafe7ed25e7473562ff
-  data.tar.gz: 0a3cb133222f05d0ff46dd7810a62a72f3b19ca1f7431bf265752867b916b8ef176f04e11b65a50d2b6ed8d04ba20dc3ecf6fe73cd5fb24caf98737f401b685b
+  metadata.gz: 24824e0ad6207a9a3c8b3e8a547a6eda2dc7e9ee5f6503995dd330c82ecb2bab11a4c4655c3fddd1d8c0235b13bc6d607010901147f305d736e46cdd959c1688
+  data.tar.gz: 257e34dc5e7855720b101d33d2bbf8404f1d4486270667653d1386e077ae4fbdc631b1edba4c7439f3c5f16b4cb80e6932c53d70c136577456d758fe55963b0d

data/CHANGELOG.md

@@ -1,5 +1,67 @@
 # Changelog
 
+# Unreleased
+
+# [2.3.0] 2020-10-01
+
+* Edits on Wikidata can now set a botflag if requested, based on the
+  `PHH_BOT` environemnt variable.
+
+# [2.2.0] 2020-09-18
+
+## Enhancements
+
+* Every position came into existence at _some_ point, and so should have
+  a P571 inception date. If that's missing, a warning will now be
+  displayed.
+
+## Improvements
+
+* When a position has more than one successor or prdecessor, those will
+  now be displayed as a proper Mediawiki list, rather than one long line
+  of text. As these are in a table cell, this should stop those growing
+  unnecessarily wide, and should generally make everything look a little
+  nicer.
+
+# [2.1.0] 2020-09-16
+
+## Enhancements
+
+* When displaying a list of members for a constituency, also include
+  a 'parliamentary group' (P4100) column, and if there's a
+  'parliamentary term' (P2937) qualifier, use it for the ordinal.
+
+# [2.0.0] 2020-09-16
+
+## Interface change
+
+* `Report#wikitext_with_header` has been removed. This was undocumented,
+  and only used internally, so should not be a breaking change, but if
+  anything *was* using it, that will now break loudly (but, usefully,
+  should also break very early.)
+
+## Enhancements
+
+* A {{PositionHolderHistory}} template can now also be added to items
+  representing single-member constituencies, to see the history of
+  representatives for that seat.
+
+# [1.11.0] 2020-09-14
+
+## Enhancements
+
+* Wikidata now has a new {{QB}} template to link to _both_ an Item and
+  its Talk page. As the PositionHolderHistory template for a position
+  often lives on its Talk page, any link to a position item now uses
+  this template, for easier of access to that. (Requested by Tagishsimon:
+  https://twitter.com/Tagishsimon/status/1304363879322079233)
+
+* The change to how warnings templates work from the last release (i.e.
+  using on-wiki templates, so they can be improved or translated, or used
+  to look for problems via backlinks) definitely seems to have been a good
+  idea, so now the warnings for having an unexpected number of inception
+  or abolition dates have also been adjusted to work the same way.
+
 # [1.10.0] 2020-09-13
 
 ## Enhancements

data/exe/position-history-for-item

@@ -8,4 +8,4 @@ if ARGV.size != 1
 e.g. #{$PROGRAM_NAME} Q14211'"
 end
 
-puts WikidataPositionHistory::Report.new(ARGV.first).wikitext_with_header
+puts WikidataPositionHistory::Report.new(ARGV.first).wikitext

data/lib/query_service.rb

@@ -49,8 +49,16 @@ module QueryService
       "{{Q|#{id}}}" if id
     end
 
+    def qblink
+      "{{QB|#{id}}}" if id
+    end
+
     def qlink_i
-      "''{{Q|#{id}}}''" if id
+      "''#{qlink}''" if qlink
+    end
+
+    def qblink_i
+      "''#{qblink}''" if qblink
     end
 
     private

data/lib/sparql/bio_query.rb

@@ -21,6 +21,22 @@ module WikidataPositionHistory
         SPARQL
       end
     end
+
+    # Biographical data for Members for a Constituency
+    class ConstituencyBioQuery < ItemQuery
+      def raw_sparql
+        <<~SPARQL
+          # constituency-biodata
+
+          SELECT DISTINCT ?item ?image
+          WHERE {
+            ?item wdt:P31 wd:Q5 ; p:P39/pq:P768 wd:%s .
+            OPTIONAL { ?item wdt:P18 ?image }
+          }
+          ORDER BY ?item
+        SPARQL
+      end
+    end
   end
 
   # Represents a single row returned from the Position query

data/lib/sparql/mandates_query.rb

@@ -25,6 +25,33 @@ module WikidataPositionHistory
         SPARQL
       end
     end
+
+    # SPARQL for fetching all mandates of a single-member district
+    class ConstituencyMandatesQuery < ItemQuery
+      def raw_sparql
+        <<~SPARQL
+          # constituency-mandates
+
+          SELECT DISTINCT ?ordinal ?item ?start_date ?start_precision ?end_date ?end_precision ?party ?prev ?next ?term
+          WHERE {
+            ?item wdt:P31 wd:Q5 ; p:P39 ?posn .
+            ?posn pq:P768 wd:%s .
+            FILTER NOT EXISTS { ?posn wikibase:rank wikibase:DeprecatedRank }
+
+            OPTIONAL { ?posn pqv:P580 [ wikibase:timeValue ?start_date; wikibase:timePrecision ?start_precision ] }
+            OPTIONAL { ?posn pqv:P582 [ wikibase:timeValue ?end_date; wikibase:timePrecision ?end_precision ] }
+            OPTIONAL { ?posn pq:P1365 ?prev }
+            OPTIONAL { ?posn pq:P1366 ?next }
+            OPTIONAL { ?posn pq:P4100 ?party }
+            OPTIONAL {
+              ?posn pq:P2937 ?term .
+              OPTIONAL { ?term p:P31/pq:P1545 ?ordinal }
+            }
+          }
+          ORDER BY DESC(?start_date) ?item
+        SPARQL
+      end
+    end
   end
 
   # Represents a single row returned from the Mandates query
@@ -37,9 +64,8 @@ module WikidataPositionHistory
       item_from(:item)
     end
 
-    # TODO: rename or remove. 'item' is meaningless/ambiguous
-    def item
-      officeholder.qlink
+    def party
+      item_from(:party)
     end
 
     # TODO: switch to item_from

data/lib/sparql/position_query.rb

@@ -11,10 +11,13 @@ module WikidataPositionHistory
           SELECT DISTINCT ?item ?inception ?inception_precision ?abolition ?abolition_precision
                           ?replaces ?replacedBy ?derivedReplaces ?derivedReplacedBy
                           ?isPosition ?isLegislator
+                          ?isConstituency ?representative_count ?legislature
           WHERE {
             VALUES ?item { wd:%s }
             BIND(EXISTS { wd:%s wdt:P279+ wd:Q4164871 } as ?isPosition)
             BIND(EXISTS { wd:%s wdt:P279+ wd:Q4175034 } as ?isLegislator)
+            BIND(EXISTS { wd:%s wdt:P31/wdt:P279+ wd:Q192611 } as ?isConstituency)
+
             OPTIONAL { ?item p:P571 [ a wikibase:BestRank ;
               psv:P571 [ wikibase:timeValue ?inception; wikibase:timePrecision ?inception_precision ]
             ] }
@@ -25,12 +28,16 @@ module WikidataPositionHistory
             OPTIONAL { ?item wdt:P1366 ?replacedBy }
             OPTIONAL { ?derivedReplaces wdt:P1366 ?item }
             OPTIONAL { ?derivedReplacedBy wdt:P1365 ?item }
+
+            OPTIONAL { # if constituency
+              ?item p:P1410 [ a wikibase:BestRank ; ps:P1410 ?representative_count ; pq:P194 ?legislature ]
+            }
           }
         SPARQL
       end
 
       def sparql_args
-        [itemid] * 3
+        [itemid] * 4
       end
     end
   end
@@ -72,5 +79,17 @@ module WikidataPositionHistory
     def legislator?
       raw(:isLegislator) == 'true'
     end
+
+    def constituency?
+      raw(:isConstituency) == 'true'
+    end
+
+    def legislature
+      item_from(:legislature)
+    end
+
+    def representative_count
+      raw(:representative_count).to_i
+    end
   end
 end

data/lib/wikidata_position_history.rb

@@ -16,6 +16,18 @@ require 'date'
 require 'mediawiki/client'
 require 'mediawiki/page'
 
+module MediaWiki
+  # mediawiki-page-replaceable_content does not provide a way to set a
+  # bot flag, so we need to monkey patch it. This should really be
+  # exposed somewhere in its interface.
+  class Client
+    def edit(hash)
+      hash['bot'] = ENV['PHH_BOT'] if ENV.key?('PHH_BOT')
+      wrapped_client.edit(hash)
+    end
+  end
+end
+
 module WikidataPositionHistory
   # Rewrites a Wiki page
   class PageRewriter

data/lib/wikidata_position_history/checks.rb

@@ -17,11 +17,12 @@ module WikidataPositionHistory
 
     attr_reader :later, :current, :earlier
 
-    def successor
+    # TODO: replace these with objects instead of strings
+    def successor_qlink
       current.next
     end
 
-    def predecessor
+    def predecessor_qlink
       current.prev
     end
 
@@ -46,7 +47,7 @@ module WikidataPositionHistory
       end
 
       def possible_explanation
-        "#{current.item} is missing #{missing.map { |field| "{{P|#{field_map[field]}}}" }.join(', ')}"
+        "#{current.officeholder.qlink} is missing #{missing.map { |field| "{{P|#{field_map[field]}}}" }.join(', ')}"
       end
 
       def missing
@@ -76,14 +77,14 @@ module WikidataPositionHistory
 
       def expect_prev?
         return unless earlier
-        return if earlier.item == current.item # sucessive terms by same person
+        return if earlier.officeholder.id == current.officeholder.id # sucessive terms by same person
 
         !current.acting?
       end
 
       def expect_next?
         return unless later
-        return if later.item == current.item # sucessive terms by same person
+        return if later.officeholder.id == current.officeholder.id # sucessive terms by same person
 
         !current.acting?
       end
@@ -92,7 +93,7 @@ module WikidataPositionHistory
     # Does the 'replaces' match the previous item in the list?
     class WrongPredecessor < Check
       def problem?
-        earlier_holder? && !!predecessor && (earlier.item != predecessor)
+        earlier_holder? && !!predecessor_qlink && (earlier.officeholder.qlink != predecessor_qlink)
       end
 
       def headline
@@ -100,14 +101,14 @@ module WikidataPositionHistory
       end
 
       def possible_explanation
-        "#{current.item} has a {{P|1365}} of #{predecessor}, but follows #{earlier.item} here"
+        "#{current.officeholder.qlink} has a {{P|1365}} of #{predecessor_qlink}, but follows #{earlier.officeholder.qlink} here"
       end
     end
 
     # Is there a 'replaces' but no previous item in the list?
     class MissingPredecessor < Check
       def problem?
-        predecessor && !earlier_holder?
+        predecessor_qlink && !earlier_holder?
       end
 
       def headline
@@ -115,14 +116,14 @@ module WikidataPositionHistory
       end
 
       def possible_explanation
-        "#{current.item} has a {{P|1365}} of #{predecessor}, but does not follow anyone here"
+        "#{current.officeholder.qlink} has a {{P|1365}} of #{predecessor_qlink}, but does not follow anyone here"
       end
     end
 
     # Does the 'replaced by' match the next item in the list?
     class WrongSuccessor < Check
       def problem?
-        later_holder? && !!successor && (later.item != successor)
+        later_holder? && !!successor_qlink && (later.officeholder.qlink != successor_qlink)
       end
 
       def headline
@@ -130,14 +131,14 @@ module WikidataPositionHistory
       end
 
       def possible_explanation
-        "#{current.item} has a {{P|1366}} of #{successor}, but is followed by #{later.item} here"
+        "#{current.officeholder.qlink} has a {{P|1366}} of #{successor_qlink}, but is followed by #{later.officeholder.qlink} here"
       end
     end
 
     # Is there a 'replaced by' but no next item in the list?
     class MissingSuccessor < Check
       def problem?
-        successor && !later_holder?
+        successor_qlink && !later_holder?
       end
 
       def headline
@@ -145,7 +146,7 @@ module WikidataPositionHistory
       end
 
       def possible_explanation
-        "#{current.item} has a {{P|1366}} of #{successor}, but is not followed by anyone here"
+        "#{current.officeholder.qlink} has a {{P|1366}} of #{successor_qlink}, but is not followed by anyone here"
       end
     end
 
@@ -167,7 +168,8 @@ module WikidataPositionHistory
       end
 
       def possible_explanation
-        "#{current.item} has a {{P|582}} of #{current.end_date}, which #{overlap_explanation} the {{P|580}} of #{later.start_date} for #{later.item}"
+        format('%s has a {{P|582}} of %s, which %s the {{P|580}} of %s for %s',
+               current.officeholder.qlink, current.end_date, overlap_explanation, later.start_date, later.officeholder.qlink)
       end
 
       protected

data/lib/wikidata_position_history/output_row.rb

@@ -22,8 +22,12 @@ module WikidataPositionHistory
         "#{ordinal}."
       end
 
-      def person
-        current.item
+      def party
+        current.party
+      end
+
+      def officeholder
+        current.officeholder
       end
 
       def dates
@@ -62,8 +66,8 @@ module WikidataPositionHistory
 
       attr_reader :metadata
 
-      def qlink
-        metadata.position.qlink
+      def position_id
+        metadata.position.id
       end
     end
 
@@ -72,10 +76,9 @@ module WikidataPositionHistory
       def warnings
         count = dates.count
         return [] if count == 1
+        return [Warning.new('Missing field', "{{PositionHolderHistory/warning_no_inception_date|item=#{position_id}}}")] if count.zero?
 
-        return [Warning.new('Missing field', "#{qlink} is missing {{P|571}}")] if count.zero?
-
-        [Warning.new('Multiple values', "#{qlink} has more than one {{P|571}}")]
+        [Warning.new('Multiple values', "{{PositionHolderHistory/warning_multiple_inception_dates|item=#{position_id}}}")]
       end
 
       private
@@ -90,7 +93,7 @@ module WikidataPositionHistory
       def warnings
         return [] unless dates.count > 1
 
-        [Warning.new('Multiple values', "#{qlink} has more than one {{P|576}}")]
+        [Warning.new('Multiple values', "{{PositionHolderHistory/warning_multiple_abolition_dates|item=#{position_id}}}")]
       end
 
       private
@@ -109,7 +112,10 @@ module WikidataPositionHistory
       def position
         return if implied_list.empty?
 
-        (implied_list.direct.map(&:qlink) + implied_list.indirect_only.map(&:qlink_i)).join(', ')
+        list = (implied_list.direct.map(&:qblink) + implied_list.indirect_only.map(&:qblink_i))
+        return list.first if list.count == 1
+
+        list.map { |item| "\n* #{item}" }.join
       end
 
       def warnings

data/lib/wikidata_position_history/report.rb

@@ -1,5 +1,11 @@
 # frozen_string_literal: true
 
+require_relative 'report/abstract'
+require_relative 'report/legislator'
+require_relative 'report/mandate'
+require_relative 'report/constituency'
+require_relative 'report/position'
+
 module WikidataPositionHistory
   # A list made up of both direct and indirect claims, where we
   # can tell which came from which, when required
@@ -68,6 +74,15 @@ module WikidataPositionHistory
       rows.map(&:legislator?).first
     end
 
+    def constituency?
+      # this should be the same everywhere
+      rows.map(&:constituency?).first
+    end
+
+    def representative_count
+      rows.map(&:representative_count).max
+    end
+
     def replaces_combined
       @replaces_combined ||= ImpliedList.new(uniq_by_id(:replaces), uniq_by_id(:derived_replaces))
     end
@@ -95,84 +110,30 @@ module WikidataPositionHistory
 
   # The entire wikitext generated for this report
   class Report
-    def initialize(position_id, template_class = ReportTemplate)
+    def initialize(position_id)
       @position_id = position_id
       @template_class = template_class
     end
 
     attr_reader :position_id, :template_class
 
-    def wikitext
-      return legislator_template if metadata.legislator?
-      return no_items_output if mandates.empty?
-
-      template_class.new(template_params).output
-    end
-
-    def header
-      "== {{Q|#{position_id}}} officeholders #{position_dates} =="
-    end
-
-    def position_dates
-      dates = [metadata.inception.date, metadata.abolition.date]
-      return '' if dates.compact.empty?
-
-      format('(%s)', dates.join(' – '))
-    end
-
-    def wikitext_with_header
-      [header, wikitext].join("\n")
-    end
-
-    def template_params
-      {
-        metadata:   metadata,
-        table_rows: table_rows,
-        sparql_url: sparql.wdqs_url,
-      }
-    end
-
-    private
-
     def metadata
       @metadata ||= Metadata.new(SPARQL::PositionQuery.new(position_id).results_as(PositionRow))
     end
 
-    def biodata
-      @biodata ||= SPARQL::BioQuery.new(position_id).results_as(BioRow)
-    end
-
-    def biodata_for(officeholder)
-      biodata.select { |bio| bio.person.id == officeholder.id }
-    end
-
-    def padded_mandates
-      [nil, mandates, nil].flatten(1)
-    end
-
-    def sparql
-      @sparql ||= SPARQL::MandatesQuery.new(position_id)
-    end
-
-    def mandates
-      @mandates ||= sparql.results_as(MandateRow)
-    end
+    def report
+      return Report::Legislator.new(metadata) if metadata.legislator?
+      return Report::Constituency.new(metadata) if metadata.constituency?
 
-    def no_items_output
-      "\n{{PositionHolderHistory/error_no_holders|id=#{position_id}}}\n"
+      Report::Position.new(metadata)
     end
 
-    def legislator_template
-      "\n{{PositionHolderHistory/error_legislator|id=#{position_id}}}\n"
+    def template_params
+      report.template_params
     end
 
-    def table_rows
-      padded_mandates.each_cons(3).map do |later, current, earlier|
-        {
-          mandate: OutputRow::Mandate.new(later, current, earlier),
-          bio:     biodata_for(current.officeholder),
-        }
-      end
+    def wikitext
+      report.wikitext
     end
   end
 end

data/lib/wikidata_position_history/report/abstract.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module WikidataPositionHistory
+  class Report
+    # Abstract base class for Reports
+    class Abstract
+      def initialize(metadata)
+        @metadata = metadata
+      end
+
+      protected
+
+      attr_reader :metadata
+
+      def position_id
+        metadata.position.id
+      end
+    end
+  end
+end

data/lib/wikidata_position_history/report/constituency.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module WikidataPositionHistory
+  class Report
+    # Report of representatives for a single-member consttuency
+    class Constituency < Mandate
+      def wikitext
+        return multimember_error_template unless metadata.representative_count == 1
+
+        super
+      end
+
+      def mandates_query
+        SPARQL::ConstituencyMandatesQuery
+      end
+
+      def biodata_query
+        SPARQL::ConstituencyBioQuery
+      end
+
+      def multimember_error_template
+        "\n{{PositionHolderHistory/error_multimember}}\n"
+      end
+    end
+  end
+end

data/lib/wikidata_position_history/report/legislator.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module WikidataPositionHistory
+  class Report
+    # Report for a (presumed multi-member) legislative position
+    class Legislator < Abstract
+      def wikitext
+        "\n{{PositionHolderHistory/error_legislator|id=#{position_id}}}\n"
+      end
+    end
+  end
+end

data/lib/wikidata_position_history/report/mandate.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module WikidataPositionHistory
+  class Report
+    # base report where each row is one person holding an office for a period
+    class Mandate < Abstract
+      def wikitext
+        return no_items_output if mandates.empty?
+
+        ReportTemplate.new(template_params).output
+      end
+
+      def template_params
+        {
+          metadata:   metadata,
+          table_rows: table_rows,
+          sparql_url: sparql.wdqs_url,
+        }
+      end
+
+      private
+
+      def biodata
+        @biodata ||= biodata_sparql.results_as(BioRow)
+      end
+
+      def biodata_for(officeholder)
+        biodata.select { |bio| bio.person.id == officeholder.id }
+      end
+
+      def padded_mandates
+        [nil, mandates, nil].flatten(1)
+      end
+
+      def sparql
+        @sparql ||= mandates_query.new(position_id)
+      end
+
+      def biodata_sparql
+        biodata_query.new(position_id)
+      end
+
+      def mandates
+        @mandates ||= sparql.results_as(MandateRow)
+      end
+
+      def no_items_output
+        "\n{{PositionHolderHistory/error_no_holders|id=#{position_id}}}\n"
+      end
+
+      def table_rows
+        padded_mandates.each_cons(3).map do |later, current, earlier|
+          {
+            mandate: OutputRow::Mandate.new(later, current, earlier),
+            bio:     biodata_for(current.officeholder),
+          }
+        end
+      end
+    end
+  end
+end

data/lib/wikidata_position_history/report/position.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module WikidataPositionHistory
+  class Report
+    # The default single-person-at-a-time position
+    class Position < Mandate
+      def mandates_query
+        SPARQL::MandatesQuery
+      end
+
+      def biodata_query
+        SPARQL::BioQuery
+      end
+    end
+  end
+end

data/lib/wikidata_position_history/template.rb

@@ -33,8 +33,8 @@ module WikidataPositionHistory
         <% end -%>
         <% if metadata.successor.position -%>
         |-
-        | colspan="2" style="border: none; background: #fff; font-size: 1.15em; text-align: right;" | '''Replaced by''':
-        | style=" border: none; background: #fff; text-align: left;" | <%= metadata.successor.position %>
+        | colspan="2" style="border: none; background: #fff; font-size: 1.15em; vertical-align: baseline; text-align: right;" | '''Replaced by''':
+        | style=" border: none; background: #fff; vertical-align: baseline; text-align: left;" | <%= metadata.successor.position %>
         | style=" border: none; background: #fff; text-align: left;" | \
         <% metadata.successor.warnings.each do |warning| -%>
         <span style="display: block">[[File:Pictogram voting comment.svg|15px|link=]]&nbsp;<span style="color: #d33; font-weight: bold; vertical-align: middle;"><%= warning.headline %></span>&nbsp;<ref><%= warning.explanation %></ref></span>\
@@ -49,7 +49,10 @@ module WikidataPositionHistory
         |-
         | style="padding:0.5em 2em" | <%= mandate.ordinal_string %>
         | style="padding:0.5em 2em" | <%= bio.map(&:image_link).first %>
-        | style="padding:0.5em 2em" | <span style="font-size: <%= mandate.acting? ? '1.25em; font-style: italic;' : '1.5em' %>; display: block;"><%= mandate.person %></span> <%= mandate.dates %>
+        | style="padding:0.5em 2em" | <span style="font-size: <%= mandate.acting? ? '1.25em; font-style: italic;' : '1.5em' %>; display: block;"><%= mandate.officeholder.qlink %></span> <%= mandate.dates %>
+        <% if metadata.constituency? -%>
+        | style="padding:0.5em 1em" | <% if mandate.party %><%= mandate.party.qlink %><% end %>
+        <% end -%>
         | style="padding:0.5em 2em 0.5em 1em; border: none; background: #fff; text-align: left;" | \
         <% mandate.warnings.each do |warning| -%>
         <span style="display: block">[[File:Pictogram voting comment.svg|15px|link=]]&nbsp;<span style="color: #d33; font-weight: bold; vertical-align: middle;"><%= warning.headline %></span>&nbsp;<ref><%= warning.explanation %></ref></span>\
@@ -60,7 +63,7 @@ module WikidataPositionHistory
         | colspan="3" style="padding:0.5em; border: none; background: #fff"> |&nbsp;
         | colspan="1" style="padding:0.5em; border: none; background: #fff"> |&nbsp;
         <% end -%>
-        <% if metadata.inception.date -%>
+        <% if metadata.inception.date || metadata.inception.warnings.any? -%>
         |-
         | colspan="2" style="border: none; background: #fff; font-size: 1.15em; text-align: right;" | '''Position created''':
         | style="border: none; background: #fff; text-align: left;" | <%= metadata.inception.date %>

data/lib/wikidata_position_history/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module WikidataPositionHistory
-  VERSION = '1.10.0'
+  VERSION = '2.3.0'
 end

data/wikidata_position_history.gemspec

@@ -36,5 +36,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop-performance', '~> 1.8.0'
   spec.add_development_dependency 'rubocop-rspec', '~> 1.43.2'
   spec.add_development_dependency 'warning', '~> 1.1'
-  spec.add_development_dependency 'webmock', '~> 3.8.3'
+  spec.add_development_dependency 'webmock', '~> 3.9.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wikidata_position_history
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Tony Bowden
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-13 00:00:00.000000000 Z
+date: 2020-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mediawiki-replaceable-content
@@ -171,14 +171,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.3
+        version: 3.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.3
+        version: 3.9.1
 description:
 email:
 - tony@tmtm.com
@@ -212,6 +212,11 @@ files:
 - lib/wikidata_position_history/checks.rb
 - lib/wikidata_position_history/output_row.rb
 - lib/wikidata_position_history/report.rb
+- lib/wikidata_position_history/report/abstract.rb
+- lib/wikidata_position_history/report/constituency.rb
+- lib/wikidata_position_history/report/legislator.rb
+- lib/wikidata_position_history/report/mandate.rb
+- lib/wikidata_position_history/report/position.rb
 - lib/wikidata_position_history/template.rb
 - lib/wikidata_position_history/version.rb
 - wikidata_position_history.gemspec