wikidata-diff-analyzer 0.1.1 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26977ede877056aed781db63e598954ebcd274ea07958f2b75aebcbf0356b3e2
-  data.tar.gz: dd750db5d4b6586bca95133ccc05abd5f30eac7f18ecd021817d77128a30fcbc
+  metadata.gz: e2582edb55fb495d5256a573a6431eaf2ea628872d85a21591badd0d16ad528b
+  data.tar.gz: ac0c0dd70e982f169b6ac52dc882c7f1fbe8c632868ba48368b53f10e530ad60
 SHA512:
-  metadata.gz: 9743c0e26386fbc08e7669525ced6ebd12358691a788cf76e004407b1cad575be6e7525d640954a91a148f60c11e5c732e00c975253f8f9a2088b43dc4934a1e
-  data.tar.gz: 249f1591b28199205e560943d6ec710c7cb8c597325842d584b4f31bb83335920db912570c7cd25f4a7a0a0aa1467ff2189cfc8cc4f934eeb6eeda2a46878595
+  metadata.gz: 554b47cea6fdf10c41760e19c34102ca12607b26e1a09aad9fa82ce595b19593cacac9feae95da553c1a6afb6c62a75cd6ddf73cf5ff5683f36f3e217f0b3ff7
+  data.tar.gz: 2dcbd83e6f1a93b1bd3ccfeb7d54d81bd89f4f88c290a1f9384658f2291392fa6b4873f44c82bb2240a8fa5b153334fd48b0656e611cb23187d2ecde2ae25192

data/CHANGELOG.md

@@ -3,3 +3,11 @@
 ## [0.1.0] - 2023-05-22
 
 - Initial release
+
+## [0.1.1] 
+
+- Solving errors and removing unnecessary print statements
+
+## [2.0.0] 
+
+- Adding support for lexeme and property

data/Gemfile

@@ -15,5 +15,3 @@ gem 'mediawiki_api'
 
 gem 'json'
 
-gem 'dotenv'
-

data/README.md

@@ -1,6 +1,6 @@
 # WikidataDiffAnalyzer
 
-Welcome to WikidataDiffAnalyzer(Alpha Version)! The WikidataDiffAnalyzer is a Ruby gem that provides functionality to parse the differences between Wikidata revisions and extract statistics about the changes. It enables accurate analysis of Wikidata edits, such as counting the number of claims, qualifiers, references, aliases, labels, descriptions and site-links added, removed, and changed. This gem has been developed to enhance Wikidata statistics on the Wiki Education Dashboard and Programs & Events Dashboard, but it can be utilized for various other purposes as well.
+Welcome to WikidataDiffAnalyzer! The WikidataDiffAnalyzer is a Ruby gem that provides functionality to parse the differences between Wikidata revisions and extract statistics about the changes. It enables accurate analysis of Wikidata edits, such as counting the number of claims, qualifiers, references, aliases, labels, descriptions and site links added, removed, and changed. The stats for merge-to, merge-from, redirect, restore, undo and item-clearing are also returned. This gem has been developed to enhance Wikidata statistics on the Wiki Education Dashboard and Programs & Events Dashboard, but it can be utilized for various other purposes as well.
 
 ## Installation
 
@@ -16,11 +16,12 @@ Alternatively, you can install it directly via:
 ## Usage
 The main method of this gem is `WikidataDiffAnalyzer.analyze`, which receives an array of revision IDs and provides a comprehensive analysis of the differences among them.
 
-**The input should be an array of integers**. Only the valid revision ids containing wikidata-item revisions and having a parent revision will be analyzed. Other revision ids (such as invalid revision IDs, revision IDs having no parent id/ deleted parent id, and revision ids having revisions of wikitext or lexeme) will be returned as not-analyzed in this version.
+**The input should be an array of integers**. Only the valid revision ids including first rev ids containing wikidata-item/wikidata-lexeme/wikidata-property revisions will be analyzed. Other revision ids (such as invalid revision IDs, revision IDs having deleted parent IDs, and revision ids having revisions of wikitext) will be returned as not-analyzed in this version.
 
+Let's look at an example with some real revision ids -
 You can look at the HTML version of the difference between the edits with their parent revision below:
 - 0 (does not exist)
-- [123](https://www.wikidata.org/w/index.php?&diff=123) (No parent revision, is not analyzed)
+- [123](https://www.wikidata.org/w/index.php?&diff=123) (First revision, considered everything as added)
 - [622872009](https://www.wikidata.org/w/index.php?&diff=622872009) (added 1 claim)
 - [1902995129](https://www.wikidata.org/w/index.php?&diff=1902995129) (removed 1 claim, 1 reference, and 1 qualifier)
 - [1903003546](https://www.wikidata.org/w/index.php?&diff=1903003546) (changed 1 claim, added 1 qualifier)
@@ -39,9 +40,9 @@ The output is a hash including the information below:
 ```
 {
   diffs_analyzed_count: 3,
-  diffs_not_analyzed: [0, 123],
-  diffs: {1780106722: {...}, 1903003546: {...}, 1902995129: {...}},
-  total: {claims_added: 0, claims_removed: 1, claims_changed: 3 ...}
+  diffs_not_analyzed: [0],
+  diffs: {123: {...}, 622872009: {...}, 1903003546: {...}, 1902995129: {...}},
+  total: {claims_added: 1, claims_removed: 1, claims_changed: 1 ...}
 }
 
 ```
@@ -57,109 +58,271 @@ puts result[:total]                  # Prints the total stats of all diffs
 Here's the full output structure:
 ```
 # the count of analyzed diffs
-3
+4
 # the list of revision IDs not analyzed
 0
-123
 # the detailed analysis of each diff (Key is the revision ID)
-{
-  {
-  622872009=>{
-    :added_claims=>1,
-    :removed_claims=>0,
-    :changed_claims=>0,
-    :added_references=>0,
-    :removed_references=>0,
-    :changed_references=>0,
-    :added_qualifiers=>0,
-    :removed_qualifiers=>0,
-    :changed_qualifiers=>0,
-    :added_aliases=>0,
-    :removed_aliases=>0,
-    :changed_aliases=>0,
-    :added_labels=>0,
-    :removed_labels=>0,
-    :changed_labels=>0,
-    :added_descriptions=>0,
-    :removed_descriptions=>0,
-    :changed_descriptions=>0,
-    :added_sitelinks=>0,
-    :removed_sitelinks=>0,
-    :changed_sitelinks=>0
-  },
-  1902995129=>{
-    :added_claims=>0,
-    :removed_claims=>1,
-    :changed_claims=>0,
-    :added_references=>0,
-    :removed_references=>1,
-    :changed_references=>0,
-    :added_qualifiers=>0,
-    :removed_qualifiers=>1,
-    :changed_qualifiers=>0,
-    :added_aliases=>0,
-    :removed_aliases=>0,
-    :changed_aliases=>0,
-    :added_labels=>0,
-    :removed_labels=>0,
-    :changed_labels=>0,
-    :added_descriptions=>0,
-    :removed_descriptions=>0,
-    :changed_descriptions=>0,
-    :added_sitelinks=>0,
-    :removed_sitelinks=>0,
-    :changed_sitelinks=>0
-  },
-  1903003546=>{
-    :added_claims=>0,
-    :removed_claims=>0,
-    :changed_claims=>1,
-    :added_references=>0,
-    :removed_references=>0,
-    :changed_references=>0,
-    :added_qualifiers=>1,
-    :removed_qualifiers=>0,
-    :changed_qualifiers=>0,
-    :added_aliases=>0,
-    :removed_aliases=>0,
-    :changed_aliases=>0,
-    :added_labels=>0,
-    :removed_labels=>0,
-    :changed_labels=>0,
-    :added_descriptions=>0,
-    :removed_descriptions=>0,
-    :changed_descriptions=>0,
-    :added_sitelinks=>0,
-    :removed_sitelinks=>0,
-    :changed_sitelinks=>0
-  }
-}
-
-}
+{123=>
+    {:added_claims=>0,
+     :removed_claims=>0,
+     :changed_claims=>0,
+     :added_references=>0,
+     :removed_references=>0,
+     :changed_references=>0,
+     :added_qualifiers=>0,
+     :removed_qualifiers=>0,
+     :changed_qualifiers=>0,
+     :added_aliases=>0,
+     :removed_aliases=>0,
+     :changed_aliases=>0,
+     :added_labels=>1,
+     :removed_labels=>0,
+     :changed_labels=>0,
+     :added_descriptions=>1,
+     :removed_descriptions=>0,
+     :changed_descriptions=>0,
+     :added_sitelinks=>0,
+     :removed_sitelinks=>0,
+     :changed_sitelinks=>0,
+     :merge_to=>0,
+     :merge_from=>0,
+     :redirect=>0,
+     :undo=>0,
+     :restore=>0,
+     :clear_item=>0,
+     :create_item=>0,
+     :added_lemmas=>0,
+     :removed_lemmas=>0,
+     :changed_lemmas=>0,
+     :added_forms=>0,
+     :removed_forms=>0,
+     :changed_forms=>0,
+     :added_senses=>0,
+     :removed_senses=>0,
+     :changed_senses=>0,
+     :create_property=>0,
+     :create_lexeme=>0,
+     :added_representations=>0,
+     :removed_representations=>0,
+     :changed_representations=>0,
+     :added_glosses=>0,
+     :removed_glosses=>0,
+     :changed_glosses=>0,
+     :added_formclaims=>0,
+     :removed_formclaims=>0,
+     :changed_formclaims=>0,
+     :added_senseclaims=>0,
+     :removed_senseclaims=>0,
+     :changed_senseclaims=>0},
+   622872009=>
+    {:added_claims=>1,
+     :removed_claims=>0,
+     :changed_claims=>0,
+     :added_references=>0,
+     :removed_references=>0,
+     :changed_references=>0,
+     :added_qualifiers=>0,
+     :removed_qualifiers=>0,
+     :changed_qualifiers=>0,
+     :added_aliases=>0,
+     :removed_aliases=>0,
+     :changed_aliases=>0,
+     :added_labels=>0,
+     :removed_labels=>0,
+     :changed_labels=>0,
+     :added_descriptions=>0,
+     :removed_descriptions=>0,
+     :changed_descriptions=>0,
+     :added_sitelinks=>0,
+     :removed_sitelinks=>0,
+     :changed_sitelinks=>0,
+     :merge_to=>0,
+     :merge_from=>0,
+     :redirect=>0,
+     :undo=>0,
+     :restore=>0,
+     :clear_item=>0,
+     :create_item=>0,
+     :added_lemmas=>0,
+     :removed_lemmas=>0,
+     :changed_lemmas=>0,
+     :added_forms=>0,
+     :removed_forms=>0,
+     :changed_forms=>0,
+     :added_senses=>0,
+     :removed_senses=>0,
+     :changed_senses=>0,
+     :create_property=>0,
+     :create_lexeme=>0,
+     :added_representations=>0,
+     :removed_representations=>0,
+     :changed_representations=>0,
+     :added_glosses=>0,
+     :removed_glosses=>0,
+     :changed_glosses=>0,
+     :added_formclaims=>0,
+     :removed_formclaims=>0,
+     :changed_formclaims=>0,
+     :added_senseclaims=>0,
+     :removed_senseclaims=>0,
+     :changed_senseclaims=>0},
+   1902995129=>
+    {:added_claims=>0,
+     :removed_claims=>1,
+     :changed_claims=>0,
+     :added_references=>0,
+     :removed_references=>1,
+     :changed_references=>0,
+     :added_qualifiers=>0,
+     :removed_qualifiers=>1,
+     :changed_qualifiers=>0,
+     :added_aliases=>0,
+     :removed_aliases=>0,
+     :changed_aliases=>0,
+     :added_labels=>0,
+     :removed_labels=>0,
+     :changed_labels=>0,
+     :added_descriptions=>0,
+     :removed_descriptions=>0,
+     :changed_descriptions=>0,
+     :added_sitelinks=>0,
+     :removed_sitelinks=>0,
+     :changed_sitelinks=>0,
+     :merge_to=>0,
+     :merge_from=>0,
+     :redirect=>0,
+     :undo=>0,
+     :restore=>0,
+     :clear_item=>0,
+     :create_item=>0,
+     :added_lemmas=>0,
+     :removed_lemmas=>0,
+     :changed_lemmas=>0,
+     :added_forms=>0,
+     :removed_forms=>0,
+     :changed_forms=>0,
+     :added_senses=>0,
+     :removed_senses=>0,
+     :changed_senses=>0,
+     :create_property=>0,
+     :create_lexeme=>0,
+     :added_representations=>0,
+     :removed_representations=>0,
+     :changed_representations=>0,
+     :added_glosses=>0,
+     :removed_glosses=>0,
+     :changed_glosses=>0,
+     :added_formclaims=>0,
+     :removed_formclaims=>0,
+     :changed_formclaims=>0,
+     :added_senseclaims=>0,
+     :removed_senseclaims=>0,
+     :changed_senseclaims=>0},
+   1903003546=>
+    {:added_claims=>0,
+     :removed_claims=>0,
+     :changed_claims=>1,
+     :added_references=>0,
+     :removed_references=>0,
+     :changed_references=>0,
+     :added_qualifiers=>1,
+     :removed_qualifiers=>0,
+     :changed_qualifiers=>0,
+     :added_aliases=>0,
+     :removed_aliases=>0,
+     :changed_aliases=>0,
+     :added_labels=>0,
+     :removed_labels=>0,
+     :changed_labels=>0,
+     :added_descriptions=>0,
+     :removed_descriptions=>0,
+     :changed_descriptions=>0,
+     :added_sitelinks=>0,
+     :removed_sitelinks=>0,
+     :changed_sitelinks=>0,
+     :merge_to=>0,
+     :merge_from=>0,
+     :redirect=>0,
+     :undo=>0,
+     :restore=>0,
+     :clear_item=>0,
+     :create_item=>0,
+     :added_lemmas=>0,
+     :removed_lemmas=>0,
+     :changed_lemmas=>0,
+     :added_forms=>0,
+     :removed_forms=>0,
+     :changed_forms=>0,
+     :added_senses=>0,
+     :removed_senses=>0,
+     :changed_senses=>0,
+     :create_property=>0,
+     :create_lexeme=>0,
+     :added_representations=>0,
+     :removed_representations=>0,
+     :changed_representations=>0,
+     :added_glosses=>0,
+     :removed_glosses=>0,
+     :changed_glosses=>0,
+     :added_formclaims=>0,
+     :removed_formclaims=>0,
+     :changed_formclaims=>0,
+     :added_senseclaims=>0,
+     :removed_senseclaims=>0,
+     :changed_senseclaims=>0}}
 # the total stats of all diffs
-{
-  :claims_added=>1,
-  :claims_removed=>1,
-  :claims_changed=>1,
-  :references_added=>0,
-  :references_removed=>1,
-  :references_changed=>0,
-  :qualifiers_added=>1,
-  :qualifiers_removed=>1,
-  :qualifiers_changed=>0,
-  :aliases_added=>0,
-  :aliases_removed=>0,
-  :aliases_changed=>0,
-  :labels_added=>0,
-  :labels_removed=>0,
-  :labels_changed=>0,
-  :descriptions_added=>0,
-  :descriptions_removed=>0,
-  :descriptions_changed=>0,
-  :sitelinks_added=>0,
-  :sitelinks_removed=>0,
-  :sitelinks_changed=>0
-}
+:total=>
+  {:claims_added=>1,
+   :claims_removed=>1,
+   :claims_changed=>1,
+   :references_added=>0,
+   :references_removed=>1,
+   :references_changed=>0,
+   :qualifiers_added=>1,
+   :qualifiers_removed=>1,
+   :qualifiers_changed=>0,
+   :aliases_added=>0,
+   :aliases_removed=>0,
+   :aliases_changed=>0,
+   :labels_added=>1,
+   :labels_removed=>0,
+   :labels_changed=>0,
+   :descriptions_added=>1,
+   :descriptions_removed=>0,
+   :descriptions_changed=>0,
+   :sitelinks_added=>0,
+   :sitelinks_removed=>0,
+   :sitelinks_changed=>0,
+   :lemmas_added=>0,
+   :lemmas_removed=>0,
+   :lemmas_changed=>0,
+   :forms_added=>0,
+   :forms_removed=>0,
+   :forms_changed=>0,
+   :representations_added=>0,
+   :representations_removed=>0,
+   :representations_changed=>0,
+   :formclaims_added=>0,
+   :formclaims_removed=>0,
+   :formclaims_changed=>0,
+   :senses_added=>0,
+   :senses_removed=>0,
+   :senses_changed=>0,
+   :glosses_added=>0,
+   :glosses_removed=>0,
+   :glosses_changed=>0,
+   :senseclaims_added=>0,
+   :senseclaims_removed=>0,
+   :senseclaims_changed=>0,
+   :merge_to=>0,
+   :merge_from=>0,
+   :redirect=>0,
+   :undo=>0,
+   :restore=>0,
+   :clear_item=>0,
+   :create_item=>0,
+   :create_property=>0,
+   :create_lexeme=>0}
 
 
 ```

data/lib/wikidata/diff/alias_analyzer.rb

@@ -1,71 +1,88 @@
 class AliasAnalyzer
     def self.isolate_aliases_differences(current_content, parent_content)
         return {
-        changed: [],
-        removed: [],
-        added: []
+        changed_aliases: [],
+        removed_aliases: [],
+        added_aliases: []
         } if current_content.nil? && parent_content.nil?
-    
-        current_aliases = current_content['aliases'] || {}
-        parent_aliases = parent_content['aliases'] || {}
 
         changed_aliases = []
         removed_aliases = []
         added_aliases = []
-    
-        if current_aliases.is_a?(Array) || parent_aliases.is_a?(Array)
-        return {
-        changed: changed_aliases,
-        removed: removed_aliases,
-        added: added_aliases
-        }
+
+        if current_content
+            current_aliases = current_content['aliases']
+            if current_aliases.nil? || current_aliases.is_a?(Array)
+                current_aliases = {}
+            end
+        else
+            current_aliases = {}
         end
-    
-        # Iterate over each language in the current aliases
-        (current_aliases || {}).each do |lang, current_aliases_arr|
-        parent_aliases_arr = parent_aliases[lang]
-    
-        # Check if the language exists in the parent aliases
-        if parent_aliases_arr
-            # Ensure that current_aliases_arr is always an array
-            current_aliases_arr = [current_aliases_arr] unless current_aliases_arr.is_a?(Array)
-    
-            current_aliases_arr.each_with_index do |current_alias, index|
-            parent_alias = parent_aliases_arr[index]
-            if parent_alias.nil?
-                added_aliases << { lang: lang, index: index }
-            elsif current_alias != parent_alias
-                changed_aliases << { lang: lang, index: index }
+
+        if parent_content
+            parent_aliases = parent_content['aliases']
+            if parent_aliases.nil? || parent_aliases.is_a?(Array)
+                parent_aliases = {}
             end
+        else
+            parent_aliases = {}
+        end
+
+
+        if parent_content.nil?
+            (current_aliases || {}).each do |lang, current_aliases_arr|
+                current_aliases_arr = [current_aliases_arr] unless current_aliases_arr.is_a?(Array)
+            
+                current_aliases_arr.each_with_index do |current_alias, index|
+                    added_aliases << { lang: lang, index: index }
+                end
             end
         else
-            # Ensure that current_aliases_arr is always an array
-            current_aliases_arr = [current_aliases_arr] unless current_aliases_arr.is_a?(Array)
-    
-            current_aliases_arr.each_with_index do |current_alias, index|
-            added_aliases << { lang: lang, index: index }
+            # Iterate over each language in the current aliases
+            (current_aliases || {}).each do |lang, current_aliases_arr|
+                parent_aliases_arr = parent_aliases[lang]
+            
+                # Check if the language exists in the parent aliases
+                if parent_aliases_arr
+                    # Ensure that current_aliases_arr is always an array
+                    current_aliases_arr = [current_aliases_arr] unless current_aliases_arr.is_a?(Array)
+            
+                    current_aliases_arr.each_with_index do |current_alias, index|
+                    parent_alias = parent_aliases_arr[index]
+                    if parent_alias.nil?
+                        added_aliases << { lang: lang, index: index }
+                    elsif current_alias != parent_alias
+                        changed_aliases << { lang: lang, index: index }
+                    end
+                    end
+                else
+                    # Ensure that current_aliases_arr is always an array
+                    current_aliases_arr = [current_aliases_arr] unless current_aliases_arr.is_a?(Array)
+            
+                    current_aliases_arr.each_with_index do |current_alias, index|
+                    added_aliases << { lang: lang, index: index }
+                    end
+                end
             end
-        end
-        end
-    
-        # Iterate over each language in the parent aliases to find removed aliases
-        (parent_aliases || {}).each do |lang, parent_aliases_arr|
-        # Ensure that parent_aliases_arr is always an array
-        parent_aliases_arr = [parent_aliases_arr] unless parent_aliases_arr.is_a?(Array)
-    
-        current_aliases_arr = current_aliases[lang]
-    
-        if current_aliases_arr.nil?
-            parent_aliases_arr.each_index do |index|
-            removed_aliases << { lang: lang, index: index }
+        
+            # Iterate over each language in the parent aliases to find removed aliases
+            (parent_aliases || {}).each do |lang, parent_aliases_arr|
+            # Ensure that parent_aliases_arr is always an array
+                parent_aliases_arr = [parent_aliases_arr] unless parent_aliases_arr.is_a?(Array)
+            
+                current_aliases_arr = current_aliases[lang]
+            
+                if current_aliases_arr.nil?
+                    parent_aliases_arr.each_index do |index|
+                    removed_aliases << { lang: lang, index: index }
+                    end
+                end
             end
         end
-        end
-    
         {
-        changed: changed_aliases,
-        removed: removed_aliases,
-        added: added_aliases
+            changed_aliases: changed_aliases,
+            removed_aliases: removed_aliases,
+            added_aliases: added_aliases    
         }
     end
 end

data/lib/wikidata/diff/api.rb

@@ -17,12 +17,11 @@ class Api
             prop: 'revisions',
             revids: revision_ids.join('|'),
             rvslots: 'main',
-            rvprop: 'content|ids',
+            rvprop: 'content|ids|comment',
             format: 'json'
         )
 
         if response.nil?
-            puts "No response received for revision IDs: #{revision_ids.join(', ')}"
             return {}
         end
 
@@ -30,31 +29,45 @@ class Api
 
         # checks if it has pages
         if response.data['pages'].nil?
-            puts "No pages found in the response for revision IDs: #{revision_ids.join(', ')}"
             return nil
         end
 
         response.data['pages'].keys.each do |page|
             page = response.data['pages'][page]
             revisions = page['revisions']
-
+          
             revisions.each do |revision|
-            if revision['slots']['main']['contentmodel'] != 'wikibase-item'
-                puts "Content model is not wikibase-item"
-                # include the revision ids that are not wikibase-item
-                puts "Revision ID #{revision['revid']} is a #{revision['slots']['main']['contentmodel']}"
-            else
-                content = revision['slots']['main']['*']
-                revid = revision['revid']
-                if revid == 0
-                    parsed_contents[revid] = {content: nil, parentid: 0}
+              content_model = revision['slots']['main']['contentmodel']
+              if content_model == 'wikibase-item' || content_model == 'wikibase-property' || content_model == 'wikibase-lexeme'
+                if revision.key?('texthidden')
+                  puts "Content has been hidden or deleted"
+                  revid = revision['revid']
+                  parentid = revision['parentid']
+                  parsed_contents[revid] = { content: nil, comment: nil, parentid: parentid, model: content_model }
+                # checking if comment has been deleted
+                elsif revision.key?('commenthidden')
+                  puts "Comment has been hidden or deleted"
+                  revid = revision['revid']
+                  content = revision['slots']['main']['*']
+                  parentid = revision['parentid']
+                  parsed_contents[revid] = { content: JSON.parse(content), comment: nil, parentid: parentid, model: content_model }
                 else
-                    parentid = revision['parentid']
-                    parsed_contents[revid] = {content: JSON.parse(content), parentid: parentid}
+                  content = revision['slots']['main']['*']
+                  revid = revision['revid']
+                  comment = revision['comment']
+                  parentid = revision['parentid']
+                  if revid == 0 || revid.nil?
+                    parsed_contents[revid] = { content: nil, comment: nil, parentid: nil, model: 'wikibase-item' }
+                  else
+                    parsed_contents[revid] = { content: JSON.parse(content), comment: comment, parentid: parentid, model: content_model}
+                  end
                 end
+              else
+                puts "Content model is #{content_model}"
+                puts "Revision id is #{revision['revid']}"
+              end
             end
-            end
-        end
+          end
         return parsed_contents
         rescue MediawikiApi::ApiError => e
         puts "Error retrieving revision content: #{e.message}"
@@ -64,4 +77,4 @@ class Api
         raise e
         end
     end
-end
+  end