wicked_pdf 2.0.2 → 2.8.2

data/test/functional/wicked_pdf_helper_assets_test.rb

@@ -4,17 +4,146 @@ require 'action_view/test_case'
 class WickedPdfHelperAssetsTest < ActionView::TestCase
   include WickedPdf::WickedPdfHelper::Assets
 
+  setup do
+    @saved_config = WickedPdf.config
+    WickedPdf.config = {}
+  end
+
+  teardown do
+    WickedPdf.config = @saved_config
+
+    # @see freerange/mocha#331
+    Rails.application.unstub(:assets)
+    Rails.application.unstub(:assets_manifest)
+  end
+
   if Rails::VERSION::MAJOR > 3 || (Rails::VERSION::MAJOR == 3 && Rails::VERSION::MINOR > 0)
     test 'wicked_pdf_asset_base64 returns a base64 encoded asset' do
       assert_match %r{data:text\/css;base64,.+}, wicked_pdf_asset_base64('wicked.css')
     end
 
+    test 'wicked_pdf_asset_base64 works without file extension when using sprockets' do
+      assert_match %r{data:application\/javascript;base64,.+}, wicked_pdf_asset_base64('wicked')
+    end
+
+    test 'wicked_pdf_asset_base64 works with nested files and without file extension when using sprockets' do
+      assert_match %r{data:application\/javascript;base64,.+}, wicked_pdf_asset_base64('subdirectory/nested')
+    end
+
+    test 'wicked_pdf_asset_base64 works without file extension when using asset manifest' do
+      stub_manifest = OpenStruct.new(
+        :dir => Rails.root.join('app/assets'),
+        :assets => { 'wicked.css' => 'stylesheets/wicked.css', 'wicked.js' => 'javascripts/wicked.js' }
+      )
+      Rails.application.stubs(:assets).returns(nil)
+      Rails.application.stubs(:assets_manifest).returns(stub_manifest)
+
+      assert_match %r{data:text\/css;base64,.+}, wicked_pdf_asset_base64('wicked')
+    end
+
+    test 'wicked_pdf_asset_base64 works with nested files and without file extension when using asset manifest' do
+      stub_manifest = OpenStruct.new(
+        :dir => Rails.root.join('app/assets'),
+        :assets => { 'subdirectory/nested.js' => 'javascripts/subdirectory/nested.js' }
+      )
+      Rails.application.stubs(:assets).returns(nil)
+      Rails.application.stubs(:assets_manifest).returns(stub_manifest)
+
+      assert_match %r{data:text\/javascript;base64,.+}, wicked_pdf_asset_base64('subdirectory/nested')
+    end
+
     test 'wicked_pdf_stylesheet_link_tag should inline the stylesheets passed in' do
       Rails.configuration.assets.expects(:compile => true)
       assert_equal "<style type='text/css'>/* Wicked styles */\n\n</style>",
                    wicked_pdf_stylesheet_link_tag('wicked')
     end
 
+    test 'wicked_pdf_stylesheet_link_tag should work without file extension when using sprockets' do
+      Rails.configuration.assets.expects(:compile => true)
+      assert_equal "<style type='text/css'>/* Wicked styles */\n\n</style>",
+                   wicked_pdf_stylesheet_link_tag('wicked')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should work without file extension when using asset manifest' do
+      stub_manifest = OpenStruct.new(
+        :dir => Rails.root.join('app/assets'),
+        :assets => { 'wicked.css' => 'stylesheets/wicked.css', 'wicked.js' => 'javascripts/wicked.js' }
+      )
+
+      Rails.application.stubs(:assets).returns(nil)
+      Rails.application.stubs(:assets_manifest).returns(stub_manifest)
+
+      assert_equal "<style type='text/css'>/* Wicked styles */\n</style>",
+                   wicked_pdf_stylesheet_link_tag('wicked')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should raise if the stylesheet is not available and config is set' do
+      Rails.configuration.assets.expects(:compile => true)
+      WickedPdf.config[:raise_on_missing_assets] = true
+      assert_raise WickedPdf::WickedPdfHelper::Assets::MissingLocalAsset do
+        wicked_pdf_stylesheet_link_tag('non_existent')
+      end
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should return empty if the stylesheet is not available' do
+      Rails.configuration.assets.expects(:compile => true)
+      assert_equal "<style type='text/css'></style>",
+                   wicked_pdf_stylesheet_link_tag('non_existent')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should raise if the absolute path stylesheet is not available and config is set' do
+      Rails.configuration.assets.expects(:compile => true)
+      WickedPdf.config[:raise_on_missing_assets] = true
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_raise WickedPdf::WickedPdfHelper::Assets::MissingLocalAsset do
+        wicked_pdf_stylesheet_link_tag('/non_existent')
+      end
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should return empty if the absolute path stylesheet is not available' do
+      Rails.configuration.assets.expects(:compile => true).twice
+      assert_equal "<style type='text/css'></style>",
+                   wicked_pdf_stylesheet_link_tag('/non_existent')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should inline the stylesheets passed in when assets are remote' do
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 200, :body => '/* Wicked styles */')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_equal "<style type='text/css'>/* Wicked styles */</style>",
+                   wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should inline the stylesheets passed in when assets are remote and using asset manifest' do
+      stub_manifest = OpenStruct.new(
+        :dir => Rails.root.join('app/assets'),
+        :assets => { 'wicked.css' => 'stylesheets/wicked.css', 'wicked.js' => 'javascripts/wicked.js' }
+      )
+
+      Rails.application.stubs(:assets).returns(nil)
+      Rails.application.stubs(:assets_manifest).returns(stub_manifest)
+
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 200, :body => '/* Wicked styles */')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_equal "<style type='text/css'>/* Wicked styles */</style>",
+                   wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should raise if remote assets are not available and config is set' do
+      WickedPdf.config[:raise_on_missing_assets] = true
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 404, :body => 'File not found')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_raise WickedPdf::WickedPdfHelper::Assets::MissingRemoteAsset do
+        wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+      end
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should return empty if remote assets are not available' do
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 404, :body => 'File not found')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_equal "<style type='text/css'></style>",
+                   wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+    end
+
     test 'wicked_pdf_image_tag should return the same as image_tag when passed a full path' do
       Rails.configuration.assets.expects(:compile => true)
       assert_equal image_tag("file:///#{Rails.root.join('public', 'pdf')}"),

data/test/test_helper.rb

@@ -7,10 +7,12 @@ require 'test/unit'
 require 'mocha'
 require 'rails/test_help'
 require 'mocha/test_unit'
+require 'webmock/minitest'
 
 require 'wicked_pdf'
 
 Rails.backtrace_cleaner.remove_silencers!
+WickedPdf.silence_deprecations = true
 
 if (assets_dir = Rails.root.join('app/assets')) && File.directory?(assets_dir)
   # Copy CSS file
@@ -25,6 +27,11 @@ if (assets_dir = Rails.root.join('app/assets')) && File.directory?(assets_dir)
   source = File.read('test/fixtures/wicked.js')
   File.open(destination, 'w') { |f| f.write(source) }
 
+  Dir.mkdir(js_dir.join('subdirectory')) unless File.directory?(js_dir.join('subdirectory'))
+  destination = js_dir.join('subdirectory/nested.js')
+  source = File.read('test/fixtures/subdirectory/nested.js')
+  File.open(destination, 'w') { |f| f.write(source) }
+
   config_dir = assets_dir.join('config')
   Dir.mkdir(config_dir) unless File.directory?(config_dir)
   source = File.read('test/fixtures/manifest.js')

data/test/unit/wicked_pdf_binary_test.rb

@@ -0,0 +1,26 @@
+require 'test_helper'
+
+class WickedPdfBinaryTest < ActiveSupport::TestCase
+  test 'should extract old wkhtmltopdf version' do
+    version_info_sample = "Name:\n  wkhtmltopdf 0.9.9\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
+    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, binary.parse_version_string(version_info_sample)
+  end
+
+  test 'should extract new wkhtmltopdf version' do
+    version_info_sample = "Name:\n  wkhtmltopdf 0.11.0 rc2\n\nLicense:\n  Copyright (C) 2010 wkhtmltopdf/wkhtmltoimage Authors.\n\n\n\n  License LGPLv3+: GNU Lesser General Public License version 3 or later\n  <http://gnu.org/licenses/lgpl.html>. This is free software: you are free to\n  change and redistribute it. There is NO WARRANTY, to the extent permitted by\n  law.\n\nAuthors:\n  Written by Jan Habermann, Christian Sciberras and Jakob Truelsen. Patches by\n  Mehdi Abbad, Lyes Amazouz, Pascal Bach, Emmanuel Bouthenot, Benoit Garret and\n  Mario Silva."
+    assert_equal Gem::Version.new('0.11.0'), binary.parse_version_string(version_info_sample)
+  end
+
+  test 'should extract wkhtmltopdf version with nondigit symbols' do
+    version_info_sample = "Name:\n  wkhtmltopdf 0.10.4b\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
+    assert_equal Gem::Version.new('0.10.4b'), binary.parse_version_string(version_info_sample)
+  end
+
+  test 'should fallback to default version on parse error' do
+    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, binary.parse_version_string('')
+  end
+
+  def binary(path = nil)
+    WickedPdf::Binary.new(path)
+  end
+end

data/test/unit/wicked_pdf_option_parser_test.rb

@@ -0,0 +1,133 @@
+require 'test_helper'
+
+class WickedPdfOptionParserTest < ActiveSupport::TestCase
+  test 'should parse header and footer options' do
+    %i[header footer].each do |hf|
+      %i[center font_name left right].each do |o|
+        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} header_footer",
+                     parse_options(hf => { o => 'header_footer' }).strip
+      end
+
+      %i[font_size spacing].each do |o|
+        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} 12",
+                     parse_options(hf => { o => '12' }).strip
+      end
+
+      assert_equal "--#{hf}-line",
+                   parse_options(hf => { :line => true }).strip
+      assert_equal "--#{hf}-html http://www.abc.com",
+                   parse_options(hf => { :html => { :url => 'http://www.abc.com' } }).strip
+    end
+  end
+
+  test 'should parse toc options' do
+    toc_option = option_parser.valid_option('toc')
+
+    %i[font_name header_text].each do |o|
+      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} toc",
+                   parse_options(:toc => { o => 'toc' }).strip
+    end
+
+    %i[
+      depth header_fs l1_font_size l2_font_size l3_font_size l4_font_size
+      l5_font_size l6_font_size l7_font_size l1_indentation l2_indentation
+      l3_indentation l4_indentation l5_indentation l6_indentation l7_indentation
+    ].each do |o|
+      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} 5",
+                   parse_options(:toc => { o => 5 }).strip
+    end
+
+    %i[no_dots disable_links disable_back_links].each do |o|
+      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')}",
+                   parse_options(:toc => { o => true }).strip
+    end
+  end
+
+  test 'should parse outline options' do
+    assert_equal '--outline', parse_options(:outline => { :outline => true }).strip
+    assert_equal '--outline-depth 5', parse_options(:outline => { :outline_depth => 5 }).strip
+  end
+
+  test 'should parse no_images option' do
+    assert_equal '--no-images', parse_options(:no_images => true).strip
+    assert_equal '--images', parse_options(:images => true).strip
+  end
+
+  test 'should parse margins options' do
+    %i[top bottom left right].each do |o|
+      assert_equal "--margin-#{o} 12", parse_options(:margin => { o => '12' }).strip
+    end
+  end
+
+  test 'should parse cover' do
+    cover_option = option_parser.valid_option('cover')
+
+    pathname = Rails.root.join('app', 'views', 'pdf', 'file.html')
+    assert_equal "#{cover_option} http://example.org", parse_options(:cover => 'http://example.org').strip, 'URL'
+    assert_equal "#{cover_option} #{pathname}", parse_options(:cover => pathname).strip, 'Pathname'
+    assert_match(/#{cover_option} .+wicked_cover_pdf.+\.html/, parse_options(:cover => '<html><body>HELLO</body></html>').strip, 'HTML')
+  end
+
+  test 'should parse other options' do
+    %i[
+      orientation page_size proxy username password dpi
+      encoding user_style_sheet
+    ].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} opts", parse_options(o => 'opts').strip
+    end
+
+    %i[allow].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} opts", parse_options(o => 'opts').strip
+      assert_equal "--#{o.to_s.tr('_', '-')} opts1 --#{o.to_s.tr('_', '-')} opts2", parse_options(o => %w[opts1 opts2]).strip
+    end
+
+    %i[cookie post].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} name value", parse_options(o => 'name value').strip
+
+      nv_formatter = proc { |number| "--#{o.to_s.tr('_', '-')} par#{number} val#{number}" }
+      assert_equal "#{nv_formatter.call(1)} #{nv_formatter.call(2)}", parse_options(o => ['par1 val1', 'par2 val2']).strip
+    end
+
+    %i[redirect_delay zoom page_offset].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} 5", parse_options(o => 5).strip
+    end
+
+    %i[
+      book default_header disable_javascript grayscale lowquality
+      enable_plugins disable_internal_links disable_external_links
+      print_media_type disable_smart_shrinking use_xserver no_background disable_local_file_access
+    ].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')}", parse_options(o => true).strip
+    end
+  end
+
+  test 'should not use double dash options for version without dashes' do
+    op = option_parser(WickedPdf::OptionParser::BINARY_VERSION_WITHOUT_DASHES)
+
+    %w[toc cover].each do |name|
+      assert_equal op.valid_option(name), name
+    end
+  end
+
+  test 'should use double dash options for version with dashes' do
+    op = option_parser(Gem::Version.new('0.11.0'))
+
+    %w[toc cover].each do |name|
+      assert_equal op.valid_option(name), "--#{name}"
+    end
+  end
+
+  test '-- options should not be given after object' do
+    options = { :header => { :center => 3 }, :cover => 'http://example.org', :disable_javascript => true }
+    cover_option = option_parser.valid_option('cover')
+    assert_equal parse_options(options), "--disable-javascript --header-center 3 #{cover_option} http://example.org"
+  end
+
+  def parse_options(options, version = WickedPdf::DEFAULT_BINARY_VERSION)
+    option_parser(version).parse(options).join(' ')
+  end
+
+  def option_parser(version = WickedPdf::DEFAULT_BINARY_VERSION)
+    WickedPdf::OptionParser.new(version)
+  end
+end

data/test/unit/wicked_pdf_test.rb

@@ -2,26 +2,26 @@ require 'test_helper'
 WickedPdf.config = { :exe_path => ENV['WKHTMLTOPDF_BIN'] || '/usr/local/bin/wkhtmltopdf' }
 HTML_DOCUMENT = '<html><body>Hello World</body></html>'.freeze
 
-# Provide a public accessor to the normally-private parse_options function.
-# Also, smash the returned array of options into a single string for
-# convenience in testing below.
-class WickedPdf
-  undef :binary_version
-  undef :binary_version=
-  attr_accessor :binary_version
-
-  def get_parsed_options(opts)
-    parse_options(opts).join(' ')
+class WickedPdfTest < ActiveSupport::TestCase
+  def setup
+    @wp = WickedPdf.new
   end
 
-  def get_valid_option(name)
-    valid_option(name)
+  test 'should update config through .configure class method' do
+    WickedPdf.configure do |c|
+      c.test = 'foobar'
+    end
+
+    assert WickedPdf.config == { :exe_path => ENV['WKHTMLTOPDF_BIN'] || '/usr/local/bin/wkhtmltopdf', :test => 'foobar' }
   end
-end
 
-class WickedPdfTest < ActiveSupport::TestCase
-  def setup
-    @wp = WickedPdf.new
+  test 'should clear config through .clear_config class method' do
+    backup_config = WickedPdf.config
+
+    WickedPdf.clear_config
+    assert WickedPdf.config == {}
+
+    WickedPdf.config = backup_config
   end
 
   test 'should generate PDF from html document' do
@@ -86,146 +86,6 @@ class WickedPdfTest < ActiveSupport::TestCase
     end
   end
 
-  test 'should parse header and footer options' do
-    [:header, :footer].each do |hf|
-      [:center, :font_name, :left, :right].each do |o|
-        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} header_footer",
-                     @wp.get_parsed_options(hf => { o => 'header_footer' }).strip
-      end
-
-      [:font_size, :spacing].each do |o|
-        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} 12",
-                     @wp.get_parsed_options(hf => { o => '12' }).strip
-      end
-
-      assert_equal "--#{hf}-line",
-                   @wp.get_parsed_options(hf => { :line => true }).strip
-      assert_equal "--#{hf}-html http://www.abc.com",
-                   @wp.get_parsed_options(hf => { :html => { :url => 'http://www.abc.com' } }).strip
-    end
-  end
-
-  test 'should parse toc options' do
-    toc_option = @wp.get_valid_option('toc')
-
-    [:font_name, :header_text].each do |o|
-      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} toc",
-                   @wp.get_parsed_options(:toc => { o => 'toc' }).strip
-    end
-
-    [
-      :depth, :header_fs, :l1_font_size, :l2_font_size, :l3_font_size, :l4_font_size,
-      :l5_font_size, :l6_font_size, :l7_font_size, :l1_indentation, :l2_indentation,
-      :l3_indentation, :l4_indentation, :l5_indentation, :l6_indentation, :l7_indentation
-    ].each do |o|
-      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} 5",
-                   @wp.get_parsed_options(:toc => { o => 5 }).strip
-    end
-
-    [:no_dots, :disable_links, :disable_back_links].each do |o|
-      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')}",
-                   @wp.get_parsed_options(:toc => { o => true }).strip
-    end
-  end
-
-  test 'should parse outline options' do
-    assert_equal '--outline', @wp.get_parsed_options(:outline => { :outline => true }).strip
-    assert_equal '--outline-depth 5', @wp.get_parsed_options(:outline => { :outline_depth => 5 }).strip
-  end
-
-  test 'should parse no_images option' do
-    assert_equal '--no-images', @wp.get_parsed_options(:no_images => true).strip
-    assert_equal '--images', @wp.get_parsed_options(:images => true).strip
-  end
-
-  test 'should parse margins options' do
-    [:top, :bottom, :left, :right].each do |o|
-      assert_equal "--margin-#{o} 12", @wp.get_parsed_options(:margin => { o => '12' }).strip
-    end
-  end
-
-  test 'should parse cover' do
-    cover_option = @wp.get_valid_option('cover')
-
-    pathname = Rails.root.join('app', 'views', 'pdf', 'file.html')
-    assert_equal "#{cover_option} http://example.org", @wp.get_parsed_options(:cover => 'http://example.org').strip, 'URL'
-    assert_equal "#{cover_option} #{pathname}", @wp.get_parsed_options(:cover => pathname).strip, 'Pathname'
-    assert_match %r{#{cover_option} .+wicked_cover_pdf.+\.html}, @wp.get_parsed_options(:cover => '<html><body>HELLO</body></html>').strip, 'HTML'
-  end
-
-  test 'should parse other options' do
-    [
-      :orientation, :page_size, :proxy, :username, :password, :dpi,
-      :encoding, :user_style_sheet
-    ].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')} opts", @wp.get_parsed_options(o => 'opts').strip
-    end
-
-    [:cookie, :post].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')} name value", @wp.get_parsed_options(o => 'name value').strip
-
-      nv_formatter = proc { |number| "--#{o.to_s.tr('_', '-')} par#{number} val#{number}" }
-      assert_equal "#{nv_formatter.call(1)} #{nv_formatter.call(2)}", @wp.get_parsed_options(o => ['par1 val1', 'par2 val2']).strip
-    end
-
-    [:redirect_delay, :zoom, :page_offset].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')} 5", @wp.get_parsed_options(o => 5).strip
-    end
-
-    [
-      :book, :default_header, :disable_javascript, :grayscale, :lowquality,
-      :enable_plugins, :disable_internal_links, :disable_external_links,
-      :print_media_type, :disable_smart_shrinking, :use_xserver, :no_background
-    ].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')}", @wp.get_parsed_options(o => true).strip
-    end
-  end
-
-  test 'should extract old wkhtmltopdf version' do
-    version_info_sample = "Name:\n  wkhtmltopdf 0.9.9\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
-    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, @wp.send(:parse_version, version_info_sample)
-  end
-
-  test 'should extract new wkhtmltopdf version' do
-    version_info_sample = "Name:\n  wkhtmltopdf 0.11.0 rc2\n\nLicense:\n  Copyright (C) 2010 wkhtmltopdf/wkhtmltoimage Authors.\n\n\n\n  License LGPLv3+: GNU Lesser General Public License version 3 or later\n  <http://gnu.org/licenses/lgpl.html>. This is free software: you are free to\n  change and redistribute it. There is NO WARRANTY, to the extent permitted by\n  law.\n\nAuthors:\n  Written by Jan Habermann, Christian Sciberras and Jakob Truelsen. Patches by\n  Mehdi Abbad, Lyes Amazouz, Pascal Bach, Emmanuel Bouthenot, Benoit Garret and\n  Mario Silva."
-    assert_equal Gem::Version.new('0.11.0'), @wp.send(:parse_version, version_info_sample)
-  end
-
-  test 'should extract wkhtmltopdf version with nondigit symbols' do
-    version_info_sample = "Name:\n  wkhtmltopdf 0.10.4b\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
-    assert_equal Gem::Version.new('0.10.4b'), @wp.send(:parse_version, version_info_sample)
-  end
-
-  test 'should fallback to default version on parse error' do
-    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, @wp.send(:parse_version, '')
-  end
-
-  test 'should set version on initialize' do
-    assert_not_equal @wp.send(:binary_version), ''
-  end
-
-  test 'should not use double dash options for version without dashes' do
-    @wp.binary_version = WickedPdf::BINARY_VERSION_WITHOUT_DASHES
-
-    %w[toc cover].each do |name|
-      assert_equal @wp.get_valid_option(name), name
-    end
-  end
-
-  test 'should use double dash options for version with dashes' do
-    @wp.binary_version = Gem::Version.new('0.11.0')
-
-    %w[toc cover].each do |name|
-      assert_equal @wp.get_valid_option(name), "--#{name}"
-    end
-  end
-
-  test '-- options should not be given after object' do
-    options = { :header => { :center => 3 }, :cover => 'http://example.org', :disable_javascript => true }
-    cover_option = @wp.get_valid_option('cover')
-    assert_equal @wp.get_parsed_options(options), "--disable-javascript --header-center 3 #{cover_option} http://example.org"
-  end
-
   test 'should output progress when creating pdfs on compatible hosts' do
     wp = WickedPdf.new
     output = []

data/test/unit/wkhtmltopdf_location_test.rb

@@ -1,5 +1,3 @@
-
-
 class WkhtmltopdfLocationTest < ActiveSupport::TestCase
   setup do
     @saved_config = WickedPdf.config

data/wicked_pdf.gemspec

@@ -1,4 +1,3 @@
-
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'wicked_pdf/version'
@@ -24,19 +23,20 @@ DESC
 
   spec.required_ruby_version = Gem::Requirement.new('>= 2.2')
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
   spec.requirements << 'wkhtmltopdf'
 
   spec.add_dependency 'activesupport'
+  spec.add_dependency 'ostruct'
 
-  spec.add_development_dependency 'rails'
   spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'mocha', '= 1.3'
+  spec.add_development_dependency 'rails'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop', '~> 0.68.0'
+  spec.add_development_dependency 'rubocop', '~> 1.46'
   spec.add_development_dependency 'sqlite3', '~> 1.3'
-  spec.add_development_dependency 'mocha', '= 1.3'
   spec.add_development_dependency 'test-unit'
+  spec.add_development_dependency 'webmock', '~> 3.19'
 end