wicked_pdf 1.1.0 → 2.8.0

data/test/fixtures/manifest.js

@@ -0,0 +1,3 @@
+//= link_tree ../images
+//= link wicked.js
+//= link wicked.css

data/test/functional/pdf_helper_test.rb

@@ -5,10 +5,32 @@ module ActionController
     def render_to_string(opts = {})
       opts.to_s
     end
+
+    def self.alias_method_chain(_target, _feature); end
+  end
+end
+
+module ActionControllerMock
+  class Base
+    def render(_)
+      [:base]
+    end
+
+    def render_to_string; end
+
+    def self.after_action(_); end
   end
 end
 
 class PdfHelperTest < ActionController::TestCase
+  module SomePatch
+    def render(_)
+      super.tap do |s|
+        s << :patched
+      end
+    end
+  end
+
   def setup
     @ac = ActionController::Base.new
   end
@@ -22,4 +44,53 @@ class PdfHelperTest < ActionController::TestCase
                        :header => { :html => { :template => 'hf.html.erb' } })
     assert_match %r{^file:\/\/\/.*wicked_header_pdf.*\.html}, options[:header][:html][:url]
   end
+
+  test 'should not interfere with already prepended patches' do
+    # Emulate railtie
+    if Rails::VERSION::MAJOR >= 5
+      # this spec tests the following:
+      # if another gem prepends a render method to ActionController::Base
+      # before wicked_pdf does, does calling render trigger an infinite loop?
+      # this spec fails with 6392bea1fe3a41682dfd7c20fd9c179b5a758f59 because PdfHelper
+      # aliases the render method prepended by the other gem to render_without_pdf, then
+      # base_evals its own definition of render, which calls render_with_pdf -> render_without_pdf.
+      # If the other gem uses the prepend inhertinance pattern (calling super instead of aliasing),
+      # when it calls super it calls the base_eval'd version of render instead of going up the
+      # inheritance chain, causing an infinite loop.
+
+      # This fiddling with consts is required to get around the fact that PdfHelper checks
+      # that it is being prepended to ActionController::Base
+      OriginalBase = ActionController::Base
+      ActionController.send(:remove_const, :Base)
+      ActionController.const_set(:Base, ActionControllerMock::Base)
+
+      # Emulate another gem being loaded before wicked
+      ActionController::Base.prepend(SomePatch)
+      ActionController::Base.prepend(::WickedPdf::PdfHelper)
+
+      begin
+        # test that wicked's render method is actually called
+        ac = ActionController::Base.new
+        ac.expects(:render_with_wicked_pdf)
+        ac.render(:cats)
+
+        # test that calling render does not trigger infinite loop
+        ac = ActionController::Base.new
+        assert_equal %i[base patched], ac.render(:cats)
+      rescue SystemStackError
+        assert_equal true, false # force spec failure
+      ensure
+        ActionController.send(:remove_const, :Base)
+        ActionController.const_set(:Base, OriginalBase)
+      end
+    end
+  end
+
+  test 'should call after_action instead of after_filter when able' do
+    ActionController::Base.expects(:after_filter).with(:clean_temp_files).never
+    ActionController::Base.expects(:after_action).with(:clean_temp_files).once
+    ActionController::Base.class_eval do
+      include ::WickedPdf::PdfHelper
+    end
+  end
 end

data/test/functional/wicked_pdf_helper_assets_test.rb

@@ -4,6 +4,15 @@ require 'action_view/test_case'
 class WickedPdfHelperAssetsTest < ActionView::TestCase
   include WickedPdf::WickedPdfHelper::Assets
 
+  setup do
+    @saved_config = WickedPdf.config
+    WickedPdf.config = {}
+  end
+
+  teardown do
+    WickedPdf.config = @saved_config
+  end
+
   if Rails::VERSION::MAJOR > 3 || (Rails::VERSION::MAJOR == 3 && Rails::VERSION::MINOR > 0)
     test 'wicked_pdf_asset_base64 returns a base64 encoded asset' do
       assert_match %r{data:text\/css;base64,.+}, wicked_pdf_asset_base64('wicked.css')
@@ -15,6 +24,58 @@ class WickedPdfHelperAssetsTest < ActionView::TestCase
                    wicked_pdf_stylesheet_link_tag('wicked')
     end
 
+    test 'wicked_pdf_stylesheet_link_tag should raise if the stylesheet is not available and config is set' do
+      Rails.configuration.assets.expects(:compile => true)
+      WickedPdf.config[:raise_on_missing_assets] = true
+      assert_raise WickedPdf::WickedPdfHelper::Assets::MissingLocalAsset do
+        wicked_pdf_stylesheet_link_tag('non_existent')
+      end
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should return empty if the stylesheet is not available' do
+      Rails.configuration.assets.expects(:compile => true)
+      assert_equal "<style type='text/css'></style>",
+                   wicked_pdf_stylesheet_link_tag('non_existent')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should raise if the absolute path stylesheet is not available and config is set' do
+      Rails.configuration.assets.expects(:compile => true)
+      WickedPdf.config[:raise_on_missing_assets] = true
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_raise WickedPdf::WickedPdfHelper::Assets::MissingLocalAsset do
+        wicked_pdf_stylesheet_link_tag('/non_existent')
+      end
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should return empty if the absolute path stylesheet is not available' do
+      Rails.configuration.assets.expects(:compile => true).twice
+      assert_equal "<style type='text/css'></style>",
+                   wicked_pdf_stylesheet_link_tag('/non_existent')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should inline the stylesheets passed in when assets are remote' do
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 200, :body => '/* Wicked styles */')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_equal "<style type='text/css'>/* Wicked styles */</style>",
+                   wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should raise if remote assets are not available and config is set' do
+      WickedPdf.config[:raise_on_missing_assets] = true
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 404, :body => 'File not found')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_raise WickedPdf::WickedPdfHelper::Assets::MissingRemoteAsset do
+        wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+      end
+    end
+
+    test 'wicked_pdf_stylesheet_link_tag should return empty if remote assets are not available' do
+      stub_request(:get, 'https://www.example.com/wicked.css').to_return(:status => 404, :body => 'File not found')
+      expects(:precompiled_or_absolute_asset? => true).twice
+      assert_equal "<style type='text/css'></style>",
+                   wicked_pdf_stylesheet_link_tag('https://www.example.com/wicked.css')
+    end
+
     test 'wicked_pdf_image_tag should return the same as image_tag when passed a full path' do
       Rails.configuration.assets.expects(:compile => true)
       assert_equal image_tag("file:///#{Rails.root.join('public', 'pdf')}"),

data/test/test_helper.rb

@@ -5,17 +5,14 @@ require File.expand_path('../dummy/config/environment.rb', __FILE__)
 
 require 'test/unit'
 require 'mocha'
-
-if Rails::VERSION::MAJOR == 2
-  require 'test_help'
-else
-  require 'rails/test_help'
-  require 'mocha/test_unit'
-end
+require 'rails/test_help'
+require 'mocha/test_unit'
+require 'webmock/minitest'
 
 require 'wicked_pdf'
 
 Rails.backtrace_cleaner.remove_silencers!
+WickedPdf.silence_deprecations = true
 
 if (assets_dir = Rails.root.join('app/assets')) && File.directory?(assets_dir)
   # Copy CSS file
@@ -24,7 +21,15 @@ if (assets_dir = Rails.root.join('app/assets')) && File.directory?(assets_dir)
   File.open(destination, 'w') { |f| f.write(source) }
 
   # Copy JS file
-  destination = assets_dir.join('javascripts/wicked.js')
+  js_dir = assets_dir.join('javascripts')
+  Dir.mkdir(js_dir) unless File.directory?(js_dir)
+  destination = js_dir.join('wicked.js')
   source = File.read('test/fixtures/wicked.js')
   File.open(destination, 'w') { |f| f.write(source) }
+
+  config_dir = assets_dir.join('config')
+  Dir.mkdir(config_dir) unless File.directory?(config_dir)
+  source = File.read('test/fixtures/manifest.js')
+  destination = config_dir.join('manifest.js')
+  File.open(destination, 'w') { |f| f.write(source) }
 end

data/test/unit/wicked_pdf_binary_test.rb

@@ -0,0 +1,26 @@
+require 'test_helper'
+
+class WickedPdfBinaryTest < ActiveSupport::TestCase
+  test 'should extract old wkhtmltopdf version' do
+    version_info_sample = "Name:\n  wkhtmltopdf 0.9.9\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
+    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, binary.parse_version_string(version_info_sample)
+  end
+
+  test 'should extract new wkhtmltopdf version' do
+    version_info_sample = "Name:\n  wkhtmltopdf 0.11.0 rc2\n\nLicense:\n  Copyright (C) 2010 wkhtmltopdf/wkhtmltoimage Authors.\n\n\n\n  License LGPLv3+: GNU Lesser General Public License version 3 or later\n  <http://gnu.org/licenses/lgpl.html>. This is free software: you are free to\n  change and redistribute it. There is NO WARRANTY, to the extent permitted by\n  law.\n\nAuthors:\n  Written by Jan Habermann, Christian Sciberras and Jakob Truelsen. Patches by\n  Mehdi Abbad, Lyes Amazouz, Pascal Bach, Emmanuel Bouthenot, Benoit Garret and\n  Mario Silva."
+    assert_equal Gem::Version.new('0.11.0'), binary.parse_version_string(version_info_sample)
+  end
+
+  test 'should extract wkhtmltopdf version with nondigit symbols' do
+    version_info_sample = "Name:\n  wkhtmltopdf 0.10.4b\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
+    assert_equal Gem::Version.new('0.10.4b'), binary.parse_version_string(version_info_sample)
+  end
+
+  test 'should fallback to default version on parse error' do
+    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, binary.parse_version_string('')
+  end
+
+  def binary(path = nil)
+    WickedPdf::Binary.new(path)
+  end
+end

data/test/unit/wicked_pdf_option_parser_test.rb

@@ -0,0 +1,133 @@
+require 'test_helper'
+
+class WickedPdfOptionParserTest < ActiveSupport::TestCase
+  test 'should parse header and footer options' do
+    %i[header footer].each do |hf|
+      %i[center font_name left right].each do |o|
+        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} header_footer",
+                     parse_options(hf => { o => 'header_footer' }).strip
+      end
+
+      %i[font_size spacing].each do |o|
+        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} 12",
+                     parse_options(hf => { o => '12' }).strip
+      end
+
+      assert_equal "--#{hf}-line",
+                   parse_options(hf => { :line => true }).strip
+      assert_equal "--#{hf}-html http://www.abc.com",
+                   parse_options(hf => { :html => { :url => 'http://www.abc.com' } }).strip
+    end
+  end
+
+  test 'should parse toc options' do
+    toc_option = option_parser.valid_option('toc')
+
+    %i[font_name header_text].each do |o|
+      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} toc",
+                   parse_options(:toc => { o => 'toc' }).strip
+    end
+
+    %i[
+      depth header_fs l1_font_size l2_font_size l3_font_size l4_font_size
+      l5_font_size l6_font_size l7_font_size l1_indentation l2_indentation
+      l3_indentation l4_indentation l5_indentation l6_indentation l7_indentation
+    ].each do |o|
+      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} 5",
+                   parse_options(:toc => { o => 5 }).strip
+    end
+
+    %i[no_dots disable_links disable_back_links].each do |o|
+      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')}",
+                   parse_options(:toc => { o => true }).strip
+    end
+  end
+
+  test 'should parse outline options' do
+    assert_equal '--outline', parse_options(:outline => { :outline => true }).strip
+    assert_equal '--outline-depth 5', parse_options(:outline => { :outline_depth => 5 }).strip
+  end
+
+  test 'should parse no_images option' do
+    assert_equal '--no-images', parse_options(:no_images => true).strip
+    assert_equal '--images', parse_options(:images => true).strip
+  end
+
+  test 'should parse margins options' do
+    %i[top bottom left right].each do |o|
+      assert_equal "--margin-#{o} 12", parse_options(:margin => { o => '12' }).strip
+    end
+  end
+
+  test 'should parse cover' do
+    cover_option = option_parser.valid_option('cover')
+
+    pathname = Rails.root.join('app', 'views', 'pdf', 'file.html')
+    assert_equal "#{cover_option} http://example.org", parse_options(:cover => 'http://example.org').strip, 'URL'
+    assert_equal "#{cover_option} #{pathname}", parse_options(:cover => pathname).strip, 'Pathname'
+    assert_match(/#{cover_option} .+wicked_cover_pdf.+\.html/, parse_options(:cover => '<html><body>HELLO</body></html>').strip, 'HTML')
+  end
+
+  test 'should parse other options' do
+    %i[
+      orientation page_size proxy username password dpi
+      encoding user_style_sheet
+    ].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} opts", parse_options(o => 'opts').strip
+    end
+
+    %i[allow].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} opts", parse_options(o => 'opts').strip
+      assert_equal "--#{o.to_s.tr('_', '-')} opts1 --#{o.to_s.tr('_', '-')} opts2", parse_options(o => %w[opts1 opts2]).strip
+    end
+
+    %i[cookie post].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} name value", parse_options(o => 'name value').strip
+
+      nv_formatter = proc { |number| "--#{o.to_s.tr('_', '-')} par#{number} val#{number}" }
+      assert_equal "#{nv_formatter.call(1)} #{nv_formatter.call(2)}", parse_options(o => ['par1 val1', 'par2 val2']).strip
+    end
+
+    %i[redirect_delay zoom page_offset].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')} 5", parse_options(o => 5).strip
+    end
+
+    %i[
+      book default_header disable_javascript grayscale lowquality
+      enable_plugins disable_internal_links disable_external_links
+      print_media_type disable_smart_shrinking use_xserver no_background disable_local_file_access
+    ].each do |o|
+      assert_equal "--#{o.to_s.tr('_', '-')}", parse_options(o => true).strip
+    end
+  end
+
+  test 'should not use double dash options for version without dashes' do
+    op = option_parser(WickedPdf::OptionParser::BINARY_VERSION_WITHOUT_DASHES)
+
+    %w[toc cover].each do |name|
+      assert_equal op.valid_option(name), name
+    end
+  end
+
+  test 'should use double dash options for version with dashes' do
+    op = option_parser(Gem::Version.new('0.11.0'))
+
+    %w[toc cover].each do |name|
+      assert_equal op.valid_option(name), "--#{name}"
+    end
+  end
+
+  test '-- options should not be given after object' do
+    options = { :header => { :center => 3 }, :cover => 'http://example.org', :disable_javascript => true }
+    cover_option = option_parser.valid_option('cover')
+    assert_equal parse_options(options), "--disable-javascript --header-center 3 #{cover_option} http://example.org"
+  end
+
+  def parse_options(options, version = WickedPdf::DEFAULT_BINARY_VERSION)
+    option_parser(version).parse(options).join(' ')
+  end
+
+  def option_parser(version = WickedPdf::DEFAULT_BINARY_VERSION)
+    WickedPdf::OptionParser.new(version)
+  end
+end

data/test/unit/wicked_pdf_test.rb

@@ -1,25 +1,27 @@
 require 'test_helper'
-
 WickedPdf.config = { :exe_path => ENV['WKHTMLTOPDF_BIN'] || '/usr/local/bin/wkhtmltopdf' }
 HTML_DOCUMENT = '<html><body>Hello World</body></html>'.freeze
 
-# Provide a public accessor to the normally-private parse_options function.
-# Also, smash the returned array of options into a single string for
-# convenience in testing below.
-class WickedPdf
-  attr_accessor :binary_version
-  def get_parsed_options(opts)
-    parse_options(opts).join(' ')
+class WickedPdfTest < ActiveSupport::TestCase
+  def setup
+    @wp = WickedPdf.new
   end
 
-  def get_valid_option(name)
-    valid_option(name)
+  test 'should update config through .configure class method' do
+    WickedPdf.configure do |c|
+      c.test = 'foobar'
+    end
+
+    assert WickedPdf.config == { :exe_path => ENV['WKHTMLTOPDF_BIN'] || '/usr/local/bin/wkhtmltopdf', :test => 'foobar' }
   end
-end
 
-class WickedPdfTest < ActiveSupport::TestCase
-  def setup
-    @wp = WickedPdf.new
+  test 'should clear config through .clear_config class method' do
+    backup_config = WickedPdf.config
+
+    WickedPdf.clear_config
+    assert WickedPdf.config == {}
+
+    WickedPdf.config = backup_config
   end
 
   test 'should generate PDF from html document' do
@@ -84,138 +86,15 @@ class WickedPdfTest < ActiveSupport::TestCase
     end
   end
 
-  test 'should parse header and footer options' do
-    [:header, :footer].each do |hf|
-      [:center, :font_name, :left, :right].each do |o|
-        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} header_footer",
-                     @wp.get_parsed_options(hf => { o => 'header_footer' }).strip
-      end
-
-      [:font_size, :spacing].each do |o|
-        assert_equal "--#{hf}-#{o.to_s.tr('_', '-')} 12",
-                     @wp.get_parsed_options(hf => { o => '12' }).strip
-      end
-
-      assert_equal "--#{hf}-line",
-                   @wp.get_parsed_options(hf => { :line => true }).strip
-      assert_equal "--#{hf}-html http://www.abc.com",
-                   @wp.get_parsed_options(hf => { :html => { :url => 'http://www.abc.com' } }).strip
-    end
-  end
-
-  test 'should parse toc options' do
-    toc_option = @wp.get_valid_option('toc')
-
-    [:font_name, :header_text].each do |o|
-      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} toc",
-                   @wp.get_parsed_options(:toc => { o => 'toc' }).strip
-    end
-
-    [
-      :depth, :header_fs, :l1_font_size, :l2_font_size, :l3_font_size, :l4_font_size,
-      :l5_font_size, :l6_font_size, :l7_font_size, :l1_indentation, :l2_indentation,
-      :l3_indentation, :l4_indentation, :l5_indentation, :l6_indentation, :l7_indentation
-    ].each do |o|
-      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')} 5",
-                   @wp.get_parsed_options(:toc => { o => 5 }).strip
-    end
-
-    [:no_dots, :disable_links, :disable_back_links].each do |o|
-      assert_equal "#{toc_option} --toc-#{o.to_s.tr('_', '-')}",
-                   @wp.get_parsed_options(:toc => { o => true }).strip
-    end
-  end
-
-  test 'should parse outline options' do
-    assert_equal '--outline', @wp.get_parsed_options(:outline => { :outline => true }).strip
-    assert_equal '--outline-depth 5', @wp.get_parsed_options(:outline => { :outline_depth => 5 }).strip
-  end
-
-  test 'should parse margins options' do
-    [:top, :bottom, :left, :right].each do |o|
-      assert_equal "--margin-#{o} 12", @wp.get_parsed_options(:margin => { o => '12' }).strip
-    end
-  end
-
-  test 'should parse cover' do
-    cover_option = @wp.get_valid_option('cover')
-
-    pathname = Rails.root.join('app', 'views', 'pdf', 'file.html')
-    assert_equal "#{cover_option} http://example.org", @wp.get_parsed_options(:cover => 'http://example.org').strip, 'URL'
-    assert_equal "#{cover_option} #{pathname}", @wp.get_parsed_options(:cover => pathname).strip, 'Pathname'
-    assert_match %r{#{cover_option} .+wicked_cover_pdf.+\.html}, @wp.get_parsed_options(:cover => '<html><body>HELLO</body></html>').strip, 'HTML'
-  end
-
-  test 'should parse other options' do
-    [
-      :orientation, :page_size, :proxy, :username, :password, :dpi,
-      :encoding, :user_style_sheet
-    ].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')} opts", @wp.get_parsed_options(o => 'opts').strip
-    end
-
-    [:cookie, :post].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')} name value", @wp.get_parsed_options(o => 'name value').strip
-
-      nv_formatter = proc { |number| "--#{o.to_s.tr('_', '-')} par#{number} val#{number}" }
-      assert_equal "#{nv_formatter.call(1)} #{nv_formatter.call(2)}", @wp.get_parsed_options(o => ['par1 val1', 'par2 val2']).strip
-    end
-
-    [:redirect_delay, :zoom, :page_offset].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')} 5", @wp.get_parsed_options(o => 5).strip
-    end
-
-    [
-      :book, :default_header, :disable_javascript, :grayscale, :lowquality,
-      :enable_plugins, :disable_internal_links, :disable_external_links,
-      :print_media_type, :disable_smart_shrinking, :use_xserver, :no_background
-    ].each do |o|
-      assert_equal "--#{o.to_s.tr('_', '-')}", @wp.get_parsed_options(o => true).strip
+  test 'should output progress when creating pdfs on compatible hosts' do
+    wp = WickedPdf.new
+    output = []
+    options = { :progress => proc { |o| output << o } }
+    wp.pdf_from_string HTML_DOCUMENT, options
+    if RbConfig::CONFIG['target_os'] =~ /mswin|mingw/
+      assert_empty output
+    else
+      assert(output.collect { |l| !l.match(/Loading/).nil? }.include?(true)) # should output something like "Loading pages (1/5)"
     end
   end
-
-  test 'should extract old wkhtmltopdf version' do
-    version_info_sample = "Name:\n  wkhtmltopdf 0.9.9\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
-    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, @wp.send(:parse_version, version_info_sample)
-  end
-
-  test 'should extract new wkhtmltopdf version' do
-    version_info_sample = "Name:\n  wkhtmltopdf 0.11.0 rc2\n\nLicense:\n  Copyright (C) 2010 wkhtmltopdf/wkhtmltoimage Authors.\n\n\n\n  License LGPLv3+: GNU Lesser General Public License version 3 or later\n  <http://gnu.org/licenses/lgpl.html>. This is free software: you are free to\n  change and redistribute it. There is NO WARRANTY, to the extent permitted by\n  law.\n\nAuthors:\n  Written by Jan Habermann, Christian Sciberras and Jakob Truelsen. Patches by\n  Mehdi Abbad, Lyes Amazouz, Pascal Bach, Emmanuel Bouthenot, Benoit Garret and\n  Mario Silva."
-    assert_equal Gem::Version.new('0.11.0'), @wp.send(:parse_version, version_info_sample)
-  end
-
-  test 'should extract wkhtmltopdf version with nondigit symbols' do
-    version_info_sample = "Name:\n  wkhtmltopdf 0.10.4b\n\nLicense:\n  Copyright (C) 2008,2009 Wkhtmltopdf Authors.\n\n\n\n  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.\n  This is free software: you are free to change and redistribute it. There is NO\n  WARRANTY, to the extent permitted by law.\n\nAuthors:\n  Written by Jakob Truelsen. Patches by Mrio Silva, Benoit Garret and Emmanuel\n  Bouthenot.\n"
-    assert_equal Gem::Version.new('0.10.4b'), @wp.send(:parse_version, version_info_sample)
-  end
-
-  test 'should fallback to default version on parse error' do
-    assert_equal WickedPdf::DEFAULT_BINARY_VERSION, @wp.send(:parse_version, '')
-  end
-
-  test 'should set version on initialize' do
-    assert_not_equal @wp.send(:binary_version), ''
-  end
-
-  test 'should not use double dash options for version without dashes' do
-    @wp.binary_version = WickedPdf::BINARY_VERSION_WITHOUT_DASHES
-
-    %w(toc cover).each do |name|
-      assert_equal @wp.get_valid_option(name), name
-    end
-  end
-
-  test 'should use double dash options for version with dashes' do
-    @wp.binary_version = Gem::Version.new('0.11.0')
-
-    %w(toc cover).each do |name|
-      assert_equal @wp.get_valid_option(name), "--#{name}"
-    end
-  end
-
-  test '-- options should not be given after object' do
-    options = { :header => { :center => 3 }, :cover => 'http://example.org', :disable_javascript => true }
-    cover_option = @wp.get_valid_option('cover')
-    assert_equal @wp.get_parsed_options(options), "--disable-javascript --header-center 3 #{cover_option} http://example.org"
-  end
 end

data/test/unit/wkhtmltopdf_location_test.rb

@@ -0,0 +1,48 @@
+class WkhtmltopdfLocationTest < ActiveSupport::TestCase
+  setup do
+    @saved_config = WickedPdf.config
+    WickedPdf.config = {}
+  end
+
+  teardown do
+    WickedPdf.config = @saved_config
+  end
+
+  test 'should correctly locate wkhtmltopdf without bundler' do
+    bundler_module = Bundler
+    Object.send(:remove_const, :Bundler)
+
+    assert_nothing_raised do
+      WickedPdf.new
+    end
+
+    Object.const_set(:Bundler, bundler_module)
+  end
+
+  test 'should correctly locate wkhtmltopdf with bundler' do
+    assert_nothing_raised do
+      WickedPdf.new
+    end
+  end
+
+  class LocationNonWritableTest < ActiveSupport::TestCase
+    setup do
+      @saved_config = WickedPdf.config
+      WickedPdf.config = {}
+
+      @old_home = ENV['HOME']
+      ENV['HOME'] = '/not/a/writable/directory'
+    end
+
+    teardown do
+      WickedPdf.config = @saved_config
+      ENV['HOME'] = @old_home
+    end
+
+    test 'should correctly locate wkhtmltopdf with bundler while HOME is set to a non-writable directory' do
+      assert_nothing_raised do
+        WickedPdf.new
+      end
+    end
+  end
+end

data/wicked_pdf.gemspec

@@ -1,4 +1,3 @@
-# coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'wicked_pdf/version'
@@ -7,28 +6,36 @@ require 'English'
 Gem::Specification.new do |spec|
   spec.name          = 'wicked_pdf'
   spec.version       = WickedPdf::VERSION
-  spec.authors       = ['Miles Z. Sterrett']
-  spec.email         = 'miles.sterrett@gmail.com'
+  spec.authors       = ['Miles Z. Sterrett', 'David Jones']
+  spec.email         = ['miles.sterrett@gmail.com', 'unixmonkey1@gmail.com']
   spec.summary       = 'PDF generator (from HTML) gem for Ruby on Rails'
   spec.homepage      = 'https://github.com/mileszs/wicked_pdf'
   spec.license       = 'MIT'
   spec.date          = Time.now.strftime('%Y-%m-%d')
-  spec.description   = <<desc
-Wicked PDF uses the shell utility wkhtmltopdf to serve a PDF file to a user from HTML.
-In other words, rather than dealing with a PDF generation DSL of some sort,
-you simply write an HTML view as you would normally, and let Wicked take care of the hard stuff.
-desc
+  spec.description   = <<DESC.gsub(/^\s+/, '')
+    Wicked PDF uses the shell utility wkhtmltopdf to serve a PDF file to a user from HTML.
+    In other words, rather than dealing with a PDF generation DSL of some sort,
+    you simply write an HTML view as you would normally, and let Wicked take care of the hard stuff.
+DESC
+  spec.metadata =    {
+    'changelog_uri' => 'https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md'
+  }
 
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.2')
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.requirements << 'wkhtmltopdf'
+
+  spec.add_dependency 'activesupport'
+
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'mocha', '= 1.3'
   spec.add_development_dependency 'rails'
-  spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop' if RUBY_VERSION >= '2.0.0'
-  spec.add_development_dependency 'sqlite3'
-  spec.add_development_dependency 'mocha'
+  spec.add_development_dependency 'rubocop', '~> 1.46'
+  spec.add_development_dependency 'sqlite3', '~> 1.3'
   spec.add_development_dependency 'test-unit'
+  spec.add_development_dependency 'webmock', '~> 3.19'
 end