whos_dated_who 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a514d64aca0c9604731c4787b82025cb6b72349
-  data.tar.gz: 0d50b08f2673d864b281fea5e44ba56eed7af320
+  metadata.gz: 6926df4ea88a005695b59c0aeaf9ea31945c1cde
+  data.tar.gz: 9fc1d12d3d151d8d5499b9cae8df2ea01e0886dc
 SHA512:
-  metadata.gz: 7007d44aaf1273520b25e606973ee7ac20bfc0596655d474defad940fc303ff6141467befd8a93f479de21993461477b6b7ce05e49e0bdcb564a3972453b3895
-  data.tar.gz: 5cd81f8543cb39c424bd7891cf9b2a105440ae5d4255cdabad66efbdb8506c84aa6df851dbdc9b0a9fb895809309128524653d6ebcae5b03eea5b6d5bef7c522
+  metadata.gz: d21d1383ba7f9a095f3909a9b18d5633b92ada3afa1eb867885b19e6069ca2eb97dfb6f86ab2a78dbabe968024824801d16ee8e4f1ff899850ca13504dc55b6f
+  data.tar.gz: 26d201634852dc932e49afd46866257fab9525c2493b02f4b91bc1ce4b32b90ff3cf0825476c8c96b0198d5491eace5c426907ed8b8d23d50bb103f61970f24b

data/Rakefile

@@ -1,2 +1,5 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
+RSpec::Core::RakeTask.new('spec')
+task default: :spec

data/lib/whos_dated_who/bing_client.rb

@@ -2,9 +2,9 @@ require 'yaml'
 module WhosDatedWho
   class BingClient
     API_KEY = ENV['BING_API_KEY'] ||
-      YAML.load_file( File.expand_path('~/.whos_dated_who.yml'))[:bing_api_key]
+              YAML.load_file(File.expand_path('~/.whos_dated_who.yml'))[:bing_api_key]
 
-    def initialize(type='Web', num_results=10, api_key=API_KEY)
+    def initialize(type = 'Web', num_results = 10, api_key = API_KEY)
       @api_key = api_key
       @client = Bing.new(@api_key, num_results, type)
     end

data/lib/whos_dated_who/biography.rb

@@ -1,9 +1,9 @@
-require "date"
+require 'date'
 
 class Biography < Hashie::Trash
   include Hashie::Extensions::IgnoreUndeclared
 
-  @split_on_comma = ->(i) { i.kind_of?(Array) ? i : i.split(", ") }
+  @split_on_comma = ->(i) { i.is_a?(Array) ? i : i.split(', ') }
 
   property :first_name
   property :middle_name
@@ -35,7 +35,7 @@ class Biography < Hashie::Trash
   property :measurements_inches
   property :dress_size
   property :shoe_size
-  property :websites, from: :official_website #array
+  property :websites, from: :official_website # array
   property :father
   property :mother
   property :brothers # array

data/lib/whos_dated_who/cli.rb

@@ -3,19 +3,19 @@ require 'whos_dated_who'
 
 module WhosDatedWho
   class CLI < Thor
-    desc "version", "Return the version of WhosDatedWho"
+    desc 'version', 'Return the version of WhosDatedWho'
     def version
       puts WhosDatedWho::VERSION
     end
 
-    desc "query", "Return the relationship status of a celebrity"
+    desc 'query', 'Return the relationship status of a celebrity'
     def query(name)
       result = Client.new.fetch(name)
       puts "#{result[:relationship_status]}: #{result[:current_relationship][:human]}"
-      puts result[:current_relationship][:dates].join(", ")
+      puts result[:current_relationship][:dates].join(', ')
     end
 
-    desc "explore", "Return the relationship status of everyone included in celebs.yml"
+    desc 'explore', 'Return the relationship status of everyone included in celebs.yml'
     def explore
       results = []
       celebs = my_celebs
@@ -30,17 +30,18 @@ module WhosDatedWho
       results
     end
 
-    desc "import_mine", "Import my favorites into RethinkDB"
+    desc 'import_mine', 'Import my favorites into RethinkDB'
     def import_mine
       Importer.new('celebs', 'mine').fetch_and_import(my_celebs)
     end
 
-    desc "import_maxim", "Import maxim hot 100"
+    desc 'import_maxim', 'Import maxim hot 100'
     def import_maxim
       resp = Faraday.get('http://www.maxim.com/hot100/2014')
     end
 
     private
+
     def my_celebs
       YAML.load_file(File.expand_path('../../../celebs.yml', __FILE__))
     end

data/lib/whos_dated_who/client.rb

@@ -10,6 +10,7 @@ module WhosDatedWho
     end
 
     private
+
     def normalize(name)
       name.gsub(/\s/, '-').downcase
     end

data/lib/whos_dated_who/importer.rb

@@ -18,7 +18,7 @@ module WhosDatedWho
           import(result)
         rescue
           first_name, last_name = celeb.split
-          r.table("missing_#{table_name}").insert({first_name: first_name, last_name: last_name}).run(conn)
+          r.table("missing_#{table_name}").insert(first_name: first_name, last_name: last_name).run(conn)
           logger.error("Error importing #{celeb}, added to missing")
         end
       end

data/lib/whos_dated_who/parser.rb

@@ -15,6 +15,7 @@ module WhosDatedWho
     end
 
     private
+
     def extract_bio
       result = {}
       result[:description] = @doc.css('#wikitext').text
@@ -66,11 +67,11 @@ module WhosDatedWho
     end
 
     def parse_height(value)
-      ($1.to_i / 100.0) if value =~ /(\d+) cm.*$/
+      (Regexp.last_match(1).to_i / 100.0) if value =~ /(\d+) cm.*$/
     end
 
     def parse_weight(value)
-      $1.to_f if value =~ /\((.+) kg/
+      Regexp.last_match(1).to_f if value =~ /\((.+) kg/
     end
   end
 end

data/lib/whos_dated_who/version.rb

@@ -1,3 +1,3 @@
 module WhosDatedWho
-  VERSION = "0.3.0"
+  VERSION = '0.3.1'
 end

data/lib/whos_dated_who.rb

@@ -1,11 +1,11 @@
-require "faraday"
-require "hashie"
-require "nokogiri"
-require "active_support/core_ext/string"
-require "searchbing"
+require 'faraday'
+require 'hashie'
+require 'nokogiri'
+require 'active_support/core_ext/string'
+require 'searchbing'
 
-require "whos_dated_who/version"
-require "whos_dated_who/biography"
-require "whos_dated_who/parser"
-require "whos_dated_who/bing_client"
-require "whos_dated_who/client"
+require 'whos_dated_who/version'
+require 'whos_dated_who/biography'
+require 'whos_dated_who/parser'
+require 'whos_dated_who/bing_client'
+require 'whos_dated_who/client'

data/spec/acceptance/whos_dated_who_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe WhosDatedWho do
+  let(:client) { WhosDatedWho::Client.new }
+
+  context 'smoke test' do
+    it 'fetches and parses the correct results' do
+      result = client.fetch('Candice Swanepoel')
+      expect(result.status).to eq(:dating)
+      expect(result.biography.first_name).to eq('Candice')
+      expect(result.biography.last_name).to eq('Swanepoel')
+      expect(result.biography.age).to eq(26)
+
+      result = client.fetch('Katheryn Winnick')
+      expect(result.status).to eq(:unknown)
+      expect(result.biography.first_name).to eq('Katheryn')
+      expect(result.biography.last_name).to eq('Winnick')
+      expect(result.biography.age).to eq(37)
+    end
+  end
+end

data/spec/whos_dated_who/client_spec.rb

@@ -2,6 +2,5 @@ require 'spec_helper'
 
 module WhosDatedWho
   describe Client do
-
   end
 end

data/spec/whos_dated_who/parser_spec.rb

@@ -9,36 +9,36 @@ module WhosDatedWho
       @result = parser.result.biography
     end
 
-    context "biography" do
-      it "parses the HTML and returns a result hash" do
-        expect(@result.first_name).to eq("Scarlett")
-        expect(@result.last_name).to eq("Dauriac")
-        expect(@result.maiden_name).to eq("Johansson")
+    context 'biography' do
+      it 'parses the HTML and returns a result hash' do
+        expect(@result.first_name).to eq('Scarlett')
+        expect(@result.last_name).to eq('Dauriac')
+        expect(@result.maiden_name).to eq('Johansson')
       end
 
-      it "translates keys" do
+      it 'translates keys' do
         expect(@result.born_at).to be_truthy
         expect(@result.born_on).to be_truthy
       end
 
-      it "coerces result values" do
+      it 'coerces result values' do
         expect(@result.age).to eq(30)
         expect(@result.born_on).to be_kind_of(Date)
       end
 
-      it "ignores irrelevant keys" do
-        expect(@result).to_not have_key("snapshot")
+      it 'ignores irrelevant keys' do
+        expect(@result).to_not have_key('snapshot')
       end
 
-      it "parses height" do
+      it 'parses height' do
         expect(@result.height).to eq(1.60)
       end
 
-      it "parses weight" do
+      it 'parses weight' do
         expect(@result.weight).to eq(56.7)
       end
 
-      it "populates arrays" do
+      it 'populates arrays' do
         [
           :other_names, :brand_endorsements, :websites, :brothers, :sisters,
           :friends, :pets, :favorite_movies, :favorite_places, :favorite_foods,
@@ -58,7 +58,7 @@ module WhosDatedWho
         expect(@result.favorite_places).to include('London')
       end
 
-      it "gets a description" do
+      it 'gets a description' do
         expect(@result.description).to match(/American actress, model, and singer/)
       end
     end

data/whos_dated_who.gemspec

@@ -4,32 +4,32 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'whos_dated_who/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "whos_dated_who"
+  spec.name          = 'whos_dated_who'
   spec.version       = WhosDatedWho::VERSION
-  spec.authors       = ["Adrian Perez"]
-  spec.email         = ["adrianperez.deb@gmail.com"]
-  spec.summary       = %q{Unofficial API for whosdatedwho.com}
+  spec.authors       = ['Adrian Perez']
+  spec.email         = ['adrianperez.deb@gmail.com']
+  spec.summary       = 'Unofficial API for whosdatedwho.com'
   spec.description   = spec.summary
-  spec.homepage      = "https://github.com/blackxored/whos_dated_who"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/blackxored/whos_dated_who'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "faraday"
-  spec.add_dependency "hashie"
-  spec.add_dependency "nokogiri"
-  spec.add_dependency "searchbing"
-  spec.add_dependency "activesupport", "~> 4"
-  spec.add_dependency "thor"
+  spec.add_dependency 'faraday'
+  spec.add_dependency 'hashie'
+  spec.add_dependency 'nokogiri'
+  spec.add_dependency 'searchbing'
+  spec.add_dependency 'activesupport', '~> 4'
+  spec.add_dependency 'thor'
 
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "webmock"
-  spec.add_development_dependency "pry-rescue"
-  spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "rethinkdb"
+  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'webmock'
+  spec.add_development_dependency 'pry-rescue'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'rethinkdb'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: whos_dated_who
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Adrian Perez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-18 00:00:00.000000000 Z
+date: 2015-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -217,6 +217,7 @@ files:
 - lib/whos_dated_who/importer.rb
 - lib/whos_dated_who/parser.rb
 - lib/whos_dated_who/version.rb
+- spec/acceptance/whos_dated_who_spec.rb
 - spec/fixtures/scarlett-johansson.resp
 - spec/spec_helper.rb
 - spec/whos_dated_who/client_spec.rb
@@ -247,7 +248,9 @@ signing_key:
 specification_version: 4
 summary: Unofficial API for whosdatedwho.com
 test_files:
+- spec/acceptance/whos_dated_who_spec.rb
 - spec/fixtures/scarlett-johansson.resp
 - spec/spec_helper.rb
 - spec/whos_dated_who/client_spec.rb
 - spec/whos_dated_who/parser_spec.rb
+has_rdoc: