whois 6.0.0 → 6.0.2

data/lib/whois/client.rb

@@ -9,7 +9,7 @@
 #++
 
 
-require 'timeout'
+require "timeout"
 
 
 module Whois

data/lib/whois/record.rb

@@ -9,7 +9,7 @@
 #++
 
 
-require 'whois/record/part'
+require "whois/record/part"
 
 
 module Whois

data/lib/whois/server/adapters/arpa.rb

@@ -35,11 +35,9 @@ module Whois
           a, b, c, d = string.scan(/[0-9]{1,3}\./).reverse
           [a, b, c, d].map do |token|
             token = (token || 0).to_i
-            if token <= 255 && token >= 0
-              token
-            else
-              raise ServerError, "Invalid .in-addr.arpa token `#{token}'"
-            end
+            raise ServerError, "Invalid .in-addr.arpa token `#{token}'" unless token.between?(0, 255)
+
+            token
           end.join(".")
         end
 

data/lib/whois/server/adapters/base.rb

@@ -9,9 +9,9 @@
 #++
 
 
-require 'whois/record/part'
-require 'whois/record'
-require 'whois/server/socket_handler'
+require "whois/record/part"
+require "whois/record"
+require "whois/server/socket_handler"
 
 
 module Whois

data/lib/whois/server/adapters/none.rb

@@ -36,7 +36,7 @@ module Whois
         #
         # @raise  [Whois::NoInterfaceError] For every request.
         #
-        def request(string)
+        def request(_string)
           raise NoInterfaceError, "This `#{type}' has no whois server"
         end
 

data/lib/whois/server/adapters/not_implemented.rb

@@ -22,7 +22,7 @@ module Whois
         #
         # @raise  [Whois::ServerNotImplemented] For every request.
         #
-        def request(string)
+        def request(_string)
           raise ServerNotImplemented, "The `#{host}' feature has not been implemented yet."
         end
 

data/lib/whois/server/adapters/web.rb

@@ -32,7 +32,7 @@ module Whois
         #
         # @raise  [Whois::WebInterfaceError] For every request.
         #
-        def request(string)
+        def request(_string)
           raise WebInterfaceError, options[:url]
         end
 

data/lib/whois/server/socket_handler.rb

@@ -9,8 +9,8 @@
 #++
 
 
-require 'socket'
-require 'whois/errors'
+require "socket"
+require "whois/errors"
 
 
 module Whois
@@ -58,7 +58,7 @@ module Whois
         client.write("#{query}\r\n")    # I could use put(foo) and forget the \n
         client.read                     # but write/read is more symmetric than puts/read
       ensure                            # and I really want to use read instead of gets.
-        client.close if client          # If != client something went wrong.
+        client&.close # If != client something went wrong.
       end
     end
 

data/lib/whois/server.rb

@@ -9,8 +9,8 @@
 #++
 
 
-require 'ipaddr'
-require 'json'
+require "ipaddr"
+require "json"
 require "whois/server/adapters/base"
 require "whois/server/adapters/arin"
 require "whois/server/adapters/arpa"
@@ -67,7 +67,7 @@ module Whois
       # @return [void]
       def load_definitions
         clear_definitions
-        Dir[File.expand_path('../../data/*.json', __dir__)].each { |f| load_json(f) }
+        Dir[File.expand_path("../../data/*.json", __dir__)].each { |f| load_json(f) }
       end
 
       # Loads the definitions from a JSON file.
@@ -283,7 +283,7 @@ module Whois
       # @param  string [String]
       # @raise  [Whois::ServerNotSupported]
       #         emails are not supported.
-      def find_for_email(string)
+      def find_for_email(_string)
         raise ServerNotSupported, "No WHOIS server is known for email objects"
       end
 
@@ -363,7 +363,7 @@ module Whois
       end
 
       def matches_email?(string)
-        string.include?('@')
+        string.include?("@")
       end
 
       def matches_asn?(string)

data/lib/whois/version.rb

@@ -11,5 +11,5 @@
 
 module Whois
   # The current library version.
-  VERSION = "6.0.0"
+  VERSION = "6.0.2"
 end

data/lib/whois.rb

@@ -9,11 +9,11 @@
 #++
 
 
-require 'whois/version'
-require 'whois/errors'
-require 'whois/client'
-require 'whois/server'
-require 'whois/record'
+require "whois/version"
+require "whois/errors"
+require "whois/client"
+require "whois/server"
+require "whois/record"
 
 
 module Whois
@@ -74,7 +74,7 @@ module Whois
       result
     end
 
-    def deprecate(message = nil, callstack = caller)
+    def deprecate(message = nil, _callstack = caller)
       # warn("DEPRECATION WARNING: #{message} #{deprecation_caller_message(callstack)}")
       warn("DEPRECATION WARNING: #{message}")
     end
@@ -99,24 +99,24 @@ module Whois
 
     def deprecation_caller_message(callstack)
       file, line, method = extract_callstack(callstack)
-      if file
-        if line && method
-          "(called from #{method} at #{file}:#{line})"
-        else
-          "(called from #{file}:#{line})"
-        end
+      return unless file
+
+      if line && method
+        "(called from #{method} at #{file}:#{line})"
+      else
+        "(called from #{file}:#{line})"
       end
     end
 
     def extract_callstack(callstack)
       gem_root = "#{File.expand_path('../..', __dir__)}/"
       offending_line = callstack.find { |line| !line.start_with?(gem_root) } || callstack.first
-      if offending_line
-        if (md = offending_line.match(/^(.+?):(\d+)(?::in `(.*?)')?/))
-          md.captures
-        else
-          offending_line
-        end
+      return unless offending_line
+
+      if (md = offending_line.match(/^(.+?):(\d+)(?::in `(.*?)')?/))
+        md.captures
+      else
+        offending_line
       end
     end
   end

data/spec/integration/whois_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois do
   let(:response) { "Domain:             example.it\nStatus:             AVAILABLE\n" }
@@ -13,7 +13,7 @@ describe Whois do
           .with("example.it", "whois.nic.it", 43)
           .and_return(response)
 
-        record = Whois.lookup("example.it")
+        record = described_class.lookup("example.it")
 
         expect(record).to be_a(Whois::Record)
         # expect(record.available?).to be_truthy

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'rspec'
-require 'whois'
+require "rspec"
+require "whois"
 
 SPEC_ROOT = File.expand_path(__dir__) unless defined?(SPEC_ROOT)
 

data/spec/whois/client_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Client do
   describe "#initialize" do

data/spec/whois/record/part_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Record::Part do
   describe "#initialize" do

data/spec/whois/record_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Record do
   subject { described_class.new(server, parts) }
@@ -65,64 +65,72 @@ describe Whois::Record do
       one = two = described_class.new(server, parts)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns true when other has same class and has the same parts" do
-      one, two = described_class.new(server, parts), described_class.new(server, parts)
+      one = described_class.new(server, parts)
+      two = described_class.new(server, parts)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns true when other has descendant class and has the same parts" do
       subklass = Class.new(described_class)
-      one, two = described_class.new(server, parts), subklass.new(server, parts)
+      one = described_class.new(server, parts)
+      two = subklass.new(server, parts)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns true when other has same class and has equal parts" do
-      one, two = described_class.new(server, parts), described_class.new(server, parts.dup)
+      one = described_class.new(server, parts)
+      two = described_class.new(server, parts.dup)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns true when other has same class, different server and the same parts" do
-      one, two = described_class.new(server, parts), described_class.new(nil, parts)
+      one = described_class.new(server, parts)
+      two = described_class.new(nil, parts)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns false when other has different class and has the same parts" do
-      one, two = described_class.new(server, parts), Struct.new(:server, :parts).new(server, parts)
+      one = described_class.new(server, parts)
+      two = Struct.new(:server, :parts).new(server, parts)
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
 
     it "returns false when other has different parts" do
-      one, two = described_class.new(server, parts), described_class.new(server, [])
+      one = described_class.new(server, parts)
+      two = described_class.new(server, [])
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
 
     it "returns false when other is string and has the same content" do
-      one, two = described_class.new(server, parts), described_class.new(server, parts).to_s
+      one = described_class.new(server, parts)
+      two = described_class.new(server, parts).to_s
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
 
     it "returns false when other is string and has different content" do
-      one, two = described_class.new(server, parts), "different"
+      one = described_class.new(server, parts)
+      two = "different"
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
   end
 

data/spec/whois/server/adapters/afilias_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Afilias do
   let(:definition) { [:tld, ".test", "whois.afilias-grs.info", {}] }

data/spec/whois/server/adapters/arin_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Arin do
   let(:definition) { [:ipv4, "0.0.0.0/1", "whois.arin.net"] }

data/spec/whois/server/adapters/arpa_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-require 'whois/server/adapters/arin'
+require "spec_helper"
+require "whois/server/adapters/arin"
 
 describe Whois::Server::Adapters::Arpa do
   let(:definition) { [:tld, ".in-addr.arpa", nil, {}] }

data/spec/whois/server/adapters/base_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Base do
   let(:definition) { [:tld, ".test", "whois.test", { foo: "bar" }] }
@@ -36,43 +36,48 @@ describe Whois::Server::Adapters::Base do
       one = two = described_class.new(*definition)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns true when other has same class and has the same attributes" do
-      one, two = described_class.new(*definition), described_class.new(*definition)
+      one = described_class.new(*definition)
+      two = described_class.new(*definition)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns true when other has descendant class and has the same attributes" do
       subklass = Class.new(described_class)
-      one, two = described_class.new(*definition), subklass.new(*definition)
+      one = described_class.new(*definition)
+      two = subklass.new(*definition)
 
       expect(one == two).to be_truthy
-      expect(one.eql?(two)).to be_truthy
+      expect(one).to eql(two)
     end
 
     it "returns false when other has different class and has the same attributes" do
-      one, two = described_class.new(*definition), Struct.new(:type, :allocation, :host, :options).new(*definition)
+      one = described_class.new(*definition)
+      two = Struct.new(:type, :allocation, :host, :options).new(*definition)
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
 
     it "returns false when other has different attributes" do
-      one, two = described_class.new(:tld, ".test", "whois.test"), described_class.new(:tld, ".cool", "whois.test")
+      one = described_class.new(:tld, ".test", "whois.test")
+      two = described_class.new(:tld, ".cool", "whois.test")
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
 
     it "returns false when other has different options" do
-      one, two = described_class.new(:tld, ".test", "whois.test"), described_class.new(:tld, ".test", "whois.test", { foo: "bar" })
+      one = described_class.new(:tld, ".test", "whois.test")
+      two = described_class.new(:tld, ".test", "whois.test", { foo: "bar" })
 
       expect(one == two).to be_falsey
-      expect(one.eql?(two)).to be_falsey
+      expect(one).not_to eql(two)
     end
   end
 

data/spec/whois/server/adapters/formatted_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Formatted do
   let(:definition) { [:tld, ".de", "whois.denic.de", { format: "-T dn,ace -C US-ASCII %s" }] }

data/spec/whois/server/adapters/none_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::None do
   describe "#lookup" do

data/spec/whois/server/adapters/not_implemented_spec.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::NotImplemented do
   before do
-    @definition = [:ipv6, "2001:0000::/32", "teredo", { adapter: Whois::Server::Adapters::NotImplemented }]
+    @definition = [:ipv6, "2001:0000::/32", "teredo", { adapter: described_class }]
   end
 
 

data/spec/whois/server/adapters/standard_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Standard do
   let(:definition) { [:tld, ".test", "whois.test", {}] }

data/spec/whois/server/adapters/verisign_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Verisign do
   let(:definition) { [:tld, ".test", "whois.test", {}] }

data/spec/whois/server/adapters/web_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
+require "spec_helper"
 
 describe Whois::Server::Adapters::Web do
   before do

data/spec/whois/server/socket_handler_spec.rb

@@ -1,15 +1,17 @@
 # frozen_string_literal: true
 
-require 'spec_helper'
-require 'whois/server/socket_handler'
+require "spec_helper"
+require "whois/server/socket_handler"
 
 describe Whois::Server::SocketHandler do
   describe "#call" do
     [Errno::ECONNRESET, Errno::EHOSTUNREACH, Errno::ECONNREFUSED, Errno::ETIMEDOUT, Errno::EPIPE, SocketError].each do |error|
       it "re-raises #{error} as Whois::ConnectionError" do
-        expect(subject).to receive(:execute).and_raise(error)
+        handler = described_class.new
+        expect(handler).to receive(:execute).and_raise(error)
+
         expect {
-          subject.call("example.test", "whois.test", 43)
+          handler.call("example.test", "whois.test", 43)
         }.to raise_error(Whois::ConnectionError, "#{error}: #{error.new.message}")
       end
 
@@ -22,7 +24,9 @@ describe Whois::Server::SocketHandler do
         expect(TCPSocket).to receive(:new)
           .with("whois.test", 43)
           .and_return(socket)
-        subject.call("example.test", "whois.test", 43)
+
+        handler = described_class.new
+        handler.call("example.test", "whois.test", 43)
       end
     end
   end