whittaker_tech-midas 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe9c21222c40c9da18f01c21076e775b5d00f6f7b817f2c06c05223cdd88de8b
-  data.tar.gz: 50ec83ec5d2b1fbe82e3856180ce63c8bc35f458679f14ab3fdd800229ef519d
+  metadata.gz: 0f638743662ef34c451ad0c93e3c00ccef2b1fb74c21520e5a6c0e98cf83b8a1
+  data.tar.gz: 2b44bc0773c678e7b9ecbdac928656cfc4e9a00c2c737fcfad0b08b892d71d8e
 SHA512:
-  metadata.gz: 4833df22795e85d8e837bd2c0fa81ee6cf593a401463daf7ca42b6adf659be45cecd497213a0641d363c1523019fd2ac616265212aca85e531ee56d9d50efb7f
-  data.tar.gz: bdcf127c769350759698cfefb12babe569c5c0c2ed907b3127212e2d806ff3c8eec0d9dedde9f62b6ec59721683e8fa99b21eeef883a6148166d567673dce20a
+  metadata.gz: e1ff7f68891ca65f9ca77aed3758c02f176bf6208fc11d3cc854d40d3b66f4a3f441cfe590d7b5794df773a575634f6fc3dabf5fb0e3e4beba0a8b3f14e9fd10
+  data.tar.gz: 15ebf018ffe904a87180df6cea837a92cdef2729596677047d81789ffdd1212fc098098d80bd85da38a095ef5ee0b1759892c79d5000ff29a31dd0b363a9240b

data/README.md

@@ -2,7 +2,7 @@
 
 [![MIT License](https://img.shields.io/badge/license-MIT-green.svg)](MIT-LICENSE)
 ![Ruby 3.2](https://img.shields.io/badge/ruby-3.2+-red.svg)
-![Rails 7.1](https://img.shields.io/badge/rails-7.1+-crimson.svg)
+![Rails 6.1](https://img.shields.io/badge/rails-6.1+-crimson.svg)
 [![Gem Version](https://badge.fury.io/rb/whittaker_tech-midas.svg)](https://badge.fury.io/rb/whittaker_tech-midas)
 [![CI](https://github.com/WhittakerTech/midas/actions/workflows/ci.yml/badge.svg)](https://github.com/WhittakerTech/midas/actions)
 
@@ -28,8 +28,11 @@ This design keeps your pricing, billing, and financial reporting consistent acro
 
 ## Requirements
 
-- Ruby 3.4+
-- Rails 7.1+
+- Ruby 3.2+
+- Rails 6.1+ (6.1 supported for legacy consumers, exercised in CI on Ruby 3.3;
+  `Ledger` uses the Rails 7.1 `enum` form where available and falls back to the
+  6.1 syntax, where an unknown value raises `ArgumentError` on assignment rather
+  than becoming a validation error)
 - money gem ~> 6.19.0
 
 ## Installation

data/app/models/concerns/whittaker_tech/midas/bankable.rb

@@ -129,8 +129,8 @@ module WhittakerTech::Midas::Bankable
     def define_methods(name, label, assoc_name)
       define_method(name) { public_send(assoc_name) }
 
-      define_method("#{name}_amount")   { public_send(name)&.amount }
-      define_method("#{name}_format")   { public_send(name)&.amount&.format }
+      define_method("#{name}_amount") { public_send(name)&.amount }
+      define_method("#{name}_format") { public_send(name)&.amount&.format }
       define_method("#{name}_in") { |to| public_send(name)&.exchange_to(to)&.format }
 
       # Sets the coin value with the specified amount and currency.

data/app/models/whittaker_tech/midas/ledger/account.rb

@@ -26,14 +26,29 @@ class WhittakerTech::Midas::Ledger::Account < WhittakerTech::Midas::ApplicationR
            dependent: :restrict_with_error,
            inverse_of: :account
 
-  enum :kind, {
+  KINDS = {
     asset: 'asset',
     liability: 'liability',
     equity: 'equity',
     revenue: 'revenue',
     expense: 'expense',
     suspense: 'suspense'
-  }, validate: true
+  }.freeze
+
+  # Rails 7.1 introduced both the positional `enum :name, values` form and the
+  # `validate: true` option (unknown values become validation errors rather
+  # than raising ArgumentError on assignment). Rails 6.1 has neither, so the
+  # declaration is version-conditional. On 6.1 an unknown value still raises
+  # ArgumentError at assignment time -- stricter than 7.1+, never looser --
+  # and AR 6.1 offers no way to defer that to validation.
+  if ActiveRecord::VERSION::STRING >= '7.1'
+    enum :kind, KINDS, validate: true
+  else
+    # rubocop:disable Rails/EnumSyntax -- the positional form this cop wants
+    # is exactly what Rails 6.1 lacks; that is why this branch exists.
+    enum kind: KINDS
+    # rubocop:enable Rails/EnumSyntax
+  end
 
   before_validation :normalize_currency_code
 

data/app/models/whittaker_tech/midas/ledger/posting.rb

@@ -31,7 +31,22 @@ class WhittakerTech::Midas::Ledger::Posting < WhittakerTech::Midas::ApplicationR
   # overriding so it can still be called.
   alias attach_amount_coin set_amount
 
-  enum :direction, { debit: 'debit', credit: 'credit' }, validate: true
+  DIRECTIONS = { debit: 'debit', credit: 'credit' }.freeze
+
+  # Rails 7.1 introduced both the positional `enum :name, values` form and the
+  # `validate: true` option (unknown values become validation errors rather
+  # than raising ArgumentError on assignment). Rails 6.1 has neither, so the
+  # declaration is version-conditional. On 6.1 an unknown value still raises
+  # ArgumentError at assignment time -- stricter than 7.1+, never looser --
+  # and AR 6.1 offers no way to defer that to validation.
+  if ActiveRecord::VERSION::STRING >= '7.1'
+    enum :direction, DIRECTIONS, validate: true
+  else
+    # rubocop:disable Rails/EnumSyntax -- the positional form this cop wants
+    # is exactly what Rails 6.1 lacks; that is why this branch exists.
+    enum direction: DIRECTIONS
+    # rubocop:enable Rails/EnumSyntax
+  end
 
   validates :occurred_at, presence: true
   # account/entry are both present at creation time (before any amount is

data/db/migrate/20260101000000_create_whittaker_tech_schema.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class CreateWhittakerTechSchema < ActiveRecord::Migration[8.0]
+class CreateWhittakerTechSchema < ActiveRecord::Migration[6.1]
   SCHEMA_NAME = (WhittakerTech::Midas.table_namespace || 'midas').freeze
   raise 'Invalid schema name' unless SCHEMA_NAME =~ /\A[a-z_][a-z0-9_]*\z/
 

data/db/migrate/20260101000001_create_midas_coins.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class CreateMidasCoins < ActiveRecord::Migration[8.0]
+class CreateMidasCoins < ActiveRecord::Migration[6.1]
   def change
     create_table WhittakerTech::Midas.table_name('coins') do |t|
       t.references :resource, polymorphic: true, null: false, index: true

data/db/migrate/20260219120000_rename_resource_label_to_resource_role_in_wt_midas_coins.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class RenameResourceLabelToResourceRoleInWtMidasCoins < ActiveRecord::Migration[8.0]
+class RenameResourceLabelToResourceRoleInWtMidasCoins < ActiveRecord::Migration[6.1]
   def change
     rename_column WhittakerTech::Midas.table_name('coins'), :resource_label, :resource_role
     rename_index  WhittakerTech::Midas.table_name('coins'),

data/db/migrate/20260219150000_rename_wt_midas_coins_to_midas_coins.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class RenameWtMidasCoinsToMidasCoins < ActiveRecord::Migration[8.0]
+class RenameWtMidasCoinsToMidasCoins < ActiveRecord::Migration[6.1]
   def change
     rename_table :wt_midas_coins, :midas_coins
     rename_index :midas_coins,

data/db/migrate/20260707000000_create_midas_exchanges.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class CreateMidasExchanges < ActiveRecord::Migration[8.0]
+class CreateMidasExchanges < ActiveRecord::Migration[6.1]
   def change
     create_table WhittakerTech::Midas.table_name('exchanges') do |t|
       t.decimal :rate, precision: 24, scale: 12, null: false

data/db/migrate/20260713000001_create_midas_ledger_accounts.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class CreateMidasLedgerAccounts < ActiveRecord::Migration[8.0]
+class CreateMidasLedgerAccounts < ActiveRecord::Migration[6.1]
   def change
     create_table WhittakerTech::Midas.table_name('ledger_accounts') do |t|
       t.references :owner, polymorphic: true, null: true, index: true

data/db/migrate/20260713000002_create_midas_ledger_entries.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class CreateMidasLedgerEntries < ActiveRecord::Migration[8.0]
+class CreateMidasLedgerEntries < ActiveRecord::Migration[6.1]
   def change
     create_table WhittakerTech::Midas.table_name('ledger_entries') do |t|
       t.string :currency_code, null: false, limit: 3

data/db/migrate/20260713000003_create_midas_ledger_postings.rb

@@ -2,7 +2,7 @@
 
 require 'whittaker_tech/midas'
 
-class CreateMidasLedgerPostings < ActiveRecord::Migration[8.0]
+class CreateMidasLedgerPostings < ActiveRecord::Migration[6.1]
   def change
     create_table WhittakerTech::Midas.table_name('ledger_postings') do |t|
       t.references(

data/lib/generators/whittaker_tech/midas/install/install_generator.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class WhittakerTech::Midas::Generators::InstallGenerator < Rails::Generators::Base
+class WhittakerTech::Midas::InstallGenerator < Rails::Generators::Base
   desc 'Installs Midas and copies migrations.'
 
   def copy_migrations

data/lib/whittaker_tech/midas/engine.rb

@@ -108,6 +108,15 @@ class WhittakerTech::Midas::Engine < Rails::Engine
   config.eager_load_paths += Dir["#{config.root}/app/models"]
 
   initializer 'midas.helpers' do
+    # Explicit require rather than relying on Zeitwerk autoload resolution
+    # here: ActiveSupport.on_load(:action_view) fires immediately (not
+    # deferred) whenever ActionView::Base is already loaded by the time this
+    # initializer runs, which on Rails 8 hosts happens before this engine's
+    # own autoload paths are guaranteed ready -- raising a NameError on boot
+    # for WhittakerTech::Midas::FormHelper. Requiring the file directly
+    # sidesteps the race entirely.
+    require_relative '../../../app/helpers/whittaker_tech/midas/form_helper'
+
     ActiveSupport.on_load(:action_view) do
       include WhittakerTech::Midas::FormHelper
     end

data/lib/whittaker_tech/midas/version.rb

@@ -1,5 +1,10 @@
+# rubocop:disable Style/OneClassPerFile -- .rubocop.yml enforces compact
+# module style (Style/ClassAndModuleChildren: compact), which requires the
+# parent module to be opened separately. The two cops are mutually exclusive
+# here; compact style wins because it is the repo-wide convention.
 module WhittakerTech; end
 
 module WhittakerTech::Midas
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.5.0'.freeze
 end
+# rubocop:enable Style/OneClassPerFile

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: whittaker_tech-midas
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Lee Whittaker
@@ -29,28 +29,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 7.1.5.2
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 7.1.5.2
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
@@ -97,16 +97,16 @@ dependencies:
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '6.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement