where_exists 2.0.0 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f3ba0936a289c595a6efec3b73bcc9f46f445981150a43fa72af419eb13dec8
-  data.tar.gz: 022c543b783c601be1076b4de866e9052d1c6b352b727b52a793585a571aed61
+  metadata.gz: d9957b5787ab2fda2505560b01ffeca8f2e1d24bf0d0d38e09f4f25969a30ab6
+  data.tar.gz: 4718917be7477f54afb0e322a588adadb4d2d375c6b7938d922b89ef0629ea27
 SHA512:
-  metadata.gz: 265df32741d7633eaaac17b5dfa27a33e813ba4680a98ca4c8fd05d58d839adf4439944dd5e0942b1b44af850a14fb2bf5b48848d73fb8c4beb6fb2b94766749
-  data.tar.gz: 7dd2b69d952f63f4bb96999b0e4c86672fe08cdd77f37755a48a7d6d2aab0072bf0a65b5f6aed8183a6688dcbdff453fd00d41a035e29009762cfc69fcc8a261
+  metadata.gz: 839de9969500c67df98512ee5f5043b4d34a8e337263e3dcc79dd081e6730a0b1bb6bce3c632a764372d6dabe143f9b3c7ffcbc55092f55727d8746d40eafaf3
+  data.tar.gz: a4c38490f6caf945889d2f92075e1069cef92706524c299bd4d800c4b856fd62fda39738539fee816daa955a5ef3908e49c7aed9ed4e3be97af6bf8c419f3b07

data/README.markdown

@@ -4,7 +4,7 @@
 
 ## Description
 
-<img src="http://i.imgur.com/psLfPoW.gif" alt="Exists" align="right" width="100" height="200">
+<img src="exists.png" alt="Exists" align="right" width="100" height="200">
 
 This gem does exactly two things:
 
@@ -155,6 +155,8 @@ Also,
 * Submit pull request with new features or bug fixes
 * Enhance or clarify the documentation that you are reading
 
+**Please ping me in addition to creating PR/issue** (just add "@EugZol" to the PR/issue text). Thank you!
+
 To run tests:
 ```
 > bundle exec appraisal install

data/lib/where_exists/version.rb

@@ -1,3 +1,3 @@
 module WhereExists
-  VERSION = "2.0.0"
+  VERSION = "2.0.2"
 end

data/lib/where_exists.rb

@@ -36,11 +36,11 @@ module WhereExists
 
     case association.macro
     when :belongs_to
-      queries = where_exists_for_belongs_to_query(association, where_parameters)
+      queries = where_exists_for_belongs_to_query(association, where_parameters, &block)
     when :has_many, :has_one
-      queries = where_exists_for_has_many_query(association, where_parameters)
+      queries = where_exists_for_has_many_query(association, where_parameters, &block)
     when :has_and_belongs_to_many
-      queries = where_exists_for_habtm_query(association, where_parameters)
+      queries = where_exists_for_habtm_query(association, where_parameters, &block)
     else
       inspection = nil
       begin
@@ -53,13 +53,12 @@ module WhereExists
 
     queries_sql =
       queries.map do |query|
-        query = yield query if block_given?
         "EXISTS (" + query.to_sql + ")"
       end
     queries_sql.join(" OR ")
   end
 
-  def where_exists_for_belongs_to_query(association, where_parameters)
+  def where_exists_for_belongs_to_query(association, where_parameters, &block)
     polymorphic = association.options[:polymorphic].present?
 
     association_scope = association.scope
@@ -93,13 +92,14 @@ module WhereExists
 
         query = query.where("#{self_type} IN (?)", other_types.uniq)
       end
+      query = yield query if block_given?
       queries.push query
     end
 
     queries
   end
 
-  def where_exists_for_has_many_query(association, where_parameters, next_association = {})
+  def where_exists_for_has_many_query(association, where_parameters, next_association = {}, &block)
     if association.through_reflection
       raise ArgumentError.new(association) unless association.source_reflection
       next_association = {
@@ -111,9 +111,9 @@ module WhereExists
 
       case association.macro
       when :has_many, :has_one
-        return where_exists_for_has_many_query(association, {}, next_association)
+        return where_exists_for_has_many_query(association, {}, next_association, &block)
       when :has_and_belongs_to_many
-        return where_exists_for_habtm_query(association, {}, next_association)
+        return where_exists_for_habtm_query(association, {}, next_association, &block)
       else
         inspection = nil
         begin
@@ -148,17 +148,18 @@ module WhereExists
     end
 
     if next_association[:association]
-      return loop_nested_association(result, next_association)
+      return loop_nested_association(result, next_association, &block)
     end
 
     if where_parameters != []
       result = result.where(*where_parameters)
     end
 
+    result = yield result if block_given?
     [result]
   end
 
-  def where_exists_for_habtm_query(association, where_parameters, next_association = {})
+  def where_exists_for_habtm_query(association, where_parameters, next_association = {}, &block)
     association_scope = association.scope
 
     associated_model = association.klass
@@ -182,7 +183,7 @@ module WhereExists
       where("#{join_ids} = #{self_ids}")
 
     if next_association[:association]
-      return loop_nested_association(result, next_association)
+      return loop_nested_association(result, next_association, &block)
     end
 
     if where_parameters != []
@@ -193,15 +194,18 @@ module WhereExists
       result = result.instance_exec(&association_scope)
     end
 
+    result = yield result if block_given?
+
     [result]
   end
 
-  def loop_nested_association(query, next_association = {}, nested = false)
+  def loop_nested_association(query, next_association = {}, nested = false, &block)
     str = query.klass.build_exists_string(
       next_association[:association].name,
       *[
         *next_association[:params]
       ],
+      &block
     )
 
     if next_association[:next_association] && next_association[:next_association][:association]
@@ -210,7 +214,8 @@ module WhereExists
         "(#{subq} AND (#{loop_nested_association(
           next_association[:association],
           next_association[:next_association],
-          true
+          true,
+          &block
         )}))"
       end
     end

data/test/has_many_through_test.rb

@@ -52,8 +52,6 @@ class Blob < ActiveRecord::Base
   end
 end
 
-
-
 class Project < ActiveRecord::Base
   has_many :tasks
   has_many :invoices, :through => :tasks
@@ -99,8 +97,6 @@ class HasManyThroughTest < Minitest::Test
   end
 
   def test_one_level_through
-    ActiveRecord::Base.descendants.each(&:delete_all)
-
     project = Project.create!
     irrelevant_project = Project.create!
 
@@ -121,8 +117,6 @@ class HasManyThroughTest < Minitest::Test
   end
 
   def test_deep_through
-    ActiveRecord::Base.descendants.each(&:delete_all)
-
     project = Project.create! name: 'relevant'
     irrelevant_project = Project.create! name: 'irrelevant'
 
@@ -188,6 +182,14 @@ class HasManyThroughTest < Minitest::Test
     result = Project.where_not_exists(:blobs)
 
     assert_equal 0, result.length
+  end
 
+  def test_with_yield
+    project = Project.create! name: 'example_project'
+    task = Task.create!(project: project)
+    line_item = LineItem.create!(name: 'example_line_item', task: task)
+    result = Project.where_exists(:project_line_items) { |scope| scope.where(name: 'example_line_item') }
+
+    assert_equal 1, result.length
   end
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: where_exists
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.2
 platform: ruby
 authors:
 - Eugene Zolotarev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-16 00:00:00.000000000 Z
+date: 2022-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -114,7 +114,6 @@ files:
 - lib/where_exists/version.rb
 - test/belongs_to_polymorphic_test.rb
 - test/belongs_to_test.rb
-- test/db/test.db
 - test/documentation_test.rb
 - test/has_and_belongs_to_many.rb
 - test/has_many_polymorphic_test.rb
@@ -145,12 +144,11 @@ signing_key:
 specification_version: 4
 summary: "#where_exists extension of ActiveRecord"
 test_files:
+- test/documentation_test.rb
 - test/belongs_to_polymorphic_test.rb
 - test/belongs_to_test.rb
-- test/db/test.db
-- test/documentation_test.rb
-- test/has_and_belongs_to_many.rb
 - test/has_many_polymorphic_test.rb
-- test/has_many_test.rb
 - test/has_many_through_test.rb
 - test/test_helper.rb
+- test/has_and_belongs_to_many.rb
+- test/has_many_test.rb