where_exists 1.2.2 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28bde73cd6a1857a0762a1fd489258ad40b44cea344afba4357cbe7fa83cdf41
-  data.tar.gz: ed7a98cb6a7391cb955c911f0063f9eb901e86305b0b7ddb3e01b9a209371476
+  metadata.gz: 70bb8d0cc4affb99051fe748c883841abd8635f78faab07572208dd495ae9e0e
+  data.tar.gz: 56be70dc7847f0beddf4a19284485e8e50c38709e2b0db4f64a0250c967b0a33
 SHA512:
-  metadata.gz: 943e345289ac9f2a2d44a5428a559c8a22adb11713b26ac0e7893fd28ccbb9577a092bbae50fa9eec960c72497ca5d902892209ce7c83d9c2b291fc017e0d5ab
-  data.tar.gz: 509c56167e4998c662bf21efa637de8495cc5d2974421041d8264f66de16f99a2c223463cfd494b35f64bffb39b8511696822405e2609b649ff876f685ffd4cc
+  metadata.gz: e86824a1c85aa3a4006bc20035444fe36d1895c7cb17fd3019e5da5431753ba45fd735bbd41ae903f807bc7e45e36d415c887390d2fab8805d44e8afdcd37f2c
+  data.tar.gz: 5a4814a20b678da5ee28b9cdbccd99ef653f4ea6284fd42f5203d0074301d35b3627524e00e89623000595fdb7f9c110873224f163edc2b0a112ae0deeba18b9

data/README.markdown

@@ -4,7 +4,7 @@
 
 ## Description
 
-<img src="http://i.imgur.com/psLfPoW.gif" alt="Exists" align="right" width="100" height="200">
+<img src="exists.png" alt="Exists" align="right" width="100" height="200">
 
 This gem does exactly two things:
 
@@ -29,7 +29,7 @@ Syntax:
 Model.where_exists(association, additional_finder_parameters)
 ```
 
-Supported Rails versions: >= 4.2.
+Supported Rails versions: >= 5.2.
 
 ## Example of usage
 
@@ -155,7 +155,13 @@ Also,
 * Submit pull request with new features or bug fixes
 * Enhance or clarify the documentation that you are reading
 
-To run tests: `bundle exec rake test`
+**Please ping me in addition to creating PR/issue** (just add "@EugZol" to the PR/issue text). Thank you!
+
+To run tests:
+```
+> bundle exec appraisal install
+> bundle exec appraisal rake test
+```
 
 ## License
 

data/lib/where_exists/version.rb

@@ -1,3 +1,3 @@
 module WhereExists
-  VERSION = "1.2.2"
+  VERSION = "2.0.1"
 end

data/lib/where_exists.rb

@@ -20,7 +20,11 @@ module WhereExists
       not_string = "NOT "
     end
 
-    self.where("#{not_string}(#{queries_sql})")
+    if queries_sql.empty?
+      does_exist ? self.none : self.all
+    else
+      self.where("#{not_string}(#{queries_sql})")
+    end
   end
 
   def build_exists_string(association_name, *where_parameters, &block)

data/test/belongs_to_polymorphic_test.rb

@@ -61,6 +61,18 @@ class BelongsToPolymorphicTest < Minitest::Test
     assert_equal orphaned_child.id, result.first.id
   end
 
+  def test_no_entities_or_empty_child_relation
+    result = BelongsToPolymorphicChild.where_not_exists(:polymorphic_entity)
+    assert_equal 0, result.length
+
+    _first_child = BelongsToPolymorphicChild.create!
+    result = BelongsToPolymorphicChild.where_not_exists(:polymorphic_entity)
+    assert_equal 1, result.length
+
+    result = BelongsToPolymorphicChild.where_exists(:polymorphic_entity)
+    assert_equal 0, result.length
+  end
+
   def test_table_name_based_lookup
     first_entity = FirstPolymorphicEntity.create!
     second_entity = SecondPolymorphicEntity.create! id: first_entity.id + 1

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: where_exists
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 2.0.1
 platform: ruby
 authors:
 - Eugene Zolotarev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-13 00:00:00.000000000 Z
+date: 2022-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -86,6 +86,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rails way to harness the power of SQL "EXISTS" statement
 email:
 - eugzol@gmail.com
@@ -126,17 +140,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: "#where_exists extension of ActiveRecord"
 test_files:
-- test/has_and_belongs_to_many.rb
+- test/documentation_test.rb
 - test/belongs_to_polymorphic_test.rb
-- test/has_many_through_test.rb
+- test/belongs_to_test.rb
+- test/has_many_polymorphic_test.rb
 - test/db/test.db
+- test/has_many_through_test.rb
 - test/test_helper.rb
-- test/has_many_polymorphic_test.rb
+- test/has_and_belongs_to_many.rb
 - test/has_many_test.rb
-- test/documentation_test.rb
-- test/belongs_to_test.rb