whenever-test 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e58e9d99279233e6a8275a597c0027ad970833c
-  data.tar.gz: 3e1c0a686c3c37d8ce9624fbed598330c6848840
+  metadata.gz: c2346b3f9e18edead15842c3fb6da7ec281acd28
+  data.tar.gz: b8d9acb025487943dcc0a0443d53345c18c76229
 SHA512:
-  metadata.gz: ab551e5513e11c13624fe18334f5f26ef31b06546fcba4e39e4cfdffbf1ee41a27322af8c80bdd8f72fe5672134753d32d8c3eddc15d38dcb8921af707aedf53
-  data.tar.gz: 8e6b25ec2930806c7073e8c4df9ddec90162d963ef2c98c853ccab87a5f95798f2b6927d7a8331b5370507ad68ce3d948b27d6a6f00766c94b3df64a6775ea18
+  metadata.gz: 1c9751ae19c4ab6d1e75ddb6ff0ac0c4736d0aca22ee7d74d5245ea50110aa3d17e1420e937ebbff44eae554a1bea07d5ab4558ed7ab85095c0f13073bd6127f
+  data.tar.gz: 05f20610d2e781685a21230466f492f4f94eb5e6262df4a82db568407b038f6fe1e241754cbfd286c12835556b0c225a73e9855652f38c3de89b64d773374c62

data/Gemfile

@@ -3,12 +3,12 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem "bundler"
-  gem "rake"
-  gem "pry-byebug"
+  gem 'bundler'
+  gem 'rake'
+  gem 'pry-byebug'
 end
 
 group :test do
-  gem "minitest"
-  gem "mocha", require: false
+  gem 'minitest'
+  gem 'mocha', require: false
 end

data/README.md

@@ -10,9 +10,9 @@ A gem that adds test support to [Whenever](https://github.com/javan/whenever) ge
 
 ### Background
 
-I've been part of many projects that used whenever gem, but testing the `schedule.rb` file was always neglected.
+I've been part of many projects that used [Whenever](https://github.com/javan/whenever), but testing the `schedule.rb` file was always neglected.
 
-Turns out your jobs defined in Whenever schedule might reference rake tasks that don't exist in runtime and not even have correct ruby syntax (in case or runner-type jobs).
+Turns out your jobs defined in [Whenever](https://github.com/javan/whenever) schedule might reference rake tasks that don't exist in runtime and not even have correct ruby syntax (in case or runner-type jobs).
 
 This gem adds a support class so you can write specs that asserts against definitions in the `schedule.rb` file. To make sure ruby statements referenced in runner-type jobs actually work, you can `instance_eval` them and write expectations on what should happen, and then you'll be sure cron jobs won't have runtime issues that are detected only in staging or production environments.
 
@@ -20,7 +20,8 @@ NOTE: *This gem is test-framework agnostic, so you can use with RSpec, MiniTest,
 
 ### Installation
 
-Add this line to your application's Gemfile:
+Since it's available in [Rubygems](https://rubygems.org/gems/whenever-test), just add the following to Gemfile:
+Add this line to your Gemfile:
 
 ```ruby
 group :test do
@@ -28,8 +29,6 @@ group :test do
 end
 ```
 
-Available in RubyGems: https://rubygems.org/gems/whenever-test
-
 ### Usage
 
 Suppose you have a schedule such as:
@@ -78,21 +77,21 @@ describe 'Whenever Schedule' do
     schedule = Whenever::Test::Schedule.new(file: fixture)
 
     assert_equal 'http://myapp.com/cron-alive', schedule.jobs[:curl].first[:task]
-    assert_equal 'curl :task', schedule.jobs[:ping].first[:command]
-    assert_equal [:minute], schedule.jobs[:ping].first[:every]
+    assert_equal 'curl :task', schedule.jobs[:curl].first[:command]
+    assert_equal [:minute], schedule.jobs[:curl].first[:every]
   end
 end
 ```
 
 **Now the important part:** these specs guarantee that:
 
-1. If `TimeoutOffers` constant is not defined or `TimeoutOffers.perform_async` methods doesn't exist, an error will raise
-2. If Rake task `db_sync:import` doesn't exist, an error will raise
-3. You should have a custom task named `curl` to make sure that job will work
+1. If `TimeoutOffers` constant is not defined or `TimeoutOffers.perform_async` method doesn't exist, the spec fails
+2. If Rake task `db_sync:import` doesn't exist, the spec fails
+3. You should have a custom task named `curl` to make sure that job will work, otherwise the spec fails
 
 ### How it works
 
-This gem implements a class that has the same DSL interface as Whenever gem. It basically runs the `schedule.rb` file against the `Whenever::Test::DSLInterpreter` and stores all statements and parameters found so you can easily query them in your tests.
+This gem implements a class that has the same DSL interface as Whenever gem. It basically runs the `schedule.rb` file against `Whenever::Test::DSLInterpreter` and stores all statements and parameters found so you can easily query them in your tests.
 
 ### Contributors
 

data/Rakefile

@@ -1,7 +1,7 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'rake/testtask'
 
 Rake::TestTask.new do |t|
-  t.libs += ["spec", "lib"]
+  t.libs += %w(spec lib)
   t.test_files = FileList['spec/**/*_spec.rb']
 end

data/lib/whenever/test.rb

@@ -1,3 +1,3 @@
 require 'whenever'
 
-Dir.glob(File.join(File.dirname(__FILE__), "/test/**/*.rb")).sort.each { |f| require f }
+Dir.glob(File.join(File.dirname(__FILE__), '/test/**/*.rb')).sort.each { |f| require f }

data/lib/whenever/test/dsl.rb

@@ -1,15 +1,12 @@
 module Whenever::Test
   class DSLInterpreter
-    def initialize(schedule_world, vars)
+    def initialize(schedule_world)
       @_world = schedule_world
-      vars.each do |name, value|
-        instance_variable_set("@#{name}", value)
-      end
     end
 
     def job_type(job, command)
       @_world.jobs[job] = []
-      define_singleton_method(job) do |task, *args|
+      define_singleton_method(job) do |task, *_args|
         @_world.jobs[job] << StrictHash[task: task, every: @_current_every, command: command]
       end
     end
@@ -20,6 +17,9 @@ module Whenever::Test
     end
 
     def set(name, value)
+      instance_variable_set("@#{name}".to_sym, value)
+      self.class.send(:attr_reader, name.to_sym)
+
       @_world.sets[name] = value
     end
 

data/lib/whenever/test/schedule.rb

@@ -7,16 +7,16 @@ module Whenever::Test
       self.envs = {}
       self.sets = {}
 
-      dsl = DSLInterpreter.new(self, vars)
+      dsl = DSLInterpreter.new(self)
       setup_whenever(dsl)
+      vars.each { |k,v| dsl.set(k, v) }
       parse(dsl, file)
     end
 
     private
 
     def setup_whenever(dsl)
-      whenever_setup_file = File.join(Gem.loaded_specs['whenever'].full_gem_path, 'lib', 'whenever', 'setup.rb').to_s
-      dsl.instance_eval File.read(whenever_setup_file)
+      parse(dsl, File.join(Gem.loaded_specs['whenever'].full_gem_path, 'lib', 'whenever', 'setup.rb').to_s)
     end
 
     def parse(dsl, file)

data/lib/whenever/test/strict_hash.rb

@@ -1,5 +1,5 @@
 module Whenever::Test
   class StrictHash < Hash
-    alias [] fetch
+    alias_method :[], :fetch
   end
 end

data/spec/fixtures/schedule.rb

@@ -1,4 +1,4 @@
-set :output, '/var/log/whenever.log'
+set :output, "#{path}/log/whenever.log"
 set :runner_command, 'bundle exec rails runner'
 job_type :ping, 'ping :task'
 env :PATH, ENV['PATH']

data/spec/whenever/test/schedule_spec.rb

@@ -30,12 +30,26 @@ describe Whenever::Test::Schedule do
     end
   end
 
-  it 'makes sure `set` statements are captured ' do
+  it 'makes sure `set` statements are captured from the schedule file ' do
     schedule = Whenever::Test::Schedule.new(file: fixture)
 
     assert_equal 'bundle exec rails runner', schedule.sets[:runner_command]
   end
 
+  it 'makes sure `set` statements are captured from the setup file ' do
+    schedule = Whenever::Test::Schedule.new(file: fixture)
+
+    assert schedule.sets[:path]
+  end
+
+  it 'makes sure user-specified variables override those in the setup file ' do
+    schedule = Whenever::Test::Schedule.new(file: fixture)
+    assert_equal 'production', schedule.sets[:environment]
+
+    schedule = Whenever::Test::Schedule.new(file: fixture, vars: { environment: 'staging' })
+    assert_equal 'staging', schedule.sets[:environment]
+  end
+
   it 'makes sure `env` statements are captured ' do
     schedule = Whenever::Test::Schedule.new(file: fixture)
 

data/whenever-test.gemspec

@@ -4,11 +4,11 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'whenever-test'
-  spec.version       = '1.0.0'
+  spec.version       = '1.0.1'
   spec.authors       = ['Rafael Sales']
   spec.email         = ['rafaelcds@gmail.com']
-  spec.summary       = %q{Test Whenever scheduled jobs}
-  spec.description   = %q{Whenever gem doesn't provide test support, so whenever-test makes that possible}
+  spec.summary       = 'Test Whenever scheduled jobs'
+  spec.description   = "Whenever gem doesn't provide test support, so whenever-test makes that possible"
   spec.homepage      = 'https://github.com/heartbits/whenever-test'
   spec.license       = 'MIT'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: whenever-test
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Rafael Sales
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-06 00:00:00.000000000 Z
+date: 2016-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: whenever
@@ -67,7 +67,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Test Whenever scheduled jobs