wgif 0.2.0 → 0.3.0

data/spec/{wgif → unit/wgif}/downloader_spec.rb

@@ -22,12 +22,14 @@ describe WGif::Downloader do
   end
 
   it 'throws an error if the video is not found' do
-    ViddlRb.should_receive(:get_urls).with(clip_url).and_return(['http://lol.wut'])
-    expect{ downloader.get_video(clip_url) }.to raise_error(WGif::VideoNotFoundException)
+    ViddlRb.should_receive(:get_urls).with(clip_url)
+      .and_return(['http://lol.wut'])
+    expect { downloader.get_video(clip_url) }
+      .to raise_error(WGif::VideoNotFoundException)
   end
 
   it 'extracts a YouTube ID from a URL' do
-    downloader.video_id("https://www.youtube.com/watch?v=tmNXKqeUtJM").should eq("tmNXKqeUtJM")
+    downloader.video_id('http://lol.wut?v=id').should eq('id')
   end
 
   context 'downloading videos' do
@@ -36,7 +38,8 @@ describe WGif::Downloader do
       ViddlRb.stub(:get_urls).and_return([clip_url])
       fake_request = double('Typhoeus::Request')
       fake_response = double('Typhoeus::Response')
-      Typhoeus::Request.should_receive(:new).once.with(clip_url).and_return(fake_request)
+      Typhoeus::Request.should_receive(:new).once
+        .with(clip_url).and_return(fake_request)
       fake_request.should_receive(:on_headers)
       fake_request.should_receive(:on_body)
       fake_request.should_receive(:run).and_return(fake_response)
@@ -45,9 +48,9 @@ describe WGif::Downloader do
 
     it 'downloads a clip' do
       video = double(name: 'video')
-      WGif::Video.should_receive(:new).with('roflcopter', "/tmp/wgif/roflcopter").
-        and_return(video)
-      video = downloader.get_video(clip_url)
+      WGif::Video.should_receive(:new)
+        .with('roflcopter', '/tmp/wgif/roflcopter').and_return(video)
+      downloader.get_video(clip_url)
     end
 
     it 'does not download the clip when already cached' do
@@ -60,11 +63,13 @@ describe WGif::Downloader do
 
     it 'throws an exception when the download URL is not found' do
       ViddlRb.stub(:get_urls).and_raise(RuntimeError)
-      expect{ downloader.video_url('invalid url') }.to raise_error(WGif::VideoNotFoundException)
+      expect { downloader.video_url('invalid url') }
+        .to raise_error(WGif::VideoNotFoundException)
     end
 
     it 'throws an exception when the download URL is invalid' do
-      expect{ downloader.video_id(nil) }.to raise_error(WGif::InvalidUrlException)
+      expect { downloader.video_id(nil) }
+        .to raise_error(WGif::InvalidUrlException)
     end
 
   end

data/spec/{wgif → unit/wgif}/installer_spec.rb

@@ -16,14 +16,14 @@ describe WGif::Installer do
   context 'checking for Homebrew' do
 
     it 'finds Homebrew when it exists' do
-      expect(Kernel).to receive(:system).with('brew info > /dev/null').
-        and_return(true)
+      expect(Kernel).to receive(:system).with('brew info > /dev/null')
+        .and_return(true)
       expect(installer.homebrew_installed?).to eq(true)
     end
 
     it 'returns false when Homebrew does not exist' do
-      expect(Kernel).to receive(:system).with('brew info > /dev/null').
-        and_return(false)
+      expect(Kernel).to receive(:system).with('brew info > /dev/null')
+        .and_return(false)
       expect(installer.homebrew_installed?).to eq(false)
     end
 
@@ -32,18 +32,18 @@ describe WGif::Installer do
   context 'checking for dependencies' do
 
     it 'returns true if dependencies are installed' do
-      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').
-        and_return(true)
-      expect(Kernel).to receive(:system).with('which convert > /dev/null').
-        and_return(true)
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null')
+        .and_return(true)
+      expect(Kernel).to receive(:system).with('which convert > /dev/null')
+        .and_return(true)
       expect(installer.dependencies_installed?).to eq(true)
     end
 
     it 'returns false if dependencies are not installed' do
-      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').
-        and_return(true)
-      expect(Kernel).to receive(:system).with('which convert > /dev/null').
-        and_return(false)
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null')
+        .and_return(true)
+      expect(Kernel).to receive(:system).with('which convert > /dev/null')
+        .and_return(false)
       expect(installer.dependencies_installed?).to eq(false)
     end
 
@@ -52,23 +52,23 @@ describe WGif::Installer do
   context 'installing dependencies' do
 
     it 'does not install dependencies if they are found' do
-      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').
-        and_return(true)
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null')
+        .and_return(true)
       expect(Kernel).not_to receive(:system).with('brew install ffmpeg')
       installer.install('ffmpeg', 'ffmpeg')
     end
 
     it 'installs dependencies' do
-      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').
-        and_return(false)
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null')
+        .and_return(false)
       expect(Kernel).to receive(:system).with('brew install ffmpeg')
       installer.install('ffmpeg', 'ffmpeg')
     end
 
     it 'has a list of its dependencies' do
-      expect(installer.class::DEPENDENCIES).
-        to eq([['ffmpeg', 'ffmpeg'],
-               ['imagemagick', 'convert']])
+      expect(installer.class::DEPENDENCIES)
+        .to eq([['ffmpeg', 'ffmpeg'],
+                ['imagemagick', 'convert']])
     end
 
     it 'checks if a dependency exists' do
@@ -81,26 +81,36 @@ describe WGif::Installer do
   context 'running' do
 
     it 'installs all dependencies' do
-      expect(Kernel).to receive(:system).with('brew info > /dev/null').
-        and_return(true)
-      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').twice.
-        and_return(true)
-      expect(Kernel).to receive(:system).with('which convert > /dev/null').twice.
-        and_return(false)
+      expect(Kernel).to receive(:system).with('brew info > /dev/null')
+        .and_return(true)
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').twice
+        .and_return(true)
+      expect(Kernel).to receive(:system).with('which convert > /dev/null').twice
+        .and_return(false)
       expect(Kernel).to receive(:system).with('brew install imagemagick')
-      expect{ installer.run }.to raise_error(SystemExit)
+      expect { installer.run }.to raise_error(SystemExit)
     end
 
     it 'prints a helpful error if homebrew is not found' do
-      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null').
-        and_return(true)
-      expect(Kernel).to receive(:system).with('which convert > /dev/null').
-        and_return(false)
-      expect(Kernel).to receive(:system).with('brew info > /dev/null').
-        and_return(false)
-      expect{ installer.run }.to raise_error(SystemExit)
-      expect(@mock_stdout.string).to eq("WGif can't find Homebrew. Visit http://brew.sh/ to get it.\n")
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null')
+        .and_return(true)
+      expect(Kernel).to receive(:system).with('which convert > /dev/null')
+        .and_return(false)
+      expect(Kernel).to receive(:system).with('brew info > /dev/null')
+        .and_return(false)
+      expect { installer.run }.to raise_error(SystemExit)
+      expect(@mock_stdout.string)
+        .to eq("WGif can't find Homebrew. Visit http://brew.sh/ to get it.\n")
     end
-  end
 
+    it 'prints a helpful message if all dependencies are installed' do
+      expect(Kernel).to receive(:system).with('which ffmpeg > /dev/null')
+        .and_return(true)
+      expect(Kernel).to receive(:system).with('which convert > /dev/null')
+        .and_return(true)
+      expect { installer.run }.to raise_error(SystemExit)
+      expect(@mock_stdout.string)
+        .to eq("All dependencies are installed. Go make a gif.\n")
+    end
+  end
 end

data/spec/unit/wgif/uploader_spec.rb

@@ -0,0 +1,48 @@
+require 'json'
+require 'spec_helper'
+require 'typhoeus'
+require 'wgif/uploader'
+
+describe WGif::Uploader do
+  let(:api_key) { 'api-key' }
+  let(:uploader) { WGif::Uploader.new(api_key) }
+  let(:success) do
+    Typhoeus::Response.new(
+      response_code: 200,
+      return_code: :ok,
+      body: { data: { link: 'foo' } }.to_json
+    )
+  end
+  let(:failure) do
+    Typhoeus::Response.new(
+      response_code: 400,
+      return_code: :error,
+      body: { data: { error: 'You broke everything!' } }.to_json
+    )
+  end
+  let(:tempfile) { Tempfile.new('whatever') }
+  let(:request_params) do
+    { body: { image: tempfile },
+      headers: { Authorization: "Client-ID #{api_key}" } }
+  end
+
+  it 'sends an authorized POST request to Imgur with image file data' do
+    File.stub(:open).and_yield(tempfile)
+    expect(Typhoeus).to receive(:post)
+      .with('https://api.imgur.com/3/image', request_params).and_return(success)
+    uploader.upload(tempfile.path)
+  end
+
+  it 'raises an exception if request is not successful' do
+    Typhoeus.stub(/http/).and_return(failure)
+    expect { uploader.upload(tempfile.path) }
+      .to raise_error(WGif::ImgurException, 'You broke everything!')
+  end
+
+  it 'returns the url when successful' do
+    File.stub(:open).and_yield(tempfile)
+    expect(Typhoeus).to receive(:post)
+      .with('https://api.imgur.com/3/image', request_params).and_return(success)
+    expect(uploader.upload(tempfile.path)).to eq('foo')
+  end
+end

data/spec/{wgif → unit/wgif}/video_spec.rb

@@ -10,36 +10,37 @@ describe WGif::Video do
 
   it 'has a name and filepath' do
     clip.stub(:path).and_return('/tmp/wgif/bjork.mp4')
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    video.name.should eq("bjork")
-    video.clip.path.should eq("/tmp/wgif/bjork.mp4")
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    video.name.should eq('bjork')
+    video.clip.path.should eq('/tmp/wgif/bjork.mp4')
   end
 
   it 'sets up a logger' do
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    video.logger.instance_variable_get(:@logdev).filename.should eq("/tmp/wgif/bjork.log")
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    video.logger.instance_variable_get(:@logdev).filename
+      .should eq('/tmp/wgif/bjork.log')
   end
 
   it 'redirects FFMPEG log output to a file' do
     expect(FFMPEG).to receive(:logger=).with(an_instance_of(Logger))
-    video = described_class.new "penguin", "spec/fixtures/penguin.mp4"
+    described_class.new 'penguin', 'spec/fixtures/penguin.mp4'
   end
 
   it 'is trimmable' do
     clip.stub(:duration).and_return(5.0)
     expect(clip).to receive(:transcode)
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    video = video.trim("00:00:00", 5.0)
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    video = video.trim('00:00:00', 5.0)
     video.clip.duration.should eq(5.0)
   end
 
   it 'returns its frames' do
     expect(clip).to receive(:transcode)
     FileUtils.stub(:rm)
-    fake_frames = ["one", "two", "three"]
-    expect(Dir).to receive(:glob).with('/tmp/wgif/frames/*.png').twice.
-      and_return(fake_frames)
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
+    fake_frames = ['one', 'two', 'three']
+    expect(Dir).to receive(:glob).with('/tmp/wgif/frames/*.png').twice
+      .and_return(fake_frames)
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
     frames = video.to_frames
     frames.count.should eq(3)
   end
@@ -51,26 +52,30 @@ describe WGif::Video do
     FileUtils.stub(:rm)
     expect(clip).to receive(:duration).and_return 2
     expect(Dir).to receive(:glob).with('/tmp/wgif/frames/*.png').twice
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    frames = video.to_frames(frames: 10)
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    video.to_frames(frames: 10)
   end
 
   it 'catches transcode errors and raises an exception' do
     expect(clip).to receive(:transcode).and_raise(FFMPEG::Error)
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    expect{ video.trim("00:00:00", 5.0) }.to raise_error(WGif::ClipEncodingException)
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    expect { video.trim('00:00:00', 5.0) }
+      .to raise_error(WGif::ClipEncodingException)
   end
 
   it 'silences transcode errors from ripping frames' do
-    expect(clip).to receive(:transcode).and_raise(FFMPEG::Error.new "no output file created")
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    expect{ video.trim("00:00:00", 5.0) }.not_to raise_error
+    expect(clip).to receive(:transcode)
+      .and_raise(FFMPEG::Error.new 'no output file created')
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    expect { video.trim('00:00:00', 5.0) }
+      .not_to raise_error
   end
 
   it 'silences transcode errors from ripping frames when input is invalid' do
-    message = "no output file created. Invalid data found when processing input"
+    message = 'no output file created. Invalid data found when processing input'
     expect(clip).to receive(:transcode).and_raise(FFMPEG::Error.new message)
-    video = described_class.new "bjork", "/tmp/wgif/bjork.mp4"
-    expect{ video.trim("00:00:00", 5.0) }.to raise_error(WGif::ClipEncodingException)
+    video = described_class.new 'bjork', '/tmp/wgif/bjork.mp4'
+    expect { video.trim('00:00:00', 5.0) }
+      .to raise_error(WGif::ClipEncodingException)
   end
 end

data/wgif.gemspec

@@ -4,30 +4,30 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'wgif/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "wgif"
+  spec.name          = 'wgif'
   spec.version       = WGif::VERSION
-  spec.authors       = ["Connor Mendenhall"]
-  spec.email         = ["ecmendenhall@gmail.com"]
-  spec.description   = %q{A command-line tool for creating animated GIFs.}
-  spec.summary       = %q{A command-line tool for creating animated GIFs from YouTube videos. Uses FFmpeg and ImageMagick.}
-  spec.homepage      = "https://github.com/ecmendenhall/wgif"
-  spec.license       = "MIT"
+  spec.authors       = ['Connor Mendenhall']
+  spec.email         = ['ecmendenhall@gmail.com']
+  spec.description   = %q(A command-line tool for creating animated GIFs.)
+  spec.summary       = %q(A command-line tool for creating animated GIFs from YouTube videos. Uses FFmpeg and ImageMagick.)
+  spec.homepage      = 'https://github.com/ecmendenhall/wgif'
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/) << 'lib/wgif/uploader.rb'
-  spec.executables   = ["wgif"]
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.files         = `git ls-files`.split($/)
+  spec.executables   = ['wgif']
+  spec.test_files    = spec.files.grep(/^(test|spec|features)\//)
+  spec.require_paths = ['lib']
 
+  spec.add_dependency 'rmagick'
+  spec.add_dependency 'ruby-progressbar'
+  spec.add_dependency 'streamio-ffmpeg'
+  spec.add_dependency 'typhoeus', '~> 0.6'
+  spec.add_dependency 'viddl-rb'
 
-  spec.add_dependency "rmagick"
-  spec.add_dependency "ruby-progressbar"
-  spec.add_dependency "streamio-ffmpeg"
-  spec.add_dependency "typhoeus", "~> 0.6"
-  spec.add_dependency "viddl-rb"
-
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "pry"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.14"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'codeclimate-test-reporter'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency 'simplecov'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wgif
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Connor Mendenhall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-11 00:00:00.000000000 Z
+date: 2014-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rmagick
@@ -94,6 +94,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -168,6 +182,7 @@ files:
 - Rakefile
 - bin/wgif
 - lib/wgif.rb
+- lib/wgif/argument_parser.rb
 - lib/wgif/cli.rb
 - lib/wgif/download_bar.rb
 - lib/wgif/downloader.rb
@@ -178,15 +193,17 @@ files:
 - lib/wgif/version.rb
 - lib/wgif/video.rb
 - lib/wgif/video_cache.rb
+- spec/integration/empty_image_list_spec.rb
 - spec/spec_helper.rb
-- spec/wgif/cli_spec.rb
-- spec/wgif/download_bar_spec.rb
-- spec/wgif/downloader_spec.rb
-- spec/wgif/gif_maker_spec.rb
-- spec/wgif/installer_spec.rb
-- spec/wgif/uploader_spec.rb
-- spec/wgif/video_cache_spec.rb
-- spec/wgif/video_spec.rb
+- spec/unit/wgif/argument_parser_spec.rb
+- spec/unit/wgif/cli_spec.rb
+- spec/unit/wgif/download_bar_spec.rb
+- spec/unit/wgif/downloader_spec.rb
+- spec/unit/wgif/gif_maker_spec.rb
+- spec/unit/wgif/installer_spec.rb
+- spec/unit/wgif/uploader_spec.rb
+- spec/unit/wgif/video_cache_spec.rb
+- spec/unit/wgif/video_spec.rb
 - wgif.gemspec
 homepage: https://github.com/ecmendenhall/wgif
 licenses:
@@ -214,12 +231,14 @@ specification_version: 4
 summary: A command-line tool for creating animated GIFs from YouTube videos. Uses
   FFmpeg and ImageMagick.
 test_files:
+- spec/integration/empty_image_list_spec.rb
 - spec/spec_helper.rb
-- spec/wgif/cli_spec.rb
-- spec/wgif/download_bar_spec.rb
-- spec/wgif/downloader_spec.rb
-- spec/wgif/gif_maker_spec.rb
-- spec/wgif/installer_spec.rb
-- spec/wgif/uploader_spec.rb
-- spec/wgif/video_cache_spec.rb
-- spec/wgif/video_spec.rb
+- spec/unit/wgif/argument_parser_spec.rb
+- spec/unit/wgif/cli_spec.rb
+- spec/unit/wgif/download_bar_spec.rb
+- spec/unit/wgif/downloader_spec.rb
+- spec/unit/wgif/gif_maker_spec.rb
+- spec/unit/wgif/installer_spec.rb
+- spec/unit/wgif/uploader_spec.rb
+- spec/unit/wgif/video_cache_spec.rb
+- spec/unit/wgif/video_spec.rb