wetransfer 0.4.4 → 0.9.0.beta

data/spec/we_transfer_client/remote_transfer_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe RemoteTransfer do
+  let(:params) {
+    {
+      id: '2ae97886522f375c1c6696799a56f0d820180912075119',
+      state: 'uploading',
+      message: 'Test transfer',
+      url: nil,
+      files:
+        [
+          {
+            id: '5e3823ea8ad54f259c85b776eaf7086e20180912075119',
+            name: 'transfer_integration_spec.rb',
+            size: 7361,
+            multipart: {part_numbers: 1, chunk_size: 7361},
+            type: 'file',
+          },
+          {
+            id: '43b5a6323102eced46f071f2db9ec2eb20180912075119',
+            name: 'two_chunks',
+            size: 6291460,
+            multipart: {part_numbers: 2, chunk_size: 5242880},
+            type: 'file',
+          }
+        ]
+    }
+  }
+
+  describe '#initialize' do
+    it 'fails when id is missing' do
+      params.delete(:id)
+      expect {
+        described_class.new(params)
+      }.to raise_error ArgumentError, /id/
+    end
+
+    it 'fails when state is missing' do
+      params.delete(:state)
+      expect {
+        described_class.new(params)
+      }.to raise_error ArgumentError, /state/
+    end
+
+    it 'fails when message is missing' do
+      params.delete(:message)
+      expect {
+        described_class.new(params)
+      }.to raise_error ArgumentError, /message/
+    end
+
+    it 'fails when files is a string' do
+      params.delete(:files)
+      params[:files] = 'Not an array'
+      expect {
+        described_class.new(params)
+      }.to raise_error NoMethodError
+    end
+
+    it 'fails when files is a string' do
+      params.delete(:files)
+      params[:files] = 'Not an array'
+      expect {
+        described_class.new(params)
+      }.to raise_error NoMethodError
+    end
+  end
+
+  describe '#files_to_class' do
+    it 'creates classes of remote files' do
+      transfer = described_class.new(params)
+      expect(transfer.files.map(&:class)).to eq([RemoteFile, RemoteFile])
+    end
+  end
+
+  describe '#prepare_file_upload' do
+    pending 'it retreives the upload url' do
+      fail
+    end
+  end
+
+  describe '#Getters' do
+    subject { described_class.new(params) }
+
+    it '#files' do
+      subject.files
+    end
+
+    it '#url' do
+      subject.url
+    end
+
+    it '#state' do
+      subject.state
+    end
+
+    it '#id' do
+      subject.id
+    end
+  end
+end

data/spec/we_transfer_client/transfer_builder_spec.rb

@@ -1,61 +1,58 @@
 require 'spec_helper'
 
 describe TransferBuilder do
-  it 'raises if given an item with a size of 0' do
-    broken = StringIO.new('')
-    expect {
-      described_class.new.ensure_io_compliant!(broken)
-    }.to raise_error(/The IO object given to add_file has a size of 0/)
-  end
-
-  it 'raises if IO raises an error' do
-    broken = []
-
-    expect {
-      described_class.new.ensure_io_compliant!(broken)
-    }.to raise_error(TransferBuilder::TransferIOError)
-  end
-
-  it 'adds a file' do
-    transfer_builder = described_class.new
-    transfer_builder.add_file_at(path: __FILE__)
-    expect(transfer_builder.items.count).to eq(1)
+  let(:transfer) { described_class.new }
 
-    item = transfer_builder.items.first
-    expect(item.name).to eq('transfer_builder_spec.rb')
-    expect(item.io).to be_kind_of(File)
-    expect(item.local_identifier).to be_kind_of(String)
+  describe '#initialze' do
+    it 'initializes with an empty files array' do
+      expect(transfer.files.empty?).to be(true)
+    end
   end
 
-  it 'should add a url' do
-    transfer_builder = described_class.new
-    transfer_builder.add_web_url(url: 'https://www.wetransfer.com/')
-    expect(transfer_builder.items.count).to eq(1)
-
-    item = transfer_builder.items.first
-    expect(item.url).to eq('https://www.wetransfer.com/')
-    expect(item.local_identifier).to be_kind_of(String)
+  describe '#add_file' do
+    it 'returns an error when name is missing' do
+      expect {
+        transfer.add_file(io: File.open(__FILE__, 'rb'))
+      }.to raise_error ArgumentError, /name/
+    end
+
+    it 'returns an error when io is missing' do
+      expect {
+        transfer.add_file(name: 'file name')
+      }.to raise_error ArgumentError, /io/
+    end
+
+    it 'returns a error when file doesnt exists' do
+      expect {
+        transfer.add_file(name: 'file name', io: File.open('foo', 'rb'))
+      }.to raise_error Errno::ENOENT
+    end
+
+    it 'adds a file when name and io is given' do
+      transfer.add_file(name: 'file name', io: File.open(__FILE__, 'rb'))
+      expect(transfer.files.first).to be_kind_of(FutureFile)
+    end
   end
 
-  it 'should user url for the title when none is given' do
-    transfer_builder = described_class.new
-    transfer_builder.add_web_url(url: 'https://www.wetransfer.com/')
-    expect(transfer_builder.items.count).to eq(1)
-
-    item = transfer_builder.items.first
-
-    expect(item.title).to eq('https://www.wetransfer.com/')
-    expect(item.local_identifier).to be_kind_of(String)
-  end
-
-  it 'should pass title as webcontent title' do
-    transfer_builder = described_class.new
-    transfer_builder.add_web_url(url: 'https://www.wetransfer.com/', title: 'awesome website for file transfering')
-    expect(transfer_builder.items.count).to eq(1)
-
-    item = transfer_builder.items.first
-    expect(item.url).to eq('https://www.wetransfer.com/')
-    expect(item.title).to eq('awesome website for file transfering')
-    expect(item.local_identifier).to be_kind_of(String)
+  describe '#add_file_at' do
+    it 'adds a file from a path' do
+      transfer.add_file_at(path: __FILE__)
+      expect(transfer.files.first).to be_kind_of(FutureFile)
+    end
+
+    it 'throws a Error when file doesnt exists' do
+      expect {
+        transfer.add_file_at(path: '/this/path/leads/to/nothing.exe')
+      }.to raise_error Errno::ENOENT
+    end
+
+    pending 'should call #add_file' do
+      skip "Lets not trigger status:400 errors"
+      client = WeTransfer::Client.new(api_key: ENV.fetch('WT_API_KEY'), logger: test_logger)
+      client.create_transfer(message: 'A transfer message') do |builder|
+        expect(builder).to receive(:add_file).with(name: kind_of(String), io: kind_of(::File))
+        builder.add_file_at(path: __FILE__)
+      end
+    end
   end
 end

data/spec/we_transfer_client/transfers_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe WeTransfer::Client::Transfers do
+  describe '#create_transfer_and_upload_files' do
+    it 'creates a transfer and uploads the files' do
+      client = WeTransfer::Client.new(api_key: ENV.fetch('WT_API_KEY'))
+      transfer = client.create_transfer_and_upload_files(message: 'test description') do |b|
+        b.add_file(name: File.basename(__FILE__), io: File.open(__FILE__, 'rb'))
+        b.add_file_at(path: fixtures_dir + 'Japan-01.jpg')
+      end
+
+      expect(transfer).to be_kind_of(RemoteTransfer)
+      expect(transfer.url).to start_with('https://we.tl/')
+
+      transfer = loop do
+        res = client.get_transfer(transfer_id: transfer.id)
+        break res if res.state != 'processing'
+        sleep 1
+      end
+
+      expect(transfer.state).to eq('downloadable')
+    end
+
+    it 'fails when no files are added' do
+      client = WeTransfer::Client.new(api_key: ENV.fetch('WT_API_KEY'))
+      expect {
+        client.create_transfer_and_upload_files(message: 'test description')
+      }.to raise_error ArgumentError, /No files/
+    end
+
+    it 'fails with duplicate file names' do
+      client = WeTransfer::Client.new(api_key: ENV.fetch('WT_API_KEY', logger: test_logger))
+      expect {
+        client.create_transfer_and_upload_files(message: 'All the (same) Things') do |builder|
+          builder.add_file(name: 'README.txt', io: StringIO.new("A thing"))
+          builder.add_file(name: 'README.txt', io: StringIO.new("another thing"))
+        end
+      }.to raise_error ArgumentError, /Duplicate file entry/
+    end
+  end
+
+  pending '#create_transfers'
+  pending "#complete_transfer"
+  pending "#get_transfer"
+end

data/spec/we_transfer_client_spec.rb

@@ -1,9 +1,57 @@
 require 'spec_helper'
 
-require_relative '../lib/we_transfer_client.rb'
+describe WeTransfer::Client do
+  subject { described_class.new(params) }
+  let(:params) { { api_key: ENV.fetch('WT_API_KEY') } }
 
-describe WeTransferClient do
   it 'exposes VERSION' do
-    expect(WeTransferClient::VERSION).to be_kind_of(String)
+    expect(WeTransfer::VERSION).to be_kind_of(String)
+  end
+
+  describe "#ensure_ok_status!" do
+    before(:all) { Response = Struct.new(:status) }
+
+    context "on success" do
+      it "returns true if the status code is in the 2xx range" do
+        (200..299).each do |status_code|
+          response = Response.new(status_code)
+          expect(subject.ensure_ok_status!(response)).to be_truthy
+        end
+      end
+    end
+
+    context "unsuccessful" do
+      it "raises with a message including the status code the server returned" do
+        response = Response.new("404")
+        expect { subject.ensure_ok_status!(response) }
+          .to raise_error(WeTransfer::Client::Error, %r/Response had a 404 code/)
+
+        response = Response.new("Mehh")
+        expect { subject.ensure_ok_status!(response) }
+          .to raise_error(WeTransfer::Client::Error, %r/Response had a Mehh code/)
+      end
+
+      it "if there is a server error, it raises with information that we can retry" do
+        (500..504).each do |status_code|
+          response = Response.new(status_code)
+          expect { subject.ensure_ok_status!(response) }
+            .to raise_error(WeTransfer::Client::Error, /we could retry/)
+        end
+      end
+
+      it "on client error, it raises with information that the server cannot understand this" do
+        (400..499).each do |status_code|
+          response = Response.new(status_code)
+          expect { subject.ensure_ok_status!(response) }
+            .to raise_error(WeTransfer::Client::Error, /server will not accept this request even if retried/)
+        end
+      end
+
+      it "if the status code is unknown, it raises a generic error" do
+        response = Response.new("I aint a status code")
+        expect { subject.ensure_ok_status!(response) }
+          .to raise_error(WeTransfer::Client::Error, /no idea what to do/)
+      end
+    end
   end
 end

data/wetransfer.gemspec

@@ -5,9 +5,9 @@ require 'we_transfer_client/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'wetransfer'
-  spec.version       = WeTransferClient::VERSION
-  spec.authors       = ['Noah Berman', 'David Bosveld']
-  spec.email         = ['noah@wetransfer.com', 'david@wetransfer.com', 'developers@wetransfer.com']
+  spec.version       = WeTransfer::VERSION
+  spec.authors       = ['Noah Berman', 'David Bosveld', 'Arno Fleming']
+  spec.email         = ['noah@wetransfer.com', 'david@wetransfer.com', 'developers@wetransfer.com', 'arno@wetransfer.com']
 
   spec.summary       = "A Ruby SDK for WeTransfer's Public API"
   spec.description   = "Ruby bindings for using WeTransfer's Public API."
@@ -29,7 +29,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'faraday', '~> 0.12'
-  spec.add_dependency 'ks', '~> 0.0.1'
 
   spec.add_development_dependency 'dotenv', '~> 2.2'
   spec.add_development_dependency 'bundler', '~> 1.16'
@@ -37,5 +36,12 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'simplecov', '~> 0.15'
-  spec.add_development_dependency 'wetransfer_style', '0.5.0'
+  spec.add_development_dependency 'wetransfer_style', '0.6.0'
+  spec.add_development_dependency 'guard-rspec', '~> 4.7'
+  spec.add_development_dependency 'guard-rubocop', '~> 1.3'
 end
+
+#   spec.add_development_dependency 'guard-flay'
+#   spec.add_development_dependency 'guard-flog'
+#   spec.add_development_dependency 'flay', '~> 2.4'
+#   spec.add_development_dependency 'flog'

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: wetransfer
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.9.0.beta
 platform: ruby
 authors:
 - Noah Berman
 - David Bosveld
+- Arno Fleming
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-31 00:00:00.000000000 Z
+date: 2018-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -25,20 +26,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.12'
-- !ruby/object:Gem::Dependency
-  name: ks
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.0.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.0.1
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
@@ -129,19 +116,48 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.0
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 description: Ruby bindings for using WeTransfer's Public API.
 email:
 - noah@wetransfer.com
 - david@wetransfer.com
 - developers@wetransfer.com
+- arno@wetransfer.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -157,26 +173,50 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- V2_README.md
 - bin/console
 - bin/setup
+- examples/create_collection.rb
 - examples/create_transfer.rb
 - lib/we_transfer_client.rb
-- lib/we_transfer_client/future_file_item.rb
+- lib/we_transfer_client/board_builder.rb
+- lib/we_transfer_client/boards.rb
+- lib/we_transfer_client/future_board.rb
+- lib/we_transfer_client/future_file.rb
+- lib/we_transfer_client/future_link.rb
 - lib/we_transfer_client/future_transfer.rb
-- lib/we_transfer_client/future_web_item.rb
-- lib/we_transfer_client/remote_item.rb
+- lib/we_transfer_client/remote_board.rb
+- lib/we_transfer_client/remote_file.rb
+- lib/we_transfer_client/remote_link.rb
 - lib/we_transfer_client/remote_transfer.rb
 - lib/we_transfer_client/transfer_builder.rb
+- lib/we_transfer_client/transfers.rb
 - lib/we_transfer_client/version.rb
-- spec/integration_spec.rb
+- spec/board_integration_spec.rb
+- spec/features/add_items_to_board_spec.rb
+- spec/features/create_board_spec.rb
+- spec/features/get_board_spec.rb
+- spec/features/transfer_spec.rb
+- spec/fixtures/Japan-01.jpg
+- spec/fixtures/Japan-02.jpg
 - spec/spec_helper.rb
-- spec/we_transfer_client/future_file_item_spec.rb
+- spec/transfer_integration_spec.rb
+- spec/we_transfer_client/board_builder_spec.rb
+- spec/we_transfer_client/boards_spec.rb
+- spec/we_transfer_client/future_board_spec.rb
+- spec/we_transfer_client/future_file_spec.rb
+- spec/we_transfer_client/future_link_spec.rb
 - spec/we_transfer_client/future_transfer_spec.rb
-- spec/we_transfer_client/future_web_item_spec.rb
+- spec/we_transfer_client/remote_board_spec.rb
+- spec/we_transfer_client/remote_file_spec.rb
+- spec/we_transfer_client/remote_link_spec.rb
+- spec/we_transfer_client/remote_transfer_spec.rb
 - spec/we_transfer_client/transfer_builder_spec.rb
+- spec/we_transfer_client/transfers_spec.rb
 - spec/we_transfer_client_spec.rb
 - wetransfer.gemspec
 homepage: https://developers.wetransfer.com
@@ -195,12 +235,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: A Ruby SDK for WeTransfer's Public API