wetransfer 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b127566b552bca3dc2cba123d42068d1da3d1207
-  data.tar.gz: a7a43758463d7b3843cca5dc9b63a725305626d2
+  metadata.gz: fdd9e1dde8effa9bce088e6339dd19213adbd865
+  data.tar.gz: 9b93c2b1712d70f3a127f8b78fd088cf9f9aaf38
 SHA512:
-  metadata.gz: e9c63a68dd28022d301f792f6e4e32c6dacb028a37977ae7da6bf84c0508aa2d4e1adf8a69aa70210114fdc92670b27f568f27acdbd64904949abe963c7cce2c
-  data.tar.gz: f32301712449dc9f4d7298356978d8802c4b82a2df9109a8222b18ac25555de568a2cd83ab371ee4a55a1d4bba8b280cd185aae6f344825c6dcb1363326b5eea
+  metadata.gz: 6e6402e0660e1dab0fca754caae6634562cfc8fe029a05d3a590d481124fb5a04ecf311ce0cd6afdc23a25da9e8063b454105cb91bbe00a1d4b933bd28b2c2de
+  data.tar.gz: 7a70a9be5367f7f30adafe69b79fd18a197b1aeed22a2e14958352091b9444b0319bb0c1d77110cbba4e4f5c922eee0abcd92cc2814c82476a408b87db92ba3b

data/README.md

@@ -34,7 +34,7 @@ Or install it yourself as:
 
 ## Usage
 
-### Super simple transfers
+### Minimalist transfers
 
 You'll need to retrieve an API key from [our developer portal](https://developers.wetransfer.com).
 
@@ -76,7 +76,7 @@ transfer.shortened_url => "https://we.tl/SSBsb3ZlIHJ1Ynk="
 The upload will be performed at the end of the block.
 
 ## Development
-You'll need to retrieve an API key from [our developer portal](https://developers.wetransfer.com), and store it in a local `.env` file. As always, do not commit this file to github! :) 
+You'll need to retrieve an API key from [our developer portal](https://developers.wetransfer.com), and as described above, store it in a local `.env` file. As always, do not commit this file to github! :)
 
 After forking and cloning down the repo, run `bundle install` to install dependencies. Then, run `bundle exec rspec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
@@ -94,6 +94,16 @@ To execute to ruby specs, run:
 $ bundle exec rspec
 ```
 
+Please note that we use rubocop to lint this gem -- be sure to run it prior to submitting a PR for maximum mergeability.
+
+    $ bundle exec rubocop
+
+If any violations can be handled by rubocop, you can run auto-fix and it'll handle them for you, though do run the tests again and make sure it hasn't done something ... unexpected.
+
+    $ bundle exec rubocop -a
+
+Hooray!
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/wetransfer/wetransfer_ruby_sdk. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct. More extensive contribution guidelines can be found [here](https://github.com/WeTransfer/wetransfer_ruby_sdk/blob/master/.github/CONTRIBUTING.md).

data/lib/we_transfer_client.rb

@@ -86,7 +86,6 @@ class WeTransferClient
   def create_transfer(name:, description:)
     builder = TransferBuilder.new
     yield(builder)
-    raise 'The transfer you have tried to create contains no items' if builder.items.empty?
     future_transfer = FutureTransfer.new(name: name, description: description, items: builder.items)
     create_and_upload(future_transfer)
   end

data/lib/we_transfer_client/version.rb

@@ -1,3 +1,3 @@
 class WeTransferClient
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/spec/integration_spec.rb

@@ -1,9 +1,4 @@
-require 'tempfile'
-require 'bundler'
-Bundler.setup
-
-require 'dotenv'
-Dotenv.load
+require 'spec_helper'
 
 require_relative '../lib/we_transfer_client.rb'
 
@@ -61,13 +56,12 @@ describe WeTransferClient do
     expect(response['location']).to start_with('https://wetransfer')
   end
 
-  it 'refuses to create a transfer with no items' do
+  it 'is able to create a transfer with no items' do
     client = WeTransferClient.new(api_key: ENV.fetch('WT_API_KEY'), logger: test_logger)
-    expect {
-      client.create_transfer(name: 'My amazing board', description: 'Hi there!') do |builder|
-        # ...do nothing
-      end
-    }.to raise_error(/no items/)
+    response = client.create_transfer(name: 'My amazing board', description: 'Hi there!') do |builder|
+    end
+    expect(response[:size]).to eq(0)
+    expect(response[:items]).to eq([])
   end
 
   it 'refuses to create a transfer when reading an IO raises an error' do

data/spec/spec_helper.rb

@@ -0,0 +1,19 @@
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/spec/'
+end
+
+require 'we_transfer_client'
+require 'pry'
+require 'rspec'
+require 'bundler'
+Bundler.setup
+require 'tempfile'
+require 'dotenv'
+Dotenv.load
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wetransfer
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Noah Berman
@@ -166,6 +166,7 @@ files:
 - lib/we_transfer_client.rb
 - lib/we_transfer_client/version.rb
 - spec/integration_spec.rb
+- spec/spec_helper.rb
 - wetransfer.gemspec
 homepage: https://developers.wetransfer.com
 licenses: