wepay-signer 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e479de889f8eb00c3156d88c8cee78009301599
-  data.tar.gz: 7a3c9b4b299eda43cad03715e539024e42f0f082
+  metadata.gz: dee087f2859195456da1b0ed41de40beefa30ab7
+  data.tar.gz: ec8a0ebdb7918e3d14af18d9591199070c09f154
 SHA512:
-  metadata.gz: c9e4fa128e14c42f8f715946d615cf39aa31d22c4e6fac937926d6ebbc11d3835707ec5ec4ad3a580645ba7b72cffa4be9101e45208a728d7df515cbec1cf128
-  data.tar.gz: de5d9d3b9b51cc7a80ca1015ff45cd4d4b9a615776fdcf84fe731f89f01f5a4c59652178e642b589a8ccd27296c98f61bfa0a918120fcfb9a5b7ec75f78b24dc
+  metadata.gz: 9089628d9b8642359f8c3a1d071a91298e4c9df22fe1b2b38c8b9288022fba00301b35e7920bf522c046bd021fc032c962da4a6ec4d31544aa9fc208cca7be0e
+  data.tar.gz: 877c49f80dc7360751985e814c634ad656822bf1cef7953444529a6ac87bb1ccebe7c951ceba0746f93fe7558330b1cf718a42617af9d379b7a2dcf2c412b8b9

data/lib/{signer.rb → wepay-signer.rb}

@@ -29,6 +29,11 @@ module WePay
   ##
   class Signer
 
+    attr_reader :self_key
+    attr_reader :client_id
+    attr_reader :client_secret
+    attr_reader :hash_algo
+
     ##
     # Constructs a new instance of this class.
     #
@@ -42,43 +47,16 @@ module WePay
     # @option options [String] hash_algo (sha512) The hash algorithm to use for signing.
     ##
     def initialize(client_id, client_secret, options = {})
-      @client_id = client_id
-      @client_secret = client_secret
+      @client_id = client_id.to_s
+      @client_secret = client_secret.to_s
 
       options = {
         :self_key  => 'WePay',
         :hash_algo => 'sha512',
-      }.merge(options);
+      }.merge(options)
 
-      @self_key = options[:self_key]
-      @hash_algo = options[:hash_algo]
-    end
-
-    ##
-    # Gets the self key that was set in the constructor.
-    #
-    # @return [String] The self key.
-    ##
-    def get_self_key
-      @self_key
-    end
-
-    ##
-    # Gets the client key that was set in the constructor.
-    #
-    # @return [String] The client key.
-    ##
-    def get_client_id
-      @client_id
-    end
-
-    ##
-    # Gets the client secret that was set in the constructor.
-    #
-    # @return [String] The client secret.
-    ##
-    def get_client_secret
-      @client_secret
+      @self_key = options[:self_key].to_s
+      @hash_algo = options[:hash_algo].to_s
     end
 
     ##
@@ -100,9 +78,7 @@ module WePay
       context = create_context(payload)
       s2s = create_string_to_sign(scope, context)
       signing_key = get_signing_salt
-      signature = OpenSSL::HMAC.hexdigest(@hash_algo, signing_key, s2s)
-
-      return signature
+      OpenSSL::HMAC.hexdigest(@hash_algo, signing_key, s2s)
     end
 
     ##
@@ -118,13 +94,13 @@ module WePay
       signed_token = sign(payload)
       payload[:client_id] = @client_id
       payload[:stoken] = signed_token
-      qsa = Array.new
+      qsa = []
 
       payload.keys.sort.each do | key |
         qsa.push sprintf("%s=%s", key, payload[key])
       end
 
-      return qsa.join("&")
+      qsa.join("&")
     end
 
 private
@@ -139,7 +115,7 @@ private
     def create_string_to_sign(scope, context)
       scope_hash = OpenSSL::Digest.new(@hash_algo, scope)
       context_hash = OpenSSL::Digest.new(@hash_algo, context)
-      s2s = sprintf "SIGNER-HMAC-%s\n%s\n%s\n%s\n%s", @hash_algo.upcase, @self_key, @client_id, scope_hash, context_hash
+      sprintf "SIGNER-HMAC-%s\n%s\n%s\n%s\n%s", @hash_algo.upcase, @self_key, @client_id, scope_hash, context_hash
     end
 
     ##
@@ -161,8 +137,8 @@ private
 
       canonical_payload.sort!
 
-      signed_headers_string = payload.keys.sort_by {|s| s.to_s}.join(";")
-      canonical_context = canonical_payload.join("") + "\n" + signed_headers_string
+      signed_headers_string = payload.keys.sort_by {|s| s.to_s }.join(";")
+      canonical_payload.join("") + "\n" + signed_headers_string
     end
 
     ##
@@ -173,7 +149,7 @@ private
     def get_signing_salt
       self_key_sign = OpenSSL::HMAC.digest(@hash_algo, @client_secret, @self_key)
       client_id_sign = OpenSSL::HMAC.digest(@hash_algo, self_key_sign, @client_id)
-      salt = OpenSSL::HMAC.digest(@hash_algo, client_id_sign, 'signer')
+      OpenSSL::HMAC.digest(@hash_algo, client_id_sign, 'signer')
     end
 
     ##
@@ -182,7 +158,7 @@ private
     # @return [String] The string which represents the scope in which the signature is valid.
     ##
     def create_scope
-      scope = sprintf "%s/%s/signer", @self_key, @client_id
+      sprintf "%s/%s/signer", @self_key, @client_id
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wepay-signer
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - WePay
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-16 00:00:00.000000000 Z
+date: 2015-04-23 00:00:00.000000000 Z
 dependencies: []
 description: A Modern Ruby SDK for signing WePay requests.
 email: api@wepay.com
@@ -16,7 +16,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/signer.rb
+- lib/wepay-signer.rb
 homepage: https://github.com/wepay/signer-ruby
 licenses:
 - Apache-2.0