weneedfeed 0.3.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b201152f3a5b05f2c336caf0ba02416eea09da02834a46818dc00c86596ee0d3
-  data.tar.gz: 0fc63fe70919ac5284297c309545d0d1ea3a3253166d36f434bb6b598aa92721
+  metadata.gz: c580b642b78a2c26bf06d840fad6a745d498630779c670784deba389d9b28f1a
+  data.tar.gz: e29a86399e141b1c650a064cf6c45066149d93dee722b70fa657366519015f7b
 SHA512:
-  metadata.gz: a318105d868fc4ca2b91a03541feffde8bb1af257b4c3126716c2988f21703f7ee87699183ab0d8f3ab67d111008af9485ee4e219d464ef618e459b5a8b8fc1e
-  data.tar.gz: 726e20a19227146a81a309b32837396753a1fe572fe1ec6fd8ce44767dab61ebc337ccaa5af53d8d1449ba987bcefd76d6486db3988f4c95bd8d316f2440fd57
+  metadata.gz: 3293b7dbba14a24988a77bb2070adfef0a4c4f343197d5633076c497747d6f66d9642b89e37ec11f9d2c51a0f91b18c8dfd614cf053339adfc3c7b4390702774
+  data.tar.gz: f9549a610dec4b77e9e6f86829890bc31928f086652480cbe2c501b1c9fda479a1a0d549ec6efb3a40d1f8ea4fcdb4cc4ccc198403c57ab0a2dbf3c9010ea27f

data/.github/workflows/test.yml

@@ -5,16 +5,18 @@ on:
   push:
     branches:
       - master
+
 jobs:
   build:
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-ruby@v1
+      - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '2.7.2'
-      - run: bundle install --jobs=$(($(nproc) - 1)) --retry=3
-      - run: bundle exec rubocop --color --parallel
+          bundler-cache: true
+          ruby-version: 2.7.2
+      - uses: r7kamura/rubocop-problem-matchers-action@v1
+      - run: bundle exec rubocop --parallel
       - run: bundle exec rspec --force-color
 
 

data/.rspec

@@ -1 +1,2 @@
+--format doc
 --require spec_helper

data/.rubocop.yml

@@ -9,3 +9,6 @@ Metrics:
 
 Style/Documentation:
   Enabled: false
+
+Style/TrailingCommaInArguments:
+  Enabled: false

data/CHANGELOG.md

@@ -7,6 +7,61 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 0.6.1 - 2020-11-15
+
+### Changed
+
+- Require hibana 0.2 or later.
+
+### Fixed
+
+- Fix installation error caused by hanami-router version restriction.
+
+### Removed
+
+- Remove direct dependency on hanami-router.
+
+## 0.6.0 - 2020-11-15
+
+### Changed
+
+- Change pages schema from Hash to Array.
+- Require hanami-router 2.0.0.alpha3 or later versions.
+- Ignore pubDate when item.time is not found.
+- Make some item_description_selector and item_time_selector optional.
+
+## 0.5.0 - 2020-11-14
+
+### Added
+
+- Add datetime attribute support on time element.
+
+### Changed
+
+- Change schema format about selectors.
+
+## 0.4.1 - 2020-11-08
+
+### Fixed
+
+- Fix error when item description is not found.
+
+## 0.4.0 - 2020-11-08
+
+### Added
+
+- Add CSS selector support.
+
+### Changed
+
+- Change schema key from `xpath` to `selectors`.
+- Change item_link_selector target from href attribute to a element.
+- Change some argument names from `_xpath` to `_selector`.
+- Change `weneedfeed build` description.
+- Change `weneedfeed server` description.
+- Change channel link from feed URL to top page URL.
+- Sort top page feeds by its title.
+
 ## 0.3.0 - 2020-11-08
 
 ### Added

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    weneedfeed (0.3.0)
+    weneedfeed (0.6.1)
       faraday
-      hibana
+      hibana (>= 0.2)
       nokogiri
       rack-capture (>= 0.4.0)
       thor
@@ -14,29 +14,28 @@ GEM
     addressable (2.7.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.1)
-    concurrent-ruby (1.1.7)
     crack (0.4.4)
     diff-lcs (1.4.4)
     faraday (1.1.0)
       multipart-post (>= 1.2, < 3)
       ruby2_keywords
-    hanami-router (1.3.2)
-      hanami-utils (~> 1.3)
-      http_router (= 0.11.2)
+    hanami-router (2.0.0.alpha3)
+      mustermann (~> 1.0)
+      mustermann-contrib (~> 1.0)
       rack (~> 2.0)
-    hanami-utils (1.3.6)
-      concurrent-ruby (~> 1.0)
-      transproc (~> 1.0)
+    hansi (0.2.0)
     hashdiff (1.0.1)
-    hibana (0.1.1)
-      hanami-router
+    hibana (0.2.0)
+      hanami-router (>= 2.0.0.alpha3)
       rack
       tilt
-    http_router (0.11.2)
-      rack (>= 1.0.0)
-      url_mount (~> 0.2.1)
     mini_portile2 (2.4.0)
     multipart-post (2.1.1)
+    mustermann (1.1.1)
+      ruby2_keywords (~> 0.0.1)
+    mustermann-contrib (1.1.1)
+      hansi (~> 0.2.0)
+      mustermann (= 1.1.1)
     nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
     parallel (1.19.2)
@@ -80,10 +79,7 @@ GEM
     ruby2_keywords (0.0.2)
     thor (1.0.1)
     tilt (2.0.10)
-    transproc (1.1.1)
     unicode-display_width (1.7.0)
-    url_mount (0.2.1)
-      rack
     webmock (3.9.3)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)

data/README.md

@@ -3,7 +3,7 @@
 [![](https://badge.fury.io/rb/weneedfeed.svg)](https://rubygems.org/gems/weneedfeed)
 [![](https://github.com/r7kamura/weneedfeed/workflows/test/badge.svg)](https://github.com/r7kamura/weneedfeed/actions?query=workflow%3Atest)
 
-Generate feeds from URL and XPath.
+Generate feeds from URL and selectors.
 
 ## Installation
 
@@ -25,38 +25,124 @@ Or install it yourself as:
 gem install weneedfeed
 ```
 
-## Usage
+## Schema
+
+You need to write a schema file named with `weneedfeed.yml` to use this gem.
 
-Write schema:
+### Example
 
 ```yaml
 pages:
-  example:
-    title: example name
-    url: http://example.com/
-    xpath:
-      item: //li
-      item_description: .//p[3]
-      item_link: .//a/@href
-      item_time: .//time/@datetime
-      item_title: .//p[2]
+  - id: example1
+    title: Example feed with CSS Selector
+    url: http://example.com/1
+    item_selector: li
+    item_description_selector: p:nth-child(3)
+    item_link_selector: a
+    item_time_selector: time
+    item_title_selector: p:nth-child(2)
+  - id: example2
+    title: Example feed with XPath
+    url: http://example.com/2
+    item_selector: //li
+    item_description_selector: .//p[3]
+    item_link_selector: .//a
+    item_time_selector: .//time
+    item_title_selector: .//p[2]
 ```
 
-And then call `Weneedfeed::Capture`:
+### `id`
 
-```ruby
-require 'weneedfeed'
+Feed ID.
+
+- required
+- Used for feed URL.
+
+### `title`
+
+Feed title.
+
+- required
+- Used for RSS `<title>` element in `<channel>` element.
+
+### `url`
+
+HTML source URL.
+
+- required
+- Used to fetch HTML page for building feed.
+
+### `item_selector`
+
+CSS or XPath selector to search each item.
+
+- required
+- Equivalent unit to RSS `<item>` element.
+
+### `item_link_selector`
+
+CSS or XPath selector to find `<a>` element in each item.
+
+- required
+- Used for `<link>` in `<item>`.
+
+### `item_title_selector`
+
+CSS or XPath selector to find element with title information in each item.
+
+- required
+- Used for `<title>` in `<item>`.
+
+### `item_description_selector`
+
+CSS or XPath selector to find element with description information in each item.
+
+- optional
+- Used for `<description>` in `<item>`.
+
+### `item_time_selector`
+
+CSS or XPath selector to find element with datetime information in each item.
+
+- optional
+- Used for `<pubDate>` in `<item>`. Its `datetime` attribute or its inner HTML is used to calculate datetime.
+
+## Usage
+
+### Build
+
+Run `weneedfeed build` to build static files.
+
+```
+Usage:
+  weneedfeed build --base-url=BASE_URL
+
+Options:
+  --base-url=BASE_URL          # Base URL where to locate built files. (e.g. `"https://user.github.io/repo"`)
+  [--schema-path=SCHEMA_PATH]  # Path to weneedfeed YAML schema file.
+                               # Default: weneedfeed.yml
+
+Build static files.
+```
+
+### Server
+
+Run `weneedfeed server` to run HTTP server.
+
+```
+Usage:
+  weneedfeed server
+
+Options:
+  [--schema-path=SCHEMA_PATH]  # Path to weneedfeed YAML schema file.
+                               # Default: weneedfeed.yml
 
-Weneedfeed::Capture.call(
-  base_url: 'https://user.github.io/repo',
-  schema_path: 'schema.yml'
-)
+Run HTTP server.
 ```
 
-These files will be generated:
+## GitHub Actions Integration
 
-- output/index.html
-- output/feeds/example.xml
+Use [weneedfeed-action](https://github.com/r7kamura/weneedfeed-action) for invoking weneedfeed on GitHub Actions.
 
 ## Development
 

data/lib/weneedfeed.rb

@@ -7,8 +7,11 @@ module Weneedfeed
   autoload :Capture, 'weneedfeed/capture'
   autoload :Command, 'weneedfeed/command'
   autoload :Controllers, 'weneedfeed/controllers'
+  autoload :Helpers, 'weneedfeed/helpers'
   autoload :Item, 'weneedfeed/item'
   autoload :Page, 'weneedfeed/page'
+  autoload :PageSchema, 'weneedfeed/page_schema'
+  autoload :Schema, 'weneedfeed/schema'
   autoload :Scraping, 'weneedfeed/scraping'
   autoload :Views, 'weneedfeed/views'
 end

data/lib/weneedfeed/application.rb

@@ -6,12 +6,12 @@ module Weneedfeed
   class Application < ::Hibana::Application
     route do
       get '/', to: ::Weneedfeed::Controllers::ShowTopPage, as: :top_page
-      get '/feeds/:page_name.xml', to: ::Weneedfeed::Controllers::ShowFeed, as: :feed
+      get '/feeds/:page_id.xml', to: ::Weneedfeed::Controllers::ShowFeed, as: :feed
     end
 
     # @param [Hash] schema
     def initialize(schema:)
-      @schema = schema
+      @schema = ::Weneedfeed::Schema.new(schema)
       super()
     end
 
@@ -23,8 +23,8 @@ module Weneedfeed
 
     # @return [Array<String>]
     def paths
-      ['/'] + @schema['pages'].keys.map do |page_name|
-        "/feeds/#{page_name}.xml"
+      ['/'] + @schema.page_ids.map do |page_id|
+        "/feeds/#{page_id}.xml"
       end
     end
   end

data/lib/weneedfeed/command.rb

@@ -16,7 +16,7 @@ module Weneedfeed
 
     desc(
       'build',
-      'Build static files for feeds.'
+      'Build static files.'
     )
 
     method_option(
@@ -44,7 +44,7 @@ module Weneedfeed
 
     desc(
       'server',
-      'Run HTTP server'
+      'Run HTTP server.'
     )
 
     method_option(

data/lib/weneedfeed/controllers.rb

@@ -2,6 +2,7 @@
 
 module Weneedfeed
   module Controllers
+    autoload :Base, 'weneedfeed/controllers/base'
     autoload :ShowFeed, 'weneedfeed/controllers/show_feed'
     autoload :ShowTopPage, 'weneedfeed/controllers/show_top_page'
   end

data/lib/weneedfeed/controllers/base.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Weneedfeed
+  module Controllers
+    class Base < ::Hibana::Controller
+      include ::Weneedfeed::Helpers::Parameters
+
+      private
+
+      # @return [Weneedfeed::Schema]
+      def schema
+        request.env['weneedfeed.schema']
+      end
+    end
+  end
+end

data/lib/weneedfeed/controllers/show_feed.rb

@@ -2,31 +2,22 @@
 
 module Weneedfeed
   module Controllers
-    class ShowFeed < ::Hibana::Controller
+    class ShowFeed < ::Weneedfeed::Controllers::Base
       def call
-        env = request.env
-        page_name = env.dig(
-          'router.params',
-          :page_name
-        )
-        properties = env.dig(
-          'weneedfeed.schema',
-          'pages',
-          page_name
-        )
-        unless properties
+        page_schema = schema.find_page_schema(path_parameters[:page_id])
+        unless page_schema
           response.status = 404
           return
         end
 
         scraping = ::Weneedfeed::Scraping.new(
-          item_description_xpath: properties['xpath']['item_description'],
-          item_link_xpath: properties['xpath']['item_link'],
-          item_time_xpath: properties['xpath']['item_time'],
-          item_title_xpath: properties['xpath']['item_title'],
-          item_xpath: properties['xpath']['item'],
-          title: properties['title'],
-          url: properties['url']
+          item_description_selector: page_schema.item_description_selector,
+          item_link_selector: page_schema.item_link_selector,
+          item_time_selector: page_schema.item_time_selector,
+          item_title_selector: page_schema.item_title_selector,
+          item_selector: page_schema.item_selector,
+          title: page_schema.title,
+          url: page_schema.url,
         )
         page = scraping.call
 

data/lib/weneedfeed/controllers/show_top_page.rb

@@ -2,16 +2,13 @@
 
 module Weneedfeed
   module Controllers
-    class ShowTopPage < ::Hibana::Controller
+    class ShowTopPage < ::Weneedfeed::Controllers::Base
       def call
-        pages = request.env.dig(
-          'weneedfeed.schema',
-          'pages'
-        )
+        page_schemata = schema.page_schemata.sort_by(&:title)
         response.content_type = 'text/html'
         response.write(
           ::Weneedfeed::Views::ShowTopPage.new(
-            pages: pages,
+            page_schemata: page_schemata,
             partial_template_path: ::File.expand_path(
               'templates/show_top_page.html.erb',
               "#{__dir__}/../../.."

data/lib/weneedfeed/helpers.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Weneedfeed
+  module Helpers
+    autoload :Parameters, 'weneedfeed/helpers/parameters'
+  end
+end

data/lib/weneedfeed/helpers/parameters.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Weneedfeed
+  module Helpers
+    module Parameters
+      private
+
+      # @return [Hash]
+      def path_parameters
+        request.env['router.params']
+      end
+    end
+  end
+end

data/lib/weneedfeed/item.rb

@@ -15,56 +15,71 @@ module Weneedfeed
       end
     end
 
-    # @param [String] description_xpath
-    # @param [String] link_xpath
+    # @param [String, nil] description_selector
+    # @param [String, nil] link_selector
     # @param [Nokogiri::Node] node
-    # @param [String] time_xpath
-    # @param [String] title_xpath
+    # @param [String] time_selector
+    # @param [String] title_selector
     # @param [String] url
     def initialize(
-      description_xpath:,
-      link_xpath:,
+      description_selector:,
+      link_selector:,
       node:,
-      time_xpath:,
-      title_xpath:,
+      time_selector:,
+      title_selector:,
       url:
     )
-      @description_xpath = description_xpath
-      @link_xpath = link_xpath
+      @description_selector = description_selector
+      @link_selector = link_selector
       @node = node
-      @time_xpath = time_xpath
-      @title_xpath = title_xpath
+      @time_selector = time_selector
+      @title_selector = title_selector
       @url = url
     end
 
     # @return [String, nil]
     def description
-      @node.xpath(@description_xpath).inner_html
+      return unless @description_selector
+
+      @node.at(@description_selector)&.inner_html
     end
 
     # @return [String]
     def link
       ::URI.join(
         @url,
-        @node.xpath(@link_xpath).inner_html
+        @node.at(@link_selector)['href']
       ).to_s
     end
 
     # @return [Time, nil]
     def time
-      self.class.parse_time(time_string)
+      return unless @time_selector
+
+      string = time_string
+      return unless string
+
+      self.class.parse_time(string)
     end
 
-    # @return [String, nil]
+    # @return [String]
     def title
-      @node.xpath(@title_xpath).inner_text
+      @node.at(@title_selector).inner_text
     end
 
     private
 
-    # @return [String]
+    # @return [Nokogiri::Node, nil]
+    def time_node
+      @node.at(@time_selector)
+    end
+
+    # @return [String, nil]
     def time_string
-      @node.xpath(@time_xpath).inner_html
+      node = time_node
+      return unless node
+
+      node['datetime'] || node.inner_html
     end
   end
 end

data/lib/weneedfeed/page.rb

@@ -8,29 +8,29 @@ module Weneedfeed
     # @return [String]
     attr_reader :url
 
-    # @param [String] item_description_xpath
-    # @param [String] item_link_xpath
-    # @param [String] item_time_xpath
-    # @param [String] item_title_xpath
-    # @param [String] item_xpath
+    # @param [String, nil] item_description_selector
+    # @param [String] item_link_selector
+    # @param [String, nil] item_time_selector
+    # @param [String] item_title_selector
+    # @param [String] item_selector
     # @param [Nokogiri::Node] node
     # @param [String] title
     # @param [String] url
     def initialize(
-      item_description_xpath:,
-      item_link_xpath:,
-      item_time_xpath:,
-      item_title_xpath:,
-      item_xpath:,
+      item_description_selector:,
+      item_link_selector:,
+      item_time_selector:,
+      item_title_selector:,
+      item_selector:,
       node:,
       title:,
       url:
     )
-      @item_description_xpath = item_description_xpath
-      @item_link_xpath = item_link_xpath
-      @item_time_xpath = item_time_xpath
-      @item_title_xpath = item_title_xpath
-      @item_xpath = item_xpath
+      @item_description_selector = item_description_selector
+      @item_link_selector = item_link_selector
+      @item_time_selector = item_time_selector
+      @item_title_selector = item_title_selector
+      @item_selector = item_selector
       @node = node
       @title = title
       @url = url
@@ -38,13 +38,13 @@ module Weneedfeed
 
     # @return [Array<Weneedfeed::Item>]
     def items
-      @node.xpath(@item_xpath).map do |node|
+      @node.search(@item_selector).map do |node|
         ::Weneedfeed::Item.new(
-          description_xpath: @item_description_xpath,
-          link_xpath: @item_link_xpath,
+          description_selector: @item_description_selector,
+          link_selector: @item_link_selector,
           node: node,
-          time_xpath: @item_time_xpath,
-          title_xpath: @item_title_xpath,
+          time_selector: @item_time_selector,
+          title_selector: @item_title_selector,
           url: @url
         )
       end

data/lib/weneedfeed/page_schema.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Weneedfeed
+  PageSchema = Struct.new(
+    :id,
+    :item_description_selector,
+    :item_link_selector,
+    :item_time_selector,
+    :item_title_selector,
+    :item_selector,
+    :title,
+    :url,
+    keyword_init: true,
+  )
+end

data/lib/weneedfeed/schema.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Weneedfeed
+  class Schema
+    # @param [Hash] raw
+    def initialize(raw)
+      @raw = raw
+    end
+
+    # @param [String, nl] page_schema_id
+    # @return [Weneedfeed::PageSchema]
+    def find_page_schema(page_schema_id)
+      page_schemata.find do |page_schema|
+        page_schema.id == page_schema_id
+      end
+    end
+
+    # @return [Array<String>]
+    def page_ids
+      page_schemata.map(&:id)
+    end
+
+    # @return [Array<Weneedfeed::PageSchema>]
+    def page_schemata
+      @raw['pages'].map do |hash|
+        ::Weneedfeed::PageSchema.new(
+          id: hash['id'],
+          item_link_selector: hash['item_link_selector'],
+          item_time_selector: hash['item_time_selector'],
+          item_title_selector: hash['item_title_selector'],
+          item_selector: hash['item_selector'],
+          title: hash['title'],
+          url: hash['url'],
+        )
+      end
+    end
+  end
+end

data/lib/weneedfeed/scraping.rb

@@ -5,27 +5,27 @@ require 'nokogiri'
 
 module Weneedfeed
   class Scraping
-    # @param [String] item_description_xpath
-    # @param [String] item_link_xpath
-    # @param [String] item_time_xpath
-    # @param [String] item_title_xpath
-    # @param [String] item_xpath
+    # @param [String, nil] item_description_selector
+    # @param [String] item_link_selector
+    # @param [String, nil] item_time_selector
+    # @param [String] item_title_selector
+    # @param [String] item_selector
     # @param [String] title
     # @param [String] url
     def initialize(
-      item_description_xpath:,
-      item_link_xpath:,
-      item_time_xpath:,
-      item_title_xpath:,
-      item_xpath:,
+      item_description_selector:,
+      item_link_selector:,
+      item_time_selector:,
+      item_title_selector:,
+      item_selector:,
       title:,
       url:
     )
-      @item_description_xpath = item_description_xpath
-      @item_link_xpath = item_link_xpath
-      @item_time_xpath = item_time_xpath
-      @item_title_xpath = item_title_xpath
-      @item_xpath = item_xpath
+      @item_description_selector = item_description_selector
+      @item_link_selector = item_link_selector
+      @item_time_selector = item_time_selector
+      @item_title_selector = item_title_selector
+      @item_selector = item_selector
       @title = title
       @url = url
     end
@@ -34,11 +34,11 @@ module Weneedfeed
     def call
       ::Weneedfeed::Page.new(
         node: parsed_body,
-        item_description_xpath: @item_description_xpath,
-        item_xpath: @item_xpath,
-        item_link_xpath: @item_link_xpath,
-        item_time_xpath: @item_time_xpath,
-        item_title_xpath: @item_title_xpath,
+        item_description_selector: @item_description_selector,
+        item_selector: @item_selector,
+        item_link_selector: @item_link_selector,
+        item_time_selector: @item_time_selector,
+        item_title_selector: @item_title_selector,
         title: @title,
         url: @url
       )

data/lib/weneedfeed/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Weneedfeed
-  VERSION = '0.3.0'
+  VERSION = '0.6.1'
 end

data/lib/weneedfeed/views/show_feed.rb

@@ -3,6 +3,8 @@
 module Weneedfeed
   module Views
     class ShowFeed < ::Hibana::View
+      include ::Weneedfeed::Helpers::Parameters
+
       # @param [Weneedfeed::Page] page
       def initialize(page:, **argv)
         super(**argv)
@@ -11,6 +13,11 @@ module Weneedfeed
 
       private
 
+      # @return [String]
+      def top_page_path
+        request.path.delete_suffix(router.path(:feed, page_id: page_id))
+      end
+
       # @return [Enumerable<Weneedfeed::Item>]
       def items
         @page.items.sort_by do |item|
@@ -19,8 +26,13 @@ module Weneedfeed
       end
 
       # @return [String]
-      def page_name
-        request.env['router.params'][:page_name]
+      def page_id
+        path_parameters[:page_id]
+      end
+
+      # @return [Hanami::Router]
+      def router
+        ::Weneedfeed::Application.router
       end
     end
   end

data/lib/weneedfeed/views/show_top_page.rb

@@ -3,10 +3,10 @@
 module Weneedfeed
   module Views
     class ShowTopPage < ::Hibana::View
-      # @param [Array<Weneedfeed::Page>] pages
-      def initialize(pages:, **argv)
+      # @param [Array<Hash>] page_schemata
+      def initialize(page_schemata:, **argv)
         super(**argv)
-        @pages = pages
+        @page_schemata = page_schemata
       end
 
       private
@@ -16,10 +16,10 @@ module Weneedfeed
         request.path.delete_suffix(router.path(:top_page))
       end
 
-      # @param [String] page_name
+      # @param [String] page_id
       # @return [String]
-      def feed_path(page_name:)
-        "#{base_path}#{router.path(:feed, page_name: page_name)}"
+      def feed_path(page_id:)
+        "#{base_path}#{router.path(:feed, page_id: page_id)}"
       end
 
       # @return [Hanami::Router]

data/templates/show_feed.xml.erb

@@ -4,7 +4,7 @@
   xmlns:content="http://purl.org/rss/1.0/modules/content/">
   <channel>
     <title><![CDATA[<%= @page.title %>]]></title>
-    <link><%= "#{request.base_url}#{request.path}" %></link>
+    <link><%= "#{request.base_url}#{top_page_path}" %></link>
     <atom:link href="<%= "#{request.base_url}#{request.path}" %>" rel="self"/>
     <description><![CDATA[Recent content on <%= @page.title %>]]></description>
     <lastBuildDate><%= Time.now.rfc822 %></lastBuildDate>
@@ -12,7 +12,9 @@
     <item>
       <title><![CDATA[<%= item.title %>]]></title>
       <link><%= item.link %></link>
-      <pubDate><%= item.time.rfc822 %></pubDate>
+      <% if item.time %>
+        <pubDate><%= item.time.rfc822 %></pubDate>
+      <% end %>
       <description><![CDATA[<%= item.description %>]]></description>
       <content:encoded><![CDATA[<%= item.description %>]]></content:encoded>
       <guid isPermaLink="true"><%= item.link %></guid>

data/templates/show_top_page.html.erb

@@ -7,9 +7,9 @@
   </head>
   <body>
     <ul>
-      <% @pages.each do |page_name, hash| %>
+      <% @page_schemata.each do |page_schema| %>
       <li>
-        <a href="<%= feed_path(page_name: page_name) %>"><%= hash['title'] %></a>
+        <a href="<%= feed_path(page_id: page_schema.id) %>"><%= page_schema.title %></a>
       </li>
       <% end %>
     </ul>

data/weneedfeed.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Ryo Nakamura']
   spec.email         = ['r7kamura@gmail.com']
 
-  spec.summary       = 'Generate feeds from URL and XPath.'
+  spec.summary       = 'Generate feeds from URL and selectors.'
   spec.homepage      = 'https://github.com/r7kamura/weneedfeed'
   spec.license       = 'MIT'
   spec.required_ruby_version = Gem::Requirement.new('>= 2.5.0')
@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'faraday'
-  spec.add_runtime_dependency 'hibana'
+  spec.add_runtime_dependency 'hibana', '>= 0.2'
   spec.add_runtime_dependency 'nokogiri'
   spec.add_runtime_dependency 'rack-capture', '>= 0.4.0'
   spec.add_runtime_dependency 'thor'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: weneedfeed
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-11-07 00:00:00.000000000 Z
+date: 2020-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -106,10 +106,15 @@ files:
 - lib/weneedfeed/capture.rb
 - lib/weneedfeed/command.rb
 - lib/weneedfeed/controllers.rb
+- lib/weneedfeed/controllers/base.rb
 - lib/weneedfeed/controllers/show_feed.rb
 - lib/weneedfeed/controllers/show_top_page.rb
+- lib/weneedfeed/helpers.rb
+- lib/weneedfeed/helpers/parameters.rb
 - lib/weneedfeed/item.rb
 - lib/weneedfeed/page.rb
+- lib/weneedfeed/page_schema.rb
+- lib/weneedfeed/schema.rb
 - lib/weneedfeed/scraping.rb
 - lib/weneedfeed/version.rb
 - lib/weneedfeed/views.rb
@@ -142,5 +147,5 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: Generate feeds from URL and XPath.
+summary: Generate feeds from URL and selectors.
 test_files: []