weneedfeed 0.10.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f0099d83b69c32c84f244925370a77c7724874e287e9d55d105af0b5ab53df8
-  data.tar.gz: 39646f492c8b1accb725dab3ef96a9bb5ab77291e46182789fb75f2389cc0df9
+  metadata.gz: b15a14704cc5ed0eb9e73c0211aec07e3b196ff1fab56f042cbdfcf68071e8f0
+  data.tar.gz: 936bf427a0e666ecbd7cec9943f9961f89ce463358b6dca6472709bb05c86def
 SHA512:
-  metadata.gz: 50699fe2779917eb03e0d6845d884c26398312f7950252663dce13ac73d9f5356cbea1670ac84d39877692897711f393d1e8b55c5c3de5a9c7f8a514dd8a296c
-  data.tar.gz: 45cbe8c18b887791ccb7c3a83c35c841be13f95d4219bc16a31f8ae766a59880820291a091c3d0f58e97aba71e3ea766f4993948c063f6c18b812bf88560cfa9
+  metadata.gz: 1e839fe9a30af84216310c9abc1680d81bbfc2dbd74ab422a97ebc5365cc27dc67fcc6539fb41d5c137e27c0193feb38d1fe4988c36b343a177a8c89722c3480
+  data.tar.gz: 57180cb7901a7e91f5bcb73b2944aff645b355b76be66fb546cafb9b55940e7929d17e5095c94494c1c6a03e34c2c44483e5563bf4a454966e6629174e845540

data/.github/workflows/test.yml

@@ -4,7 +4,7 @@ on:
   pull_request:
   push:
     branches:
-      - master
+      - main
 
 jobs:
   rspec:

data/.rubocop.yml

@@ -1,4 +1,5 @@
 require:
+  - rubocop-rake
   - rubocop-rspec
 
 AllCops:

data/CHANGELOG.md

@@ -7,6 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 0.13.0 - 2022-04-14
+
+### Changed
+
+- Normalize item URLs.
+
+## 0.12.0 - 2022-04-14
+
+### Fixed
+
+- Handle incorrect URLs a little better.
+
+## 0.11.0 - 2022-04-13
+
+### Changed
+
+- Support invalid link URL and image URL.
+
 ## 0.10.0 - 2022-04-13
 
 ### Changed

data/Gemfile

@@ -9,5 +9,6 @@ gem 'rack-test'
 gem 'rake', '~> 12.0'
 gem 'rspec'
 gem 'rubocop'
+gem 'rubocop-rake'
 gem 'rubocop-rspec'
 gem 'webmock'

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    weneedfeed (0.10.0)
+    weneedfeed (0.13.0)
       activesupport
+      addressable
       builder
       faraday
       faraday_middleware
@@ -115,6 +116,8 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.17.0)
       parser (>= 3.1.1.0)
+    rubocop-rake (0.6.0)
+      rubocop (~> 1.0)
     rubocop-rspec (2.9.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
@@ -137,6 +140,7 @@ DEPENDENCIES
   rake (~> 12.0)
   rspec
   rubocop
+  rubocop-rake
   rubocop-rspec
   webmock
   weneedfeed!

data/lib/weneedfeed/faraday_response_middleware.rb

@@ -1,9 +1,8 @@
 # frozen_string_literal: true
 
-# For faraday_middleware/response_middleware.
+# To load ActiveSupport::IsolatedExecutionState on activesupport 7.
 # https://github.com/r7kamura/weneedfeed/issues/19
 require 'active_support'
-require 'active_support/isolated_execution_state' if ActiveSupport.gem_version >= Gem::Version.new('7')
 
 require 'active_support/core_ext/array/conversions'
 require 'active_support/core_ext/hash/conversions'

data/lib/weneedfeed/item.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
+require 'addressable'
 require 'marcel'
-require 'uri'
 
 module Weneedfeed
   class Item
@@ -74,18 +74,20 @@ module Weneedfeed
     def image_url
       return unless image_path_or_url
 
-      ::URI.join(
+      ::Addressable::URI.join(
         @url,
         image_path_or_url
-      ).to_s
+      ).normalize.to_s
     end
 
     # @return [String]
     def link
-      ::URI.join(
+      return unless link_path_or_url
+
+      ::Addressable::URI.join(
         @url,
         link_path_or_url
-      ).to_s
+      ).normalize.to_s
     end
 
     # @return [Nokogiri::Node, nil]
@@ -96,6 +98,8 @@ module Weneedfeed
     # @return [String, nil]
     def link_path_or_url
       node = link_node
+      return unless node
+
       node['href'] || node.inner_text
     end
 

data/lib/weneedfeed/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Weneedfeed
-  VERSION = '0.10.0'
+  VERSION = '0.13.0'
 end

data/weneedfeed.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'activesupport'
+  spec.add_runtime_dependency 'addressable'
   spec.add_runtime_dependency 'builder'
   spec.add_runtime_dependency 'faraday'
   spec.add_runtime_dependency 'faraday_middleware'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: weneedfeed
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.13.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-04-13 00:00:00.000000000 Z
+date: 2022-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement