welaika-suspenders 2.6.0 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: adc79e2386ca47469c4c8e485def10ae44d4156c
-  data.tar.gz: 187f6b410ce7741cd6728601967cf35fb325092d
+  metadata.gz: 1ecf4d405edda55de70fd1f180c267d59dfa9006
+  data.tar.gz: 645f248b78993bd9edaf7a0727769b8ad3377994
 SHA512:
-  metadata.gz: c4fa622f15fd26cf4918ba06d0591df4fc53e62cabd1b36c24a79ab913206d788969720394482096fa35580334f52b27bc5282a1c076bf8b631b69877eb4bac2
-  data.tar.gz: 3c61e25a858f9c75b3005c8d56ff195aaa039c8776932dd7732dad642f2c95b4571635dc773017e505240aca1fffcb4488d7f7f1cc1958e3a95d49705c9b2f1d
+  metadata.gz: 2a78896ad5dbcdb5dd16cf2ecf75dbf5e7aa9a0cb398c434fc4cca68fdf2f434cf71c74713666bf9100b98bc62eb71a90627835b973da0962646f4d7b737342b
+  data.tar.gz: 29f40fa844f103f2c0a2c0d49826049a23f5a405f0310df35656c26a3da7c1d9f160ed39ee8a6e3b6f7144c245df1bd99e2780f6c19d29724b2ac1537364fa76

data/CONTRIBUTING.md

@@ -1,7 +1,5 @@
 # Contributing
 
-We love pull requests. Here's a quick guide.
-
 Fork the repo:
 
     git clone git@github.com:thoughtbot/suspenders.git
@@ -14,23 +12,32 @@ Make sure the tests pass:
 
     rake
 
-Make your change. Add tests for your change. Make the tests pass:
+Make your change.
+Write tests.
+Follow our [style guide][style].
+Make the tests pass:
+
+[style]: https://github.com/thoughtbot/guides/tree/master/style
 
     rake
 
-Push to your fork and [submit a pull request][pr].
+Write a [good commit message][commit].
+Push to your fork.
+[Submit a pull request][pr].
 
+[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 [pr]: https://github.com/thoughtbot/suspenders/compare/
 
-At this point you're waiting on us. We like to at least comment on pull requests
-within three business days (and, typically, one business day). We may suggest
-some changes or improvements or alternatives.
+If [Hound] catches style violations,
+fix them.
 
-Some things that will increase the chance that your pull request is accepted:
+[hound]: https://houndci.com
 
-* Write tests.
-* Follow our [style guide][style].
-* Write a [good commit message][commit].
+Wait for us.
+We try to at least comment on pull requests within one business day.
+We may suggest changes.
 
-[style]: https://github.com/thoughtbot/guides/tree/master/style
-[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+## Versions
+
+To update the Ruby version,
+change `.ruby-version` and `.travis.yml`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    welaika-suspenders (2.6.0)
+    welaika-suspenders (2.7.0)
       bitters (~> 0.10.0)
       bundler (~> 1.3)
       rails (= 4.2.0)
@@ -53,7 +53,7 @@ GEM
       bourbon (>= 3.2)
       sass (>= 3.2)
       thor
-    bourbon (4.1.0)
+    bourbon (4.1.1)
       sass (~> 3.3)
       thor
     builder (3.2.2)
@@ -80,14 +80,14 @@ GEM
       activesupport (>= 4.1.0)
     hike (1.2.3)
     i18n (0.7.0)
-    json (1.8.1)
+    json (1.8.2)
     loofah (2.0.1)
       nokogiri (>= 1.5.9)
     mail (2.6.3)
       mime-types (>= 1.16, < 3)
     mime-types (2.4.3)
     mini_portile (0.6.0)
-    minitest (5.5.0)
+    minitest (5.5.1)
     multi_json (1.10.1)
     multi_test (0.1.1)
     nokogiri (1.6.2.1)
@@ -128,13 +128,13 @@ GEM
     rspec-expectations (2.99.0)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.99.0)
-    sass (3.4.9)
+    sass (3.4.11)
     sprockets (2.12.3)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.2)
+    sprockets-rails (2.2.4)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (>= 2.8, < 4.0)

data/NEWS.md

@@ -1,3 +1,24 @@
+1.24.0 (February 3, 2015)
+
+* Remove things in Suspenders that Rails does for us now.
+* Document how to use the `title` view helper.
+* Improve speed of bundling in `bin/setup` script.
+* Set ENV variable to make out-of-the-box Heroku static asset experience better.
+
+1.23.0 (January 19, 2015)
+
+* Use Bourbon 4.1.0.
+* Use Neat 1.7.0.
+* Remove [parameter wrapping] for every format, including JSON.
+* Turn off TravisCI email notifications for Suspended apps.
+* Run `rake dev:prime` on CI in order to test
+  whether `bin/setup` has any regressions.
+* Fix `config.action_mailer.default_url_options`'s value.
+  It now correctly uses `ENV.fetch("HOST")` in staging
+  and production.
+
+[parameter wrapping]: http://api.rubyonrails.org/classes/ActionController/ParamsWrapper.html
+
 1.22.0 (January 11, 2015)
 
 * Allow additional

data/README.md

@@ -64,3 +64,4 @@ List of changes we made since [this is commit](https://github.com/thoughtbot/sus
 - create common folders like `app/queries`, `app/services`, etc.
 - use `application.css.sass` instead of `application.css.scss`
 - do not import refills/flashes
+- add `quiet_assets` gem

data/lib/suspenders/actions.rb

@@ -10,8 +10,8 @@ module Suspenders
     end
 
     def action_mailer_host(rails_env, host)
-      host_config = "config.action_mailer.default_url_options = { host: '#{host}' }"
-      configure_environment(rails_env, host_config)
+      config = "config.action_mailer.default_url_options = { host: #{host} }"
+      configure_environment(rails_env, config)
     end
 
     def configure_environment(rails_env, config)

data/lib/suspenders/app_builder.rb

@@ -107,7 +107,7 @@ module Suspenders
 
       inject_into_file(
         "config/environments/production.rb",
-        'config.static_cache_control = "public, max-age=#{1.year.to_i}"',
+        '  config.static_cache_control = "public, max-age=#{1.year.to_i}"',
         after: serve_static_files_line
       )
     end
@@ -130,6 +130,10 @@ end
       template 'secrets.yml', 'config/secrets.yml', force: true
     end
 
+    def disallow_wrapping_parameters
+      remove_file "config/initializers/wrap_parameters.rb"
+    end
+
     def create_partials_directory
       empty_directory 'app/views/application'
     end
@@ -149,12 +153,6 @@ end
         force: true
     end
 
-    def remove_turbolinks
-      replace_in_file 'app/assets/javascripts/application.js',
-        /\/\/= require turbolinks\n/,
-        ''
-    end
-
     def use_postgres_config_template
       template 'postgresql_database.yml.erb', 'config/database.yml',
         force: true
@@ -228,19 +226,6 @@ end
       copy_file 'action_mailer.rb', 'spec/support/action_mailer.rb'
     end
 
-    def configure_time_zone
-      config = <<-RUBY
-    config.active_record.default_timezone = :utc
-      RUBY
-
-      inject_into_class 'config/application.rb', 'Application', config
-    end
-
-    def configure_time_formats
-      remove_file "config/locales/en.yml"
-      template "config_locales_en.yml.erb", "config/locales/en.yml"
-    end
-
     def configure_rack_timeout
       copy_file 'rack_timeout.rb', 'config/initializers/rack_timeout.rb'
     end
@@ -254,8 +239,8 @@ end
     end
 
     def configure_action_mailer
-      action_mailer_host "development", "localhost:#{port}"
-      action_mailer_host "test", "www.example.com"
+      action_mailer_host "development", %{"localhost:#{port}"}
+      action_mailer_host "test", %{"www.example.com"}
       action_mailer_host "staging", %{ENV.fetch("HOST")}
       action_mailer_host "production", %{ENV.fetch("HOST")}
     end
@@ -329,9 +314,13 @@ end
     end
 
     def create_heroku_apps(flags)
+      rack_env = "RACK_ENV=staging RAILS_ENV=staging"
+      rails_serve_static_files = "RAILS_SERVE_STATIC_FILES=true"
+      staging_config = "#{rack_env} #{rails_serve_static_files}"
       run_heroku "create #{app_name}-production #{flags}", "production"
       run_heroku "create #{app_name}-staging #{flags}", "staging"
-      run_heroku "config:add RACK_ENV=staging RAILS_ENV=staging", "staging"
+      run_heroku "config:add #{staging_config}", "staging"
+      run_heroku "config:add #{rails_serve_static_files}", "production"
     end
 
     def set_heroku_remotes
@@ -373,6 +362,7 @@ fi
       copy_file "bin_deploy", "bin/deploy"
 
       instructions = <<-MARKDOWN
+
 ## Deploying
 
 If you have previously run the `./bin/setup` script,
@@ -459,10 +449,6 @@ end
       run "#{path_addition} heroku #{command} --remote #{environment}"
     end
 
-    def factories_spec_rake_task
-      IO.read find_in_source_paths('factories_spec_rake_task.rb')
-    end
-
     def generate_secret
       SecureRandom.hex(64)
     end

data/lib/suspenders/generators/app_generator.rb

@@ -18,6 +18,9 @@ module Suspenders
     class_option :skip_test_unit, type: :boolean, aliases: "-T", default: true,
       desc: "Skip Test::Unit files"
 
+    class_option :skip_turbolinks, type: :boolean, default: true,
+      desc: "Skip turbolinks gem"
+
     def finish_template
       invoke :suspenders_customization
       super
@@ -31,7 +34,6 @@ module Suspenders
       invoke :setup_staging_environment
       invoke :setup_secret_token
       invoke :create_suspenders_views
-      invoke :setup_coffeescript
       invoke :configure_app
       invoke :setup_stylesheets
       invoke :install_bitters
@@ -119,16 +121,9 @@ module Suspenders
       build :create_application_layout
     end
 
-    def setup_coffeescript
-      say 'Setting up CoffeeScript defaults'
-      build :remove_turbolinks
-    end
-
     def configure_app
       say 'Configuring app'
       build :configure_action_mailer
-      build :configure_time_zone
-      build :configure_time_formats
       build :configure_rack_timeout
       build :configure_simple_form
       build :configure_slim

data/lib/suspenders/version.rb

@@ -1,5 +1,5 @@
 module Suspenders
   RAILS_VERSION = "4.2.0"
   RUBY_VERSION = IO.read("#{File.dirname(__FILE__)}/../../.ruby-version").strip
-  VERSION = "2.6.0"
+  VERSION = "2.7.0"
 end

data/templates/Gemfile.erb

@@ -28,6 +28,7 @@ gem "unicorn"
 
 group :development do
   gem "letter_opener"
+  gem "quiet_assets"
   gem "spring"
   gem "spring-commands-rspec"
   gem "web-console"

data/templates/bin_setup.erb

@@ -7,8 +7,8 @@
 set -e
 
 # Set up Ruby dependencies via Bundler
-gem list bundler --installed > /dev/null || gem install bundler
-bundle install
+gem install bundler --conservative
+bundle check || bundle install
 
 # Set up configurable environment variables
 if [ ! -f .env ]; then

data/templates/development_seeds.rb

@@ -1,4 +1,4 @@
-if Rails.env.development?
+if Rails.env.development? || Rails.env.test?
   require "factory_girl"
 
   namespace :dev do

data/templates/suspenders_gitignore

@@ -9,5 +9,6 @@
 /db/*.sqlite3
 /log/*
 /public/system
+/public/assets
 /tags
 /tmp/*

data/templates/suspenders_layout.html.slim

@@ -5,6 +5,11 @@ html
     meta http-equiv="X-UA-Compatible" content="IE=edge"
     meta name="ROBOTS" content="NOODP"
     meta name="viewport" content="width=device-width, initial-scale=1"
+
+    / Configure default and controller-, and view-specific titles in
+      config/locales/en.yml. For more see:
+      https://github.com/calebthompson/title#usage
+
     title= title
     = stylesheet_link_tag :application, media: 'all'
     = csrf_meta_tags

data/templates/travis.yml.erb

@@ -13,8 +13,7 @@ cache:
 language:
   - ruby
 notifications:
-  email:
-    - false
+  email: false
 rvm:
   - <%= Suspenders::RUBY_VERSION %>
 addons:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: welaika-suspenders
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 2.7.0
 platform: ruby
 authors:
 - thoughtbot
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-13 00:00:00.000000000 Z
+date: 2015-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bitters
@@ -166,7 +166,6 @@ files:
 - templates/bin_setup.erb
 - templates/bundler_audit.rake
 - templates/config_i18n_tasks.yml
-- templates/config_locales_en.yml.erb
 - templates/database_cleaner_rspec.rb
 - templates/development_seeds.rb
 - templates/disable_xml_params.rb

data/templates/config_locales_en.yml.erb

@@ -1,19 +0,0 @@
-en:
-  date:
-    formats:
-      default:
-        "%m/%d/%Y"
-      with_weekday:
-        "%a %m/%d/%y"
-
-  time:
-    formats:
-      default:
-        "%a, %b %-d, %Y at %r"
-      date:
-        "%b %-d, %Y"
-      short:
-        "%B %d"
-
-  titles:
-    application: <%= app_name.humanize %>