welaika-suspenders 2.31.0 → 2.32.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 481695d6f96c668275a33508d56f895dc39e4db46449ef9ab2c9a033660ecef4
-  data.tar.gz: 25c5807eec92e54601a670a33909230c9152fd41adaf7bce883cdaf71be17308
+  metadata.gz: fa410fcc07994007373f8540720d69b677a4c99a93d4e7a7ddcfa6a6cc0164d1
+  data.tar.gz: 5882a69046c98bed5863298d97b6b53787320fbf13c41ecb206de269744c22c1
 SHA512:
-  metadata.gz: 85bfef921287615e993923e897ba6e19228fc866bd8481678e56fef63794ce395c3672eb29645671ca20464f3b4861b42e51d448d691cfa377717f66ac4160fc
-  data.tar.gz: 9f01d5156c6515a5d5a30215228953c36015ca73dc13f71a79ebd4602c966ec0b3abe63b64feab78f187f990e0dea152481d773c20e87a83a86c485ca4216a20
+  metadata.gz: 42f5419c01bd320331fc8f064dab72da935e02c1414b5bd8ebca046b2717062644f552be248e7298164a4aa9d6304be571c60edda4fa7f4ed1a874998ca6969e
+  data.tar.gz: c4389e82bec8f413934f1c0c5a7ba7fc79d3ed39438e0666228d126179c5fe571a32836646b6c3f22d92249bb85eac01f27c415b33e834d17760f16366060a75

data/.ruby-version

@@ -1 +1 @@
-2.6.2
+2.6.3

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
-rvm: 2.6.2
+rvm: 2.6.3
 cache: bundler
 sudo: false
 before_install:

data/CHANGELOG_WELAIKA.md

@@ -0,0 +1,9 @@
+2.32.0 (June 24, 2019)
+* Changed: introduced this file (`CHANGELOG_WELAIKA`) to tracks changes. The original file from thoughtbot is called `NEWS.MD`.
+* Feature: linter for sass files ([stylelint](https://stylelint.io/)). Defaults are almost the same as thoughtbot. I edited some rules to support sass syntax, but probably we will need more tweaks. Voluteers?
+* Change: use system tests instead of feature tests. Rspec now suggests you to use system tests instead of features tests because 1) they are build in in Rails 2) they share the same database connection so we don't need `database_cleaner` anymore. Create system tests in `spec/system`, that's it!
+* Change: reintroduced `autoprefixer-rails`. I removed it some weeks ago because I had problems deploying a rails app with in on Heroku. I don't know if anything changed, but I would like to give it a second chance :)
+* Change: rubocop is not splitted in several gems
+* Feature: use a custom docker image for gitlab.ci. We experimented this already in a couple of projects. We use a docker image so we can install node, yarn and chrome once for all.
+* Change: removed the CI configuration for a remote selenium webdriver. We don't need it anymore. Some old projects still uses it, but newer ones will just use headless Chrome and a custom docker image.
+* Change: use bundler 2 now that Heroku supports it https://devcenter.heroku.com/articles/ruby-support#libraries

data/NEWS.md

@@ -1,3 +1,16 @@
+1.52.0 (June 7, 2019)
+* Changed: Setup system tests instead of feature specs
+* Upgraded: Rails 5.2.3
+
+1.51.0 (April 26, 2019)
+
+* Changed: from sass-rails to sassc-rails.
+* Upgraded: Ruby 2.6.3.
+* Fixed: Avoid installing autoprefixer-rails in api mode
+* New generator: `suspenders:stylelint` for setting up stylelint.
+* New generator: `suspenders:production:manifest` for app.json.
+* New generator: `suspenders:production:deployment` for bin/deploy script.
+
 1.50.0 (December 28, 2018)
 
 * Removed: jquery-rails.

data/lib/suspenders/app_builder.rb

@@ -237,6 +237,7 @@ config.public_file_server.headers = {
     end
 
     def copy_miscellaneous_files
+      copy_file "browserslist", "browserslist"
       copy_file "errors.rb", "config/initializers/errors.rb"
       copy_file "json_encoding.rb", "config/initializers/json_encoding.rb"
     end

data/lib/suspenders/generators/app_generator.rb

@@ -163,6 +163,7 @@ module Suspenders
       generate("suspenders:db_optimizations")
       generate("suspenders:factories")
       generate("suspenders:lint")
+      generate("suspenders:stylelint")
       generate("suspenders:views")
       generate("suspenders:decorator")
       generate("suspenders:faker")

data/lib/suspenders/generators/ci_generator.rb

@@ -4,7 +4,9 @@ module Suspenders
   class CiGenerator < Generators::Base
     def configure_ci
       template 'gitlab-ci.yml.erb', '.gitlab-ci.yml'
+      template 'Dockerfile.gitlab.erb', 'Dockerfile.gitlab'
       copy_file 'database.gitlab.yml', 'config/database.gitlab.yml'
+      copy_file 'dockerignore', '.dockerignore'
     end
   end
 end

data/lib/suspenders/generators/js_driver_generator.rb

@@ -5,11 +5,16 @@ module Suspenders
     def add_gems
       gem 'capybara', '>= 2.15', '< 4.0', group: :test
       gem 'selenium-webdriver', group: :test
+      gem 'webdrivers', '~> 4.0', group: :test
       Bundler.with_clean_env { run "bundle install" }
     end
 
-    def configure_chromedriver
+    def configure_capybara
       copy_file "chromedriver.rb", "spec/support/chromedriver.rb"
+      copy_file(
+        "capybara_silence_puma.rb",
+        "spec/support/capybara_silence_puma.rb",
+      )
     end
   end
 end

data/lib/suspenders/generators/lint_generator.rb

@@ -3,12 +3,17 @@ require_relative "base"
 module Suspenders
   class LintGenerator < Generators::Base
     def add_linters_gems
-      gem 'rubocop', require: false, group: :development
+      gem 'rubocop', '~> 0.71.0', require: false, group: :development
+      gem 'rubocop-performance', require: false, group: :development
+      gem 'rubocop-rails', require: false, group: :development
       gem 'rubocop-rspec', require: false, group: :development
       gem 'slim_lint', require: false, group: :development
-      gem 'overcommit', require: false, group: :development
+      gem 'overcommit', '>= 0.48.1', require: false, group: :development
       gem 'rubycritic', require: false, group: :development
-      Bundler.with_clean_env { run "bundle install" }
+
+      # FIXME: switch back to bundle install once https://github.com/sds/overcommit/pull/649
+      # will be merged
+      Bundler.with_clean_env { run "bundle update" }
     end
 
     def setup_rubocop

data/lib/suspenders/generators/stylelint_generator.rb

@@ -0,0 +1,37 @@
+require_relative "base"
+
+module Suspenders
+  class StylelintGenerator < Generators::Base
+    def install_stylelint
+      dependencies = ["stylelint",
+                      "stylelint-config-recommended",
+                      "stylelint-order",
+                      "stylelint-declaration-block-no-ignored-properties",
+                      "stylelint-scss"]
+      action YarnInstall.new(self, dependencies, "--dev")
+    end
+
+    def copy_stylelint_config
+      copy_file "stylelintrc.json", ".stylelintrc.json"
+    end
+
+    class YarnInstall
+      def initialize(base, dependencies, flags)
+        @base = base
+        @dependencies = dependencies.join(" ")
+        @flags = flags
+      end
+
+      def invoke!
+        @base.run "bin/yarn add #{@dependencies} #{@flags}"
+      end
+
+      def revoke!
+        @base.behavior = :invoke
+        @base.run "bin/yarn remove #{@dependencies}"
+      ensure
+        @base.behavior = :revoke
+      end
+    end
+  end
+end

data/lib/suspenders/generators/testing_generator.rb

@@ -27,8 +27,9 @@ module Suspenders
       )
     end
 
-    def configure_spec_support_features
+    def configure_system_tests
       empty_directory_with_keep_file "spec/system"
+      empty_directory_with_keep_file "spec/support/system"
     end
 
     def configure_i18n_for_test_environment

data/lib/suspenders/version.rb

@@ -1,9 +1,9 @@
 module Suspenders
-  RAILS_VERSION = "~> 5.2.2".freeze
+  RAILS_VERSION = "~> 5.2.3".freeze
   POSTGRES_VERSION = "10.6".freeze # Used in CI
   RUBY_VERSION = IO.
     read("#{File.dirname(__FILE__)}/../../.ruby-version").
     strip.
     freeze
-  VERSION = "2.31.0".freeze
+  VERSION = "2.32.0".freeze
 end

data/lib/suspenders.rb

@@ -2,6 +2,7 @@ require "suspenders/version"
 require "suspenders/generators/app_generator"
 require "suspenders/generators/static_generator"
 require "suspenders/generators/stylesheet_base_generator"
+require "suspenders/generators/stylelint_generator"
 require "suspenders/generators/ci_generator"
 require "suspenders/generators/db_optimizations_generator"
 require "suspenders/generators/factories_generator"

data/spec/features/stylelint_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+
+RSpec.describe "suspenders:stylelint", type: :generator do
+  context "generate" do
+    it "creates .stylelintrc.json" do
+      with_app { generate("suspenders:stylelint") }
+
+      expect(".stylelintrc.json").to exist_as_a_file
+    end
+
+    it "adds stylelint to the package.json" do
+      with_app { generate("suspenders:stylelint") }
+
+      expect("package.json").to match_contents(/devDependencies/)
+      expect("package.json").to match_contents(/stylelint/)
+    end
+  end
+
+  context "destroy" do
+    it "removes .stylelintrc.json" do
+      with_app do
+        generate("suspenders:stylelint")
+        destroy("suspenders:stylelint")
+      end
+
+      expect(".stylelintrc.json").not_to exist_as_a_file
+    end
+
+    it "removes stylelint from package.json" do
+      with_app do
+        generate("suspenders:stylelint")
+        destroy("suspenders:stylelint")
+      end
+
+      expect("package.json").not_to match_contents(/stylelint/)
+    end
+  end
+end

data/suspenders.gemspec

@@ -27,6 +27,7 @@ weLaika's fork of the famous thoughbot suspenders gem.
   s.version = Suspenders::VERSION
 
   s.add_dependency 'rails', Suspenders::RAILS_VERSION
+  s.add_dependency 'bundler', '>=2'
 
   s.add_development_dependency 'rspec', '~> 3.8'
   s.add_development_dependency 'pry-byebug', '~> 3.6'

data/templates/Dockerfile.gitlab.erb

@@ -0,0 +1,56 @@
+FROM ruby:<%= Suspenders::RUBY_VERSION %>
+
+LABEL maintainer="fabrizio.monti@welaika.com"
+
+# https://github.com/hadolint/hadolint/wiki/DL4006
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3008
+RUN apt-get update \
+    && apt-get install -y --no-install-recommends locales \
+    && localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8 \
+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+ENV LANG en_US.utf8
+
+# install project specific apt packages
+# hadolint ignore=DL3008
+RUN apt-get update \
+    && apt-get install -y --no-install-recommends imagemagick \
+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+# install nodejs
+# hadolint ignore=DL3008
+RUN curl -sSL https://deb.nodesource.com/setup_10.x | bash - \
+    && apt-get update \
+    && apt-get install -y --no-install-recommends nodejs \
+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+# install yarn
+# hadolint ignore=DL3008
+RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
+    && echo "deb https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list \
+    && apt-get update \
+    && apt-get install -y --no-install-recommends yarn \
+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+# install chrome
+# `dpkg -i` and `apt-get -f` must be different bash commands, so we must use `;` instead of `&&` chain
+RUN curl -sS -O https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb \
+    && dpkg -i google-chrome-stable_current_amd64.deb; \
+    apt-get update \
+    && apt-get -y --fix-broken --no-install-recommends install \
+    && rm google-chrome-stable_current_amd64.deb \
+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN gem install bundler --version '>= 2' \
+    && bundle config git.allow_insecure true \
+    && bundle config silence_root_warning true \
+    && bundle config jobs "$(nproc)"
+
+CMD ["irb"]

data/templates/Gemfile.erb

@@ -9,7 +9,10 @@ end
 
 ruby '<%= Suspenders::RUBY_VERSION %>'
 
-gem 'active_interaction', '~> 3.6'
+gem 'active_interaction', '~> 3.7'
+<% unless options[:api] %>
+gem 'autoprefixer-rails'
+<% end %>
 gem 'bootsnap', '>= 1.1.0', require: false
 gem 'coffee-rails', '~> 4.2'
 gem 'email_validator'

data/templates/README.md.erb

@@ -2,15 +2,7 @@
 
 ## Getting Started
 
-After you have cloned this repo, run this setup script to set up your machine
-with the necessary dependencies to run and test this app:
-
-    % ./bin/setup
-
-It assumes you have a machine equipped with Ruby, Postgres or MySQL, Node, Yarn and ImageMagick.
-
 To install Ruby, read the [rbenv guide](https://github.com/rbenv/rbenv#installation)
-or the [rvm guide](https://rvm.io/rvm/install).
 
 To install Postgres:
 
@@ -30,18 +22,22 @@ To install Yarn:
 
     $ brew install yarn
 
-To install Chromedriver (for integration test):
-
-    $ brew cask install chromedriver
-
 To install ImageMagick (delete if not applicable):
 
     $ brew install imagemagick@6
 
-After setting up, you can run the application using [Heroku Local](https://devcenter.heroku.com/articles/heroku-local):
+Now, clone this repo and you are ready to run the setup script:
+
+    % ./bin/setup
+
+You can run the application using [Heroku Local](https://devcenter.heroku.com/articles/heroku-local):
 
     $ heroku local
 
+Run the quality checks and the tests suite:
+
+    $ rake
+
 ## Setup on Heroku (delete if not applicable):
 
 ### Database
@@ -81,3 +77,19 @@ For Sentry's release detection to work correctly, please run
 https://elements.heroku.com/addons/heroku-redis
 
     $ heroku addons:create heroku-redis:hobby-dev
+
+## Gitlab Docker Image
+
+We use a customer Docker image for our gitlab CI.
+
+You can read more about submitting a new image version [here](https://gitlab.com/welaika/<%= app_name %>/container_registry).
+
+Since our `Dockerfile` is called `Dockerfile.gitlab`, the commands are slightly different:
+
+
+```bash
+$ docker build -f Dockerfile.gitlab -t registry.gitlab.com/welaika/<%= app_name %> .
+$ docker push registry.gitlab.com/welaika/<%= app_name %>
+```
+
+Eventually, you can lint Dockerfiles with [hadolint](https://github.com/hadolint/hadolint)

data/templates/browserslist

@@ -0,0 +1 @@
+Last 2 versions

data/templates/capybara_silence_puma.rb

@@ -0,0 +1 @@
+Capybara.server = :puma, { Silent: true }

data/templates/chromedriver.rb

@@ -1,10 +1,19 @@
 # frozen_string_literal: true
 
+require 'webdrivers'
 require 'selenium/webdriver'
 
-Capybara.server = :puma, { Silent: true }
+Capybara.register_driver :chrome do |app|
+  Capybara::Selenium::Driver.new(app, browser: :chrome)
+end
 
 Capybara.register_driver :headless_chrome do |app|
+  options = ::Selenium::WebDriver::Chrome::Options.new
+  options.headless!
+  # Set a big (15" MBP retina resolution) window size so that
+  # `save_and_open_screenshot` captures the whole page.
+  options.add_argument "--window-size=1680,1050"
+
   capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
     chromeOptions: { args: %w[headless disable-gpu] }
   )
@@ -12,31 +21,17 @@ Capybara.register_driver :headless_chrome do |app|
   Capybara::Selenium::Driver.new(
     app,
     browser: :chrome,
+    options: options,
     desired_capabilities: capabilities
   )
 end
 
+# NOTE: here for backwards compatibility, we should use system tests
+# instead now (`driven_by :headless_chrome`)
+Capybara.javascript_driver = :headless_chrome
+
 RSpec.configure do |config|
   config.before(:each, type: :system) do
-    if ENV['SELENIUM_REMOTE_URL'].present?
-      # Make the test app listen to outside requests, for the remote Selenium instance.
-      Capybara.server_host = '0.0.0.0'
-
-      # Specify the driver
-      driven_by :selenium, using: :chrome, screen_size: [1400, 2000],
-                           options: { url: ENV['SELENIUM_REMOTE_URL'] }
-
-      # Get the rails application IP
-      rails_ip = Socket.ip_address_list.find(&:ipv4_private?).ip_address
-
-      # Set the rails application Port (choose what you want)
-      Capybara.server_port = 3001
-
-      # Use the IP instead of localhost so Capybara knows where to direct Selenium
-      host! "http://#{rails_ip}:#{Capybara.server_port}"
-    else
-      # Otherwise, use the local machine's chromedriver
-      driven_by :headless_chrome
-    end
+    driven_by :headless_chrome
   end
 end

data/templates/dockerignore

@@ -0,0 +1,28 @@
+# Git
+/.git
+/.gitignore
+
+# Editor temp files
+*.swp *.swo
+
+# Logs
+/log/*
+
+# Dumps
+/*.sql.gz
+/latest.dump
+
+# Temp files
+/tmp/*
+
+# Node
+/node_modules/*
+
+# Uploads
+/public/system/*
+/public/uploads/*
+/storage/*
+/uploads/*
+
+# Test
+/coverage/*

data/templates/gitlab-ci.yml.erb

@@ -1,4 +1,4 @@
-image: ruby:<%= Suspenders::RUBY_VERSION %>
+image: registry.gitlab.com/welaika/<%= app_name %>
 
 variables:
   GET_SOURCES_ATTEMPTS: 3
@@ -7,7 +7,6 @@ variables:
   POSTGRES_DB: rails_app_test
   POSTGRES_USER: root
   POSTGRES_PASSWORD: ''
-  SELENIUM_REMOTE_URL: "http://selenium__standalone-chrome:4444/wd/hub/"
 
 .job-creation-policy: &job-creation-policy
   only:
@@ -18,7 +17,6 @@ variables:
 
 .services: &rails-services
   - postgres:<%= Suspenders::POSTGRES_VERSION %>
-  - selenium/standalone-chrome:latest
 
 .cache: &cache-settings
   key: "$CI_COMMIT_REF_SLUG"
@@ -50,6 +48,14 @@ quality:rubocop:
     - bundle check --path vendor/bundle
     - bundle exec rubocop
 
+quality:stylelint:
+  <<: *job-creation-policy
+  stage: quality
+  cache:
+    <<: *cache-settings
+  script:
+    - npx stylelint app/assets/stylesheets
+
 quality:slim_lint:
   <<: *job-creation-policy
   stage: quality
@@ -93,15 +99,6 @@ test:rspec:
   cache:
     <<: *cache-settings
   script:
-    # Install node
-    - curl -sL https://deb.nodesource.com/setup_10.x | bash -
-    - apt-get install -qq nodejs
-
-    # Install yarn
-    - curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
-    - echo "deb https://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list
-    - apt-get update -qq && apt-get install -qq yarn
-
     # Verify node and yarn versions
     - node --version
     - yarn --version

data/templates/overcommit.yml

@@ -12,3 +12,12 @@ PreCommit:
     enabled: true
     on_warn: fail # Treat all warnings as failures
     command: ['bundle', 'exec', 'slim-lint'] # Invoke within Bundler context
+
+  Stylelint:
+    enabled: true
+    description: 'Check styles with Stylelint'
+    command: ['npx', 'stylelint']
+    include:
+      - '**/*.scss'
+      - '**/*.sass'
+      - '**/*.css'

data/templates/rakefile_template.rb

@@ -11,6 +11,7 @@ task(:default).clear
 desc 'Run linters, quality, security and tests'
 task :default do
   sh 'bundle exec rubocop'
+  sh 'npx stylelint app/assets/stylesheets'
   sh 'bundle exec slim-lint app/views/'
   sh 'bundle exec rubycritic app/ config/ lib/ --no-browser --minimum-score 94 --format console'
   sh 'bundle exec bundle-audit check --update'

data/templates/rubocop.yml

@@ -1,4 +1,7 @@
-require: rubocop-rspec
+require:
+  - rubocop-rspec
+  - rubocop-performance
+  - rubocop-rails
 inherit_from: .rubocop_todo.yml
 
 AllCops:

data/templates/spec_helper.rb

@@ -38,7 +38,9 @@ RSpec.configure do |config|
   Kernel.srand config.seed
 end
 
-WebMock.disable_net_connect!(allow_localhost: true)
+WebMock.disable_net_connect!(
+  allow_localhost: true, allow: %w[chromedriver.storage.googleapis.com]
+)
 
 # Only allow Timecop with block syntax
 Timecop.safe_mode = true

data/templates/stylelintrc.json

@@ -0,0 +1,83 @@
+{
+  "extends": "stylelint-config-recommended",
+  "plugins": [
+    "stylelint-declaration-block-no-ignored-properties",
+    "stylelint-order",
+    "stylelint-scss"
+  ],
+  "rules": {
+    "at-rule-no-unknown": null,
+    "block-closing-brace-empty-line-before": null,
+    "block-closing-brace-newline-before": null,
+    "block-opening-brace-newline-after": null,
+    "block-opening-brace-space-before": null,
+    "color-hex-case": "lower",
+    "color-hex-length": "short",
+    "color-named": "never",
+    "comment-whitespace-inside": "always",
+    "declaration-bang-space-after": "never",
+    "declaration-bang-space-before": "always",
+    "declaration-block-semicolon-newline-after": null,
+    "declaration-block-trailing-semicolon": null,
+    "declaration-colon-space-after": "always-single-line",
+    "declaration-colon-space-before": "never",
+    "declaration-no-important": true,
+    "declaration-property-unit-whitelist": {
+      "line-height": []
+    },
+    "declaration-property-value-blacklist": {
+      "/^transition/": ["/all/"]
+    },
+    "function-calc-no-invalid": true,
+    "function-comma-space-after": "always-single-line",
+    "function-comma-space-before": "never",
+    "function-parentheses-space-inside": "never-single-line",
+    "function-url-quotes": "always",
+    "indentation": 2,
+    "length-zero-no-unit": true,
+    "max-nesting-depth": 3,
+    "no-eol-whitespace": true,
+    "no-missing-end-of-source-newline": true,
+    "number-leading-zero": "always",
+    "number-no-trailing-zeros": true,
+    "order/properties-alphabetical-order": true,
+    "plugin/declaration-block-no-ignored-properties": true,
+    "property-no-vendor-prefix": true,
+    "rule-empty-line-before": [
+      "always",
+      {
+        "except": [
+          "first-nested"
+        ],
+        "ignore": [
+          "after-comment"
+        ]
+      }
+    ],
+    "scss/at-extend-no-missing-placeholder": true,
+    "scss/at-import-no-partial-leading-underscore": true,
+    "scss/at-import-partial-extension-blacklist": ["scss"],
+    "scss/at-rule-no-unknown": true,
+    "scss/dollar-variable-colon-space-after": "always",
+    "scss/dollar-variable-colon-space-before": "never",
+    "scss/no-duplicate-dollar-variables": true,
+    "scss/operator-no-unspaced": true,
+    "scss/selector-no-redundant-nesting-selector": true,
+    "selector-list-comma-newline-after": "always",
+    "selector-max-id": 0,
+    "selector-nested-pattern": [
+      "^(?!&__|&--|&-|&_).*", {
+        "message": "Don't concatenate selectors using Sass's parent selector (`&`)."
+      }
+    ],
+    "selector-no-qualifying-type": true,
+    "selector-no-vendor-prefix": true,
+    "selector-pseudo-class-case": "lower",
+    "selector-pseudo-element-case": "lower",
+    "selector-pseudo-element-colon-notation": "double",
+    "selector-type-case": "lower",
+    "shorthand-property-no-redundant-values": true,
+    "string-quotes": "double",
+    "value-no-vendor-prefix": true
+  }
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: welaika-suspenders
 version: !ruby/object:Gem::Version
-  version: 2.31.0
+  version: 2.32.0
 platform: ruby
 authors:
 - thoughtbot
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-26 00:00:00.000000000 Z
+date: 2019-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -17,14 +17,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 5.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.2
+        version: 5.2.3
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -82,6 +96,7 @@ files:
 - ".rspec"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG_WELAIKA.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
@@ -119,6 +134,7 @@ files:
 - lib/suspenders/generators/security_generator.rb
 - lib/suspenders/generators/staging/pull_requests_generator.rb
 - lib/suspenders/generators/static_generator.rb
+- lib/suspenders/generators/stylelint_generator.rb
 - lib/suspenders/generators/stylesheet_base_generator.rb
 - lib/suspenders/generators/testing_generator.rb
 - lib/suspenders/generators/views_generator.rb
@@ -136,6 +152,7 @@ files:
 - spec/features/production/email_spec.rb
 - spec/features/production/manifest_spec.rb
 - spec/features/staging/pull_requests_spec.rb
+- spec/features/stylelint_spec.rb
 - spec/spec_helper.rb
 - spec/support/be_executable_matcher.rb
 - spec/support/contain_json_matcher.rb
@@ -146,6 +163,7 @@ files:
 - spec/support/project_files.rb
 - spec/support/suspenders.rb
 - suspenders.gemspec
+- templates/Dockerfile.gitlab.erb
 - templates/Gemfile.erb
 - templates/Procfile
 - templates/README.md.erb
@@ -158,10 +176,13 @@ files:
 - templates/bin_import_dump.erb
 - templates/bin_setup
 - templates/bin_setup_review_app.erb
+- templates/browserslist
+- templates/capybara_silence_puma.rb
 - templates/chromedriver.rb
 - templates/config_locales_it.yml.erb
 - templates/database.gitlab.yml
 - templates/dev.rake
+- templates/dockerignore
 - templates/dotfiles/.ctags
 - templates/dotfiles/.env
 - templates/email.rb
@@ -190,10 +211,9 @@ files:
 - templates/slim.rb
 - templates/smtp.rb
 - templates/spec_helper.rb
+- templates/stylelintrc.json
 - templates/suspenders_gitignore
 - templates/suspenders_layout.html.slim
-- todo.txt
-- todo_suspenders.md
 homepage: http://github.com/welaika/welaika-suspenders
 licenses:
 - MIT
@@ -207,7 +227,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.2
+      version: 2.6.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -231,6 +251,7 @@ test_files:
 - spec/features/production/email_spec.rb
 - spec/features/production/manifest_spec.rb
 - spec/features/staging/pull_requests_spec.rb
+- spec/features/stylelint_spec.rb
 - spec/spec_helper.rb
 - spec/support/be_executable_matcher.rb
 - spec/support/contain_json_matcher.rb

data/todo.txt

@@ -1,15 +0,0 @@
-# TODO
-configurare gitlab ci
-
-# DONE
-controllare che :sass e :coffee nei file slim funzionino in produzione
-rake file con rubocop, brakeman, bla bla
-controllare se ci sono altri linters da mettere
-aggiungere sentry
-aggiornare rspec
-configurare rubocop
-configurare overcommit
-aggiungere jquery ad application.js oppure rimuoverlo del tutto!
-
-# SKIPPED
-aggiungere sidekiq, oppure rimuovere delayed_job:w

data/todo_suspenders.md

@@ -1 +0,0 @@
-* aggiornare rspec-rails