welaika-suspenders 2.28.0 → 2.29.0.alpha.1

data/suspenders.gemspec

@@ -5,6 +5,7 @@ require 'date'
 
 Gem::Specification.new do |s|
   s.required_ruby_version = ">= #{Suspenders::RUBY_VERSION}"
+  s.required_rubygems_version = ">= 2.7.4"
   s.authors = ['thoughtbot', 'weLaika']
   s.date = Date.today.strftime('%Y-%m-%d')
 
@@ -25,8 +26,7 @@ weLaika's fork of the famous thoughbot suspenders gem.
   s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.version = Suspenders::VERSION
 
-  s.add_dependency 'bundler', '>= 1.8.4'
   s.add_dependency 'rails', Suspenders::RAILS_VERSION
 
-  s.add_development_dependency 'rspec', '~> 3.6'
+  s.add_development_dependency 'rspec', '~> 3.8'
 end

data/templates/Gemfile.erb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 git_source(:github) do |repo_name|
@@ -7,71 +9,46 @@ end
 
 ruby "<%= Suspenders::RUBY_VERSION %>"
 
-gem "bundler", ">= 1.8.4"
-
-gem "active_interaction", "~> 3.5"
-gem "airbrake"
+gem "active_interaction", "~> 3.6"
 gem "autoprefixer-rails"
 gem "coffee-rails", "~> 4.2"
-gem "delayed_job_active_record"
-gem "draper"
 gem "email_validator"
 gem "flutie"
-gem "pg"
-gem "puma", "~> 3.7"
+gem "jquery-rails" #TODO keep  it?
+gem "pg", ">= 0.18", "< 2.0"
+gem "puma", "~> 3.11"
 gem "rack-canonical-host"
 gem "rails", "<%= Suspenders::RAILS_VERSION %>"
 gem "rails-i18n"
 gem "recipient_interceptor"
 gem "sass-rails", "~> 5.0"
-gem "simple_form"
-gem "skylight"
-gem "slim-rails"
 gem "title"
 gem "uglifier", ">= 1.3.0"
+gem "bootsnap", ">= 1.1.0", require: false
 <% if options[:webpack] %>
 gem "webpacker"
 <% end %>
-gem "welaika-suspenders"
 
 group :development do
   gem "letter_opener"
   gem "listen", ">= 3.0.5", "< 3.2"
   gem "rack-mini-profiler", require: false
   gem "spring"
-  gem "spring-commands-rspec"
-  gem "spring-watcher-listen", "~> 2.0.0"
   gem "web-console", ">= 3.3.0"
 end
 
 group :development, :test do
   gem "awesome_print"
-  gem "brakeman", require: false
-  gem "bullet"
-  gem "bundler-audit", ">= 0.5.0", require: false
   gem "dotenv-rails"
-  gem "factory_girl_rails"
-  gem "faker"
   gem "pry-byebug"
   gem "pry-rails"
-  gem "rspec-rails", "~> 3.6"
-  gem "rspec_junit_formatter"
-  gem "rubocop", require: false
-  gem "rubocop-rspec", require: false
-  gem "slim_lint", require: false
 end
 
 group :test do
-  gem "capybara"
-  gem "database_cleaner"
   gem "launchy"
-  gem "selenium-webdriver"
-  gem "shoulda-matchers"
   gem "simplecov", require: false
   gem "timecop"
   gem "webmock"
 end
 
-group :production do
-  gem "rack-timeout"
-end
+gem "welaika-suspenders", "~> <%= Suspenders::VERSION %>", group: [:development, :test]

data/templates/Procfile

@@ -1,2 +1,2 @@
 web: bundle exec puma -p $PORT -C ./config/puma.rb
-worker: bundle exec rails jobs:work
+# worker:

data/templates/_css_overrides.html.slim

@@ -0,0 +1,4 @@
+- if Rails.env.test?
+  sass:
+    *
+      transition-property: none !important

data/templates/_javascript.html.slim

@@ -3,6 +3,6 @@
 = yield :javascript
 
 - if Rails.env.test?
-  javascript:
-    $.fx.off = true;
-    $.ajaxSetup({ async: false });
+  coffee:
+    $.fx.off = true
+    $.ajaxSetup(async: false)

data/templates/action_mailer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.configure do |config|
   config.before do
     ActionMailer::Base.deliveries.clear

data/templates/app.json.erb

@@ -19,21 +19,6 @@
     },
     "SECRET_KEY_BASE":{
       "generator":"secret"
-    },
-    "SMTP_ADDRESS":{
-      "required":true
-    },
-    "SMTP_DOMAIN":{
-      "required":true
-    },
-    "SMTP_PASSWORD":{
-      "required":true
-    },
-    "SMTP_USERNAME":{
-      "required":true
-    },
-    "ERRBIT_API_KEY":{
-      "required":true
     }
   },
   "addons":[

data/templates/brakeman.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if Rails.env.development? || Rails.env.test?
   namespace :brakeman do
     desc 'Run Brakeman'

data/templates/bundler_audit.rake

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 if Rails.env.development? || Rails.env.test?
-  require "bundler/audit/task"
+  require 'bundler/audit/task'
   Bundler::Audit::Task.new
 end

data/templates/capybara_helpers.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CapybaraHelpers
+  def page!
+    save_and_open_page
+  end
+
+  def screenshot!
+    save_and_open_screenshot
+  end
+end
+
+RSpec.configure do |config|
+  config.include CapybaraHelpers, type: :feature
+end

data/templates/chromedriver.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require "selenium/webdriver"
+
+Capybara.register_driver :chrome do |app|
+  Capybara::Selenium::Driver.new(app, browser: :chrome)
+end
+
+Capybara.register_driver :headless_chrome do |app|
+  capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
+    chromeOptions: { args: %w(headless disable-gpu) },
+  )
+
+  Capybara::Selenium::Driver.new app,
+    browser: :chrome,
+    desired_capabilities: capabilities
+end
+
+Capybara.javascript_driver = :headless_chrome
+Capybara.asset_host = 'http://localhost:3000'

data/templates/dev.rake

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 if Rails.env.development? || Rails.env.test?
-  require 'factory_girl'
+  require 'factory_bot'
 
   namespace :dev do
     desc 'Sample data for local development environment'
     task prime: 'db:setup' do
-      include FactoryGirl::Syntax::Methods
+      include FactoryBot::Syntax::Methods
 
       # create(:user, email: 'user@example.com', password: 'password')
     end

data/templates/dotfiles/.env

@@ -11,4 +11,5 @@ SMTP_DOMAIN=example.com
 SMTP_PASSWORD=password
 SMTP_USERNAME=username
 WEB_CONCURRENCY=1
-ERRBIT_API_KEY=
+SENTRY_DSN=
+SENTRY_CURRENT_ENV=

data/templates/email.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+if ENV["EMAIL_RECIPIENTS"].present?
+  Mail.register_interceptor RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])
+end

data/templates/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "net/http"
 require "net/smtp"
 

data/templates/factory_bot_rspec.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+end

data/templates/faker_rspec.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 Faker::Config.locale = 'it'

data/templates/flashes_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FlashesHelper
   def user_facing_flashes
     flash.to_hash.slice('alert', 'error', 'notice', 'success')

data/templates/i18n.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.configure do |config|
   config.include ActionView::Helpers::TranslationHelper
 end

data/templates/json_encoding.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 ActiveSupport::JSON::Encoding.time_precision = 0

data/templates/puma.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server
 
 # The environment variable WEB_CONCURRENCY may be set to a default value based

data/templates/queries_helper_rspec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module QueriesHelper
   def log_queries!
     ActiveRecord::Base.logger = Logger.new(STDOUT)

data/templates/rack_mini_profiler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV["RACK_MINI_PROFILER"].to_i > 0
   require "rack-mini-profiler"
 

data/templates/rails_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ENV['RACK_ENV'] = 'test'
 
 require File.expand_path('../../config/environment', __FILE__)
@@ -7,13 +9,21 @@ require 'rspec/rails'
 
 Dir[Rails.root.join('spec', 'support', '**', '*.rb')].sort.each { |file| require file }
 
+begin
+  ActiveRecord::Migration.maintain_test_schema!
+rescue ActiveRecord::PendingMigrationError => e
+  puts e.to_s.strip
+  exit 1
+end
+
 RSpec.configure do |config|
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
   config.infer_base_class_for_anonymous_controllers = false
   config.infer_spec_type_from_file_location!
+  config.use_transactional_fixtures = true
 
   config.filter_rails_from_backtrace!
   # arbitrary gems may also be filtered via:
   # config.filter_gems_from_backtrace('gem name')
 end
 
-ActiveRecord::Migration.maintain_test_schema!

data/templates/rubocop.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if Rails.env.development? || Rails.env.test?
   require 'rubocop/rake_task'
 

data/templates/rubocop.yml

@@ -2,7 +2,7 @@ require: rubocop-rspec
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.4
+  DisplayCopNames: true
   Exclude:
     - 'bin/*'
     - 'config/**/*'
@@ -10,16 +10,9 @@ AllCops:
     - 'tmp/**/*'
     - 'vendor/**/*'
 
-Layout/TrailingBlankLines:
-  Exclude:
-    - "Gemfile"
-
 Lint/Debugger:
   Exclude:
-    - "spec/support/capybara.rb"
-
-Metrics/AbcSize:
-  Max: 20
+    - 'spec/support/capybara_helpers.rb'
 
 Metrics/BlockLength:
   Exclude:
@@ -30,18 +23,5 @@ Metrics/BlockLength:
 Metrics/LineLength:
   Max: 100
 
-Naming/FileName:
-  Exclude:
-    - 'app/views/**/*'
-
 Rails:
   Enabled: true
-
-Style/Documentation:
-  Enabled: false
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-Style/StringLiterals:
-  Enabled: false

data/templates/sentry.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+Raven.configure do |config|
+  config.dsn = ENV.fetch('SENTRY_DSN')
+  config.sanitize_fields = Rails.application.config.filter_parameters.map(&:to_s)
+  config.environments = %w[ staging production ]
+  config.current_environment = ENV.fetch('SENTRY_CURRENT_ENV', Rails.env)
+end

data/templates/shoulda_matchers_config_rspec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Shoulda::Matchers.configure do |config|
   config.integrate do |with|
     with.test_framework :rspec

data/templates/slim-lint.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if Rails.env.development? || Rails.env.test?
   require 'slim_lint/rake_task'
   SlimLint::RakeTask.new do |t|

data/templates/slim.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 Slim::Engine.set_options(js_wrapper: :cdata)

data/templates/smtp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 SMTP_SETTINGS = {
   address: ENV.fetch("SMTP_ADDRESS"), # example: "smtp.sendgrid.net"
   authentication: :plain,
@@ -7,7 +9,3 @@ SMTP_SETTINGS = {
   port: "587",
   user_name: ENV.fetch("SMTP_USERNAME")
 }
-
-if ENV["EMAIL_RECIPIENTS"].present?
-  Mail.register_interceptor RecipientInterceptor.new(ENV["EMAIL_RECIPIENTS"])
-end

data/templates/spec_helper.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 require 'simplecov'
+
 SimpleCov.start 'rails' do
-  add_group 'Services', 'app/services'
+  # TODO: interactors
+  add_group 'Interactions', 'app/interactions'
 end
 
-# Save to CircleCI's artifacts directory if we're on CircleCI
 if ENV['CIRCLE_ARTIFACTS']
   dir = File.join(ENV['CIRCLE_ARTIFACTS'], 'coverage')
   SimpleCov.coverage_dir(dir)
@@ -15,6 +18,7 @@ require 'timecop'
 # http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
     expectations.syntax = :expect
   end
 
@@ -23,10 +27,15 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
 
+  config.default_formatter = 'doc' if config.files_to_run.one?
+  config.disable_monkey_patching!
   config.example_status_persistence_file_path = 'tmp/rspec_examples.txt'
+  config.filter_run_when_matching :focus
   config.order = :random
+  config.profile_examples = 10
+  config.shared_context_metadata_behavior = :apply_to_host_groups
 
-  config.default_formatter = 'doc' if config.files_to_run.one?
+  Kernel.srand config.seed
 end
 
 WebMock.disable_net_connect!(allow_localhost: true)