welaika-suspenders 2.22.0 → 2.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f224ab95618cdbe16370496df9b772230d8a87a
-  data.tar.gz: bb92d352d3bec26429c5a9b442eac8577059a1f0
+  metadata.gz: bbe829c6d51e19782944b5685839aab374a0beb6
+  data.tar.gz: 9a9b41d93bb39c3e8a0b84b5613e570bdd5574c2
 SHA512:
-  metadata.gz: d5911bb8e7d7cd04dbb2715b925ffedd063ff3d68fecf1b5700afe9f3a6a39a35909d803756c53527c4d3da01e3558c0a228a6af39171f8ef944c2174f7c4486
-  data.tar.gz: b07fabfc77bfacfc74b7bcefb3935c41ded52426192d3df1ce8a61931aa504bbf2fcf1d136b96520ab88ba56ea00bd404354b7e1cfbe4389072a1983bd806362
+  metadata.gz: de6b9bf1f9c87a2b6032549f94acfe44614e5bbfa1e8f29915f5943e007134f3a0f7c70daf0abffe84bec1ee80d24901152c1f30a0b35217281011825ab6d414
+  data.tar.gz: f83d2baacdc8076c9b7afacb675c258ad6ec658317c21a275e929007edb8b7139ca6965cb022584b46277d6f066eb71a0bcee42d740ade120324381b01b86766

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright (c) 2008-2015 thoughtbot, inc.
+Copyright (c) 2008-2016 thoughtbot, inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/NEWS.md

@@ -1,3 +1,9 @@
+master (unreleased)
+
+* Switch from Airbrake to Honeybadger
+* Generate applications with `rack_mini_profiler` (disabled by default, enabled
+  by setting `RACK_MINI_PROFILER=1`)
+
 1.35.0 (December 30, 2015)
 
 * Introduce Heroku Pipelines support

data/README.md

@@ -66,7 +66,6 @@ List of changes we made since [this is commit](https://github.com/thoughtbot/sus
 - create common folders like `app/queries`, `app/services`, etc.
 - use `application.sass` instead of `application.scss`
 - add `brakeman` gem
-- change `i18n_tasks` configuration: set `it` as base locale
 - set `Rome` as `time_zone`
 - set `:it` as `default_locale`
 - add [simplecov](https://github.com/colszowka/simplecov)
@@ -87,3 +86,4 @@ List of changes we made since [this is commit](https://github.com/thoughtbot/sus
 - remove bitters and refills
 - lint factory girl's factories
 - remove automatic deployment
+- use airbrake instead of honeybadger

data/lib/suspenders/adapters/heroku.rb

@@ -68,12 +68,17 @@ module Suspenders
         end
 
         heroku_app_name = app_builder.app_name.dasherize
-        %w(staging production).each do |environment|
-          run_toolbelt_command(
-            "pipelines:create #{heroku_app_name} -a #{heroku_app_name}-#{environment} --stage #{environment}",
-            environment,
-          )
-        end
+        run_toolbelt_command(
+          "pipelines:create #{heroku_app_name} \
+            -a #{heroku_app_name}-staging --stage staging",
+          "staging",
+        )
+
+        run_toolbelt_command(
+          "pipelines:add #{heroku_app_name} \
+            -a #{heroku_app_name}-production --stage production",
+          "production",
+        )
       end
 
       def set_heroku_serve_static_files

data/lib/suspenders/app_builder.rb

@@ -20,6 +20,21 @@ module Suspenders
       template 'README.md.erb', 'README.md'
     end
 
+    def gitignore
+      copy_file "suspenders_gitignore", ".gitignore"
+    end
+
+    def gemfile
+      template "Gemfile.erb", "Gemfile"
+    end
+
+    def setup_rack_mini_profiler
+      copy_file(
+        "rack_mini_profiler.rb",
+        "config/initializers/rack_mini_profiler.rb",
+      )
+    end
+
     def raise_on_missing_assets_in_test
       inject_into_file(
         "config/environments/test.rb",
@@ -229,11 +244,6 @@ end
       bundle_command 'exec rake db:create db:migrate'
     end
 
-    def replace_gemfile
-      remove_file 'Gemfile'
-      template 'Gemfile.erb', 'Gemfile'
-    end
-
     def set_ruby_to_version_being_used
       create_file '.ruby-version', "#{Suspenders::RUBY_VERSION}\n"
     end
@@ -336,14 +346,6 @@ Rack::Timeout.timeout = (ENV["RACK_TIMEOUT"] || 10).to_i
       configure_environment "test", "config.active_job.queue_adapter = :inline"
     end
 
-    def fix_i18n_deprecation_warning
-      config = <<-RUBY
-    config.i18n.enforce_available_locales = true
-      RUBY
-
-      inject_into_class 'config/application.rb', 'Application', config
-    end
-
     def generate_rspec
       generate 'rspec:install'
     end
@@ -362,9 +364,7 @@ Rack::Timeout.timeout = (ENV["RACK_TIMEOUT"] || 10).to_i
         'app/assets/stylesheets/application.sass'
     end
 
-    def gitignore_files
-      remove_file '.gitignore'
-      copy_file 'suspenders_gitignore', '.gitignore'
+    def setup_default_directories
       [
         'app/forms',
         'app/decorators',
@@ -383,8 +383,7 @@ Rack::Timeout.timeout = (ENV["RACK_TIMEOUT"] || 10).to_i
         'spec/support/mixins',
         'spec/support/shared_examples'
       ].each do |dir|
-        run "mkdir #{dir}"
-        run "touch #{dir}/.keep"
+        empty_directory_with_keep_file dir
       end
     end
 

data/lib/suspenders/generators/app_generator.rb

@@ -54,7 +54,6 @@ module Suspenders
     end
 
     def customize_gemfile
-      build :replace_gemfile
       build :create_ruby_gemset_file
       build :set_ruby_to_version_being_used
 
@@ -146,10 +145,10 @@ module Suspenders
       build :configure_slim
       build :disable_xml_params
       build :configure_available_locales
-      build :fix_i18n_deprecation_warning
       build :setup_default_rake_task
       build :configure_puma
       build :set_up_forego
+      build :setup_rack_mini_profiler
     end
 
     def setup_stylesheets
@@ -159,8 +158,8 @@ module Suspenders
 
     def setup_git
       if !options[:skip_git]
-        say 'Initializing git'
-        invoke :setup_gitignore
+        say "Initializing git"
+        invoke :setup_default_directories
         invoke :init_git
       end
     end
@@ -190,8 +189,8 @@ module Suspenders
       build :copy_dotfiles
     end
 
-    def setup_gitignore
-      build :gitignore_files
+    def setup_default_directories
+      build :setup_default_directories
     end
 
     def setup_spring
@@ -227,8 +226,8 @@ module Suspenders
     end
 
     def outro
-      say "Congratulations!"
-      say "Now read the README.md"
+      say "Congratulations! You just pulled our suspenders."
+      say "Read README.md and configure Errbit."
     end
 
     protected

data/lib/suspenders/version.rb

@@ -1,5 +1,5 @@
 module Suspenders
   RAILS_VERSION = "~> 4.2.0"
   RUBY_VERSION = IO.read("#{File.dirname(__FILE__)}/../../.ruby-version").strip
-  VERSION = "2.22.0"
+  VERSION = "2.23.0"
 end

data/spec/features/new_project_spec.rb

@@ -7,6 +7,19 @@ RSpec.describe "Suspend a new project with default configuration" do
     run_suspenders
   end
 
+  it "uses custom Gemfile" do
+    gemfile_file = IO.read("#{project_path}/Gemfile")
+    expect(gemfile_file).to match(
+      /^ruby "#{Suspenders::RUBY_VERSION}"$/,
+    )
+    expect(gemfile_file).to match(
+      /^gem "autoprefixer-rails"$/,
+    )
+    expect(gemfile_file).to match(
+      /^gem "rails", "#{Suspenders::RAILS_VERSION}"$/,
+    )
+  end
+
   it "ensures project specs pass" do
     Dir.chdir(project_path) do
       Bundler.with_clean_env do
@@ -77,6 +90,23 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(File).to exist("#{project_path}/spec/support/fixtures_helper.rb")
   end
 
+  it "ensures Gemfile contains `rack-mini-profiler`" do
+    gemfile = IO.read("#{project_path}/Gemfile")
+
+    expect(gemfile).to include %{gem "rack-mini-profiler", require: false}
+  end
+
+  it "ensures .sample.env defaults to RACK_MINI_PROFILER=0" do
+    env = IO.read("#{project_path}/.env")
+
+    expect(env).to include "RACK_MINI_PROFILER=0"
+  end
+
+  it "creates a rack-mini-profiler initializer" do
+    expect(File).
+      to exist("#{project_path}/config/initializers/rack_mini_profiler.rb")
+  end
+
   it "adds rspec helper for queries" do
     expect(File).to exist("#{project_path}/spec/support/queries_helper.rb")
   end
@@ -84,7 +114,6 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "configs locale and timezone" do
     result = IO.read("#{project_path}/config/application.rb")
 
-    expect(result).to match(/^ +config.i18n.enforce_available_locales = true$/)
     expect(result).to match(/^ +config.i18n.available_locales = \[:en, :it\]$/)
     expect(result).to match(/^ +config.i18n.default_locale = :it$/)
 

data/spec/support/fake_heroku.rb

@@ -44,7 +44,7 @@ class FakeHeroku
 
   def self.has_setup_pipeline_for?(app_name)
     commands_ran =~ /^pipelines:create #{app_name} -a #{app_name}-staging --stage staging/ &&
-      commands_ran =~ /^pipelines:create #{app_name} -a #{app_name}-production --stage production/
+      commands_ran =~ /^pipelines:add #{app_name} -a #{app_name}-production --stage production/
   end
 
   def self.commands_ran

data/templates/Gemfile.erb

@@ -28,7 +28,6 @@ gem "uglifier"
 
 group :development do
   gem "letter_opener"
-  gem "quiet_assets"
   gem "spring"
   gem "spring-commands-rspec"
   gem "web-console"
@@ -45,10 +44,15 @@ group :development, :test do
   gem "priscilla"
   gem "pry-byebug"
   gem "pry-rails"
+  gem "quiet_assets"
   gem "rspec-rails", "~> 3.4.0"
   gem "rubocop", require: false
 end
 
+group :development, :staging do
+  gem "rack-mini-profiler", require: false
+end
+
 group :test do
   gem "capybara-webkit"
   gem "database_cleaner"

data/templates/dotfiles/.env

@@ -3,6 +3,7 @@ ASSET_HOST=localhost:3000
 APPLICATION_HOST=localhost:3000
 PORT=3000
 RACK_ENV=development
+RACK_MINI_PROFILER=0
 SECRET_KEY_BASE=development_secret
 EXECJS_RUNTIME=Node
 SMTP_ADDRESS=smtp.example.com

data/templates/rack_mini_profiler.rb

@@ -0,0 +1,5 @@
+if ENV["RACK_MINI_PROFILER"].to_i > 0
+  require "rack-mini-profiler"
+
+  Rack::MiniProfilerRails.initialize!(Rails.application)
+end

data/templates/rubocop.yml

@@ -1,5 +1,8 @@
+Rails:
+  Enabled: true
+
 AllCops:
-  RunRailsCops: true
+  TargetRubyVersion: 2.3
   Exclude:
     - "db/**/*"
     - "config/**/*"
@@ -15,6 +18,9 @@ Style/StringLiterals:
 Style/Documentation:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
 Metrics/AbcSize:
   Max: 18
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: welaika-suspenders
 version: !ruby/object:Gem::Version
-  version: 2.22.0
+  version: 2.23.0
 platform: ruby
 authors:
 - thoughtbot
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-03 00:00:00.000000000 Z
+date: 2016-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -144,6 +144,7 @@ files:
 - templates/postgresql_database.yml.erb
 - templates/puma.rb
 - templates/queries_helper_rspec.rb
+- templates/rack_mini_profiler.rb
 - templates/rails_helper.rb
 - templates/rubocop.rake
 - templates/rubocop.yml