wechat_payment 2.0.14 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 383f51dd9ca42a1ef6dd1231871e604fc7d985fba7990b5750759e698c5b9e8b
-  data.tar.gz: 4adbdbfbc709dc96cf6df6a038f721589fa7f11b7dfb8d744685b01bc16060b1
+  metadata.gz: 17e53d537ae37b1fcf5d6186579c35314f46dfa6a1c26a879b1935061c5864ea
+  data.tar.gz: bd1b81430ef7ac61d870ac013dd48b6ecad2fc1813a894f2a1b2b7a504914e6c
 SHA512:
-  metadata.gz: 90b55232826903f31a1aca89a4d67e620ff3a9ba73f62c7d53916f2da30b12fe3612827c5883974f8cec8a1c7bd6efad715988f3c732baa333f8c690985b32cd
-  data.tar.gz: aa71fc09c2d6fe3e8b0db85758c3a9aa4a42a0f1d38fa01691357171590b8608db3635b6240a224110f95830f512cd58a9307e71f9f0f8a49ff2820ef7151152
+  metadata.gz: e97fb758a760ba3d34e08b6a79820c233a1d70d7dd7d324bf8b59660cc27942bee800c26a5b95514e102e5dc325c945bc89cf954c53b3412f2e96cf74102b69e
+  data.tar.gz: 4eb5a89a9e5b25a23bb6530f2ac42eba6f04d631b46e0a055d70635efaa5ef6f78d153e4bd34df5bcf055c4107c02241f0d49b896dd4afb467bbb627ef1fbb1b

data/config/locales/zh-CN.yml

@@ -0,0 +1,15 @@
+
+"zh-CN":
+  wechat_payment_service_result:
+    message:
+      invoke_unifiedorder_success: 统一支付预支付成功
+      invoke_unifiedorder_failed: 统一支付预支付失败
+      payment_apply_success: 支付发起成功
+      payment_apply_failed: 支付发起失败
+      payment_exec_success: 支付执行成功
+      payment_exec_failed: 支付执行失败
+      refund_apply_success: 退款发起成功
+      refund_apply_failed: 退款发起失败
+      refund_exec_success: 退款执行成功
+      refund_exec_failed: 退款执行失败
+      validate_sign_failed: 支付回调签名验证失败

data/lib/wechat_payment/client.rb

@@ -3,23 +3,6 @@ module WechatPayment
   class Client
     GATEWAY_URL = 'https://api.mch.weixin.qq.com'.freeze
 
-    def initialize # (merchant = WechatPayment)
-      # required_attrs = [:appid, :mch_id, :key, :app_secret, :cert_path]
-      # missing_attrs = required_attrs.reject { |attr| merchant.respond_to?(attr) }
-      # if missing_attrs.present?
-      #   raise Exceptions::MerchantMissingAttr.new("Missing attributes: #{missing_attrs}, merchant target must respond to: appid, mch_id, key, appsecret, cert_path")
-      # end
-      #
-      # @merchant = merchant
-      # cert_path = Rails.root.join(merchant.cert_path)
-      #
-      # WechatPayment.appid = merchant.appid
-      # WechatPayment.key = merchant.key
-      # WechatPayment.mch_id = merchant.mch_id
-      # WechatPayment.appsecret = merchant.app_secret
-      # WechatPayment.set_apiclient_by_pkcs12(File.binread(cert_path), merchant.mch_id)
-    end
-
     ORDER_REQUIRED_FIELD = [:out_trade_no, :spbill_create_ip, :body, :total_fee, :openid]
     # 下单
     def order(order_params)
@@ -37,12 +20,15 @@ module WechatPayment
       order_result = invoke_unifiedorder(order_params)
 
       if order_result.success?
-
-        payment_logger.info("{params: #{order_params}, result: #{order_result}}")
-        WechatPayment::ServiceResult.new(success: true, data: order_result.with_indifferent_access)
+        message = "发起支付成功"
+        log_content = { message:, params: order_params, result: order_result }.to_json
+        WechatPayment::PaymentLogger.info { log_content }
+        WechatPayment::SuccessResult.new(data: order_result, message:, message_kind: :payment_apply_success)
       else
-        payment_logger.error("{params: #{order_params}, result: #{order_result}}")
-        WechatPayment::ServiceResult.new(success: false, error: order_result.with_indifferent_access)
+        message = "发起支付失败"
+        log_content = { message: , params: order_params, result: order_result }.to_json
+        WechatPayment::PaymentLogger.error { log_content }
+        WechatPayment::FailureResult.new(error: order_result, message:, message_kind: :payment_apply_failed)
       end
     end
 
@@ -61,11 +47,15 @@ module WechatPayment
       refund_result = invoke_refund(refund_params.to_options)
 
       if refund_result.success?
-        refund_logger.info "{params: #{refund_params}, result: #{refund_result}"
-        WechatPayment::ServiceResult.new(success: true, data: refund_result)
+        message = '发起退款成功'
+        log_content = { message:, params: refund_params, result: refund_result}.to_json
+        WechatPayment::RefundLogger.info { log_content }
+        WechatPayment::SuccessResult.new(data: refund_result, message:, message_kind: :refund_apply_success)
       else
-        refund_logger.error "{params: #{refund_params}, result: #{refund_result}"
-        WechatPayment::ServiceResult.new(success: false, error: refund_result)
+        message = "发起退款失败"
+        log_content = { message:, params: refund_params, result: refund_result }.to_json
+        WechatPayment::RefundLogger.error { log_content }
+        WechatPayment::FailureResult.new(error: refund_result, message:, message_kind: :refund_apply_failed)
       end
     end
 
@@ -77,18 +67,22 @@ module WechatPayment
     # 处理支付回调
     def self.handle_payment_notify(notify_data)
       if !WechatPayment::Sign.verify?(notify_data)
-        payment_logger.error("{msg: 签名验证失败, error: #{notify_data}}")
-        WechatPayment::ServiceResult.new(success: false, error: notify_data, message: "回调签名验证失败")
+        message = "回调签名验证失败"
+        WechatPayment::PaymentLogger.error { { message: , error: notify_data }.to_json }
+        WechatPayment::FailureResult.new(error: notify_data, message:, message_kind: :validate_sign_failed)
       end
 
       result = WechatPayment::InvokeResult.new(notify_data)
-
       if result.success?
-        payment_logger.info("{callback: #{notify_data}}")
-        WechatPayment::ServiceResult.new(success: true, data: notify_data, message: "支付执行成功", )
+        message = "支付执行成功"
+        log_content = { message:, callback: notify_data }.to_json
+        WechatPayment::PaymentLogger.info { log_content }
+        WechatPayment::SuccessResult.new(data: notify_data, message:, message_kind: :payment_exec_success)
       else
-        payment_logger.error("{callback: #{notify_data}}")
-        WechatPayment::ServiceResult.new(success: false, error: notify_data, message: "支付执行失败", error_type: :payment_exec_failed)
+        message = "支付执行失败"
+        log_content = { message:, callback: notify_data }.to_json
+        WechatPayment::PaymentLogger.error { log_content }
+        WechatPayment::FailureResult.new(error: notify_data, message:, message_kind: :payment_exec_failed)
       end
     end
 
@@ -98,11 +92,15 @@ module WechatPayment
 
       result = WechatPayment::InvokeResult.new(notify_data)
       if result.success?
-        refund_logger.info "退款执行成功{callback: #{notify_data}}"
-        WechatPayment::ServiceResult.new(success: true, data: notify_data)
+        message = "退款执行成功"
+        log_content = { message:, callback: notify_data }.to_json
+        WechatPayment::RefundLogger.info { log_content }
+        WechatPayment::SuccessResult.new(data: notify_data, message:, message_kind: :refund_exec_success)
       else
-        refund_logger.error "退款执行失败: {callback: #{notify_data}}"
-        WechatPayment::ServiceResult.new(success:false, error: notify_data, message: "退款回调失败")
+        message = "退款执行失败"
+        log_content = { message:, callback: notify_data}.to_json
+        WechatPayment::RefundLogger.error { log_content }
+        WechatPayment::FailureResult.new(error: notify_data, message:, message_kind: :refund_exec_failed)
       end
     end
 
@@ -139,7 +137,6 @@ module WechatPayment
       params
     end
 
-
     INVOKE_UNIFIEDORDER_REQUIRED_FIELDS = [:body, :out_trade_no, :total_fee, :spbill_create_ip, :notify_url, :trade_type]
     def invoke_unifiedorder(params, options = {})
       params = {
@@ -176,7 +173,10 @@ module WechatPayment
       params[:op_user_id] ||= params[:mch_id]
 
       check_required_options(params, INVOKE_REFUND_REQUIRED_FIELDS)
-      warn("WechatPayment Warn: missing required option: out_trade_no or transaction_id must have one") if ([:out_trade_no, :transaction_id] & params.keys) == []
+
+      if ([:out_trade_no, :transaction_id] & params.keys) == []
+        warn("WechatPayment Warn: missing required option: out_trade_no or transaction_id must have one")
+      end
 
       options = {
         cert: options.delete(:apiclient_cert) || WechatPayment.apiclient_cert,
@@ -191,7 +191,6 @@ module WechatPayment
       )
 
       yield result if block_given?
-
       result
     end
 
@@ -237,7 +236,6 @@ module WechatPayment
       res.body
     end
 
-
     private
 
     # 判断 hash 是否缺少 key
@@ -248,24 +246,5 @@ module WechatPayment
         raise WechatPayment::MissingKeyError.new("Parameter missing keys: #{lack_of_keys}")
       end
     end
-
-    # 支付日志
-    def payment_logger
-      WechatPayment::Client.payment_logger
-    end
-
-    # 退款日志
-    def refund_logger
-      WechatPayment::Client.refund_logger
-    end
-
-    def self.payment_logger
-      @payment_logger ||= WechatPayment::RLogger.make("wx_payment")
-    end
-
-    def self.refund_logger
-      @refund_logger ||= WechatPayment::RLogger.make("wx_refund")
-    end
-
   end
-end
+end

data/lib/wechat_payment/concern/goods.rb

@@ -42,10 +42,15 @@ module WechatPayment
         )
 
         unless user_goods.save
-          return WechatPayment::ServiceResult.new(success: false,
-                                                  error: user_goods.errors,
+          log_content = {
+            message: "商品中间表 #{user_goods_model.table_name} 插入数据失败",
+            error: user_goods.errors.full_messages
+          }.to_json
+
+          WechatPayment::Logger.info { log_content }
+          return WechatPayment::FailureResult.new(error: user_goods.error,
                                                   message: "商品中间表 #{user_goods_model.table_name} 插入数据失败",
-                                                  error_type: :create_user_goods_failed)
+                                                  message_kind: :create_user_goods_failed)
         end
 
         payment_order = user_goods.payment_orders.new(
@@ -55,11 +60,15 @@ module WechatPayment
           customer: user
         )
 
-        unless payment_order.save
-          return WechatPayment::ServiceResult.new(success: false, error: user_goods.errors, message: "支付订单创建失败")
+        if payment_order.save
+          message = "支付订单创建成功"
+          WechatPayment::SuccessResult.new(data: payment_order, message:, message_kind: :create_payment_order_success)
+        else
+          message = "支付订单创建失败"
+          log_content = { message:, error: payment_order.errors.full_messages }.to_json
+          WechatPayment::Logger.error { log_content }
+          WechatPayment::FailureResult.new(error: user_goods.error, message:, message_kind: :create_payment_order_failed)
         end
-
-        WechatPayment::ServiceResult.new(success: true, data: payment_order, message: "支付订单创建成功")
       end
 
       # 重新支付，应用场景是： 用户取消了支付后，使用最后一张订单进行支付
@@ -92,4 +101,4 @@ module WechatPayment
       end
     end
   end
-end
+end

data/lib/wechat_payment/engine.rb

@@ -3,5 +3,6 @@ module WechatPayment
     isolate_namespace WechatPayment
 
     config.autoload_paths << "#{config.root}/lib"
+    config.i18n.default_locale = "zh-CN"
   end
 end

data/lib/wechat_payment/failure_result.rb

@@ -0,0 +1,7 @@
+
+class WechatPayment::FailureResult < WechatPayment::ServiceResult
+  def initialize(data: {}, error: nil, message: nil, message_kind: nil, message_type: nil)
+    super(success: false, data: data, error: error, message: message, message_kind: message_kind, message_type: message_type)
+  end
+
+end

data/lib/wechat_payment/logger.rb

@@ -0,0 +1,18 @@
+
+class WechatPayment::Logger
+  def self.tags
+    ["WechatPayment"]
+  end
+
+  %w{ info error warn fatal }.each do |level|
+    define_singleton_method level do |content = "", &block|
+      Rails.logger.tagged *self.tags do
+        if block.present?
+          Rails.logger.send(level, &block)
+        else
+          Rails.logger.send(level, content)
+        end
+      end
+    end
+  end
+end

data/lib/wechat_payment/payment_logger.rb

@@ -0,0 +1,7 @@
+class WechatPayment::PaymentLogger < WechatPayment::Logger
+
+  def self.tags
+    ["WechatPayment", "Pay"]
+  end
+
+end

data/lib/wechat_payment/refund_logger.rb

@@ -0,0 +1,6 @@
+
+class WechatPayment::RefundLogger < WechatPayment::Logger
+  def self.tags
+    ["WechatPayment", "Refund"]
+  end
+end

data/lib/wechat_payment/service_result.rb

@@ -4,27 +4,22 @@ module WechatPayment
                   :error,
                   :data,
                   :message,
-                  :message_type,
-                  :error_type
+                  :message_kind,
+                  :message_type
 
     def initialize(success: false,
+                   data: {},
                    error: nil,
                    message: nil,
-                   message_type: nil,
-                   data: nil,
-                   error_type: nil)
-      self.success = success
-
-      self.data = data.presence || {}
-
-      if self.data.is_a? Hash
-        self.data = self.data.with_indifferent_access
-      end
+                   message_kind: nil,
+                   message_type: nil)
 
+      self.success = success
+      self.data = (data || {}).with_indifferent_access
       self.error = error
-
       self.message = message
       self.message_type = message_type
+      self.message_kind = message_kind
     end
 
     alias success? :success
@@ -41,9 +36,9 @@ module WechatPayment
       yield(self) if failure?
     end
 
-    def get_message_type
-      if message_type.present?
-        message_type.to_sym
+    def message_type
+      if @message_type.present?
+        @message_type.to_sym
       elsif success?
         :info
       else
@@ -51,15 +46,22 @@ module WechatPayment
       end
     end
 
+    def message_kind_prefix
+      "wechat_payment_"
+    end
+
+    def message_kind
+      "#{message_kind_prefix}#{@message_kind}"
+    end
+
     def as_json(options = {})
-      # data.as_json(options)
       {
         success: success,
         data: data,
         message: message,
-        message_type: get_message_type,
         error: error,
-        error_type: error_type
+        message_kind: message_kind,
+        message_type: message_type
       }
     end
   end

data/lib/wechat_payment/success_result.rb

@@ -0,0 +1,6 @@
+
+class WechatPayment::SuccessResult < WechatPayment::ServiceResult
+  def initialize(data: {}, error: nil, message: nil, message_kind: nil, message_type: nil)
+    super(success: true, data: data, error: error, message: message, message_kind: message_kind, message_type: message_type)
+  end
+end

data/lib/wechat_payment/version.rb

@@ -1,3 +1,3 @@
 module WechatPayment
-  VERSION = '2.0.14'
+  VERSION = '2.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wechat_payment
 version: !ruby/object:Gem::Version
-  version: 2.0.14
+  version: 2.1.2
 platform: ruby
 authors:
 - ian
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-22 00:00:00.000000000 Z
+date: 2022-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -75,6 +75,7 @@ files:
 - app/models/wechat_payment/refund_order.rb
 - app/services/wechat_payment/service.rb
 - app/views/layouts/wechat_payment/application.html.erb
+- config/locales/zh-CN.yml
 - config/routes.rb
 - db/migrate/20210706075217_create_wechat_payment_payment_orders.rb
 - db/migrate/20210706095205_create_wechat_payment_refund_orders.rb
@@ -92,11 +93,15 @@ files:
 - lib/wechat_payment/concern/user.rb
 - lib/wechat_payment/concern/user_goods.rb
 - lib/wechat_payment/engine.rb
+- lib/wechat_payment/failure_result.rb
 - lib/wechat_payment/invoke_result.rb
+- lib/wechat_payment/logger.rb
 - lib/wechat_payment/missing_key_error.rb
-- lib/wechat_payment/r_logger.rb
+- lib/wechat_payment/payment_logger.rb
+- lib/wechat_payment/refund_logger.rb
 - lib/wechat_payment/service_result.rb
 - lib/wechat_payment/sign.rb
+- lib/wechat_payment/success_result.rb
 - lib/wechat_payment/version.rb
 homepage: http://dev.com
 licenses:
@@ -120,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Summary of WechatPayment.

data/lib/wechat_payment/r_logger.rb

@@ -1,36 +0,0 @@
-module WechatPayment
-  class RLogger
-    def initialize
-      raise Exceptions::InitializeDenied.new("please use 'ILogger.make' instead of 'ILogger.new'")
-    end
-
-    class << self
-      def make(log_file)
-        @logger ||= {}
-
-        log_file_name = if log_file.class.in? [String, Symbol]
-                          log_file_name = log_file.to_sym
-
-                          unless log_file_name.to_s.end_with? ".log"
-                            log_file_name = "#{log_file_name}.log"
-                          end
-
-                          "#{root_path}/#{log_file_name}"
-                        elsif log_file.respond_to? :to_path
-                          log_file.to_path
-                        else
-                          raise Exceptions::UnsupportdParamType.new("log file parameter only support 'File' or 'String' Type.")
-                        end
-
-        # 如果已经存在日志对象，则返回已有的日志对象
-        @logger[log_file_name] ||= ::Logger.new(log_file_name)
-      end
-
-      def root_path
-        @root ||= "#{Rails.root}/log"
-      end
-    end
-
-
-  end
-end