webvalve 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 467554297c4382a3f12ce68e32c1b9fed9b2d69afa2b97fb46d3f98be5437dc7
-  data.tar.gz: cb6a4ee0e1a8db1cb37c78737a9d3822b8a4da3e864217612599174b6687e8ee
+  metadata.gz: d632e36adb6db315896d3a144d02408dfcacdb7af5196874f4839d12b187499b
+  data.tar.gz: 044a117bf8a6df2eba482f99b5234e39b393f906ef0b895b3819d76805e76e9d
 SHA512:
-  metadata.gz: 44fd3a16ea1499de33242bbb8a37dcff77e1af8b7a70ea220fda9c29fce8505f19fc2739f48fdb9f47471fe4f5057ed8ffa8d6918949d8e6d6491160b3e79c1d
-  data.tar.gz: ad0bdc05029b4fdb3e58428186841bcfc6bbeba9e7f21e2df8ab4e4fd2ded9fba0af2aa592b8d1fe0752b141b30d5c8020fd7b57efe65620033a942f9eb9bd98
+  metadata.gz: e7c5ca72aa5ac1ee8417a15df0848f66f019655a4870152c32ff62231b1df91eef435524f072e548e4091e509be76d2ac5fd19391ecafd861193c2ef1b92617e
+  data.tar.gz: b1a9d0d174ae5d65ca02fc62ecdb13b24f74489d13c6ab39995868cac56665015667632849a62477c087fc6fe4d0770d5945131ffd84914d61706e58e58b374e

data/CHANGELOG.md

@@ -9,7 +9,12 @@ and this project aims to adhere to [Semantic Versioning](http://semver.org/spec/
 ### Added
 ### Removed
 
-## [0.11.0] - 2019-09-23
+## [0.12.0] - 2020-02-22
+### Changed
+- raise an error on setup when multiple services are registered to the
+    same url. (https://github.com/Betterment/webvalve/pull/40)
+
+## [0.11.0] - 2019-11-04
 ### Changed
 - rework configuration so that WebValve has 3 operating modes: off,
     on+allowing, and on+intercepting. support toggling the latter two
@@ -47,7 +52,9 @@ and this project aims to adhere to [Semantic Versioning](http://semver.org/spec/
 ### Changed
 - WebMock 3+ support from @messanjah (https://github.com/Betterment/webvalve/pull/22)
 
-[Unreleased]: https://github.com/Betterment/webvalve/compare/v0.10.0...HEAD
+[Unreleased]: https://github.com/Betterment/webvalve/compare/v0.12.0...HEAD
+[0.12.0]: https://github.com/Betterment/webvalve/compare/v0.11.0...v0.12.0
+[0.11.0]: https://github.com/Betterment/webvalve/compare/v0.10.0...v0.11.0
 [0.10.0]: https://github.com/Betterment/webvalve/compare/v0.9.10...v0.10.0
 [0.9.10]: https://github.com/Betterment/webvalve/compare/v0.9.9...v0.9.10
 [0.9.9]: https://github.com/Betterment/webvalve/compare/v0.9.8...v0.9.9

data/lib/webvalve/manager.rb

@@ -69,6 +69,7 @@ module WebValve
     def reset
       allowlisted_urls.clear
       fake_service_configs.clear
+      stubbed_urls.clear
     end
 
     # @api private
@@ -126,6 +127,8 @@ module WebValve
     end
 
     def webmock_service(config)
+      ensure_non_duplicate_stub(config)
+
       WebMock.stub_request(
         :any,
         url_to_regexp(config.service_url)
@@ -139,5 +142,14 @@ module WebValve
     def url_to_regexp(url)
       %r(\A#{Regexp.escape url})
     end
+
+    def ensure_non_duplicate_stub(config)
+      raise "Invalid config for #{config.service_class_name}. Already stubbed url #{config.service_url}" if stubbed_urls.include?(config.service_url)
+      stubbed_urls << config.service_url
+    end
+
+    def stubbed_urls
+      @stubbed_urls ||= Set.new
+    end
   end
 end

data/lib/webvalve/version.rb

@@ -1,3 +1,3 @@
 module WebValve
-  VERSION = "0.11.0"
+  VERSION = "0.12.0"
 end

data/spec/webvalve/manager_spec.rb

@@ -129,6 +129,18 @@ RSpec.describe WebValve::Manager do
 
         expect(subject.allowlisted_urls).to include 'http://something.dev'
       end
+
+      it 'raises with duplicate stubbed urls' do
+        disabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+        other_disabled_service = class_double(WebValve::FakeService, name: 'FakeOtherThing')
+
+        with_env 'SOMETHING_API_URL' => 'http://something.dev', 'OTHER_THING_API_URL' => 'http://something.dev' do
+          subject.register disabled_service.name
+          subject.register other_disabled_service.name
+
+          expect { subject.setup }.to raise_error('Invalid config for FakeOtherThing. Already stubbed url http://something.dev')
+        end
+      end
     end
 
     context 'when WebValve is on and allowing traffic' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webvalve
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Sam Moore
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-04 00:00:00.000000000 Z
+date: 2020-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A library for faking http service integrations in development and test