RubyGems - webvalve - Versions diffs - 0.10.0 → 0.11.0 - Mend

webvalve 0.10.0 → 0.11.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (13) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +9 -0
data/README.md +13 -3
data/lib/webvalve.rb +3 -18
data/lib/webvalve/fake_service_config.rb +10 -7
data/lib/webvalve/manager.rb +73 -7
data/lib/webvalve/version.rb +1 -1
data/spec/dummy/app/assets/config/manifest.js +3 -0
data/spec/dummy/log/test.log +16 -0
data/spec/examples.txt +61 -32
data/spec/webvalve/fake_service_config_spec.rb +27 -91
data/spec/webvalve/manager_spec.rb +527 -39
metadata +4 -2

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3bf83f303a9549cb99552f7fc6810ac73ad574d551247d9b7b00f637290e34e8
-  data.tar.gz: 110b2a233b4abcf9a59a49f0354202b274dd6056561ed9aff9e985c9f8335a7a
+  metadata.gz: 467554297c4382a3f12ce68e32c1b9fed9b2d69afa2b97fb46d3f98be5437dc7
+  data.tar.gz: cb6a4ee0e1a8db1cb37c78737a9d3822b8a4da3e864217612599174b6687e8ee
 SHA512:
-  metadata.gz: a62b2b9f6a2956445f9235b88eaa5abd425845da985952394bc0844d951308f556d54d13432df941f59a9047f62dd9ee4053a5b91d770bf6532a403297d0d8cc
-  data.tar.gz: ea441eb2ba4de0f1a84c8ab6648dd1a6c25c6858985b15ebd090bb277a3a9d637df8d439992934bf9671ea99c57625d9abce457d4f2b5a43a96de3b3af9ceb06
+  metadata.gz: 44fd3a16ea1499de33242bbb8a37dcff77e1af8b7a70ea220fda9c29fce8505f19fc2739f48fdb9f47471fe4f5057ed8ffa8d6918949d8e6d6491160b3e79c1d
+  data.tar.gz: ad0bdc05029b4fdb3e58428186841bcfc6bbeba9e7f21e2df8ab4e4fd2ded9fba0af2aa592b8d1fe0752b141b30d5c8020fd7b57efe65620033a942f9eb9bd98

data/CHANGELOG.md CHANGED Viewed

@@ -9,6 +9,15 @@ and this project aims to adhere to [Semantic Versioning](http://semver.org/spec/
 ### Added
 ### Removed
+## [0.11.0] - 2019-09-23
+### Changed
+- rework configuration so that WebValve has 3 operating modes: off,
+    on+allowing, and on+intercepting. support toggling the latter two
+    modes with
+    `WEBVALVED_ENABLED=1`+`WEBVALVE_SERVICE_ENABLED_DEFAULT=1` and
+    `WEBVALVED_ENABLED=1`+`WEBVALVE_SERVICE_ENABLED_DEFAULT=0`.
+    (https://github.com/Betterment/webvalve/pull/34)
 ## [0.10.0] - 2019-09-23
 ### Changed
 - `Webvalve.register` no longer accepts classes; you must provide class names as strings. Fixes a Rails 6 deprecation warning. (https://github.com/Betterment/webvalve/pull/35)

data/README.md CHANGED Viewed

@@ -227,12 +227,22 @@ not registered.
 ## Frequently Asked Questions
-> Can I use WebValve in environments like staging and demo?
+> Can I use WebValve in environments like staging, demo, and production?
 Yes! By default WebValve is only enabled in test and development
 environments; however, it can be enabled in other environments by
-setting `WEBVALVE_ENABLED=true`. This can be useful for spinning up
-cheap, one-off environments for user-testing or demos.
+setting `WEBVALVE_ENABLED=true` (actually, any of 1/t/true will work).
+This can be useful for spinning up cheap, one-off environments for
+user-testing or demos. When WebValve is enabled in any environment other
+than development/test it will default services to enabled rather than
+disabled, allowing all traffic to pass-thru. This ensures that
+production-like environments are run integrated by default. You can
+change this behavior by setting `WEBVALVE_SERVICE_ENABLED_DEFAULT=false`
+(any of 0/f/false will work). This will default to the same experience
+as local development, defaulting services to disabled, intercepting all
+traffic. In either of these modes, you can use the
+`$SERVICE_ENABLED=true/false` to toggle a specific service into the
+desired state.
 > Can I use WebValve without Rails?

data/lib/webvalve.rb CHANGED Viewed

@@ -3,9 +3,6 @@ require 'active_support'
 require 'active_support/core_ext'
 module WebValve
-  ALWAYS_ENABLED_ENVS = %w(development test).freeze
-  ENABLED_VALUES = %w(1 t true).freeze
   class << self
     # @!method setup
     #   @see WebValve::Manager#setup
@@ -15,23 +12,11 @@ module WebValve
     #   @see WebValve::Manager#allow_url
     # @!method reset
     #   @see WebValve::Manager#reset
-    delegate :setup, :register, :allow_url, :reset, to: :manager
+    # @!method enabled?
+    #   @see WebValve::Manager#enabled?
+    delegate :setup, :register, :allow_url, :reset, :enabled?, to: :manager
     attr_writer :logger
-    def enabled?
-      if env.in?(ALWAYS_ENABLED_ENVS)
-        if ENV.key? 'WEBVALVE_ENABLED'
-          logger.warn(<<~MESSAGE)
-            WARNING: Ignoring WEBVALVE_ENABLED environment variable setting (#{ENV['WEBVALVE_ENABLED']})
-            WebValve is always enabled in development and test environments.
-          MESSAGE
-        end
-        true
-      else
-        ENABLED_VALUES.include?(ENV['WEBVALVE_ENABLED'])
-      end
-    end
     def config_paths
       @config_paths ||= Set.new
     end

data/lib/webvalve/fake_service_config.rb CHANGED Viewed

@@ -7,9 +7,12 @@ module WebValve
       @custom_service_url = url
     end
-    def should_intercept?
-      WebValve.env.test? || # always intercept in test
-        (WebValve.enabled? && !service_enabled_in_env?)
+    def explicitly_enabled?
+      value_from_env.present? && WebValve::ENABLED_VALUES.include?(value_from_env.to_s)
+    end
+    def explicitly_disabled?
+      value_from_env.present? && WebValve::DISABLED_VALUES.include?(value_from_env.to_s)
     end
     def service_url
@@ -24,6 +27,10 @@ module WebValve
     attr_reader :custom_service_url
+    def value_from_env
+      ENV["#{service_name.to_s.upcase}_ENABLED"]
+    end
     def missing_url_message
       <<~MESSAGE
         There is no URL defined for #{service_class_name}.
@@ -36,10 +43,6 @@ module WebValve
       url.to_s.sub(%r(\Ahttp(s)?://[^@/]+@), 'http\1://')
     end
-    def service_enabled_in_env?
-      WebValve::ENABLED_VALUES.include?(ENV["#{service_name.to_s.upcase}_ENABLED"])
-    end
     def default_service_url
       ENV["#{service_name.to_s.upcase}_API_URL"]
     end

data/lib/webvalve/manager.rb CHANGED Viewed

@@ -3,6 +3,10 @@ require 'singleton'
 require 'set'
 module WebValve
+  ALWAYS_ENABLED_ENVS = %w(development test).freeze
+  ENABLED_VALUES = %w(1 t true).freeze
+  DISABLED_VALUES = %w(0 f false).freeze
   # @api private
   class Manager
     include Singleton
@@ -19,16 +23,46 @@ module WebValve
     end
     def setup
-      fake_service_configs.each do |config|
-        if config.should_intercept?
-          webmock_service config
-        else
-          allowlist_service config
+      return unless enabled?
+      if intercepting?
+        fake_service_configs.each do |config|
+          if !WebValve.env.test? && config.explicitly_enabled?
+            allowlist_service config
+          else
+            webmock_service config
+          end
+        end
+        WebMock.disable_net_connect! webmock_disable_options
+        WebMock.enable!
+      end
+      if allowing?
+        fake_service_configs.each do |config|
+          if config.explicitly_disabled?
+            webmock_service config
+          end
+        end
+        if fake_service_configs.any?(&:explicitly_disabled?)
+          WebMock.allow_net_connect!
+          WebMock.enable!
         end
       end
+    end
+    # @api private
+    def enabled?
+      in_always_intercepting_env? || explicitly_enabled?
+    end
+    # @api private
+    def intercepting?
+      in_always_intercepting_env? || (explicitly_enabled? && !services_enabled_by_default?)
+    end
-      WebMock.enable!
-      WebMock.disable_net_connect! webmock_disable_options
+    # @api private
+    def allowing?
+      !in_always_intercepting_env? && explicitly_enabled? && services_enabled_by_default?
     end
     # @api private
@@ -49,6 +83,38 @@ module WebValve
     private
+    def explicitly_enabled?
+      ENABLED_VALUES.include?(ENV['WEBVALVE_ENABLED'])
+    end
+    def services_enabled_by_default?
+      if WebValve.env.in?(ALWAYS_ENABLED_ENVS)
+        if ENV.key? 'WEBVALVE_SERVICE_ENABLED_DEFAULT'
+          WebValve.logger.warn(<<~MESSAGE)
+            WARNING: Ignoring WEBVALVE_SERVICE_ENABLED_DEFAULT environment variable setting (#{ENV['WEBVALVE_SERVICE_ENABLED_DEFAULT']})
+            WebValve is always enabled in intercepting mode in development and test environments.
+          MESSAGE
+        end
+        false
+      else
+        ENABLED_VALUES.include?(ENV.fetch('WEBVALVE_SERVICE_ENABLED_DEFAULT', '1'))
+      end
+    end
+    def in_always_intercepting_env?
+      if WebValve.env.in?(ALWAYS_ENABLED_ENVS)
+        if ENV.key? 'WEBVALVE_ENABLED'
+          WebValve.logger.warn(<<~MESSAGE)
+            WARNING: Ignoring WEBVALVE_ENABLED environment variable setting (#{ENV['WEBVALVE_ENABLED']})
+            WebValve is always enabled in development and test environments.
+          MESSAGE
+        end
+        true
+      else
+        false
+      end
+    end
     def webmock_disable_options
       { allow_localhost: true }.tap do |opts|
         opts[:allow] = allowlisted_url_regexps unless WebValve.env.test?

data/lib/webvalve/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module WebValve
-  VERSION = "0.10.0"
+  VERSION = "0.11.0"
 end

data/spec/dummy/app/assets/config/manifest.js ADDED Viewed

@@ -0,0 +1,3 @@
+//= link_tree ../images
+//= link_directory ../javascripts .js
+//= link_directory ../stylesheets .css

data/spec/dummy/log/test.log CHANGED Viewed

@@ -6,3 +6,19 @@
   [1m[33mWebValve Request Captured (19.5ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
   [1m[33mWebValve Request Captured (0.4ms)[0m  [1m[1mdummy.dev GET /foos [][0m
   [1m[33mWebValve Request Captured (1.8ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (5.2ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (0.3ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (0.3ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (2.9ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (7.0ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (0.3ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (2.7ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (0.4ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (0.5ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (4.3ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (2.1ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (0.3ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (1.7ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (0.4ms)[0m  [1m[1mdummy.dev GET /foos [][0m
+  [1m[33mWebValve Request Captured (4.2ms)[0m  [1m[1mdummy.dev GET /widgets [200][0m
+  [1m[33mWebValve Request Captured (0.3ms)[0m  [1m[1mdummy.dev GET /foos [][0m

data/spec/examples.txt CHANGED Viewed

@@ -1,32 +1,61 @@
-example_id                                             | status | run_time        |
------------------------------------------------------- | ------ | --------------- |
-./spec/webvalve/fake_service_config_spec.rb[1:1:1:1]   | passed | 0.00011 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:1:2]   | passed | 0.00014 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:2:1]   | passed | 0.00012 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:2:2]   | passed | 0.00014 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:2:3]   | passed | 0.00015 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:3:1]   | passed | 0.00012 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:3:2]   | passed | 0.00011 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:3:3:1] | passed | 0.00016 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:1:3:3:2] | passed | 0.00024 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:2:1]     | passed | 0.00132 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:2:2]     | passed | 0.00061 seconds |
-./spec/webvalve/fake_service_config_spec.rb[1:2:3]     | passed | 0.00016 seconds |
-./spec/webvalve/fake_service_spec.rb[1:1]              | passed | 0.0031 seconds  |
-./spec/webvalve/fake_service_spec.rb[1:2:1]            | passed | 0.00281 seconds |
-./spec/webvalve/fake_service_spec.rb[1:2:2]            | passed | 0.02529 seconds |
-./spec/webvalve/manager_spec.rb[1:1]                   | passed | 0.00005 seconds |
-./spec/webvalve/manager_spec.rb[1:2:1]                 | passed | 0.00622 seconds |
-./spec/webvalve/manager_spec.rb[1:3:1]                 | passed | 0.00033 seconds |
-./spec/webvalve/manager_spec.rb[1:4:1]                 | passed | 0.00018 seconds |
-./spec/webvalve/manager_spec.rb[1:5:1]                 | passed | 0.02341 seconds |
-./spec/webvalve/manager_spec.rb[1:5:2]                 | passed | 0.00039 seconds |
-./spec/webvalve/manager_spec.rb[1:5:3]                 | passed | 0.00063 seconds |
-./spec/webvalve/manager_spec.rb[1:5:4:1]               | passed | 0.00038 seconds |
-./spec/webvalve/manager_spec.rb[1:5:5:1]               | passed | 0.00122 seconds |
-./spec/webvalve/manager_spec.rb[1:5:5:2]               | passed | 0.00129 seconds |
-./spec/webvalve/manager_spec.rb[1:5:5:3]               | passed | 0.00181 seconds |
-./spec/webvalve_spec.rb[1:1]                           | passed | 0.0001 seconds  |
-./spec/webvalve_spec.rb[1:2]                           | passed | 0.00449 seconds |
-./spec/webvalve_spec.rb[1:3]                           | passed | 0.00014 seconds |
-./spec/webvalve_spec.rb[1:4]                           | passed | 0.00009 seconds |
+example_id                                         | status | run_time        |
+-------------------------------------------------- | ------ | --------------- |
+./spec/webvalve/fake_service_config_spec.rb[1:1:1] | passed | 0.00032 seconds |
+./spec/webvalve/fake_service_config_spec.rb[1:1:2] | passed | 0.00406 seconds |
+./spec/webvalve/fake_service_config_spec.rb[1:2:1] | passed | 0.00014 seconds |
+./spec/webvalve/fake_service_config_spec.rb[1:2:2] | passed | 0.00015 seconds |
+./spec/webvalve/fake_service_config_spec.rb[1:3:1] | passed | 0.00215 seconds |
+./spec/webvalve/fake_service_config_spec.rb[1:3:2] | passed | 0.00019 seconds |
+./spec/webvalve/fake_service_config_spec.rb[1:3:3] | passed | 0.00013 seconds |
+./spec/webvalve/fake_service_spec.rb[1:1]          | passed | 0.01281 seconds |
+./spec/webvalve/fake_service_spec.rb[1:2:1]        | passed | 0.02669 seconds |
+./spec/webvalve/fake_service_spec.rb[1:2:2]        | passed | 0.03046 seconds |
+./spec/webvalve/manager_spec.rb[1:1]               | passed | 0.0002 seconds  |
+./spec/webvalve/manager_spec.rb[1:2:1]             | passed | 0.00387 seconds |
+./spec/webvalve/manager_spec.rb[1:3:1]             | passed | 0.00026 seconds |
+./spec/webvalve/manager_spec.rb[1:4:1]             | passed | 0.00015 seconds |
+./spec/webvalve/manager_spec.rb[1:5:1:1]           | passed | 0.00027 seconds |
+./spec/webvalve/manager_spec.rb[1:5:2:1]           | passed | 0.00027 seconds |
+./spec/webvalve/manager_spec.rb[1:5:2:2]           | passed | 0.00036 seconds |
+./spec/webvalve/manager_spec.rb[1:5:2:3]           | passed | 0.00681 seconds |
+./spec/webvalve/manager_spec.rb[1:5:2:4]           | passed | 0.00042 seconds |
+./spec/webvalve/manager_spec.rb[1:5:2:5]           | passed | 0.01559 seconds |
+./spec/webvalve/manager_spec.rb[1:5:2:6]           | passed | 0.00192 seconds |
+./spec/webvalve/manager_spec.rb[1:5:3:1:1]         | passed | 0.00026 seconds |
+./spec/webvalve/manager_spec.rb[1:5:3:2:1]         | passed | 0.00053 seconds |
+./spec/webvalve/manager_spec.rb[1:5:3:2:2]         | passed | 0.00066 seconds |
+./spec/webvalve/manager_spec.rb[1:5:3:2:3]         | passed | 0.0004 seconds  |
+./spec/webvalve/manager_spec.rb[1:5:4:1]           | passed | 0.00036 seconds |
+./spec/webvalve/manager_spec.rb[1:5:4:2]           | passed | 0.0007 seconds  |
+./spec/webvalve/manager_spec.rb[1:6:1:1]           | passed | 0.0002 seconds  |
+./spec/webvalve/manager_spec.rb[1:6:1:2]           | passed | 0.00149 seconds |
+./spec/webvalve/manager_spec.rb[1:6:2:1]           | passed | 0.00014 seconds |
+./spec/webvalve/manager_spec.rb[1:6:2:2]           | passed | 0.00109 seconds |
+./spec/webvalve/manager_spec.rb[1:6:2:3]           | passed | 0.00037 seconds |
+./spec/webvalve/manager_spec.rb[1:6:3:1]           | passed | 0.00013 seconds |
+./spec/webvalve/manager_spec.rb[1:6:3:2]           | passed | 0.00012 seconds |
+./spec/webvalve/manager_spec.rb[1:6:3:3]           | passed | 0.0001 seconds  |
+./spec/webvalve/manager_spec.rb[1:6:3:4]           | passed | 0.00011 seconds |
+./spec/webvalve/manager_spec.rb[1:6:3:5]           | passed | 0.00011 seconds |
+./spec/webvalve/manager_spec.rb[1:7:1:1]           | passed | 0.00011 seconds |
+./spec/webvalve/manager_spec.rb[1:7:1:2]           | passed | 0.00045 seconds |
+./spec/webvalve/manager_spec.rb[1:7:2:1]           | passed | 0.00011 seconds |
+./spec/webvalve/manager_spec.rb[1:7:2:2]           | passed | 0.00031 seconds |
+./spec/webvalve/manager_spec.rb[1:7:2:3]           | passed | 0.0001 seconds  |
+./spec/webvalve/manager_spec.rb[1:7:3:1]           | passed | 0.00013 seconds |
+./spec/webvalve/manager_spec.rb[1:7:3:2]           | passed | 0.00012 seconds |
+./spec/webvalve/manager_spec.rb[1:7:3:3]           | passed | 0.00016 seconds |
+./spec/webvalve/manager_spec.rb[1:7:3:4]           | passed | 0.00016 seconds |
+./spec/webvalve/manager_spec.rb[1:7:3:5]           | passed | 0.00011 seconds |
+./spec/webvalve/manager_spec.rb[1:8:1:1]           | passed | 0.00008 seconds |
+./spec/webvalve/manager_spec.rb[1:8:1:2]           | passed | 0.00028 seconds |
+./spec/webvalve/manager_spec.rb[1:8:2:1]           | passed | 0.0001 seconds  |
+./spec/webvalve/manager_spec.rb[1:8:2:2]           | passed | 0.00034 seconds |
+./spec/webvalve/manager_spec.rb[1:8:3:1]           | passed | 0.0001 seconds  |
+./spec/webvalve/manager_spec.rb[1:8:3:2]           | passed | 0.00009 seconds |
+./spec/webvalve/manager_spec.rb[1:8:3:3]           | passed | 0.00008 seconds |
+./spec/webvalve/manager_spec.rb[1:8:3:4]           | passed | 0.00007 seconds |
+./spec/webvalve_spec.rb[1:1]                       | passed | 0.0001 seconds  |
+./spec/webvalve_spec.rb[1:2]                       | passed | 0.00326 seconds |
+./spec/webvalve_spec.rb[1:3]                       | passed | 0.00021 seconds |
+./spec/webvalve_spec.rb[1:4]                       | passed | 0.00042 seconds |

data/spec/webvalve/fake_service_config_spec.rb CHANGED Viewed

@@ -19,114 +19,50 @@ RSpec.describe WebValve::FakeServiceConfig do
   subject { described_class.new service_class_name: fake_service.name }
-  describe '.should_intercept?' do
-    context 'in test env' do
-      around do |ex|
-        with_rails_env 'test' do
-          ex.run
-        end
-      end
-      it 'returns true when DUMMY_ENABLED is unset' do
-        expect(subject.should_intercept?).to eq true
-      end
-      it 'returns true regardless of DUMMY_ENABLED value' do
-        with_env 'DUMMY_ENABLED' => '1' do
-          expect(subject.should_intercept?).to eq true
-        end
-        with_env 'DUMMY_ENABLED' => '0' do
-          expect(subject.should_intercept?).to eq true
-        end
-      end
+  describe '.explicitly_enabled?' do
+    it 'returns false when DUMMY_ENABLED is unset' do
+      expect(subject.explicitly_enabled?).to eq false
     end
-    context 'in development env' do
-      around do |ex|
-        with_rails_env 'development' do
-          ex.run
-        end
+    it 'returns true when DUMMY_ENABLED is truthy' do
+      with_env 'DUMMY_ENABLED' => '1' do
+        expect(subject.explicitly_enabled?).to eq true
       end
-      it 'returns true when DUMMY_ENABLED is unset' do
-        expect(subject.should_intercept?).to eq true
+      with_env 'DUMMY_ENABLED' => 't' do
+        expect(subject.explicitly_enabled?).to eq true
       end
-      it 'returns false when DUMMY_ENABLED is truthy' do
-        with_env 'DUMMY_ENABLED' => '1' do
-          expect(subject.should_intercept?).to eq false
-        end
-        with_env 'DUMMY_ENABLED' => 't' do
-          expect(subject.should_intercept?).to eq false
-        end
-        with_env 'DUMMY_ENABLED' => 'true' do
-          expect(subject.should_intercept?).to eq false
-        end
+      with_env 'DUMMY_ENABLED' => 'true' do
+        expect(subject.explicitly_enabled?).to eq true
       end
-      it 'returns true when DUMMY_ENABLED is not truthy' do
-        with_env 'DUMMY_ENABLED' => '0' do
-          expect(subject.should_intercept?).to eq true
-        end
-        with_env 'DUMMY_ENABLED' => 'f' do
-          expect(subject.should_intercept?).to eq true
-        end
-        with_env 'DUMMY_ENABLED' => 'false' do
-          expect(subject.should_intercept?).to eq true
-        end
-        with_env 'DUMMY_ENABLED' => 'not true or false' do
-          expect(subject.should_intercept?).to eq true
-        end
+      with_env 'DUMMY_ENABLED' => 'not true or false' do
+        expect(subject.explicitly_enabled?).to eq false
       end
     end
+  end
-    context 'in production enviroment' do
-      around do |ex|
-        with_rails_env 'production' do
-          ex.run
-        end
-      end
+  describe '.explicitly_disabled?' do
+    it 'returns false when DUMMY_ENABLED is unset' do
+      expect(subject.explicitly_disabled?).to eq false
+    end
-      it 'returns false' do
-        expect(subject.should_intercept?).to eq false
+    it 'returns true when DUMMY_ENABLED is falsey' do
+      with_env 'DUMMY_ENABLED' => '0' do
+        expect(subject.explicitly_disabled?).to eq true
       end
-      it 'returns false regardless of DUMMY_ENABLED value' do
-        with_env 'DUMMY_ENABLED' => '1' do
-          expect(subject.should_intercept?).to eq false
-        end
+      with_env 'DUMMY_ENABLED' => 'f' do
+        expect(subject.explicitly_disabled?).to eq true
+      end
-        with_env 'DUMMY_ENABLED' => '0' do
-          expect(subject.should_intercept?).to eq false
-        end
+      with_env 'DUMMY_ENABLED' => 'false' do
+        expect(subject.explicitly_disabled?).to eq true
       end
-      context 'when WEBVALVE_ENABLED is true' do
-        around do |ex|
-          with_env 'WEBVALVE_ENABLED' => '1' do
-            ex.run
-          end
-        end
-        it 'returns true' do
-          expect(subject.should_intercept?).to eq true
-        end
-        it 'respects DUMMY_ENABLED flag' do
-          with_env 'DUMMY_ENABLED' => '1' do
-            expect(subject.should_intercept?).to eq false
-          end
-          with_env 'DUMMY_ENABLED' => '0' do
-            expect(subject.should_intercept?).to eq true
-          end
-        end
+      with_env 'DUMMY_ENABLED' => 'not true or false' do
+        expect(subject.explicitly_disabled?).to eq false
       end
     end
   end

data/spec/webvalve/manager_spec.rb CHANGED Viewed

@@ -32,44 +32,67 @@ RSpec.describe WebValve::Manager do
     it 'stores the url' do
       fake = class_double(WebValve::FakeService, name: "FooService")
-      subject.register fake.name, url: 'http://manual.dev'
-      expect(subject.fake_service_configs.first.service_url).to eq 'http://manual.dev'
+      subject.register fake.name, url: 'http://foo.dev'
+      expect(subject.fake_service_configs.first.service_url).to eq 'http://foo.dev'
     end
   end
   describe '#setup' do
-    it 'enables webmock' do
-      allow(WebMock).to receive(:enable!)
+    context 'when WebValve is disabled' do
+      around do |ex|
+        with_rails_env 'production' do
+          # unset
+          with_env 'WEBVALVE_ENABLED' => nil do
+            ex.run
+          end
+        end
+      end
-      subject.setup
+      it 'does not setup webmock' do
+        allow(WebMock).to receive(:allow_net_connect!)
+        allow(WebMock).to receive(:enable!)
-      expect(WebMock).to have_received(:enable!)
+        subject.setup
+        expect(WebMock).not_to have_received(:allow_net_connect!)
+        expect(WebMock).not_to have_received(:enable!)
+      end
     end
-    it 'disables network connections' do
-      allow(WebMock).to receive(:disable_net_connect!)
+    context 'when WebValve is on and intercepting traffic' do
+      around do |ex|
+        with_rails_env 'production' do
+          with_env 'WEBVALVE_ENABLED' => '1', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => '0' do
+            ex.run
+          end
+        end
+      end
-      subject.setup
+      it 'enables webmock' do
+        allow(WebMock).to receive(:enable!)
-      expect(WebMock).to have_received(:disable_net_connect!)
-    end
+        subject.setup
-    it 'allows localhost connections' do
-      allow(WebMock).to receive(:disable_net_connect!)
+        expect(WebMock).to have_received(:enable!)
+      end
-      subject.setup
+      it 'disables network connections' do
+        allow(WebMock).to receive(:disable_net_connect!)
-      expect(WebMock).to have_received(:disable_net_connect!).with(hash_including(allow_localhost: true))
-    end
+        subject.setup
-    context 'in test environment' do
-      around do |example|
-        with_rails_env 'test' do
-          example.run
-        end
+        expect(WebMock).to have_received(:disable_net_connect!)
       end
-      it 'does not allowlist configured urls in webmock' do
+      it 'allows localhost connections' do
+        allow(WebMock).to receive(:disable_net_connect!)
+        subject.setup
+        expect(WebMock).to have_received(:disable_net_connect!).with(hash_including(allow_localhost: true))
+      end
+      it 'allowlists configured urls in webmock' do
         allow(WebMock).to receive(:disable_net_connect!)
         results = [%r{\Ahttp://foo\.dev}, %r{\Ahttp://bar\.dev}]
@@ -78,19 +101,112 @@ RSpec.describe WebValve::Manager do
         subject.setup
-        expect(WebMock).not_to have_received(:disable_net_connect!)
+        expect(WebMock).to have_received(:disable_net_connect!)
           .with(hash_including(allow: results))
       end
+      it 'mocks registered fakes that are not enabled in ENV' do
+        disabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+        web_mock_stubble = double(to_rack: true)
+        allow(WebMock).to receive(:stub_request).and_return(web_mock_stubble)
+        with_env 'SOMETHING_API_URL' => 'http://something.dev' do
+          subject.register disabled_service.name
+          subject.setup
+        end
+        expect(WebMock).to have_received(:stub_request).with(:any, %r{\Ahttp://something\.dev})
+        expect(web_mock_stubble).to have_received(:to_rack)
+      end
+      it 'allowlists registered fakes that are enabled in ENV' do
+        enabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+        with_env 'SOMETHING_ENABLED' => '1', 'SOMETHING_API_URL' => 'http://something.dev' do
+          subject.register enabled_service.name
+          subject.setup
+        end
+        expect(subject.allowlisted_urls).to include 'http://something.dev'
+      end
+    end
+    context 'when WebValve is on and allowing traffic' do
+      around do |ex|
+        with_rails_env 'production' do
+          with_env 'WEBVALVE_ENABLED' => '1', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => '1' do
+            ex.run
+          end
+        end
+      end
+      context 'when there are no services disabled' do
+        it 'does not setup webmock' do
+          allow(WebMock).to receive(:allow_net_connect!)
+          allow(WebMock).to receive(:enable!)
+          subject.setup
+          expect(WebMock).not_to have_received(:allow_net_connect!)
+          expect(WebMock).not_to have_received(:enable!)
+        end
+      end
+      context 'when there are explicitly disabled fake services to stub' do
+        it 'allows network connections and enables webmock' do
+          allow(WebMock).to receive(:allow_net_connect!)
+          allow(WebMock).to receive(:enable!)
+          enabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+          with_env 'SOMETHING_ENABLED' => '0', 'SOMETHING_API_URL' => 'http://something.dev' do
+            subject.register enabled_service.name
+            subject.setup
+          end
+          expect(WebMock).to have_received(:allow_net_connect!)
+          expect(WebMock).to have_received(:enable!)
+        end
+        it 'mocks registered fakes that are explicitly disabled in ENV' do
+          disabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+          other_service = class_double(WebValve::FakeService, name: 'FakeOther')
+          web_mock_stubble = double(to_rack: true)
+          allow(WebMock).to receive(:stub_request).and_return(web_mock_stubble)
+          with_env 'SOMETHING_API_URL' => 'http://something.dev', 'SOMETHING_ENABLED' => '0', 'OTHER_API_URL' => 'http://other.dev' do
+            subject.register disabled_service.name
+            subject.register other_service.name
+            subject.setup
+          end
+          expect(WebMock).to have_received(:stub_request).with(:any, %r{\Ahttp://something\.dev})
+          expect(WebMock).not_to have_received(:stub_request).with(:any, %r{\Ahttp://other\.dev})
+          expect(web_mock_stubble).to have_received(:to_rack).once
+        end
+        it 'does not allowlist registered fakes because the network is enabled' do
+          some_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+          with_env 'SOMETHING_API_URL' => 'http://something.dev' do
+            subject.register some_service.name
+            subject.setup
+          end
+          expect(subject.allowlisted_urls).not_to include 'http://something.dev'
+        end
+      end
     end
-    context 'in non-test environment' do
+    context 'in test environment' do
       around do |example|
-        with_rails_env 'development' do
+        with_rails_env 'test' do
           example.run
         end
       end
-      it 'allowlists configured urls in webmock' do
+      it 'does not allowlist configured urls in webmock' do
         allow(WebMock).to receive(:disable_net_connect!)
         results = [%r{\Ahttp://foo\.dev}, %r{\Ahttp://bar\.dev}]
@@ -99,33 +215,405 @@ RSpec.describe WebValve::Manager do
         subject.setup
-        expect(WebMock).to have_received(:disable_net_connect!)
+        expect(WebMock).not_to have_received(:disable_net_connect!)
           .with(hash_including(allow: results))
       end
-      it 'mocks registered fakes that are not enabled in ENV' do
-        disabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+      it 'fakes all services regardless of ENV settings' do
+        enabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+        disabled_service = class_double(WebValve::FakeService, name: 'FakeSomethingElse')
+        other_service = class_double(WebValve::FakeService, name: 'FakeOther')
         web_mock_stubble = double(to_rack: true)
         allow(WebMock).to receive(:stub_request).and_return(web_mock_stubble)
-        with_env 'SOMETHING_API_URL' => 'http://fake.dev' do
-          subject.register disabled_service.name
+        with_env 'SOMETHING_ENABLED' => '1', 'SOMETHING_ELSE_ENABLED' => '0', 'OTHER_ENABLED' => nil do
+          subject.register disabled_service.name, url: 'http://something.dev'
+          subject.register enabled_service.name, url: 'http://something-else.dev'
+          subject.register other_service.name, url: 'http://other.dev'
           subject.setup
         end
-        expect(WebMock).to have_received(:stub_request).with(:any, %r{\Ahttp://fake\.dev})
-        expect(web_mock_stubble).to have_received(:to_rack)
+        expect(WebMock).to have_received(:stub_request).with(:any, %r{\Ahttp://something\.dev})
+        expect(WebMock).to have_received(:stub_request).with(:any, %r{\Ahttp://something\-else\.dev})
+        expect(WebMock).to have_received(:stub_request).with(:any, %r{\Ahttp://other\.dev})
+        expect(web_mock_stubble).to have_received(:to_rack).exactly(3).times
       end
+    end
+  end
-      it 'allowlists registered fakes that are enabled in ENV' do
-        enabled_service = class_double(WebValve::FakeService, name: 'FakeSomething')
+  describe '.intercepting?' do
+    context 'in test env' do
+      around do |ex|
+        with_rails_env 'test' do
+          ex.run
+        end
+      end
-        with_env 'SOMETHING_ENABLED' => '1', 'SOMETHING_API_URL' => 'http://real.dev' do
-          subject.register enabled_service.name
-          subject.setup
+      it 'returns true when WEBVALVE_ENABLED is unset' do
+        expect(subject.intercepting?).to eq true
+      end
+      it 'returns true regardless of WEBVALVE_ENABLED value' do
+        allow(WebValve.logger).to receive(:warn)
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.intercepting?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.intercepting?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+      end
+    end
+    context 'in development env' do
+      around do |ex|
+        with_rails_env 'development' do
+          ex.run
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is unset' do
+        expect(subject.intercepting?).to eq true
+      end
+      it 'returns true regardless of WEBVALVE_ENABLED value' do
+        allow(WebValve.logger).to receive(:warn)
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.intercepting?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.intercepting?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.intercepting?).to eq true
+        end
+      end
+    end
+    context 'in production enviroment' do
+      around do |ex|
+        with_rails_env 'production' do
+          ex.run
+        end
+      end
+      it 'return false when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.intercepting?).to eq false
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is truthy and WEBVALVE_SERVICE_ENABLED_DEFAULT is set and falsey' do
+        with_env 'WEBVALVE_ENABLED' => '1', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => '0' do
+          expect(subject.intercepting?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 't', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 'f' do
+          expect(subject.intercepting?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 'false' do
+          expect(subject.intercepting?).to eq true
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is truthy and WEBVALVE_SERVICE_ENABLED_DEFAULT is set and truthy' do
+        with_env 'WEBVALVE_ENABLED' => '1', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => '1' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 't', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 't' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 'true' do
+          expect(subject.intercepting?).to eq false
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is truthy but WEBVALVE_SERVICE_ENABLED_DEFAULT is unset' do
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 't' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true' do
+          expect(subject.intercepting?).to eq false
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is not truthy' do
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'f' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'false' do
+          expect(subject.intercepting?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'not true or false' do
+          expect(subject.intercepting?).to eq false
+        end
+      end
+    end
+  end
+  describe '.allowing?' do
+    context 'in test env' do
+      around do |ex|
+        with_rails_env 'test' do
+          ex.run
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is unset' do
+        expect(subject.allowing?).to eq false
+      end
+      it 'returns false regardless of WEBVALVE_ENABLED value' do
+        allow(WebValve.logger).to receive(:warn)
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.allowing?).to eq false
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.allowing?).to eq false
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+      end
+    end
+    context 'in development env' do
+      around do |ex|
+        with_rails_env 'development' do
+          ex.run
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is unset' do
+        expect(subject.allowing?).to eq false
+      end
+      it 'returns false regardless of WEBVALVE_ENABLED value' do
+        allow(WebValve.logger).to receive(:warn)
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.allowing?).to eq false
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.allowing?).to eq false
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.allowing?).to eq false
+        end
+      end
+    end
+    context 'in production enviroment' do
+      around do |ex|
+        with_rails_env 'production' do
+          ex.run
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.allowing?).to eq false
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is truthy and WEBVALVE_SERVICE_ENABLED_DEFAULT is unset' do
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.allowing?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 't' do
+          expect(subject.allowing?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true' do
+          expect(subject.allowing?).to eq true
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is truthy and WEBVALVE_SERVICE_ENABLED_DEFAULT is truthy' do
+        with_env 'WEBVALVE_ENABLED' => '1', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => '1' do
+          expect(subject.allowing?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 't', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 't' do
+          expect(subject.allowing?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 'true' do
+          expect(subject.allowing?).to eq true
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is truthy and WEBVALVE_SERVICE_ENABLED_DEFAULT is set and falsey' do
+        with_env 'WEBVALVE_ENABLED' => '1', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => '0' do
+          expect(subject.allowing?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 't', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 'f' do
+          expect(subject.allowing?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true', 'WEBVALVE_SERVICE_ENABLED_DEFAULT' => 'false' do
+          expect(subject.allowing?).to eq false
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is falsey' do
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.allowing?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'f' do
+          expect(subject.allowing?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'false' do
+          expect(subject.allowing?).to eq false
         end
-        expect(subject.allowlisted_urls).to include 'http://real.dev'
+        with_env 'WEBVALVE_ENABLED' => 'not true or false' do
+          expect(subject.allowing?).to eq false
+        end
+      end
+    end
+  end
+  describe '.enabled?' do
+    context 'in test env' do
+      around do |ex|
+        with_rails_env 'test' do
+          ex.run
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.enabled?).to eq true
+        end
+      end
+      it 'returns true regardless of WEBVALVE_ENABLED value' do
+        allow(WebValve.logger).to receive(:warn)
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.enabled?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.enabled?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+      end
+    end
+    context 'in development env' do
+      around do |ex|
+        with_rails_env 'development' do
+          ex.run
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.enabled?).to eq true
+        end
+      end
+      it 'returns true regardless of WEBVALVE_ENABLED value' do
+        allow(WebValve.logger).to receive(:warn)
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.enabled?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.enabled?).to eq true
+          expect(WebValve.logger).to have_received(:warn).at_least(1)
+        end
+      end
+    end
+    context 'in production enviroment' do
+      around do |ex|
+        with_rails_env 'production' do
+          ex.run
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is unset' do
+        with_env 'WEBVALVE_ENABLED' => nil do
+          expect(subject.enabled?).to eq false
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is falsey' do
+        with_env 'WEBVALVE_ENABLED' => '0' do
+          expect(subject.enabled?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'f' do
+          expect(subject.enabled?).to eq false
+        end
+        with_env 'WEBVALVE_ENABLED' => 'false' do
+          expect(subject.enabled?).to eq false
+        end
+      end
+      it 'returns true when WEBVALVE_ENABLED is truthy' do
+        with_env 'WEBVALVE_ENABLED' => '1' do
+          expect(subject.enabled?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 't' do
+          expect(subject.enabled?).to eq true
+        end
+        with_env 'WEBVALVE_ENABLED' => 'true' do
+          expect(subject.enabled?).to eq true
+        end
+      end
+      it 'returns false when WEBVALVE_ENABLED is an invalid value' do
+        with_env 'WEBVALVE_ENABLED' => 'not true or false' do
+          expect(subject.enabled?).to eq false
+        end
       end
     end
   end

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webvalve
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Sam Moore
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-09-22 00:00:00.000000000 Z
+date: 2019-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -162,6 +162,7 @@ files:
 - lib/webvalve/version.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile
+- spec/dummy/app/assets/config/manifest.js
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
@@ -229,6 +230,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/assets/config/manifest.js
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/helpers/application_helper.rb