webtranslateit-payday 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4cb98acc78809a09e4945f8d8525aee1bbafd3ed17a45234be6fb0a8836f3135
-  data.tar.gz: b3379b263fb55f5d7fdb8ec48d66924e0f0b1110325b43e15bbd0a764fbc6154
+  metadata.gz: e997f24c5936a24f8deb333262cdfb74ecf989ddd229052797211579748a8f8c
+  data.tar.gz: af5120a7dd9edd4a7cf8e980d5090f2c20a2d1e0c32d654aa711c93b777cc429
 SHA512:
-  metadata.gz: c0473911f660484293361d1fbfb7020efed4614c06dd89b000fc7995f90e52b995c763781f175609578fd42090923ed9969baab0d4bffb85140f887356964690
-  data.tar.gz: 0a401edbb42eb073bf35602caaf6c2b7b762450dff19a04f2a8ee4d3ae8aca0ecf2ceab4485300a0647a2005b22116edd2cd1eba0be60a07117f5d44e5637b39
+  metadata.gz: 73f336ccbb26a4e1ab7b98ca3f95cd407e5730d7508884c361049e1ad1120b6a09f02609f44f5edb4e492d5dff0563c3021c16fc72e67756926c50463308875e
+  data.tar.gz: ab853437c9e8d4bcdb647bde8535e0d0a5e18a9e93e5d132be4cebaccec844a5e649915123ac4216d50f832c79604905a3d7eb755b5e5dbae59cfa957d749126

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 2.1.1 (2026-11-08)
+
+* An invoice that defines `date_format` now has its dates formatted with it, the way it could already override `currency`, `invoice_logo`, `page_size`, `company_name` and `company_details`. Every one of those is read through the new `Config#value_for(invoice, property)` (#319, #321). `Payday::Invoice` has no `date_format`, so its output is unchanged.
+* Internal refactoring, no behaviour change: `Invoice#initialize` assigns its options from one list (#314); the invoice rate setters and the `LineItem` setters each share one decimal conversion (#315, #316); `Invoiceable#tax`, `#shipping` and `#retention` are one-liners (#315); `overdue?` reads through `Invoiceable.past?` (#317); `each_detail` is tidied (#318); and two doc comments no longer need RuboCop line-length directives (#320).
+* The code satisfies RuboCop 1.90's `Style/DirectiveScope` cop, the linter runs on Ruby 4.0, and guard and pry are gone from the development setup.
+
 ## 2.1.0 (2026-08-27)
 
 * Add `Payday::Appendix`, for compiling pages of your own onto the end of an invoice. `render_pdf`, `render_pdf_to_file`, `PdfRenderer.render` and `PdfRenderer.render_to_file` all take an `appendix:` keyword; every signature stays backward compatible and an invoice rendered without one is byte-for-byte what it was.

data/lib/payday/config.rb

@@ -18,6 +18,13 @@ module Payday
       @default ||= new
     end
 
+    # The invoice's own value for +property+ when it defines one and it is set, otherwise this
+    # config's. Every setting an invoice can override is read through here.
+    def value_for(invoice, property)
+      value = invoice.public_send(property) if invoice.respond_to?(property)
+      value || public_send(property)
+    end
+
     # Internal: Resets a config object back to its default settings.
     #
     # Primarily intended for use in our tests.

data/lib/payday/invoice.rb

@@ -13,49 +13,30 @@ module Payday
 
     attr_reader :tax_rate, :shipping_rate, :retention_rate
 
-    # rubocop:todo Metrics/PerceivedComplexity
-    # rubocop:todo Metrics/MethodLength
-    # rubocop:todo Metrics/AbcSize
-    def initialize(options = {}) # rubocop:todo Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/MethodLength, Metrics/PerceivedComplexity
-      self.invoice_number = options[:invoice_number] || nil
-      self.bill_to = options[:bill_to] || nil
-      self.ship_to = options[:ship_to] || nil
-      self.notes = options[:notes] || nil
+    # Options assigned as given; a missing one is nil, which the rate setters turn into 0.
+    OPTIONS = %i[invoice_number bill_to ship_to notes shipping_rate shipping_description tax_rate
+                 tax_description retention_rate retention_description due_at paid_at refunded_at
+                 currency invoice_date qr_code].freeze
+
+    def initialize(options = {})
+      OPTIONS.each { |name| public_send(:"#{name}=", options[name]) }
       self.line_items = options[:line_items] || []
-      self.shipping_rate = options[:shipping_rate] || nil
-      self.shipping_description = options[:shipping_description] || nil
-      self.tax_rate = options[:tax_rate] || nil
-      self.tax_description = options[:tax_description] || nil
-      self.retention_rate = options[:retention_rate] || nil
-      self.retention_description = options[:retention_description] || nil
-      self.due_at = options[:due_at] || nil
-      self.paid_at = options[:paid_at] || nil
-      self.refunded_at = options[:refunded_at] || nil
-      self.currency = options[:currency] || nil
       self.invoice_details = options[:invoice_details] || []
-      self.invoice_date = options[:invoice_date] || nil
-      self.qr_code = options[:qr_code] || nil
     end
-    # rubocop:enable Metrics/AbcSize
-    # rubocop:enable Metrics/MethodLength
-    # rubocop:enable Metrics/PerceivedComplexity
 
     # The tax rate that we're applying, as a BigDecimal
     def tax_rate=(value)
-      value = 0 if value.to_s.blank?
-      @tax_rate = BigDecimal(value.to_s)
+      @tax_rate = to_rate(value)
     end
 
     # Shipping rate
     def shipping_rate=(value)
-      value = 0 if value.to_s.blank?
-      @shipping_rate = BigDecimal(value.to_s)
+      @shipping_rate = to_rate(value)
     end
 
     # Retention rate (e.g. IRPF). Applied as a percentage of the subtotal and deducted from the total.
     def retention_rate=(value)
-      value = 0 if value.to_s.blank?
-      @retention_rate = BigDecimal(value.to_s)
+      @retention_rate = to_rate(value)
     end
 
     # Adds a line item
@@ -63,6 +44,13 @@ module Payday
       line_items << Payday::LineItem.new(options)
     end
 
+    private
+
+    # A blank rate (nil, "", "  ") is 0.
+    def to_rate(value)
+      BigDecimal(value.to_s.presence || 0)
+    end
+
   end
 
 end

data/lib/payday/invoice_presenter.rb

@@ -144,7 +144,7 @@ module Payday
     def date(value)
       return value.to_s unless value.is_a?(Date) || value.is_a?(Time)
 
-      value.strftime(Payday::Config.default.date_format)
+      value.strftime(setting(:date_format))
     end
 
     def t(key, default)
@@ -152,9 +152,7 @@ module Payday
     end
 
     def setting(property)
-      return @invoice.send(property) if @invoice.respond_to?(property) && @invoice.send(property)
-
-      Payday::Config.default.send(property)
+      Payday::Config.default.value_for(@invoice, property)
     end
 
   end

data/lib/payday/invoiceable.rb

@@ -12,10 +12,8 @@
 # when generating an invoice. We include a simple tax method that calculates tax, but it's probably wiser
 # to override this in your class (our calculated tax won't be stored to a database by default, for example).
 #
-# rubocop:todo Layout/LineLength
-# If the +due_at+, +paid_at+, and +refunded_at+ methods are available, {Payday::Invoiceable} will use them to show due dates,
-# rubocop:enable Layout/LineLength
-# paid dates, and refunded dates, as well as stamps showing if the invoice is paid or due.
+# If the +due_at+, +paid_at+, and +refunded_at+ methods are available, {Payday::Invoiceable} will use them
+# to show due dates, paid dates, and refunded dates, as well as stamps showing if the invoice is paid or due.
 module Payday
 
   module Invoiceable
@@ -32,31 +30,19 @@ module Payday
 
     # The tax for this invoice, as a BigDecimal
     def tax
-      if defined?(tax_rate)
-        subtotal * tax_rate / 100
-      else
-        0
-      end
+      defined?(tax_rate) ? subtotal * tax_rate / 100 : 0
     end
 
     # TODO: Add a per weight unit shipping cost
     # Calculates the shipping
     def shipping
-      if defined?(shipping_rate)
-        shipping_rate
-      else
-        0
-      end
+      defined?(shipping_rate) ? shipping_rate : 0
     end
 
     # Calculates the retention (e.g. IRPF) as a percentage of the subtotal.
     # This is a post-tax deduction subtracted from the total.
     def retention
-      if defined?(retention_rate)
-        subtotal * retention_rate / 100
-      else
-        0
-      end
+      defined?(retention_rate) ? subtotal * retention_rate / 100 : 0
     end
 
     # Calculates the total for this invoice.
@@ -65,9 +51,17 @@ module Payday
     end
 
     def overdue?
-      # rubocop:todo Layout/LineLength
-      defined?(due_at) && ((due_at.is_a?(Date) && due_at < Date.today) || (due_at.is_a?(Time) && due_at < Time.now)) && !paid_at
-      # rubocop:enable Layout/LineLength
+      defined?(due_at) && Invoiceable.past?(due_at) && !paid_at
+    end
+
+    # Whether a Date is before today or a Time before now. A module function rather than a
+    # private method, so it does not land in the classes that include Invoiceable.
+    def self.past?(moment)
+      case moment
+      when Date then moment < Date.today
+      when Time then moment < Time.now
+      else false
+      end
     end
 
     def refunded?
@@ -92,11 +86,9 @@ module Payday
     # Iterates through the details on this invoiceable. The block given should accept
     # two parameters, the detail name and the actual detail value.
     def each_detail
-      return if defined?(invoice_details).nil?
+      return unless defined?(invoice_details)
 
-      invoice_details.each do |detail|
-        yield(detail[0], detail[1])
-      end
+      invoice_details.each { |detail| yield detail[0], detail[1] }
     end
 
   end

data/lib/payday/line_item.rb

@@ -4,11 +4,9 @@ module Payday
 
   # Represents a line item in an invoice.
   #
-  # rubocop:todo Layout/LineLength
-  # +quantity+ and +price+ are written to be pretty picky, primarily because if we're not picky about what values are set to
-  # rubocop:enable Layout/LineLength
-  # them your invoice math could get pretty messed up. It's recommended that both values be set to +BigDecimal+ values.
-  # Otherwise, we'll do our best to convert the set values to a +BigDecimal+.
+  # +quantity+ and +price+ are written to be pretty picky, primarily because if we're not picky about what
+  # values are set to them your invoice math could get pretty messed up. It's recommended that both values be
+  # set to +BigDecimal+ values. Otherwise, we'll do our best to convert the set values to a +BigDecimal+.
   class LineItem
 
     include LineItemable
@@ -31,20 +29,24 @@ module Payday
 
     # Sets the quantity of this {LineItem}
     def quantity=(value)
-      value = 0 if value.to_s.blank?
-      @quantity = BigDecimal(value.to_s)
+      @quantity = to_decimal(value)
     end
 
     # Sets the price for this {LineItem}
     def price=(value)
-      value = 0 if value.to_s.blank?
-      @price = BigDecimal(value.to_s)
+      @price = to_decimal(value)
     end
 
     # Sets the predefined_amount for this {LineItem}
     def predefined_amount=(value)
-      value = 0 if value.to_s.blank?
-      @predefined_amount = BigDecimal(value.to_s)
+      @predefined_amount = to_decimal(value)
+    end
+
+    private
+
+    # A blank value (nil, "", "  ") is 0.
+    def to_decimal(value)
+      BigDecimal(value.to_s.presence || 0)
     end
 
   end

data/lib/payday/pdf_renderer.rb

@@ -27,19 +27,12 @@ module Payday
     def self.number_to_currency(number, invoice)
       Money.locale_backend = :currency
       Money.rounding_mode = BigDecimal::ROUND_HALF_UP
-      currency = Money::Currency.wrap(currency_for(invoice))
+      currency = Money::Currency.wrap(Payday::Config.default.value_for(invoice, :currency))
       number *= currency.subunit_to_unit
       number = number.round unless Money.default_infinite_precision
       Money.new(number, currency).format
     end
 
-    def self.currency_for(invoice)
-      return invoice.currency if invoice.respond_to?(:currency) && invoice.currency
-
-      Payday::Config.default.currency
-    end
-    private_class_method :currency_for
-
     def initialize(invoice, appendix: nil)
       @invoice = invoice
       @appendix = Appendix.wrap(appendix)
@@ -95,7 +88,7 @@ module Payday
 
     # Config#invoice_logo is either a path or a {filename:, size: "WxH"} Hash.
     def logo
-      setting = invoice_logo
+      setting = Payday::Config.default.value_for(@invoice, :invoice_logo)
       return nil if setting.nil?
 
       path, width, height = logo_parts(setting)
@@ -104,12 +97,6 @@ module Payday
       {name: name, width: width, height: height}
     end
 
-    def invoice_logo
-      return @invoice.invoice_logo if @invoice.respond_to?(:invoice_logo) && @invoice.invoice_logo
-
-      Payday::Config.default.invoice_logo
-    end
-
     def logo_parts(setting)
       return [setting, nil, nil] unless setting.is_a?(Hash)
 

data/payday.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'webtranslateit-payday'
-  s.version     = '2.1.0'
+  s.version     = '2.1.1'
   s.required_ruby_version = '>= 3.2'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Alan Johnson', 'Edouard Briere']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webtranslateit-payday
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Alan Johnson