websocket-driver 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d47eccadd38dcb177ff49770edfe5a8bda26b87
-  data.tar.gz: d4efbfa12364856066684508a2b90abce548b072
+  metadata.gz: 547ad558c91b225fb330155dfda3c4b80fce0ffe
+  data.tar.gz: 87efd4c7a99f2a765badd12237966e6c000e7581
 SHA512:
-  metadata.gz: 220496d4df457463df4d0ccc30d15b8d36ffd9538dfabd01cae84f34155301eae00024afb61cd5ec54cce4f184b599661b449e5a511df8c64f28682234f6f49f
-  data.tar.gz: 5bb3d0fa0fd67ce5fa0c737def048fa880b96a220205ee140c22e3d6d9256612a55d18b1fad4de56973cef5196d2c50df30b5d238967d80db33dcd177abc1fd8
+  metadata.gz: 1dc8274a20b011cb8caf5d5acb8b96a0c0e4312c1e1f7f722de8304124b7249b97eee978e84f110ac4d6988bfcb098709e4430d890f9dc442f809806d0a0a034
+  data.tar.gz: c4780127df20fbb47c9c3c5fedbc33df99fbed323a1b52cf5b4d1dd0e5a812e0fcd11515dcacd6494214759c035a01e657029cbbfac5bd20d98e2138573f9e04

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 0.3.4 / 2014-07-06
+
+* Don't hold references to frame buffers after a message has been emitted
+* Make sure that `protocol` and `version` are exposed properly by the TCP driver
+* Correct HTTP header parsing based on RFC 7230; header names cannot contain backslashes
+
 ### 0.3.3 / 2014-04-24
 
 * Fix problems with loading C and Java native extension code
@@ -45,4 +51,3 @@
 * First release
 * Proof of concept for people to try out
 * Might be unstable
-

data/README.md

@@ -327,4 +327,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
-

data/examples/tcp_server.rb

@@ -24,4 +24,3 @@ end
 EM.run {
   EM.start_server('127.0.0.1', ARGV[0], Connection)
 }
-

data/ext/websocket-driver/WebsocketMaskService.java

@@ -39,6 +39,10 @@ public class WebsocketMaskService implements BasicLibraryService {
 
     @JRubyMethod
     public IRubyObject mask(ThreadContext context, IRubyObject payload, IRubyObject mask) {
+      if (mask.isNil() || ((RubyArray)mask).getLength() == 0) {
+        return payload;
+      }
+
       int n = ((RubyArray)payload).getLength(), i;
       long p, m;
       RubyArray unmasked = RubyArray.newArray(runtime, n);

data/ext/websocket-driver/extconf.rb

@@ -2,4 +2,3 @@ require 'mkmf'
 extension_name = 'websocket_mask'
 dir_config(extension_name)
 create_makefile(extension_name)
-

data/ext/websocket-driver/websocket_mask.c

@@ -13,6 +13,10 @@ void Init_websocket_mask() {
 }
 
 VALUE method_websocket_mask(VALUE self, VALUE payload, VALUE mask) {
+  if (mask == Qnil || RARRAY_LEN(mask) == 0) {
+    return payload;
+  }
+
   int n = RARRAY_LEN(payload), i, p, m;
   VALUE unmasked = rb_ary_new2(n);
 
@@ -30,4 +34,3 @@ VALUE method_websocket_mask(VALUE self, VALUE payload, VALUE mask) {
   }
   return unmasked;
 }
-

data/lib/websocket/driver.rb

@@ -170,7 +170,6 @@ module WebSocket
     end
 
     def self.websocket?(env)
-      return false unless env['REQUEST_METHOD'] == 'GET'
       connection = env['HTTP_CONNECTION'] || ''
       upgrade    = env['HTTP_UPGRADE']    || ''
 
@@ -181,4 +180,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/client.rb

@@ -114,4 +114,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/draft75.rb

@@ -98,4 +98,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/draft76.rb

@@ -95,4 +95,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/event_emitter.rb

@@ -44,4 +44,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/headers.rb

@@ -39,4 +39,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/hybi.rb

@@ -52,14 +52,20 @@ module WebSocket
         super
         reset
 
-        @reader    = StreamReader.new
-        @stage     = 0
-        @masking   = options[:masking]
-        @protocols = options[:protocols] || []
-        @protocols = @protocols.strip.split(/\s*,\s*/) if String === @protocols
-
+        @reader          = StreamReader.new
+        @stage           = 0
+        @masking         = options[:masking]
+        @protocols       = options[:protocols] || []
+        @protocols       = @protocols.strip.split(/\s*,\s*/) if String === @protocols
         @require_masking = options[:require_masking]
         @ping_callbacks  = {}
+
+        return unless @socket.respond_to?(:env)
+
+        if protos = @socket.env['HTTP_SEC_WEBSOCKET_PROTOCOL']
+          protos = protos.split(/\s*,\s*/) if String === protos
+          @protocol = protos.find { |p| @protocols.include?(p) }
+        end
       end
 
       def version
@@ -95,7 +101,7 @@ module WebSocket
               buffer = @reader.read(@length)
               if buffer
                 @payload = buffer
-                emit_frame
+                emit_frame(buffer)
                 @stage = 0
               end
 
@@ -195,25 +201,15 @@ module WebSocket
         sec_key = @socket.env['HTTP_SEC_WEBSOCKET_KEY']
         return '' unless String === sec_key
 
-        accept    = Hybi.generate_accept(sec_key)
-        protos    = @socket.env['HTTP_SEC_WEBSOCKET_PROTOCOL']
-        supported = @protocols
-        proto     = nil
-
         headers = [
           "HTTP/1.1 101 Switching Protocols",
           "Upgrade: websocket",
           "Connection: Upgrade",
-          "Sec-WebSocket-Accept: #{accept}"
+          "Sec-WebSocket-Accept: #{Hybi.generate_accept(sec_key)}"
         ]
 
-        if protos
-          protos = protos.split(/\s*,\s*/) if String === protos
-          proto = protos.find { |p| supported.include?(p) }
-          if proto
-            @protocol = proto
-            headers << "Sec-WebSocket-Protocol: #{proto}"
-          end
+        if @protocol
+          headers << "Sec-WebSocket-Protocol: #{@protocol}"
         end
 
         (headers + [@headers.to_s, '']).join("\r\n")
@@ -243,8 +239,6 @@ module WebSocket
 
         @final   = (data & FIN) == FIN
         @opcode  = (data & OPCODE)
-        @mask    = []
-        @payload = []
 
         unless OPCODES.values.include?(@opcode)
           return fail(:protocol_error, "Unrecognized frame opcode: #{@opcode}")
@@ -299,14 +293,18 @@ module WebSocket
         end
       end
 
-      def emit_frame
-        payload = @masked ? Mask.mask(@payload, @mask) : @payload
+      def emit_frame(buffer)
+        payload  = Mask.mask(buffer, @mask)
+        is_final = @final
+        opcode   = @opcode
 
-        case @opcode
+        @final = @opcode = @length = @length_size = @masked = @mask = nil
+
+        case opcode
           when OPCODES[:continuation] then
             return fail(:protocol_error, 'Received unexpected continuation frame') unless @mode
             @buffer.concat(payload)
-            if @final
+            if is_final
               message = @buffer
               message = Driver.encode(message, :utf8) if @mode == :text
               reset
@@ -318,7 +316,7 @@ module WebSocket
             end
 
           when OPCODES[:text] then
-            if @final
+            if is_final
               message = Driver.encode(payload, :utf8)
               if message
                 emit(:message, MessageEvent.new(message))
@@ -331,7 +329,7 @@ module WebSocket
             end
 
           when OPCODES[:binary] then
-            if @final
+            if is_final
               emit(:message, MessageEvent.new(payload))
             else
               @mode = :binary
@@ -383,4 +381,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/hybi/stream_reader.rb

@@ -27,4 +27,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/server.rb

@@ -33,6 +33,12 @@ module WebSocket
         end
       end
 
+      %w[protocol version].each do |method|
+        define_method(method) do
+          @delegate && @delegate.__send__(method)
+        end
+      end
+
       def parse(buffer)
         return @delegate.parse(buffer) if @delegate
 
@@ -70,4 +76,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/driver/utf8_match.rb

@@ -4,4 +4,3 @@ module WebSocket
     UTF8_MATCH = /^([\x00-\x7F]|[\xC2-\xDF][\x80-\xBF]|\xE0[\xA0-\xBF][\x80-\xBF]|[\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}|\xED[\x80-\x9F][\x80-\xBF]|\xF0[\x90-\xBF][\x80-\xBF]{2}|[\xF1-\xF3][\x80-\xBF]{3}|\xF4[\x80-\x8F][\x80-\xBF]{2})*$/
   end
 end
-

data/lib/websocket/http.rb

@@ -13,4 +13,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/http/headers.rb

@@ -6,7 +6,34 @@ module WebSocket
       CR = 0x0D
       LF = 0x0A
 
-      HEADER_LINE = /^([!#\$%&'\*\+\-\.\\\^_`\|~0-9a-z]+):\s*([\x20-\x7e]*?)\s*$/i
+      # RFC 2616 grammar rules:
+      #
+      #       CHAR           = <any US-ASCII character (octets 0 - 127)>
+      #
+      #       CTL            = <any US-ASCII control character
+      #                        (octets 0 - 31) and DEL (127)>
+      #
+      #       SP             = <US-ASCII SP, space (32)>
+      #
+      #       HT             = <US-ASCII HT, horizontal-tab (9)>
+      #
+      #       token          = 1*<any CHAR except CTLs or separators>
+      #
+      #       separators     = "(" | ")" | "<" | ">" | "@"
+      #                      | "," | ";" | ":" | "\" | <">
+      #                      | "/" | "[" | "]" | "?" | "="
+      #                      | "{" | "}" | SP | HT
+      #
+      # Or, as redefined in RFC 7230:
+      #
+      #       token          = 1*tchar
+      #
+      #       tchar          = "!" / "#" / "$" / "%" / "&" / "'" / "*"
+      #                      / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
+      #                      / DIGIT / ALPHA
+      #                      ; any VCHAR, except delimiters
+
+      HEADER_LINE = /^([!#\$%&'\*\+\-\.\^_`\|~0-9a-z]+):\s*([\x20-\x7e]*?)\s*$/i
 
       attr_reader :headers
 
@@ -74,4 +101,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/http/request.rb

@@ -43,4 +43,3 @@ module WebSocket
 
   end
 end
-

data/lib/websocket/http/response.rb

@@ -27,4 +27,3 @@ module WebSocket
 
   end
 end
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: websocket-driver
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - James Coglan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-24 00:00:00.000000000 Z
+date: 2014-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -105,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: WebSocket protocol handler with pluggable I/O