webroar 0.2.5 → 0.2.6

data/CHANGELOG

@@ -1,3 +1,37 @@
+v0.2.6 - 23-Dec-2009
+--------------------
+
+* Updated messages for HTTP status codes 400, 404, 405, 500 and 501.
+* Fixed buffer overflow by allocating enough memory to hold REQUEST_PATH + 
+Application-Path in the request resolver for static assets.
+* Improved the logic for detection of ruby shared library prerequisite.
+* Started using RUBY_INSTALL_NAME for detecting ruby during installation.
+* Added validation for search results file created while generating service 
+script. Installation would continue even if server cannot be installed as a 
+service.
+* Corrected example for 'Headers' section in the config file.
+* Removed 'SIGCHLD' handler from the worker process - Fixes the incorrect exit 
+status issue for a shell command executed using backquote method of ruby.
+* Added HTTP Date header when the HTTP response status is 100.
+* Used _POSIX_C_SOURCE macro to identify whether the file variable is a 
+pointer to a file or a socket fd.
+* Corrected return type of 'send_static_worker_pid' method, if YAML parser 
+returns NULL value.
+* Corrected time slider based analytics graphs issue when they were being seen 
+after 2300 hrs.
+* Correctly implemented Rack specification for the Response Body. This fixes 
+worker crash seen after serving first request in Development Environment mode 
+for Rails 2.3.4+ applications.
+* Overriding Rack::Deflater to skip response body compression for user-agent 
+Internet Explorer 6.0.
+* Renamed 'log' message defined by rb_define_singleton_method() to 
+'log_message'. This fixes the issue seen when Math.log is called by
+number_to_human_size() in a Rails Application. It also fixes the worker crash 
+on REE installed with tcmalloc library. (Typically used to result in 404 error 
+for a user trying to access the Admin Panel.) Resolves Tickets #9 and #10.
+* Code cleanup in Head, Worker and Helper modules.
+
+
 v0.2.5 - 07-Dec-2009
 --------------------
 

data/lib/dependencies.rb

@@ -37,7 +37,7 @@ module Webroar
     def find
       name = @name
       case (name)
-      when CONFIG['CC'], "make", CONFIG['RUBY_SO_NAME'], "starling"; flag = find_command(name)
+      when Config::CONFIG['CC'], "make", Config::CONFIG['RUBY_INSTALL_NAME'], "starling"; flag = find_command(name)
       when "libsqlite3.so", "sqlite3.h", "gnutls/gnutls.h"; flag = find_so(name)
       when "ruby_headers"; flag = find_ruby_headers()
       when "openssl.so"; flag = find_openssl(name)
@@ -51,11 +51,13 @@ module Webroar
     end
     
     def find_shared_lib()
-      if Config::CONFIG['ENABLE_SHARED'] == 'yes'
-        flag = "\e[32mfound\e[0m."        
+      if File.exist?(File.join(Config::CONFIG['libdir'],Config::CONFIG['LIBRUBY_SO']))
+        flag = "\e[32mfound\e[0m  at #{Config::CONFIG['libdir']}."
+      elsif Config::CONFIG['ENABLE_SHARED'] == 'yes'
+        flag = "\e[32mfound\e[0m."
       else
-        flag="\e[31mnot found\e[0m."        
-      end      
+        flag="\e[31mnot found\e[0m.\nUnable to find #{Config::CONFIG['LIBRUBY_SO']} at #{Config::CONFIG['libdir']}."        
+      end
       return flag
     end
     
@@ -160,13 +162,13 @@ module Webroar
     
   end    
   module Dependencies 
-    GCC = Dependency.new(CONFIG['CC'])
+    GCC = Dependency.new(Config::CONFIG['CC'])
     Gnutls = Dependency.new('gnutls/gnutls.h')
     Make = Dependency.new('make')
     LibRuby = Dependency.new(Config::CONFIG['LIBRUBY_SO'])
     LibSqlite = Dependency.new('libsqlite3.so')
     Ruby_OpenSSL = Dependency.new('openssl-ruby')
-    Ruby = Dependency.new(CONFIG['RUBY_SO_NAME'])
+    Ruby = Dependency.new(Config::CONFIG['RUBY_INSTALL_NAME'])
     Ruby_DevHeaders = Dependency.new('ruby_headers')
     RubyGems = Dependency.new('rubygems')
     Sqlite_DevHeaders = Dependency.new('sqlite3.h')

data/lib/installer.rb

@@ -91,19 +91,28 @@ class Installer
   
   def create_service_link(level, link_name, script_file)
     system("find /etc/ -name rc#{level}.d > /tmp/search_result 2>>#{WEBROAR_ROOT}/install.log")
+
+    return false if !File.size?("/tmp/search_result")
+
     file = File.open("/tmp/search_result")
     line = file.readline.chomp
     file.close()
+    
+    return false if line == nil
+    
     link_file = File.join(line,link_name)
     
-    if line != nil and script_file != nil and !File.symlink?(link_file)
+    if script_file != nil and !File.symlink?(link_file)
       system("ln -s #{script_file} #{link_file} >>#{WEBROAR_ROOT}/install.log 2>>#{WEBROAR_ROOT}/install.log")
     end
+    
+    return true
   end
 
   def create_service
     script = nil
     script_file = nil
+
     if(check_exe_file("chkconfig"))
       script = get_service_script("# chkconfig: 2345 85 15")
     else 
@@ -111,24 +120,32 @@ class Installer
     end
     
     system("find /etc/ -name init.d > /tmp/search_result 2>>#{WEBROAR_ROOT}/install.log")
+    
+    return false if !File.size?("/tmp/search_result")
+    
     file = File.open("/tmp/search_result")
     line = file.readline.chomp
     file.close()
-    if line != nil
-      script_file = File.join("#{line}",'webroar')
-      file = File.open(script_file,"w")
-      file.puts(script)
-      file.close
-      system("chmod +x #{script_file} 2>>#{WEBROAR_ROOT}/install.log")
-    end
     
-    create_service_link("0", 'K15webroar', script_file)
-    create_service_link("1", 'K15webroar', script_file)
-    create_service_link("6", 'K15webroar', script_file)
-    create_service_link("2", 'S85webroar', script_file)
-    create_service_link("3", 'S85webroar', script_file)
-    create_service_link("4", 'S85webroar', script_file)
-    create_service_link("5", 'S85webroar', script_file)
+    return false if line == nil    
+
+    script_file = File.join("#{line}",'webroar')
+
+    file = File.open(script_file,"w")
+    file.puts(script)
+    file.close
+
+    system("chmod +x #{script_file} 2>>#{WEBROAR_ROOT}/install.log")
+    
+    return false if !create_service_link("0", 'K15webroar', script_file)
+    return false if !create_service_link("1", 'K15webroar', script_file)
+    return false if !create_service_link("6", 'K15webroar', script_file)
+    return false if !create_service_link("2", 'S85webroar', script_file)
+    return false if !create_service_link("3", 'S85webroar', script_file)
+    return false if !create_service_link("4", 'S85webroar', script_file)
+    return false if !create_service_link("5", 'S85webroar', script_file)
+    
+    return true
     
   end
 
@@ -142,6 +159,7 @@ class Installer
   def install(options, args)
     ssl = false
     str = ""
+    err_msg = nil
     
     if options[:ssl]
       ssl = true
@@ -225,8 +243,17 @@ class Installer
               if RUBY_PLATFORM =~ /linux/ and !import
                 print "Generating service script ..."
                 # Add service script in '/etc/init.d/' folder
-                create_service()
-                puts " done."
+                if create_service()
+                  puts " done."
+                else
+                  puts " failed."
+                  tmp_msg = "The server could not be installed as a service on this system. Unfortunately, you would have to set it up as a service yourself."
+                  if err_msg
+                    err_msg += tmp_msg
+                  else
+                    err_msg = tmp_msg
+                  end
+                end
               end
               
               puts"WebROaR installed successfully."
@@ -239,6 +266,7 @@ class Installer
               system("webroar start")
               
               install_msg(port, false)
+              puts "Warning: " + err_msg if err_msg
             else
               puts " failed."
               puts "Error while migrating sqlite database. Please refer 'install.log' for details"
@@ -600,7 +628,7 @@ exit 0"
 #                II) Expires value(mandatory) (No of seconds)
 #         Possible value for expires is off or no. of seconds. 
 #         Example:
-#           Header:
+#           Headers:
 #             expires: 3600
 #             expires_by_type:
 #             - ext: png, jpg, gif

data/src/admin_panel/app/controllers/graph_controller.rb

@@ -369,7 +369,7 @@ class GraphController < ApplicationController
     date_str = date_arr[0].split("/")
     start_hour = date_str[3]
     date_str1 = date_arr[1].split("/")
-    end_hour = date_str1[3]
+    end_hour = (date_str1[3] == "0" ? "24" : date_str1[3])
     if start_hour.to_i != end_hour.to_i	
 	    end_hour = end_hour.to_i-1
 	    start_time = Time.local(date_str[0], date_str[1], date_str[2], start_hour, "00", "00")
@@ -588,7 +588,7 @@ class GraphController < ApplicationController
       if session[:start_time] < Time.local(Time.now.year, Time.now.month, Time.now.day, "0","0","0")
 	      end_hour = 24
       else
-	      end_hour = (Time.now.advance(:hours => 1)).hour	
+        end_hour = (Time.now.advance(:hours => 1)).hour
       end	
       start_time = "#{session[:start_time].year}/#{session[:start_time].month}/#{session[:start_time].day}/#{start_hour}"
       end_time = "#{session[:start_time].year}/#{session[:start_time].month}/#{session[:start_time].day}/#{end_hour}"

data/src/admin_panel/app/views/graph/_javascript_partial.html.erb

@@ -21,6 +21,7 @@ along with WebROaR.  If not, see <http://www.gnu.org/licenses/>.
 
 <script type = "text/javascript">
     $j(document).ready(function(){
+      <% end_hour = 24 if end_hour == 0 %>
       $j("#slider_new_<%=count%>").slider({
           range: true,
           animate:true,

data/src/admin_panel/lib/yaml_writer.rb

@@ -125,7 +125,7 @@ class YAMLWriter
 #                II) Expires value(mandatory) (No of seconds)
 #         Possible value for expires is off or no. of seconds. 
 #         Example:
-#           Header:
+#           Headers:
 #             expires: 3600
 #             expires_by_type:
 #             - ext: png, jpg, gif

data/src/head/wr_application.c

@@ -92,7 +92,6 @@ void wr_app_wrk_add_timeout_cb(struct ev_loop *loop, ev_timer *w, int revents) {
 void wr_app_wrk_remove_cb(struct ev_loop *loop, ev_timer *w, int revents) {
   LOG_FUNCTION
   wr_app_t* app = (wr_app_t*) w->data;
-  wr_wkr_t* worker;
 
   ev_timer_stop(loop, &app->t_remove);
 
@@ -439,7 +438,7 @@ int wr_app_remove(wr_svr_t* server, const char* app_name) {
 }
 
 /** Check load balance to add the worker */
-int wr_app_chk_load_to_add_wkr(wr_app_t *app) {
+void wr_app_chk_load_to_add_wkr(wr_app_t *app) {
   if(TOTAL_WORKER_COUNT(app) < app->conf->max_worker) {
     if(app->msg_que->q_count > app->high_ratio) {
       if(!ev_is_active(&app->t_add)) {
@@ -454,7 +453,7 @@ int wr_app_chk_load_to_add_wkr(wr_app_t *app) {
 }
 
 /** Check load balance to remove the worker */
-int wr_app_chk_load_to_remove_wkr(wr_app_t *app) {
+void wr_app_chk_load_to_remove_wkr(wr_app_t *app) {
   //Check load
   if(WR_QUEUE_SIZE(app->wkr_que) > app->conf->min_worker) {
     if(app->msg_que->q_count < app->low_ratio) {

data/src/head/wr_application.h

@@ -61,9 +61,9 @@ int wr_app_wkr_add(wr_app_t*);
 /** Add request message in pending queue */
 int wr_app_message_insert(wr_svr_t*, wr_req_t*);
 /** Check load balance to add the worker */
-int wr_app_chk_load_to_add_wkr(wr_app_t*);
+void wr_app_chk_load_to_add_wkr(wr_app_t*);
 /** Check load balance to remove the worker */
-int wr_app_chk_load_to_remove_wkr(wr_app_t*);
+void wr_app_chk_load_to_remove_wkr(wr_app_t*);
 /** Add newly created worker to application */
 int wr_app_wrk_insert(wr_svr_t *, wr_wkr_t*, const wr_ctl_msg_t*);
 /** Remove application from application list */

data/src/head/wr_config.h

@@ -81,7 +81,7 @@
 // File to store Server process id
 #define WR_PID_FILE  "/var/run/webroar.pid"
 #define WR_SERVER "WebROaR"
-#define WR_VERSION "0.2.5"
+#define WR_VERSION "0.2.6"
 #define WR_MIME_TYPE_PATH "/conf/mime_type.yml"
 #define WR_CONF_PATH "/conf/config.yml"
 #define WR_SERVER_INTERNAL_CONF_PATH "/conf/server_internal_config.yml"
@@ -124,6 +124,7 @@
 #define WR_STR_LEN                64
 #define WR_LONG_STR_LEN            128
 #define WR_LONG_LONG_STR_LEN      512
+#define WR_FILE_PATH_LEN          1024
 
 #define WR_DEFAULT_PREFIX_HASH    5381
 #define WR_MSG_SIZE              1024

data/src/head/wr_configurator.c

@@ -83,9 +83,6 @@ static inline wr_app_conf_t* wr_app_conf_new(wr_svr_conf_t *server) {
 /** Create new configuration with default values */
 static inline wr_conf_t* wr_conf_new() {
   LOG_FUNCTION
-  int i;
-  wr_svr_conf_t  *server;
-  wr_app_conf_t    *app;
   wr_conf_t         *conf;
 
   conf = wr_malloc(wr_conf_t);
@@ -205,7 +202,6 @@ static inline int wr_conf_server_set(wr_conf_t * conf, node_t *root) {
   LOG_FUNCTION
   wr_svr_conf_t  *server = conf->server;
   char *str;
-  size_t len;
 
   // Set server listening port
   str = wr_validate_string(get_node_value(root, WR_CONF_SVR_PORT));
@@ -255,6 +251,7 @@ static inline int wr_conf_server_set(wr_conf_t * conf, node_t *root) {
 #ifdef HAVE_GNUTLS
 
   if(server->flag&WR_SVR_SSL_SUPPORT) {
+  	size_t len;
     struct stat buff;
     // Set certificate path
     str = wr_validate_string(get_node_value(root, WR_CONF_SVR_SSL_CERTIFICATE));
@@ -311,7 +308,7 @@ static inline int wr_conf_server_set(wr_conf_t * conf, node_t *root) {
 
 static int wr_validate_app_host_name(const char *host_name, char *err_msg) {
   LOG_FUNCTION
-  int down_level = 1, label_len, host_name_len, i;
+  int down_level = 1, label_len, i;
   char *label = NULL;
   char tmp_host[256];
   size_t len;
@@ -754,8 +751,7 @@ static inline int wr_chk_host_lists(wr_host_name_t *list1, wr_host_name_t *list2
 /** Removes Application object on repeated host_name. */
 static inline int wr_remove_app_with_dup_host(wr_conf_t *conf) {
   LOG_FUNCTION
-  wr_app_conf_t *app=conf->apps, *tmp_app = NULL, *next_app;
-  wr_host_name_t *host, *tmp_host, *next_host;
+  wr_app_conf_t *app=conf->apps, *tmp_app = NULL;
   short rv = 0;
 
   if(app == NULL) {
@@ -1040,10 +1036,7 @@ void wr_conf_free(wr_conf_t* conf) {
 wr_conf_t* wr_conf_read(const char* root_path) {
   LOG_FUNCTION
   node_t *root;
-  char *str;
   wr_conf_t* conf = NULL;
-  int can_start = 1;
-  struct stat buff;
 
   //Create configuration structure
   conf =  wr_conf_new();

data/src/head/wr_connection.c

@@ -31,15 +31,15 @@ wr_http_status_t;
 
 static wr_http_status_t http_status [] ={
   {100, "100 Continue", ""},
-  {400, "400 Bad Request", "The request could not be understood by the server."},
+  {400, "400 Bad Request", "The request could not be understood by the server due to malformed syntax."},
   {403, "403 Forbidden", "The requested page is forbidden."},
-  {404, "404 Not Found", "The requested page could not be found."},
-  {405, "405 Method Not Allowed", "The request method is not allowed."},
+  {404, "404 Not Found", "The server has not found anything matching the Request-URI."},
+  {405, "405 Method Not Allowed", "The method specified in the Request-Line is not allowed for the resource identified by the Request-URI."},
   {411, "411 Length Required", "The request requires 'Content-Length'."},
   {413, "413 Request Entity Too Large", "The request entity is too large"},
   {414, "414 Request-URI Too Large", "The request URI is too large"},
-  {500, "500 Internal Server Error", "The server is facing some error while processing the request. "},
-  {501, "501 Not Implemented", "The requested method is not implemented"}
+  {500, "500 Internal Server Error", "The server encountered an unexpected condition which prevented it from fulfilling the request."},
+  {501, "501 Not Implemented", "The server does not support the functionality required to fulfill the request."}
 };
 
 #define WR_RESP_BODY "<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">\r\n\
@@ -257,13 +257,16 @@ void wr_conn_err_resp(wr_conn_t *conn, wr_resp_status_t resp_code) {
 
   LOG_DEBUG(DEBUG, "response code = %s",http_status[resp_code].phrase);
   conn->keep_alive = 0;
+  
+  char current_date[WR_STR_LEN];
+  get_time(current_date, WR_STR_LEN);
 
   switch(resp_code) {
   case WR_HTTP_STATUS_100:
     body_len = 0;
     buff_len = sprintf(response_buff, WR_RESP_HEADERS,
-                       http_status[resp_code].phrase, WR_SERVER, WR_VERSION,
-                       body_len, http_status[resp_code].message);
+                       http_status[resp_code].phrase, current_date, WR_SERVER, 
+                       WR_VERSION, body_len, http_status[resp_code].message);
     break;
   case WR_HTTP_STATUS_400:
   case WR_HTTP_STATUS_403:
@@ -285,9 +288,7 @@ void wr_conn_err_resp(wr_conn_t *conn, wr_resp_status_t resp_code) {
                          http_status[resp_code].phrase,http_status[resp_code].phrase+4,
                          http_status[resp_code].message,WR_SERVER, WR_VERSION);
     }
-    
-    char current_date[WR_STR_LEN];
-    get_time(current_date, WR_STR_LEN);
+        
     buff_len = sprintf(response_buff, WR_RESP_HEADERS,
                        http_status[resp_code].phrase, current_date,
                        WR_SERVER, WR_VERSION, body_len, response_body);

data/src/head/wr_controller.c

@@ -53,7 +53,7 @@
 static inline wr_ctl_msg_t* wr_ctl_msg_validate(scgi_t* request, wr_ctl_t* ctl) {
   LOG_FUNCTION
   wr_ctl_msg_t* ctl_msg = wr_malloc(wr_ctl_msg_t);
-  char *val, *val1, *val2;
+  char *val;
   char error[WR_STR_LEN];
 
   ctl->type = WR_CTL_MSG_NONE;
@@ -346,11 +346,8 @@ static void wr_ctl_accept_cb(struct ev_loop *loop, struct ev_io *w, int revents)
 /** Start listening for Workers connect request on Internet socket */
 static inline int wr_ctl_init_on_inet_sock(wr_svr_t *server) {
   LOG_FUNCTION
-  struct linger ling = {
-                         0, 0
-                       };
   struct sockaddr_in addr;
-  int flags = 1, len;
+  int len;
 
   if ((server->ctl->fd = socket(AF_INET, SOCK_STREAM, 0)) == -1) {
     perror("socket()");
@@ -422,7 +419,6 @@ static inline int wr_ctl_init_on_uds(wr_svr_t *server) {
 
   /* Preparing unique controller socket path*/
   pid_t pid=getpid();
-  char pid_str[WR_SHORT_STR_LEN];
   sprintf(sock_path,"%s_%d",WR_CTL_SOCK_PATH,pid);
   size_t len = strlen(sock_path);
 

data/src/head/wr_main.c

@@ -110,7 +110,7 @@ static inline void daemonize() {
   /* first instance continues */
   sprintf(str,"%d\n",getpid());
 
-  int x = write(pid_FD,str,strlen(str)); /* record pid to lockfile */
+  write(pid_FD,str,strlen(str)); /* record pid to lockfile */
   close(pid_FD);
 
   signal(SIGCHLD, SIG_IGN);
@@ -206,7 +206,7 @@ int main(int argc, char *argv[]) {
   char *WR_ROOT = argv[1];
 
   //Initialize logger
-  if(initialize_logger(WR_LOG_FILE) == 0) {
+  if(initialize_logger(WR_LOG_FILE, WR_SERVER, WR_VERSION) == 0) {
     LOG_DEBUG(DEBUG,"Logging started in %s file",WR_LOG_FILE);
   } else {
     printf("Logger initialization failed. Please make sure you have write permission on '/var/log/webroar' directory.");

data/src/head/wr_request.c

@@ -66,7 +66,7 @@ static inline int wr_req_path_set(wr_req_t *req) {
       LOG_DEBUG(DEBUG,"query str len = %d", req->req_query_str.len);
       req->resp_buf_len = sprintf(req->resp_buf,"%s","The request query string is too large.");
       wr_req_invalid(req->conn, WR_HTTP_STATUS_413);
-      return;
+      return -1;
     }
 
     // Set host and request path
@@ -91,7 +91,7 @@ static inline int wr_req_path_set(wr_req_t *req) {
           LOG_DEBUG(DEBUG,"req path len = %d", req->req_path.len);
           req->resp_buf_len = sprintf(req->resp_buf,"%s","The request path is too large.");
           wr_req_invalid(req->conn, WR_HTTP_STATUS_413);
-          return;
+          return -1;
         }
       } else {
         host_len = req->req_uri.len - (ptr - req->req_uri.str);
@@ -179,7 +179,6 @@ static int wr_req_header_length_check(wr_req_t *req, size_t length, int index){
 void wr_req_header_field_cb(ebb_request* request, const char *at, size_t length, int header_index) {
   wr_req_t* req = (wr_req_t*) request->data;
   short status = wr_req_header_length_check(req, length, header_index);
-  size_t i;
 
   if(status != 0){
     wr_req_invalid(req->conn, status);
@@ -264,7 +263,6 @@ void wr_query_string_cb(ebb_request* request, const char *at, size_t length) {
 void wr_req_uri_cb(ebb_request* request, const char *at, size_t length) {
   LOG_FUNCTION
   wr_req_t* req =(wr_req_t*) request->data;
-  char *value=NULL;
 
   if(req->req_uri.len + length > WR_MAX_REQ_URI_LEN) {
     LOG_DEBUG(DEBUG,"req uri len = %d",__FUNCTION__, req->req_uri.len);
@@ -457,7 +455,6 @@ void wr_headers_complete_cb(ebb_request * request) {
 void wr_req_complete_cb(ebb_request * request) {
   LOG_FUNCTION
   wr_req_t* req = (wr_req_t*) request->data;
-  short retval;
   LOG_DEBUG(DEBUG,"req = %d",req->id);
   // Rewind file pointer if request body is written into file
   if(req->upload_file) {

data/src/head/wr_resolver.c

@@ -43,7 +43,7 @@ void wr_req_resolver_print(wr_req_resolver_t* resolver) {
 /** Resolve static content */
 int wr_req_resolve_static_content(wr_req_t *req){
   LOG_FUNCTION
-  char path[WR_LONG_STR_LEN];
+  char path[WR_FILE_PATH_LEN + WR_MAX_REQ_PATH_LEN];
   char *req_path;
   struct stat buf;
   int len;
@@ -297,7 +297,7 @@ int wr_req_resolve_http_req(wr_svr_t *server, wr_req_t *req) {
   }
 
   if(app && app->wkr_que->q_count > 0) {
-    int rv = 0;
+//    int rv = 0;
     req->app = app;
     wr_req_resolve_static_content(req);
     LOG_DEBUG(DEBUG,"Application resolved with %s.", req->app->conf->name.str);

data/src/head/wr_server.c

@@ -25,7 +25,6 @@ struct ev_idle idle_watcher;  //Ideal watcher
 /** Create Server */
 wr_svr_t* wr_svr_new(struct ev_loop* loop, wr_conf_t* conf) {
   LOG_FUNCTION
-  int i;
   wr_svr_t* server = wr_malloc(wr_svr_t);
 
   if(!server) {
@@ -163,7 +162,6 @@ int wr_svr_init(wr_svr_t** server, wr_conf_t *conf) {
 /** Destroy Server */
 void wr_svr_free(wr_svr_t* server) {
   LOG_FUNCTION
-  int i;
   //Destroy ebb server object
   ebb_server_unlisten(&(server->ebb_svr));
 

data/src/head/wr_worker.c

@@ -308,7 +308,6 @@ static void wr_req_body_write_cb(struct ev_loop *loop, struct ev_io *w, int reve
 //whenever there is a pending request for processing and worker's fd is ready for write, it will dump serialized data to worker by this function
 static void wr_req_hearer_write_cb(struct ev_loop *loop, struct ev_io *w, int revents) {
   LOG_FUNCTION
-  int error_flag=0;
   wr_req_t* req = (wr_req_t*) w->data;
   wr_wkr_t *worker = req->wkr;
   LOG_DEBUG(DEBUG,"Request %d",req->id);
@@ -500,7 +499,6 @@ void wr_wkr_free(wr_wkr_t *worker) {
 int wr_wkr_remove(wr_wkr_t *worker, int flag) {
   LOG_FUNCTION
   wr_app_t* app = worker->app;
-  int i, index;
 
   if(worker->state & WR_WKR_ACTIVE)
     worker->state -= WR_WKR_ACTIVE;
@@ -537,7 +535,6 @@ int wr_wkr_create(wr_svr_t *server, wr_app_conf_t *app_conf) {
   char   cuid_s[WR_SHORT_STR_LEN],
   cgid_s[WR_SHORT_STR_LEN],
   controller_path[WR_LONG_STR_LEN],
-  analytics [WR_SHORT_STR_LEN],
   log_level[WR_SHORT_STR_LEN];
 
   wr_str_t baseuri;
@@ -648,7 +645,6 @@ void wr_wkr_dispatch_req(wr_req_t* req) {
 /** Handle connect request from Worker */
 int wr_wkr_connect(wr_ctl_t *ctl, const wr_ctl_msg_t *ctl_msg) {
   LOG_FUNCTION
-  int retval;
   wr_svr_t* server = ctl->svr;
   wr_wkr_t* worker = NULL;
 

data/src/helper/wr_logger.c

@@ -29,7 +29,6 @@
 #include<errno.h>
 
 static inline char* get_date_time();
-static inline char* get_executable_path();
 static inline char* get_log_file_path();
 
 //this macro should included in common utility
@@ -76,10 +75,7 @@ void redirect_standard_io() {
 }
 
 /** Initialize logger */
-int initialize_logger(const char*file_name) {
-  char *path=NULL;
-
-  int retval;
+int initialize_logger(const char*file_name, const char *server, const char *version) {
   const char *PATH_SEPARATOR = "/";//in windows we'll need forward slash
   log_file_path=(char*)malloc(sizeof(char)*512);
   null_check(log_file_path);
@@ -105,7 +101,7 @@ int initialize_logger(const char*file_name) {
     }
   }
 
-  fprintf(log_fp,"\nLog file opened at %s",get_date_time());
+  fprintf(log_fp,"\n%s-%s: Log file opened at %s",server, version, get_date_time());
   fclose(log_fp);
   return 0;
 }
@@ -145,7 +141,7 @@ char* get_log_level_string(LOG_SEVERITY level){
   case WARN: return "WARN";
   case SEVERE: return "SEVERE";
   case FATAL: return "FATAL";
-  default: "Unknown";
+  default: return "Unknown";
   }
 }
 
@@ -166,6 +162,7 @@ LOG_SEVERITY get_log_severity(const char*str) {
   if(strcmp(str,"FATAL") == 0) {
     return FATAL;
   }
+  return DEBUG;
 }
 
 /** Change log file group-owner to given group and user id */
@@ -174,7 +171,7 @@ int change_log_file_owner(int user_id, int group_id) {
 }
 
 /** Set logging level */
-int set_log_severity(int severity) {
+void set_log_severity(int severity) {
   LOG_INFO("setting log level to %s", get_log_level_string(severity));
   logging_level = severity;
 }

data/src/helper/wr_logger.h

@@ -65,11 +65,11 @@ typedef enum
 #define LOG_FUNCTION LOG_DEBUG(DEBUG,"%s()", __FUNCTION__);
 
 void   close_logger();
-int     initialize_logger(const char*file_name); //prerequisite to use logger
+int     initialize_logger(const char*file_name, const char *server, const char *version); //prerequisite to use logger
 void   a_log(const char* type,LOG_SEVERITY level,const char* format,...);
 void   a_error(LOG_SEVERITY level, const char *file_name, int line_no, const char *function_name, const char *format, ...);
 int change_log_file_owner(int user_id, int group_id);
 LOG_SEVERITY get_log_severity(const char*str);
-int   set_log_severity(int);
+void   set_log_severity(int);
 void redirect_standard_io();
 #endif //end of wr_logger.h

data/src/helper/wr_yaml_parser.c

@@ -147,7 +147,7 @@ node_t* yaml_parse(const char*file_name) {
   yaml_event_t event;
   node_t *node, *config = NULL, *prev;
   int done = 0, is_key = 0, seq_count = -1, is_seq = 0;
-  char key[100], value[100], seq[10][100];
+  char seq[10][100];
   node_t* stack[100];
   int head = -1;
 

data/src/ruby_lib/ruby_interface/client.rb

@@ -62,8 +62,15 @@ module Webroar
       false
     end
     
-    def write_body(body)   
-      if body.kind_of?(String)
+    def write_body(body)
+      if body.respond_to?(:to_path) and File.exists?(body.to_path)    
+        #TODO: Implement 'sendfile' call for kernel-to-kernel transfer.
+        file = File.open(body.to_path, 'rb')
+        while content = file.read(Webroar::READ_CHUNK_SIZE)
+          Webroar::client_write_body(self, content)
+        end
+        file.close
+      elsif body.kind_of?(String)
         Webroar::client_write_body(self, body)
       else        
         body.each {|p|