webpacker 5.4.3 → 6.0.0.beta

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00dd2b0d467a3655a30845e4c4d6df2bd3281246aad18c04a666acb1c4ff7ae9
-  data.tar.gz: d6443bedb7c1f9e74cf654c06e016c3d4e378a3ddb962a05c597294c08143c69
+  metadata.gz: 19faa9561fccec8279b1d8031c2a386c44554ba0f24acc048ec4856853900fc5
+  data.tar.gz: a10901426f6b8ff524c243ddc21392ada8cf189fd85d63d3a6b558cd71b4237f
 SHA512:
-  metadata.gz: 5287ab184e4ec80391ad2443ffffa0037cdfa2102e9a9020773f215033cbff4b975a3a34336f9f4c5a25886aacba2580e20708450a4e0ffde05df2d17b18771e
-  data.tar.gz: c29cbe442f4e2c29964ad29726cbb48c4460fbbb4f813f6e5c5b7816b3c16b3679ef4101af3889a2cf9c25a32a46632fc50798f548ca7cdf8004e232d34f8144
+  metadata.gz: cda09944b075aa8da83a0c568f656d63b040b4c110b5a87f1e5962b60c24e63d70020a4648c1133674611a64178f048ad081128ea891df1950f82957e7a2a5da
+  data.tar.gz: aa72ec1ac73614d32405ca4dfbfbd05e910167599b30e9ed91b3360bdbc0ba12db577fb55096942f6e1a468e21e1e05ccf8bfc5b80596fb3f68e187a73fe1a63

data/.eslintrc.js

@@ -1,5 +1,5 @@
 module.exports = {
-  extends: 'airbnb',
+  extends: ['airbnb', 'prettier'],
   rules: {
     'comma-dangle': ['error', 'never'],
     'import/no-unresolved': 'off',

data/.github/workflows/ruby.yml

@@ -29,6 +29,18 @@ jobs:
             gemfile: gemfiles/Gemfile-rails.6.0.x
         experimental: [false]
         include:
+          - ruby: head
+            os: ubuntu-latest
+            gemfile: gemfiles/Gemfile-rails.6.0.x
+            experimental: true
+          - ruby: head
+            os: ubuntu-latest
+            gemfile: gemfiles/Gemfile-rails-edge
+            experimental: true
+          - ruby: 2.6
+            os: ubuntu-latest
+            gemfile: gemfiles/Gemfile-rails-edge
+            experimental: true
           - ruby: 2.7
             os: ubuntu-latest
             gemfile: gemfiles/Gemfile-rails-edge

data/.gitignore

@@ -1,5 +1,6 @@
 /.bundle
 /pkg
+/test/mounted_app/test/dummy/log
 /test/test_app/log
 node_modules
 .byebug_history
@@ -9,3 +10,4 @@ yarn-error.log*
 .yarn-integrity
 /log
 gemfiles/*.lock
+.DS_Store

data/.node-version

@@ -1 +1 @@
-10.17.0
+10.22.1

data/.rubocop.yml

@@ -5,9 +5,9 @@ AllCops:
   # to ignore them, so only the ones explicitly set in this file are enabled.
   DisabledByDefault: true
   Exclude:
-    - 'lib/install/templates/**'
-    - 'vendor/**/*'
-    - 'node_modules/**/*'
+    - "lib/install/templates/**"
+    - "vendor/**/*"
+    - "node_modules/**/*"
 
 # Prefer &&/|| over and/or.
 Style/AndOr:
@@ -118,108 +118,3 @@ Layout/EndAlignment:
 # Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
 Lint/RequireParentheses:
   Enabled: true
-
-# Use `bind_call(obj, args, ...)` instead of `bind(obj).call(args, ...)`.
-Performance/BindCall:
-  Enabled: true
-
-# Use `caller(n..n)` instead of `caller`.
-Performance/Caller:
-  Enabled: true
-
-# Use `casecmp` for case comparison.
-Performance/Casecmp:
-  Enabled: true
-
-# Extract Array and Hash literals outside of loops into local variables or constants.
-Performance/CollectionLiteralInLoop:
-  Enabled: true
-
-# Prefer `sort_by(&:foo)` instead of `sort { |a, b| a.foo <=> b.foo }`.
-Performance/CompareWithBlock:
-  Enabled: true
-
-# Use `count` instead of `{select,find_all,filter,reject}...{size,count,length}`.
-Performance/Count:
-  Enabled: true
-
-# Use `delete_prefix` instead of `gsub`.
-Performance/DeletePrefix:
-  Enabled: true
-
-# Use `delete_suffix` instead of `gsub`.
-Performance/DeleteSuffix:
-  Enabled: true
-
-# Use `detect` instead of `select.first`, `find_all.first`, `filter.first`, `select.last`, `find_all.last`, and `filter.last`.
-Performance/Detect:
-  Enabled: true
-
-# Use `str.{start,end}_with?(x, ..., y, ...)` instead of `str.{start,end}_with?(x, ...) || str.{start,end}_with?(y, ...)`.
-Performance/DoubleStartEndWith:
-  Enabled: true
-
-# Use `end_with?` instead of a regex match anchored to the end of a string.
-Performance/EndWith:
-  Enabled: true
-
-# Do not compute the size of statically sized objects except in constants.
-Performance/FixedSize:
-  Enabled: true
-
-# Use `Enumerable#flat_map` instead of `Enumerable#map...Array#flatten(1).
-Performance/FlatMap:
-  Enabled: true
-
-# Use `key?` or `value?` instead of `keys.include?` or `values.include?`.
-Performance/InefficientHashSearch:
-  Enabled: true
-
-# Use `Range#cover?` instead of `Range#include?` (or `Range#member?`).
-Performance/RangeInclude:
-  Enabled: true
-
-# Use `yield` instead of `block.call`.
-Performance/RedundantBlockCall:
-  Enabled: true
-
-# Use `=~` instead of `String#match` or `Regexp#match` in a context where the returned `MatchData` is not needed.
-Performance/RedundantMatch:
-  Enabled: true
-
-# Use Hash#[]=, rather than Hash#merge! with a single key-value pair.
-Performance/RedundantMerge:
-  Enabled: true
-
-# Use `match?` instead of `Regexp#match`, `String#match`, `Symbol#match`, `Regexp#===`, or `=~` when `MatchData` is not used.
-Performance/RegexpMatch:
-  Enabled: true
-
-# Use `reverse_each` instead of `reverse.each`.
-Performance/ReverseEach:
-  Enabled: true
-
-# Use `size` instead of `count` for counting the number of elements in `Array` and `Hash`.
-Performance/Size:
-  Enabled: true
-
-# Use `start_with?` instead of a regex match anchored to the beginning of a string.
-Performance/StartWith:
-  Enabled: true
-
-# Use `tr` instead of `gsub` when you are replacing the same number of characters.
-# Use `delete` instead of `gsub` when you are deleting characters.
-Performance/StringReplacement:
-  Enabled: true
-
-# Checks for .times.map calls.
-Performance/TimesMap:
-  Enabled: true
-
-# Use unary plus to get an unfrozen string literal.
-Performance/UnfreezeString:
-  Enabled: true
-
-# Use `URI::DEFAULT_PARSER` instead of `URI::Parser.new`.
-Performance/UriDefaultParser:
-  Enabled: true

data/6_0_upgrade.md

@@ -0,0 +1,43 @@
+# To webpacker v6 from v5
+
+This guide aims to help you migrating to webpacker 6. If you are using
+vanilla webpacker install then hopefully, the upgrade should be really
+straightforward.
+
+## Preparation
+
+- Rename `config/webpack` to `config/webpack_old`
+- Rename `config/webpacker.yml` to `config/webpacker_old.yml`
+- Upgrade webpacker
+
+  ```ruby
+  # Gemfile
+  gem 'webpacker', '~> 6.x'
+  ```
+
+  ```
+  bundle
+  ```
+
+  ```bash
+  yarn add @rails/webpacker@next
+  ```
+
+  ```bash
+  bundle exec rails webpacker:install
+  ```
+
+- Change `javascript_pack_tag` and `stylesheet_pack_tag` to `javascript_packs_with_chunks_tag` and
+  `stylesheet_packs_with_chunks_tag`
+
+- If you are using any integrations like css, react or typescript. Please see https://github.com/rails/webpacker#integrations section on how they work in v6.0
+
+- Copy over any custom webpack config from `config/webpack_old`
+
+  ```js
+  // config/webpack/base.js
+  const { webpackConfig, merge } = require('@rails/webpacker')
+  const customConfig = require('./custom')
+
+  module.exports = merge(webpackConfig, customConfig)
+  ```

data/CHANGELOG.md

@@ -2,35 +2,36 @@
 
 **Please note that Webpacker 4.1.0 has an installer bug. Please use 4.2.0 or above**
 
-## [[5.4.2]](https://github.com/rails/webpacker/compare/v5.4.0...v5.4.1) - 2021-08-20
+## [[6.0.0]](https://github.com/rails/webpacker/compare/v5.1.1...master) - 2021-TBD
 
-- Fix babel warning about private-methods in @babel/plugin-proposal-private-property-in-object as well.
+- `node_modules` will no longer be compiled by default. This primarily fixes [rails issue #35501](https://github.com/rails/rails/issues/35501) as well as [numerous other webpacker issues](https://github.com/rails/webpacker/issues/2131#issuecomment-581618497). The disabled loader can still be required explicitly via:
 
-## [[5.4.1]](https://github.com/rails/webpacker/compare/v5.4.0...v5.4.1) - 2021-08-20
-
-- Update all dependencies within the same major version (#3120)
-
-- Fix babel warning about private-methods (#3016)
-
-## [[5.4.0]](https://github.com/rails/webpacker/compare/v5.3.0...v5.4.0) - 2021-05-18
-
-- Fix compatibility with Psych 4
-
-## [[5.3.0]](https://github.com/rails/webpacker/compare/v5.2.1...v5.3.0) - 2021-04-27
+```js
+const nodeModules = require('@rails/webpacker/rules/node_modules.js')
+environment.loaders.append('nodeModules', nodeModules)
+```
 
+- If you have added `environment.loaders.delete('nodeModules')` to your `environment.js`, this must be removed or you will receive an error (`Item nodeModules not found`).
+- The install task will now set the `extract_css` default to `true` in all environments and generate a separate `application.css` file for the default `application` pack, as supported by multiple files per entry introduced in 5.0.0. [#2608](https://github.com/rails/webpacker/pull/2608)
+- Webpacker's wrapper to the `splitChunks()` API will now default `runtimeChunk: 'single'` which will help prevent potential issues when using multiple entry points per page [#2708](https://github.com/rails/webpacker/pull/2708).
+- Changes `@babel/preset-env` modules option to `'auto'` per recommendation in the Babel docs [#2709](https://github.com/rails/webpacker/pull/2709)
 - Adds experimental Yarn 2 support. Note you must manually set `nodeLinker: node-modules` in your `.yarnrc.yml`.
 
-- Keep backups, even when they're old [#2912](https://github.com/rails/webpacker/pull/2912)
+### Breaking changes
 
-## [[5.2.2]](https://github.com/rails/webpacker/compare/v5.2.1...v5.2.2) - 2021-04-27
+- Simple webpack config
+- Removed integration installers
+- Splitchunks enabled by default
+- CSS extraction enabled by default
+- Optional CSS support
 
-- Bump deps and remove node-sass [#2997](https://github.com/rails/webpacker/pull/2997).
+Please see upgrade [guide](./6_0_upgrade.md)
 
-## [[5.2.1]](https://github.com/rails/webpacker/compare/v5.2.0...v5.2.1) - 2020-08-17
+## [[5.2.1]](https://github.com/rails/webpacker/compare/v5.2.0...5.2.1) - 2020-08-17
 
 - Revert [#1311](https://github.com/rails/webpacker/pull/1311).
 
-## [[5.2.0]](https://github.com/rails/webpacker/compare/v5.1.1...v5.2.0) - 2020-08-16
+## [[5.2.0]](https://github.com/rails/webpacker/compare/v5.1.1...5.2.0) - 2020-08-16
 
 - Bump dependencies and fixes. See [diff](https://github.com/rails/webpacker/compare/v5.1.1...5-x-stable) for changes.
 

data/CONTRIBUTING.md

@@ -9,7 +9,7 @@ yarn
 ```
 
 ## Making sure your changes pass all tests
-There are a number of automated checks which run on Travis CI when a pull request is created.
+There are a number of automated checks which run on Github Actions when a pull request is created.
 You can run those checks on your own locally to make sure that your changes would not break the CI build.
 
 ### 1. Check the code for JavaScript style violations

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    webpacker (5.4.0)
+    webpacker (6.0.0.beta)
       activesupport (>= 5.2)
       rack-proxy (>= 0.6.1)
       railties (>= 5.2)
@@ -10,128 +10,124 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (6.1.3.2)
-      actionpack (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
+    actioncable (6.0.3.2)
+      actionpack (= 6.0.3.2)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailbox (6.1.3.2)
-      actionpack (= 6.1.3.2)
-      activejob (= 6.1.3.2)
-      activerecord (= 6.1.3.2)
-      activestorage (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
+    actionmailbox (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activejob (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      activestorage (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       mail (>= 2.7.1)
-    actionmailer (6.1.3.2)
-      actionpack (= 6.1.3.2)
-      actionview (= 6.1.3.2)
-      activejob (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
+    actionmailer (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      actionview (= 6.0.3.2)
+      activejob (= 6.0.3.2)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (6.1.3.2)
-      actionview (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
-      rack (~> 2.0, >= 2.0.9)
+    actionpack (6.0.3.2)
+      actionview (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
+      rack (~> 2.0, >= 2.0.8)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actiontext (6.1.3.2)
-      actionpack (= 6.1.3.2)
-      activerecord (= 6.1.3.2)
-      activestorage (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
+    actiontext (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      activestorage (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       nokogiri (>= 1.8.5)
-    actionview (6.1.3.2)
-      activesupport (= 6.1.3.2)
+    actionview (6.0.3.2)
+      activesupport (= 6.0.3.2)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activejob (6.1.3.2)
-      activesupport (= 6.1.3.2)
+    activejob (6.0.3.2)
+      activesupport (= 6.0.3.2)
       globalid (>= 0.3.6)
-    activemodel (6.1.3.2)
-      activesupport (= 6.1.3.2)
-    activerecord (6.1.3.2)
-      activemodel (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
-    activestorage (6.1.3.2)
-      actionpack (= 6.1.3.2)
-      activejob (= 6.1.3.2)
-      activerecord (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
-      marcel (~> 1.0.0)
-      mini_mime (~> 1.0.2)
-    activesupport (6.1.3.2)
+    activemodel (6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activerecord (6.0.3.2)
+      activemodel (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activestorage (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activejob (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      marcel (~> 0.3.1)
+    activesupport (6.0.3.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 1.6, < 2)
-      minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    ast (2.4.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    ast (2.4.1)
     builder (3.2.4)
     byebug (11.1.3)
-    concurrent-ruby (1.1.8)
+    concurrent-ruby (1.1.6)
     crass (1.0.6)
-    erubi (1.10.0)
+    erubi (1.9.0)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
-    i18n (1.8.10)
+    i18n (1.8.5)
       concurrent-ruby (~> 1.0)
-    loofah (2.9.1)
+    loofah (2.6.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
     mail (2.7.1)
       mini_mime (>= 0.1.1)
-    marcel (1.0.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
     method_source (1.0.0)
-    mini_mime (1.0.3)
-    mini_portile2 (2.5.1)
-    minitest (5.14.4)
-    nio4r (2.5.7)
-    nokogiri (1.11.4)
-      mini_portile2 (~> 2.5.0)
-      racc (~> 1.4)
-    parallel (1.20.1)
-    parser (3.0.1.1)
+    mimemagic (0.3.5)
+    mini_mime (1.0.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.1)
+    nio4r (2.5.2)
+    nokogiri (1.10.10)
+      mini_portile2 (~> 2.4.0)
+    parallel (1.19.2)
+    parser (2.7.2.0)
       ast (~> 2.4.1)
-    racc (1.5.2)
     rack (2.2.3)
     rack-proxy (0.6.5)
       rack
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
-    rails (6.1.3.2)
-      actioncable (= 6.1.3.2)
-      actionmailbox (= 6.1.3.2)
-      actionmailer (= 6.1.3.2)
-      actionpack (= 6.1.3.2)
-      actiontext (= 6.1.3.2)
-      actionview (= 6.1.3.2)
-      activejob (= 6.1.3.2)
-      activemodel (= 6.1.3.2)
-      activerecord (= 6.1.3.2)
-      activestorage (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
-      bundler (>= 1.15.0)
-      railties (= 6.1.3.2)
+    rails (6.0.3.2)
+      actioncable (= 6.0.3.2)
+      actionmailbox (= 6.0.3.2)
+      actionmailer (= 6.0.3.2)
+      actionpack (= 6.0.3.2)
+      actiontext (= 6.0.3.2)
+      actionview (= 6.0.3.2)
+      activejob (= 6.0.3.2)
+      activemodel (= 6.0.3.2)
+      activerecord (= 6.0.3.2)
+      activestorage (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
+      bundler (>= 1.3.0)
+      railties (= 6.0.3.2)
       sprockets-rails (>= 2.0.0)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.3.0)
       loofah (~> 2.3)
-    railties (6.1.3.2)
-      actionpack (= 6.1.3.2)
-      activesupport (= 6.1.3.2)
+    railties (6.0.3.2)
+      actionpack (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
       method_source
       rake (>= 0.8.7)
-      thor (~> 1.0)
+      thor (>= 0.20.3, < 2.0)
     rainbow (3.0.0)
-    rake (13.0.3)
-    regexp_parser (2.1.1)
-    rexml (3.2.5)
+    rake (13.0.1)
+    regexp_parser (1.8.2)
+    rexml (3.2.4)
     rubocop (0.93.1)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
@@ -141,28 +137,29 @@ GEM
       rubocop-ast (>= 0.6.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.5.0)
-      parser (>= 3.0.1.1)
-    rubocop-performance (1.10.2)
-      rubocop (>= 0.90.0, < 2.0)
+    rubocop-ast (0.8.0)
+      parser (>= 2.7.1.5)
+    rubocop-performance (1.8.1)
+      rubocop (>= 0.87.0)
       rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.11.0)
-    semantic_range (3.0.0)
+    ruby-progressbar (1.10.1)
+    semantic_range (2.3.0)
     sprockets (4.0.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
-    sprockets-rails (3.2.2)
+    sprockets-rails (3.2.1)
       actionpack (>= 4.0)
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
-    thor (1.1.0)
-    tzinfo (2.0.4)
-      concurrent-ruby (~> 1.0)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
     websocket-driver (0.7.3)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
-    zeitwerk (2.4.2)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
@@ -180,4 +177,4 @@ DEPENDENCIES
   webpacker!
 
 BUNDLED WITH
-   2.2.3
+   2.1.4