webpacker 4.0.0.rc.2 → 4.0.0.rc.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c29c9fa51a5fa2bbe873cb18849059726b5306f01c8bb1668009eba939a28c0e
-  data.tar.gz: 20b8cb4c660e26d51e186d600ab98c1979cda90207bc63a65f7ce4f1fe749eed
+  metadata.gz: 7b4e8fa7b4d57022ab1e34dd1e5ea82e7aeabda41f11c158bdb8989c05fe1c0e
+  data.tar.gz: 0c9f6d2906a79d379d7f3f5fb097b338e740a39452d0bc2ac33dd3bd30eb3895
 SHA512:
-  metadata.gz: c85de1b6b0b66bcb9a70d85ee1b4356a40ccce421193c94bc03df401ecf0ad9be84add25c190a59efd52659d3bddbcf0dcedd7edfc8ac274788d1a8d73e1f5eb
-  data.tar.gz: e7dd4e624d4b21f003430e744a863c8bd8a84e8d5a5132a502fb4366ff748cc3ed05ba375dd2687fce06cfe257d263e56549736e8e6a162f4f4316f43d17cba1
+  metadata.gz: ee59500d81e622c90f0feddd8c026126eb1f1e14f0d37af880d826af56b60f74b5b3ee380397c36bbbd157de059e48d9f2552e6d72dcd295d310ee7ebaa01a42
+  data.tar.gz: 0fc59e37a1d3fa940ed3b9e5e8e15667c771a0571029142d507f5d0d3577fa70eb670115ccc6ea0540c0b2afa35c9c501049d204701a2a0389a9499e29f2699d

data/.travis.yml

@@ -6,6 +6,7 @@ rvm:
   - 2.3.8
   - 2.4.5
   - 2.5.3
+  - 2.6.0
   - ruby-head
 gemfile:
   - gemfiles/Gemfile-rails.4.2.x
@@ -36,5 +37,9 @@ matrix:
   exclude:
     - rvm: 2.3.8
       gemfile: gemfiles/Gemfile-rails-edge
+    - rvm: 2.4.5
+      gemfile: gemfiles/Gemfile-rails-edge
+    - rvm: 2.5.3
+      gemfile: gemfiles/Gemfile-rails-edge
     - rvm: ruby-head
       gemfile: gemfiles/Gemfile-rails.4.2.x

data/CHANGELOG.md

@@ -1,5 +1,37 @@
 **Please note that Webpacker 3.1.0 and 3.1.1 have some serious bugs so please consider using either 3.0.2 or 3.2.0**
 
+## [4.0.0.rc.3] - 2019-01-17
+
+### Fixed
+ - Issue with javascript_pack_tag asset duplication [#1898](https://github.com/rails/webpacker/pull/1898)
+
+
+### Added
+ - `javascript_packs_with_chunks_tag` helper, which creates html tags
+  for a pack and all the dependent chunks, when using splitchunks.
+
+```erb
+<%= javascript_packs_with_chunks_tag 'calendar', 'map', 'data-turbolinks-track': 'reload' %>
+
+<script src="/packs/vendor-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/calendar~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/map~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/map-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+```
+
+**Important:** Pass all your pack names when using `javascript_packs_with_chunks_tag`
+helper otherwise you will get duplicated chunks on the page.
+
+```erb
+<%# DO %>
+<%= javascript_packs_with_chunks_tag 'calendar', 'map' %>
+
+<%# DON'T %>
+<%= javascript_packs_with_chunks_tag 'calendar' %>
+<%= javascript_packs_with_chunks_tag 'map' %>
+```
+
 ## [4.0.0.rc.2] - 2018-12-15
 
 ### Fixed

data/Gemfile.lock

@@ -14,7 +14,7 @@ GIT
 PATH
   remote: .
   specs:
-    webpacker (4.0.0.rc.2)
+    webpacker (4.0.0.rc.3)
       activesupport (>= 4.2)
       rack-proxy (>= 0.6.1)
       railties (>= 4.2)
@@ -156,4 +156,4 @@ DEPENDENCIES
   webpacker!
 
 BUNDLED WITH
-   1.17.1
+   1.17.3

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2016-2018 David Heinemeier Hansson, Basecamp
+Copyright (c) 2016-2019 David Heinemeier Hansson, Basecamp
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -142,6 +142,31 @@ can use the `asset_pack_path` helper:
 <img src="<%= asset_pack_path 'images/logo.svg' %>" />
 ```
 
+If you are using new webpack 4 split chunks API, then consider using `javascript_packs_with_chunks_tag` helper, which creates html
+tags for a pack and all the dependent chunks.
+
+```erb
+<%= javascript_packs_with_chunks_tag 'calendar', 'map', 'data-turbolinks-track': 'reload' %>
+
+<script src="/packs/vendor-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/calendar~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/map~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/map-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+```
+
+**Important:** Pass all your pack names when using `javascript_packs_with_chunks_tag`
+helper otherwise you will get duplicated chunks on the page.
+
+```erb
+<%# DO %>
+<%= javascript_packs_with_chunks_tag 'calendar', 'map' %>
+
+<%# DON'T %>
+<%= javascript_packs_with_chunks_tag 'calendar' %>
+<%= javascript_packs_with_chunks_tag 'map' %>
+```
+
 **Note:** In order for your styles or static assets files to be available in your view,
 you would need to link them in your "pack" or entry file.
 
@@ -269,7 +294,7 @@ You can run following commands to upgrade Webpacker to the latest stable version
 bundle update webpacker
 rails webpacker:binstubs
 yarn upgrade @rails/webpacker --latest
-yarn add webpack-dev-server@^2.11.1
+yarn add webpack-dev-server@^3.1.14
 
 # Or to install a latest release (including pre-releases)
 yarn add @rails/webpacker@next

data/docs/engines.md

@@ -0,0 +1,155 @@
+# Using in Rails engines
+
+If the application UI consists of multiple frontend application, you'd probably like to isolate their building too (e.g. if you use different frameworks/versions). Hence we needed our webpack(-er) to be isolated too: separate `package.json`, dev server, compilation process.
+
+You can do this by adding another Webpacker instance to your application.
+
+This guide describes how to do that using [Rails engines](https://guides.rubyonrails.org/engines.html).
+
+
+## Step 1: create Rails engine.
+
+First, you create a Rails engine (say, `MyEngine`). See the offical [Rails guide](https://guides.rubyonrails.org/engines.html).
+
+## Step 2: install Webpacker within the engine.
+
+There is no built-in tasks to install Webpacker within the engine, thus you have to add all the require files manually (you can copy them from the main app):
+- Add `config/webpacker.yml` and `config/webpack/*.js` files
+- Add `bin/webpack` and `bin/webpack-dev-server` files
+- Add `package.json` with required deps.
+
+
+## Step 3: configure Webpacker instance.
+
+```ruby
+module MyEngine
+  ROOT_PATH = Pathname.new(File.join(__dir__, ".."))
+
+  class << self
+    def webpacker
+      @webpacker ||= ::Webpacker::Instance.new(
+        root_path: ROOT_PATH,
+        config_path: ROOT_PATH.join("config/webpacker.yml")
+      )
+    end
+  end
+end
+```
+
+## Step 4: Configure dev server proxy.
+
+```ruby
+module MyEngine
+  class Engine < ::Rails::Engine
+    initializer "webpacker.proxy" do |app|
+        insert_middleware = begin
+                            MyEngine.webpacker.config.dev_server.present?
+                          rescue
+                            nil
+                          end
+        next unless insert_middleware
+
+        app.middleware.insert_before(
+          0, Webpacker::DevServerProxy, # "Webpacker::DevServerProxy" if Rails version < 5
+          ssl_verify_none: true,
+          webpacker: MyEngine.webpacker
+        )
+      end
+  end
+end
+```
+
+If you have multiple webpackers, you would probably want to run multiple dev servers at a time, and hence be able to configure their setting through env vars (e.g. within a `docker-compose.yml` file):
+
+```yml
+# webpacker.yml
+# ...
+development:
+  # ...
+  dev_server:
+    env_prefix: "MY_ENGINE_WEBPACKER_DEV_SERVER"
+    # ...
+```
+
+## Step 5: configure helper.
+
+```ruby
+require "webpacker/helper"
+
+module MyEngine
+  module ApplicationHelper
+    include ::Webpacker::Helper
+
+    def current_webpacker_instance
+      MyEngine.webpacker
+    end
+  end
+end
+```
+
+Now you can use `stylesheet_pack_tag` and `javascript_pack_tag` from within your engine.
+
+## Step 6: rake tasks.
+
+Add Rake task to compile assets in production (`rake my_engine:webpacker:compile`)
+
+```ruby
+namespace :my_engine do
+  namespace :webpacker do
+    desc "Install deps with yarn"
+    task :yarn_install do
+      Dir.chdir(File.join(__dir__, "../..")) do
+        system "yarn install --no-progress --production"
+      end
+    end
+
+    desc "Compile JavaScript packs using webpack for production with digests"
+    task compile: [:yarn_install, :environment] do
+      Webpacker.with_node_env("production") do
+          if MyEngine.webpacker.commands.compile
+            # Successful compilation!
+          else
+            # Failed compilation
+            exit!
+          end
+      end
+    end
+  end
+end
+```
+
+## Step 7: serving compiled packs.
+
+There are two approaches on serving compiled assets.
+
+### Put engine's assets to the root app's public/ folder
+
+You can serve engine's assets using the main app's static files server which serves files from `public/` folder.
+
+For that you must configure your engine's webpacker to put compiled assets to the app's `public/` folder:
+
+```yml
+# my_engine/config/webpacker.yml
+default: &default
+  # ...
+  # public_root_path could be used to override the path to `public/` folder
+  # (relative to the engine root)
+  public_root_path: ../public
+  # use a different sub-folder name
+  public_output_path: my-engine-packs
+```
+
+### Use a separate middleware
+
+To serve static assets from the engine's `public/` folder you must add a middleware and point it to your engine's webpacker output path:
+
+```ruby
+# application.rb
+
+config.middleware.use(
+  "Rack::Static",
+  urls: ["/my-engine-packs"], root: "my_engine/public"
+)
+```
+
+**NOTE:** in the example above we assume that your `public_output_path` is set to `my-engine-packs` in your engine's `webpacker.yml`.

data/docs/webpack.md

@@ -267,32 +267,36 @@ For the full configuration options of SplitChunks, see the [Webpack documentatio
 // config/webpack/environment.js
 const WebpackAssetsManifest = require('webpack-assets-manifest');
 
-const splitChunks = {
-  optimization: {
-    splitChunks: {
-      chunks: 'all'
-    },
-  },
-};
-
-environment.config.merge(splitChunks);
-
-// Should override the existing manifest plugin
-environment.plugins.insert(
-  'Manifest',
-  new WebpackAssetsManifest({
-    entrypoints: true, // default in rails is false
-    writeToDisk: true, // rails defaults copied from webpacker
-    publicPath: true // rails defaults copied from webpacker
-  })
-)
+// Enable the default config
+environment.splitChunks()
+
+// or using custom config
+environment.splitChunks((config) => Object.assign({}, config, { optimization: { splitChunks: false }}))
 ```
 
-To use the `javascript_pack_tag` or the `stylesheet_pack_tag` with `SplitChunks` or `RuntimeChunks` you can refer to the packs as usual.
+Then use, `javascript_packs_with_chunks_tag` helper to include all the transpiled
+packs with the chunks in your view, which creates html tags for all the chunks.
 
 ```erb
-javascript_pack_tag "your-entrypoint-javascript-file"
-stylesheet_pack_tag "your-entrypoint-stylesheet-file"
+<%= javascript_packs_with_chunks_tag 'calendar', 'map', 'data-turbolinks-track': 'reload' %>
+
+<script src="/packs/vendor-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/calendar~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/map~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+<script src="/packs/map-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+```
+
+**Important:** Pass all your pack names when using this helper otherwise you will
+get duplicated chunks on the page.
+
+```erb
+<%# DO %>
+<%= javascript_packs_with_chunks_tag 'calendar', 'map' %>
+
+<%# DON'T %>
+<%= javascript_packs_with_chunks_tag 'calendar' %>
+<%= javascript_packs_with_chunks_tag 'map' %>
 ```
 
 For the old configuration with the CommonsChunkPlugin see below. **Note** that this functionality is deprecated in Webpack V4.

data/docs/yarn.md

@@ -1,6 +1,6 @@
 # Yarn
 
-Webpacker by default uses `yarn` as package manager for node modules
+Webpacker by default uses `yarn` as a package manager for `node_modules`
 
 
 ## Add a new npm module
@@ -10,3 +10,14 @@ To add any new JS module you can use `yarn`:
 ```bash
 yarn add bootstrap material-ui
 ```
+
+## Add an npm module to `devDependencies`
+To add a new JS module that will only be available to local development:
+
+```bash
+yarn add --dev browser-sync
+```
+
+Be careful not to add any build or app related JS modules in this fashion. Adding JS modules to `devDependencies` [will block them from being installed in **any** production environment](https://yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-production-true-false).
+
+Docs from JS modules may instruct you to use `--dev` or `devDependencies`, but this is generally under the assumption that you are using a `node.js` workflow.

data/lib/install/config/webpacker.yml

@@ -3,6 +3,7 @@
 default: &default
   source_path: app/javascript
   source_entry_path: packs
+  public_root_path: public
   public_output_path: packs
   cache_path: tmp/cache/webpacker
   check_yarn_integrity: false
@@ -71,7 +72,7 @@ development:
     headers:
       'Access-Control-Allow-Origin': '*'
     watch_options:
-      ignored: /node_modules/
+      ignored: '**/node_modules/**'
 
 
 test:

data/lib/install/examples/react/babel.config.js

@@ -10,7 +10,7 @@ module.exports = function(api) {
       'Please specify a valid `NODE_ENV` or ' +
         '`BABEL_ENV` environment variables. Valid values are "development", ' +
         '"test", and "production". Instead, received: ' +
-        JSON.stringify(env) +
+        JSON.stringify(currentEnv) +
         '.'
     )
   }

data/lib/webpacker/compiler.rb

@@ -10,7 +10,7 @@ class Webpacker::Compiler
   # Webpacker::Compiler.env['FRONTEND_API_KEY'] = 'your_secret_key'
   cattr_accessor(:env) { {} }
 
-  delegate :config, :logger, to: :@webpacker
+  delegate :config, :logger, to: :webpacker
 
   def initialize(webpacker)
     @webpacker = webpacker
@@ -37,6 +37,8 @@ class Webpacker::Compiler
   end
 
   private
+    attr_reader :webpacker
+
     def last_compilation_digest
       compilation_digest_path.read if compilation_digest_path.exist? && config.public_manifest_path.exist?
     rescue Errno::ENOENT, Errno::ENOTDIR
@@ -56,7 +58,11 @@ class Webpacker::Compiler
     def run_webpack
       logger.info "Compiling…"
 
-      stdout, sterr , status = Open3.capture3(webpack_env, "#{RbConfig.ruby} #{@webpacker.root_path}/bin/webpack")
+      stdout, sterr , status = Open3.capture3(
+        webpack_env,
+        "#{RbConfig.ruby} ./bin/webpack",
+        chdir: File.expand_path(config.root_path)
+      )
 
       if sterr == "" && status.success?
         logger.info "Compiled all packs in #{config.public_output_path}"
@@ -71,17 +77,19 @@ class Webpacker::Compiler
     def default_watched_paths
       [
         *config.resolved_paths_globbed,
-        "#{config.source_path.relative_path_from(Rails.root)}/**/*",
+        "#{config.source_path.relative_path_from(config.root_path)}/**/*",
         "yarn.lock", "package.json",
         "config/webpack/**/*"
       ].freeze
     end
 
     def compilation_digest_path
-      config.cache_path.join("last-compilation-digest-#{Webpacker.env}")
+      config.cache_path.join("last-compilation-digest-#{webpacker.env}")
     end
 
     def webpack_env
+      return env unless defined?(ActionController::Base)
+
       env.merge("WEBPACKER_ASSET_HOST"        => ActionController::Base.helpers.compute_asset_host,
                 "WEBPACKER_RELATIVE_URL_ROOT" => ActionController::Base.relative_url_root)
     end

data/lib/webpacker/configuration.rb

@@ -36,7 +36,7 @@ class Webpacker::Configuration
   end
 
   def public_path
-    root_path.join("public")
+    root_path.join(fetch(:public_root_path))
   end
 
   def public_output_path

data/lib/webpacker/dev_server.rb

@@ -1,4 +1,6 @@
 class Webpacker::DevServer
+  DEFAULT_ENV_PREFIX = "WEBPACKER_DEV_SERVER".freeze
+
   # Configure dev server connection timeout (in seconds), default: 0.01
   # Webpacker.dev_server.connect_timeout = 1
   cattr_accessor(:connect_timeout) { 0.01 }
@@ -49,9 +51,13 @@ class Webpacker::DevServer
     fetch(:pretty)
   end
 
+  def env_prefix
+    config.dev_server.fetch(:env_prefix, DEFAULT_ENV_PREFIX)
+  end
+
   private
     def fetch(key)
-      ENV["WEBPACKER_DEV_SERVER_#{key.upcase}"] || config.dev_server.fetch(key, defaults[key])
+      ENV["#{env_prefix}_#{key.upcase}"] || config.dev_server.fetch(key, defaults[key])
     end
 
     def defaults

data/lib/webpacker/dev_server_proxy.rb

@@ -1,18 +1,25 @@
 require "rack/proxy"
 
 class Webpacker::DevServerProxy < Rack::Proxy
+  delegate :config, :dev_server, to: :@webpacker
+
+  def initialize(app = nil, opts = {})
+    @webpacker = opts.delete(:webpacker) || Webpacker.instance
+    super
+  end
+
   def rewrite_response(response)
     _status, headers, _body = response
     headers.delete "transfer-encoding"
-    headers.delete "content-length" if Webpacker.dev_server.running? && Webpacker.dev_server.https?
+    headers.delete "content-length" if dev_server.running? && dev_server.https?
     response
   end
 
   def perform_request(env)
-    if env["PATH_INFO"].start_with?("/#{public_output_uri_path}") && Webpacker.dev_server.running?
-      env["HTTP_HOST"] = env["HTTP_X_FORWARDED_HOST"] = env["HTTP_X_FORWARDED_SERVER"] = Webpacker.dev_server.host_with_port
-      env["HTTP_X_FORWARDED_PROTO"] = env["HTTP_X_FORWARDED_SCHEME"] = Webpacker.dev_server.protocol
-      unless Webpacker.dev_server.https?
+    if env["PATH_INFO"].start_with?("/#{public_output_uri_path}") && dev_server.running?
+      env["HTTP_HOST"] = env["HTTP_X_FORWARDED_HOST"] = env["HTTP_X_FORWARDED_SERVER"] = dev_server.host_with_port
+      env["HTTP_X_FORWARDED_PROTO"] = env["HTTP_X_FORWARDED_SCHEME"] = dev_server.protocol
+      unless dev_server.https?
         env["HTTPS"] = env["HTTP_X_FORWARDED_SSL"] = "off"
       end
       env["SCRIPT_NAME"] = ""
@@ -25,6 +32,6 @@ class Webpacker::DevServerProxy < Rack::Proxy
 
   private
     def public_output_uri_path
-      Webpacker.config.public_output_path.relative_path_from(Webpacker.config.public_path)
+      config.public_output_path.relative_path_from(config.public_path)
     end
 end

data/lib/webpacker/helper.rb

@@ -1,6 +1,13 @@
 module Webpacker::Helper
+  # Returns current Webpacker instance.
+  # Could be overriden to use multiple Webpacker
+  # configurations within the same app (e.g. with engines)
+  def current_webpacker_instance
+    Webpacker.instance
+  end
+
   # Computes the relative path for a given Webpacker asset.
-  # Return relative path using manifest.json and passes it to asset_path helper
+  # Return relative path using manifest.json and passes it to asset_path helper.
   # This will use asset_path internally, so most of their behaviors will be the same.
   #
   # Example:
@@ -11,13 +18,13 @@ module Webpacker::Helper
   #   # When extract_css is true in webpacker.yml or the file is not a css:
   #   <%= asset_pack_path 'calendar.css' %> # => "/packs/calendar-1016838bab065ae1e122.css"
   def asset_pack_path(name, **options)
-    if Webpacker.config.extract_css? || !stylesheet?(name)
-      asset_path(Webpacker.manifest.lookup!(name), **options)
+    if current_webpacker_instance.config.extract_css? || !stylesheet?(name)
+      asset_path(current_webpacker_instance.manifest.lookup!(name), **options)
     end
   end
 
   # Computes the absolute path for a given Webpacker asset.
-  # Return absolute path using manifest.json and passes it to asset_url helper
+  # Return absolute path using manifest.json and passes it to asset_url helper.
   # This will use asset_url internally, so most of their behaviors will be the same.
   #
   # Example:
@@ -28,8 +35,8 @@ module Webpacker::Helper
   #   # When extract_css is true in webpacker.yml or the file is not a css:
   #   <%= asset_pack_url 'calendar.css' %> # => "http://example.com/packs/calendar-1016838bab065ae1e122.css"
   def asset_pack_url(name, **options)
-    if Webpacker.config.extract_css? || !stylesheet?(name)
-      asset_url(Webpacker.manifest.lookup!(name), **options)
+    if current_webpacker_instance.config.extract_css? || !stylesheet?(name)
+      asset_url(current_webpacker_instance.manifest.lookup!(name), **options)
     end
   end
 
@@ -40,7 +47,7 @@ module Webpacker::Helper
   #  <%= image_pack_tag 'application.png', size: '16x10', alt: 'Edit Entry' %>
   #  <img alt='Edit Entry' src='/packs/application-k344a6d59eef8632c9d1.png' width='16' height='10' />
   def image_pack_tag(name, **options)
-    image_tag(asset_path(Webpacker.manifest.lookup!(name)), **options)
+    image_tag(asset_path(current_webpacker_instance.manifest.lookup!(name)), **options)
   end
 
   # Creates a script tag that references the named pack file, as compiled by webpack per the entries list
@@ -52,7 +59,29 @@ module Webpacker::Helper
   #   <%= javascript_pack_tag 'calendar', 'data-turbolinks-track': 'reload' %> # =>
   #   <script src="/packs/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
   def javascript_pack_tag(*names, **options)
-    javascript_include_tag(*sources_from_pack_manifest(names, type: :javascript), **options)
+    javascript_include_tag(*sources_from_manifest_entries(names, type: :javascript), **options)
+  end
+
+  # Creates script tags that references the chunks from entrypoints when using split chunks API,
+  # as compiled by webpack per the entries list in config/webpack/shared.js.
+  # By default, this list is auto-generated to match everything in
+  # app/javascript/packs/*.js and all the dependent chunks. In production mode, the digested reference is automatically looked up.
+  # See: https://webpack.js.org/plugins/split-chunks-plugin/
+  # Example:
+  #
+  #   <%= javascript_packs_with_chunks_tag 'calendar', 'map', 'data-turbolinks-track': 'reload' %> # =>
+  #   <script src="/packs/vendor-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+  #   <script src="/packs/calendar~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+  #   <script src="/packs/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+  #   <script src="/packs/map~runtime-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+  #   <script src="/packs/map-16838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+  # DO:
+  # <%= javascript_packs_with_chunks_tag 'calendar', 'map' %>
+  # DON'T:
+  # <%= javascript_packs_with_chunks_tag 'calendar' %>
+  # <%= javascript_packs_with_chunks_tag 'map' %>
+  def javascript_packs_with_chunks_tag(*names, **options)
+    javascript_include_tag(*sources_from_manifest_entrypoints(names, type: :javascript), **options)
   end
 
   # Creates a link tag that references the named pack file, as compiled by webpack per the entries list
@@ -72,8 +101,8 @@ module Webpacker::Helper
   #   <%= stylesheet_pack_tag 'calendar', 'data-turbolinks-track': 'reload' %> # =>
   #   <link rel="stylesheet" media="screen" href="/packs/calendar-1016838bab065ae1e122.css" data-turbolinks-track="reload" />
   def stylesheet_pack_tag(*names, **options)
-    if Webpacker.config.extract_css?
-      stylesheet_link_tag(*sources_from_pack_manifest(names, type: :stylesheet), **options)
+    if current_webpacker_instance.config.extract_css?
+      stylesheet_link_tag(*sources_from_manifest_entries(names, type: :stylesheet), **options)
     end
   end
 
@@ -82,7 +111,11 @@ module Webpacker::Helper
       File.extname(name) == ".css"
     end
 
-    def sources_from_pack_manifest(names, type:)
-      names.map { |name| Webpacker.manifest.lookup!(name, type: type) }.flatten
+    def sources_from_manifest_entries(names, type:)
+      names.map { |name| current_webpacker_instance.manifest.lookup!(name, type: type) }.flatten
+    end
+
+    def sources_from_manifest_entrypoints(names, type:)
+      names.map { |name| current_webpacker_instance.manifest.lookup_pack_with_chunks!(name, type: type) }.flatten.uniq
     end
 end

data/lib/webpacker/manifest.rb

@@ -18,27 +18,33 @@ class Webpacker::Manifest
     @data = load
   end
 
+  def lookup_pack_with_chunks(name, pack_type = {})
+    compile if compiling?
+
+    manifest_pack_type = manifest_type(pack_type[:type])
+    manifest_pack_name = manifest_name(name, manifest_pack_type)
+    find("entrypoints")[manifest_pack_name][manifest_pack_type]
+  rescue NoMethodError
+    nil
+  end
+
+  def lookup_pack_with_chunks!(name, pack_type = {})
+    lookup_pack_with_chunks(name, pack_type) || handle_missing_entry(name)
+  end
+
+  # Computes the relative path for a given Webpacker asset using manifest.json.
+  # If no asset is found, returns nil.
+  #
+  # Example:
+  #
+  #   Webpacker.manifest.lookup('calendar.js') # => "/packs/calendar-1016838bab065ae1e122.js"
   def lookup(name, pack_type = {})
     compile if compiling?
 
-    # When using SplitChunks or RuntimeChunks the manifest hash will contain
-    # an extra object called "entrypoints". When the entrypoints key is not
-    # present in the manifest, or the name is not found in the entrypoints hash,
-    # it will raise a NoMethodError. If this happens, we should try to lookup
-    # a single instance of the pack based on the given name.
-    begin
-      manifest_pack_type = manifest_type(pack_type[:type])
-      manifest_pack_name = manifest_name(name, manifest_pack_type)
-
-      # Lookup the pack in the entrypoints of the manifest
-      find("entrypoints")[manifest_pack_name][manifest_pack_type]
-    rescue NoMethodError
-
-      # Lookup a single instance of the pack
-      find(full_pack_name(name, pack_type[:type]))
-    end
+    find(full_pack_name(name, pack_type[:type]))
   end
 
+  # Like lookup, except that if no asset is found, raises a Webpacker::Manifest::MissingEntryError.
   def lookup!(name, pack_type = {})
     lookup(name, pack_type) || handle_missing_entry(name)
   end

data/lib/webpacker/version.rb

@@ -1,4 +1,4 @@
 module Webpacker
   # Change the version in package.json too, please!
-  VERSION = "4.0.0.rc.2".freeze
+  VERSION = "4.0.0.rc.3".freeze
 end

data/package/__tests__/dev_server.js

@@ -20,6 +20,21 @@ describe('DevServer', () => {
     expect(devServer.port).toEqual('5000')
   })
 
+  test('with custom env prefix', () => {
+    const config = require('../config')
+    config.dev_server.env_prefix = 'TEST_WEBPACKER_DEV_SERVER_'
+
+    process.env.NODE_ENV = 'development'
+    process.env.RAILS_ENV = 'development'
+    process.env.TEST_WEBPACKER_DEV_SERVER_HOST = '0.0.0.0'
+    process.env.TEST_WEBPACKER_DEV_SERVER_PORT = 5000
+
+    const devServer = require('../dev_server')
+    expect(devServer).toBeDefined()
+    expect(devServer.host).toEqual('0.0.0.0')
+    expect(devServer.port).toEqual('5000')
+  })
+
   test('with NODE_ENV and RAILS_ENV set to production', () => {
     process.env.RAILS_ENV = 'production'
     process.env.NODE_ENV = 'production'

data/package/config.js

@@ -19,7 +19,7 @@ const app = safeLoad(readFileSync(configPath), 'utf8')[railsEnv]
 if (isArray(app.extensions) && app.extensions.length) delete defaults.extensions
 
 const config = deepMerge(defaults, app)
-config.outputPath = resolve('public', config.public_output_path)
+config.outputPath = resolve(config.public_root_path, config.public_output_path)
 
 // Ensure that the publicPath includes our asset host so dynamic imports
 // (code-splitting chunks and static assets) load from the CDN instead of a relative path.

data/package/dev_server.js

@@ -9,8 +9,10 @@ const fetch = (key) => {
 const devServerConfig = config.dev_server
 
 if (devServerConfig) {
+  const envPrefix = config.dev_server.env_prefix || 'WEBPACKER_DEV_SERVER_'
+
   Object.keys(devServerConfig).forEach((key) => {
-    const envValue = fetch(`WEBPACKER_DEV_SERVER_${key.toUpperCase().replace(/_/g, '')}`)
+    const envValue = fetch(`${envPrefix}${key.toUpperCase().replace(/_/g, '')}`)
     if (envValue !== undefined) devServerConfig[key] = envValue
   })
 }

data/package/environments/development.js

@@ -9,7 +9,6 @@ module.exports = class extends Base {
 
     if (devServer.hmr) {
       this.plugins.append('HotModuleReplacement', new webpack.HotModuleReplacementPlugin())
-      this.plugins.append('NamedModules', new webpack.NamedModulesPlugin())
       this.config.output.filename = '[name]-[hash].js'
     }
 

data/package/rules/node_modules.js

@@ -5,6 +5,7 @@ const { nodeEnv } = require('../env')
 // Compile standard ES features for JS in node_modules with Babel.
 module.exports = {
   test: /\.(js|mjs)$/,
+  include: /node_modules/,
   exclude: /@babel(?:\/|\\{1,2})runtime/,
   use: [
     {

data/package/utils/helpers.js

@@ -1,3 +1,5 @@
+const { stringify } = require('flatted/cjs')
+
 const isObject = value => typeof value === 'object'
   && value !== null
   && (value.length === undefined || value.length === null)
@@ -17,7 +19,7 @@ const isStrPath = (key) => {
 
 const isArray = value => Array.isArray(value)
 
-const isEqual = (target, source) => JSON.stringify(target) === JSON.stringify(source)
+const isEqual = (target, source) => stringify(target) === stringify(source)
 
 const canMerge = value => isObject(value) || isArray(value)
 

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rails/webpacker",
-  "version": "4.0.0-rc.2",
+  "version": "4.0.0-rc.3",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "main": "package/index.js",
   "files": [
@@ -29,6 +29,7 @@
     "compression-webpack-plugin": "^2.0.0",
     "css-loader": "^2.0.1",
     "file-loader": "^2.0.0",
+    "flatted": "^2.0.0",
     "glob": "^7.1.3",
     "js-yaml": "^3.12.0",
     "mini-css-extract-plugin": "^0.5.0",

data/test/configuration_test.rb

@@ -22,6 +22,15 @@ class ConfigurationTest < Webpacker::Test
   def test_public_output_path
     public_output_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/public/packs").to_s
     assert_equal @config.public_output_path.to_s, public_output_path
+
+    @config = Webpacker::Configuration.new(
+      root_path: @config.root_path,
+      config_path: Pathname.new(File.expand_path("./test_app/config/webpacker_public_root.yml", __dir__)),
+      env: "production"
+    )
+
+    public_output_path = File.expand_path File.join(File.dirname(__FILE__), "public/packs").to_s
+    assert_equal @config.public_output_path.to_s, public_output_path
   end
 
   def test_public_manifest_path

data/test/helper_test.rb

@@ -64,7 +64,7 @@ class HelperTest < ActionView::TestCase
       %(<script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js"></script>\n) +
         %(<script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js"></script>\n) +
         %(<script src="/packs/application-k344a6d59eef8632c9d1.js"></script>),
-      javascript_pack_tag("application")
+      javascript_packs_with_chunks_tag("application")
   end
 
   def test_stylesheet_pack_tag

data/test/manifest_test.rb

@@ -22,6 +22,10 @@ class ManifestTest < Minitest::Test
     assert_nil Webpacker.manifest.lookup("foo.js")
   end
 
+  def test_lookup_chunks_nil
+    assert_nil Webpacker.manifest.lookup_pack_with_chunks("foo.js")
+  end
+
   def test_lookup_success
     assert_equal Webpacker.manifest.lookup("bootstrap.js"), "/packs/bootstrap-300631c4f0e0f9c865bc.js"
   end
@@ -33,6 +37,6 @@ class ManifestTest < Minitest::Test
       "/packs/application-k344a6d59eef8632c9d1.js"
     ]
 
-    assert_equal Webpacker.manifest.lookup!("application", type: :javascript), application_entrypoints
+    assert_equal Webpacker.manifest.lookup_pack_with_chunks!("application", type: :javascript), application_entrypoints
   end
 end

data/test/test_app/config/webpacker.yml

@@ -3,6 +3,7 @@
 default: &default
   source_path: app/javascript
   source_entry_path: packs
+  public_root_path: public
   public_output_path: packs
   cache_path: tmp/cache/webpacker
   webpack_compile_output: false

data/test/test_app/config/webpacker_public_root.yml

@@ -0,0 +1,19 @@
+# Note: You must restart bin/webpack-dev-server for changes to take effect
+
+default: &default
+  public_root_path: ../public
+
+development:
+  <<: *default
+  compile: true
+
+test:
+  <<: *default
+  compile: true
+  public_output_path: packs-test
+
+production:
+  <<: *default
+  compile: false
+  extract_css: true
+  cache_manifest: true

data/yarn.lock

@@ -3053,6 +3053,11 @@ flat-cache@^1.2.1:
     rimraf "~2.6.2"
     write "^0.2.1"
 
+flatted@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.0.tgz#55122b6536ea496b4b44893ee2608141d10d9916"
+  integrity sha512-R+H8IZclI8AAkSBRQJLVOsxwAoHd6WC40b4QTNWIjzAa6BXOBfQcM587MXDTVPeYaopFNWHUFLx7eNmHDSxMWg==
+
 flatten@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/flatten/-/flatten-1.0.2.tgz#dae46a9d78fbe25292258cc1e780a41d95c03782"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webpacker
 version: !ruby/object:Gem::Version
-  version: 4.0.0.rc.2
+  version: 4.0.0.rc.3
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-15 00:00:00.000000000 Z
+date: 2019-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -93,6 +93,7 @@ files:
 - docs/css.md
 - docs/deployment.md
 - docs/docker.md
+- docs/engines.md
 - docs/env.md
 - docs/es6.md
 - docs/folder-structure.md
@@ -238,6 +239,7 @@ files:
 - test/test_app/config/environment.rb
 - test/test_app/config/webpack/development.js
 - test/test_app/config/webpacker.yml
+- test/test_app/config/webpacker_public_root.yml
 - test/test_app/package.json
 - test/test_app/public/packs/manifest.json
 - test/test_app/yarn.lock
@@ -250,8 +252,8 @@ homepage: https://github.com/rails/webpacker
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/rails/webpacker/tree/v4.0.0.rc.2
-  changelog_uri: https://github.com/rails/webpacker/blob/v4.0.0.rc.2/CHANGELOG.md
+  source_code_uri: https://github.com/rails/webpacker/tree/v4.0.0.rc.3
+  changelog_uri: https://github.com/rails/webpacker/blob/v4.0.0.rc.3/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -291,6 +293,7 @@ test_files:
 - test/test_app/config/environment.rb
 - test/test_app/config/webpack/development.js
 - test/test_app/config/webpacker.yml
+- test/test_app/config/webpacker_public_root.yml
 - test/test_app/package.json
 - test/test_app/public/packs/manifest.json
 - test/test_app/yarn.lock