webpacker-remote 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7c82d3d11b075effbc9efd05042438065ea37b9a46b2ad16298807fa9085706
-  data.tar.gz: 4e4d31ad15d8f4c9ec935e4dd332a426c7898889575196e42cd8061140799417
+  metadata.gz: 635f4710cb86e3d78d8ae1da64807ae12f0bf97e7e3b476fb87a58098c9370f5
+  data.tar.gz: 0aa52bce7bfcf825119c82aa1cc215274c929fe3572c8e4e54523555693504ec
 SHA512:
-  metadata.gz: 750042b0c9f5132196ad095c4ae340bedaa3d26973c4efe4e45af67c8203ca03f920e2c8a1b16974a5c314d0e03b48f830503503e806d05736db29ac23ce802c
-  data.tar.gz: ed9d1bb82d933b0d2af2170fc13c517acf996b905fe3a5115d66fcedd37de8a9ac34520efca0bae3e9170fa39c07731d49afdfc772f034875a1a352572860ecf
+  metadata.gz: 823dab789035d9160449e109532bac324ee377ed8afd8caea5d4a72395d625cc1826902d2554ac5f7ee8930f3232d759f0276b79e7b703ba033bd62b439fb34e
+  data.tar.gz: 799fc8946cdc5a09b83ebe58ec6f7a244041b3e9607a0a33436feb1755fe0a3db7e3ae32ba0c00c2c6029023568e0b960f1ec5d6b75305e108691b321539afea

data/.github/workflows/branch.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         ruby: [ '2.7' ]
-        webpacker: [ '5.2.1' ]
+        webpacker: [ '4.3.0', '5.2.1' ]
     name: Ruby ${{ matrix.ruby }}, Webpacker ${{ matrix.webpacker }}
     steps:
       - uses: actions/checkout@v2

data/.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       matrix:
         ruby: [ '2.7' ]
-        webpacker: [ '5.2.1' ]
+        webpacker: [ '4.3.0', '5.2.1' ]
     name: Ruby ${{ matrix.ruby }}, Webpacker ${{ matrix.webpacker }}
     steps:
       - uses: actions/checkout@v2

data/.gitignore

@@ -4,3 +4,4 @@ Gemfile.lock
 .rspec
 bin
 coverage/
+*gem

data/README.md

@@ -13,13 +13,14 @@
 - in `config/initializers/remote_webpacker.rb`
 
 ```rb
-REMOTE_WEBPACKER = Webpacker::Remote.new(uri: 'https://../manifest.json')
+REMOTE_WEBPACKER = Webpacker::Remote.new(root_path: 'https://asset_host/build/', config_path: 'manifest.json')
 ```
 
 - in `app/views/layouts/application.html.erb` (**not** `javascript_pack_tag`)
 
 ```rb
 <%= javascript_packs_with_chunks_tag 'main', webpacker: REMOTE_WEBPACKER %>
+#=> <script src='https://asset_host/build/static/js/main.2e302672.chunk.js'>
 ```
 
 Of course, you can use as many build as you like and do blue-green deployments using gems like `rollout`

data/lib/webpacker/remote.rb

@@ -8,6 +8,7 @@ require 'webpacker'
 class Webpacker::Remote < Webpacker::Instance
   require 'webpacker/remote/manifest'
   require 'webpacker/remote/configuration'
+  require 'webpacker/remote/helper'
 
   VERSION = '0.1.0'
 
@@ -16,13 +17,20 @@ class Webpacker::Remote < Webpacker::Instance
   attr_reader :public_manifest_content
 
   # fetch early, fail fast
-  def initialize(uri:, root_path: nil, config_path: nil) # rubocop:disable Lint/UnusedMethodArgument
-    super(root_path: nil, config_path: nil)
+  # rubocop:disable Lint/MissingSuper
+  def initialize(root_path: nil, config_path: nil)
+    uri = File.join(root_path.to_s, config_path.to_s)
     @public_manifest_content = JSON.parse(self.class.get_http_response(uri))
-    @root_path = @config_path = Pathname.new('/non-existing-path-for-ctor-compatibility')
+    # deliberately not calling `super` just emulating what's done there
+    @config_path = config_path
+    @root_path = root_path
   rescue StandardError => e
-    raise Error, "#{e.class}: #{e.message}"
+    raise Error, <<~MSG
+      having {root_path: #{root_path.inspect}, config_path: #{config_path.inspect}}
+      #{e.class}: #{e.message}
+    MSG
   end
+  # rubocop:enable Lint/MissingSuper
 
   def manifest
     @manifest ||= Webpacker::Remote::Manifest.new(self)

data/lib/webpacker/remote/helper.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+# better version of https://github.com/rails/webpacker/issues/2054#issuecomment-564173103
+# rewrite all methods by accept direct injection instead of calling `current_webpacker_instance`
+# because we can have same layout with script/link tags from different webpackers
+module Webpacker::Remote::Helper
+  METHODS = %i[
+    javascript_pack_tag
+    javascript_packs_with_chunks_tag
+    stylesheet_pack_tag
+    stylesheet_packs_with_chunks_tag
+  ].freeze
+
+  METHODS.each do |meth|
+    define_method meth do |*names, **options|
+      return super(*names, **options) unless options[:webpacker]
+
+      new_helper = dup
+      new_helper.define_singleton_method(:current_webpacker_instance) do
+        options[:webpacker]
+      end
+      new_helper.send(meth, *names, **options.except(:webpacker))
+    end
+  end
+end
+
+unless ENV['SKIP_WEBPACKER_HELPER_OVERRIDE']
+  require 'webpacker/helper'
+  Webpacker::Helper.prepend Webpacker::Remote::Helper
+end

data/lib/webpacker/remote/manifest.rb

@@ -6,4 +6,16 @@ class Webpacker::Remote::Manifest < Webpacker::Manifest
   def load
     @webpacker.public_manifest_content
   end
+
+  def lookup_pack_with_chunks(name, pack_type = {})
+    return unless (paths = super)
+
+    paths.map { |p| File.join(config.root_path.to_s, p) }
+  end
+
+  def lookup(name, pack_type = {})
+    return unless (path = super)
+
+    File.join(config.root_path.to_s, path)
+  end
 end

data/webpacker-remote.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = 'webpacker-remote'
-  spec.version       = '0.1.0'
+  spec.version       = '0.2.0'
   spec.authors       = ['Vlad Bokov']
   spec.email         = ['vlad@lunatic.cat']
   spec.license       = 'MIT'
@@ -20,9 +20,8 @@ Gem::Specification.new do |spec|
   end
   spec.require_paths = ['lib']
 
-  spec.add_dependency('webpacker', ENV.fetch('WEBPACKER_GEM_VERSION', '~> 5.2'))
+  spec.add_dependency('webpacker', ENV.fetch('WEBPACKER_GEM_VERSION', '< 6'))
 
   spec.add_development_dependency('rspec', '~> 3.0')
-  spec.add_development_dependency('rspec-expectations', '~> 3.0')
   spec.add_development_dependency('simplecov', '~> 0.19')
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: webpacker-remote
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Vlad Bokov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-12 00:00:00.000000000 Z
+date: 2021-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webpacker
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -38,20 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rspec-expectations
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -83,6 +69,7 @@ files:
 - Rakefile
 - lib/webpacker/remote.rb
 - lib/webpacker/remote/configuration.rb
+- lib/webpacker/remote/helper.rb
 - lib/webpacker/remote/manifest.rb
 - webpacker-remote.gemspec
 homepage: https://github.com/lunatic-cat/webpacker-remote