webpack-rails 0.9.9 → 0.9.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1eda41f8a2de63c4b9dd46b6d6cd17d68d448d51
-  data.tar.gz: 647d5fa7649c014b59f83f83f6bc215c650b4e6c
+  metadata.gz: d76732ad3ef23985457b10deac1256897b760c1c
+  data.tar.gz: 210e16a7fbac05a2ae55d1b65429d6b815d8d469
 SHA512:
-  metadata.gz: cf133061ab304c49203928d81ffec20ebe5fe7a466c98d97dbdc895a2cbc8927fb9a16faf5f8d3abc96521d0a8ac361229dbf2043a4ae4792b584add121882e0
-  data.tar.gz: 54f64553a2e5e18e819e384e0751aa6084e6fb869e430db2bf97174b120321a3d9d6c1a11ab655ea15d391b4661012a8ff83168cf1c89f76cdb062b1c59ab4f1
+  metadata.gz: 6699ca844fd6634ba50bfef7503e7356133f4bd43b8ea9e1b5e938eb6c8ef7a25f5a53ed0ed44d019192ba9bffa3033e3596e190728201550b5cfe876da68a0e
+  data.tar.gz: baa696f3ad7da465eae27ae318c8ef5a08f9bf463c0af5c11ec1c501fc3013de0f69566df92f2b7c5f61513f909cf0599d920b4ad496d13b889f7dc43091c442

data/README.md

@@ -4,7 +4,7 @@
 
 **webpack-rails** gives you tools to integrate Webpack in to an existing Ruby on Rails application.
 
-It will happily co-exist with sprockets but does not use it for production fingerprinting or asset serving. **webpack-rails** is designed with the assumption that if you're using Webpack you treat Javascript as a first-class citizen. This means that you control the webpack config, package.json, and use npm to install Webpack & its plugins.
+It will happily co-exist with sprockets but does not use it for production fingerprinting or asset serving. **webpack-rails** is designed with the assumption that if you're using Webpack you treat Javascript as a first-class citizen. This means that you control the webpack config, package.json, and use yarn to install Webpack & its plugins.
 
 In development mode [webpack-dev-server](http://webpack.github.io/docs/webpack-dev-server.html) is used to serve webpacked entry points and offer hot module reloading. In production entry points are built in to `public/webpack`. **webpack-rails** uses [stats-webpack-plugin](https://www.npmjs.com/package/stats-webpack-plugin) to translate entry points in to asset paths.
 
@@ -20,6 +20,7 @@ This gem has been tested against Rails 4.2 and Ruby 2.2. Earlier versions of Rai
 
 ### Installation
 
+  1. Install [yarn](https://yarnpkg.com/en/docs/install) if you haven't already
   1. Add `webpack-rails` to your gemfile
   1. Run `bundle install` to install the gem
   1. Run `bundle exec rails generate webpack_rails:install` to copy across example files

data/example/package.json

@@ -3,8 +3,8 @@
   "version": "0.0.1",
   "license": "MIT",
   "dependencies": {
-    "stats-webpack-plugin": "^0.2.1",
-    "webpack": "^1.9.11",
-    "webpack-dev-server": "^1.9.0"
+    "stats-webpack-plugin": "^0.4.3",
+    "webpack": "^1.14.0",
+    "webpack-dev-server": "^1.16.2"
   }
 }

data/lib/generators/webpack_rails/install_generator.rb

@@ -40,8 +40,8 @@ module WebpackRails
       end
     end
 
-    def run_npm_install
-      run "npm install" if yes?("Would you like us to run 'npm install' for you?")
+    def run_yarn_install
+      run "yarn install" if yes?("Would you like us to run 'yarn install' for you?")
     end
 
     def run_bundle_install

data/lib/tasks/webpack.rake

@@ -2,7 +2,7 @@ namespace :webpack do
   desc "Compile webpack bundles"
   task compile: :environment do
     ENV["TARGET"] = 'production' # TODO: Deprecated, use NODE_ENV instead
-    ENV["NODE_ENV"] = 'production'
+    ENV["NODE_ENV"] ||= 'production'
     webpack_bin = ::Rails.root.join(::Rails.configuration.webpack.binary)
     config_file = ::Rails.root.join(::Rails.configuration.webpack.config_file)
 

data/lib/webpack/rails/manifest.rb

@@ -26,7 +26,7 @@ module Webpack
       class << self
         # :nodoc:
         def asset_paths(source)
-          raise WebpackError, manifest["errors"] if manifest["errors"].present?
+          raise WebpackError, manifest["errors"] unless manifest_bundled?
 
           paths = manifest["assetsByChunkName"][source]
           if paths
@@ -42,6 +42,10 @@ module Webpack
 
         private
 
+        def manifest_bundled?
+          !manifest["errors"].any? { |error| error.include? "Module build failed" }
+        end
+
         def manifest
           if ::Rails.configuration.webpack.dev_server.enabled
             # Don't cache if we're in dev server mode, manifest may change ...
@@ -66,7 +70,7 @@ module Webpack
           port = ::Rails.configuration.webpack.dev_server.manifest_port
           http = Net::HTTP.new(host, port)
           http.use_ssl = ::Rails.configuration.webpack.dev_server.https
-          http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+          http.verify_mode = ::Rails.configuration.webpack.dev_server.https_verify_peer ? OpenSSL::SSL::VERIFY_PEER : OpenSSL::SSL::VERIFY_NONE
           http.get(dev_server_path).body
         rescue => e
           raise ManifestLoadError.new("Could not load manifest from webpack-dev-server at http://#{host}:#{port}#{dev_server_path} - is it running, and is stats-webpack-plugin loaded?", e)

data/lib/webpack/rails/version.rb

@@ -1,6 +1,6 @@
 module Webpack
   # :nodoc:
   module Rails
-    VERSION = "0.9.9"
+    VERSION = "0.9.10"
   end
 end

data/lib/webpack/railtie.rb

@@ -30,9 +30,11 @@ module Webpack
     config.webpack.dev_server.manifest_host = 'localhost'
     config.webpack.dev_server.manifest_port = 3808
 
-    config.webpack.dev_server.https = false # note - this will use OpenSSL::SSL::VERIFY_NONE
+    config.webpack.dev_server.https = false
+    # Below will default to 'true' in 1.0 release
+    config.webpack.dev_server.https_verify_peer = false
     config.webpack.dev_server.binary = 'node_modules/.bin/webpack-dev-server'
-    config.webpack.dev_server.enabled = !::Rails.env.production?
+    config.webpack.dev_server.enabled = ::Rails.env.development? || ::Rails.env.test?
 
     config.webpack.output_dir = "public/webpack"
     config.webpack.public_path = "webpack"

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: webpack-rails
 version: !ruby/object:Gem::Version
-  version: 0.9.9
+  version: 0.9.10
 platform: ruby
 authors:
 - Michael Pearson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-02 00:00:00.000000000 Z
+date: 2017-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.0
 description: Production-tested, JavaScript-first tooling to use webpack within your
   Rails application
 email: