webmock 1.8.6 → 3.14.0

data/spec/unit/request_execution_verifier_spec.rb

@@ -3,96 +3,204 @@ require 'spec_helper'
 describe WebMock::RequestExecutionVerifier do
   before(:each) do
     @verifier = WebMock::RequestExecutionVerifier.new
-    @request_pattern = mock(WebMock::RequestPattern, :to_s => "www.example.com")
+    @request_pattern = double(WebMock::RequestPattern, to_s: "www.example.com")
     @verifier.request_pattern = @request_pattern
-    WebMock::RequestRegistry.instance.stub(:to_s).and_return("executed requests")
+    allow(WebMock::RequestRegistry.instance).to receive(:to_s).and_return("executed requests")
     @executed_requests_info = "\n\nThe following requests were made:\n\nexecuted requests\n" + "="*60
   end
 
+  describe "description" do
+
+    it "reports the description" do
+      @verifier.expected_times_executed = 2
+      expect(@verifier.description).to eq "request www.example.com 2 times"
+    end
+
+    it "reports description correctly when expectation is 1 time" do
+      @verifier.expected_times_executed = 1
+      expect(@verifier.description).to eq "request www.example.com 1 time"
+    end
+
+    context "at_least_times_executed is set" do
+      it "reports description correctly when expectation at least 2 times" do
+        @verifier.at_least_times_executed = 2
+        expect(@verifier.description).to eq "request www.example.com at least 2 times"
+      end
+
+      it "reports description correctly when expectation is at least 3 times" do
+        @verifier.at_least_times_executed = 3
+        expect(@verifier.description).to eq "request www.example.com at least 3 times"
+      end
+    end
+
+    context "at_most_times_executed is set" do
+      it "reports description correctly when expectation is at most 2 times" do
+        @verifier.at_most_times_executed = 2
+        expect(@verifier.description).to eq "request www.example.com at most 2 times"
+      end
+
+      it "reports description correctly when expectation is at most 1 time" do
+        @verifier.at_most_times_executed = 1
+        expect(@verifier.description).to eq "request www.example.com at most 1 time"
+      end
+    end
+
+  end
 
   describe "failure message" do
 
-    it "should report failure message" do
+    it "reports the failure message" do
       @verifier.times_executed = 0
       @verifier.expected_times_executed = 2
       expected_text = "The request www.example.com was expected to execute 2 times but it executed 0 times"
-      expected_text << @executed_requests_info
-      @verifier.failure_message.should == expected_text
+      expected_text += @executed_requests_info
+      expect(@verifier.failure_message).to eq(expected_text)
     end
 
-    it "should report failure message correctly when executed times is one" do
+    it "reports failure message correctly when executed times is one" do
       @verifier.times_executed = 1
       @verifier.expected_times_executed = 1
       expected_text = "The request www.example.com was expected to execute 1 time but it executed 1 time"
-      expected_text << @executed_requests_info
-      @verifier.failure_message.should == expected_text
+      expected_text += @executed_requests_info
+      expect(@verifier.failure_message).to eq(expected_text)
+    end
+
+    context "at_least_times_executed is set" do
+      it "reports failure message correctly when executed times is one" do
+        @verifier.times_executed = 1
+        @verifier.at_least_times_executed = 2
+        expected_text = "The request www.example.com was expected to execute at least 2 times but it executed 1 time"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message).to eq(expected_text)
+      end
+
+      it "reports failure message correctly when executed times is two" do
+        @verifier.times_executed = 2
+        @verifier.at_least_times_executed = 3
+        expected_text = "The request www.example.com was expected to execute at least 3 times but it executed 2 times"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message).to eq(expected_text)
+      end
     end
 
+    context "at_most_times_executed is set" do
+      it "reports failure message correctly when executed times is three" do
+        @verifier.times_executed = 3
+        @verifier.at_most_times_executed = 2
+        expected_text = "The request www.example.com was expected to execute at most 2 times but it executed 3 times"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message).to eq(expected_text)
+      end
+
+      it "reports failure message correctly when executed times is two" do
+        @verifier.times_executed = 2
+        @verifier.at_most_times_executed = 1
+        expected_text = "The request www.example.com was expected to execute at most 1 time but it executed 2 times"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message).to eq(expected_text)
+      end
+    end
   end
 
   describe "negative failure message" do
 
-    it "should report failure message if it executed number of times specified" do
+    it "reports failure message if it executed number of times specified" do
       @verifier.times_executed = 2
       @verifier.expected_times_executed = 2
       expected_text = "The request www.example.com was not expected to execute 2 times but it executed 2 times"
-      expected_text << @executed_requests_info
-      @verifier.negative_failure_message.should == expected_text
+      expected_text += @executed_requests_info
+      expect(@verifier.failure_message_when_negated).to eq(expected_text)
     end
 
-    it "should report failure message when not expected request but it executed" do
+    it "reports failure message when not expected request but it executed" do
       @verifier.times_executed = 1
-      expected_text = "The request www.example.com was expected to execute 0 times but it executed 1 time"
-      expected_text << @executed_requests_info
-      @verifier.negative_failure_message.should == expected_text
+      expected_text = "The request www.example.com was not expected to execute but it executed 1 time"
+      expected_text += @executed_requests_info
+      expect(@verifier.failure_message_when_negated).to eq(expected_text)
+    end
+
+    context "at_least_times_executed is set" do
+      it "reports failure message correctly when executed times is one" do
+        @verifier.times_executed = 3
+        @verifier.at_least_times_executed = 2
+        expected_text = "The request www.example.com was not expected to execute at least 2 times but it executed 3 times"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message_when_negated).to eq(expected_text)
+      end
+
+      it "reports failure message correctly when executed times is two" do
+        @verifier.times_executed = 2
+        @verifier.at_least_times_executed = 2
+        expected_text = "The request www.example.com was not expected to execute at least 2 times but it executed 2 times"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message_when_negated).to eq(expected_text)
+      end
+    end
+
+    context "at_most_times_executed is set" do
+      it "reports failure message correctly when executed times is three" do
+        @verifier.times_executed = 2
+        @verifier.at_most_times_executed = 3
+        expected_text = "The request www.example.com was not expected to execute at most 3 times but it executed 2 times"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message_when_negated).to eq(expected_text)
+      end
+
+      it "reports failure message correctly when executed times is one" do
+        @verifier.times_executed = 1
+        @verifier.at_most_times_executed = 2
+        expected_text = "The request www.example.com was not expected to execute at most 2 times but it executed 1 time"
+        expected_text += @executed_requests_info
+        expect(@verifier.failure_message_when_negated).to eq(expected_text)
+      end
     end
 
   end
 
   describe "matches?" do
 
-    it "should succeed if request was executed expected number of times" do
-      WebMock::RequestRegistry.instance.
-        should_receive(:times_executed).with(@request_pattern).and_return(10)
+    it "succeeds if request was executed expected number of times" do
+      expect(WebMock::RequestRegistry.instance).
+        to receive(:times_executed).with(@request_pattern).and_return(10)
       @verifier.expected_times_executed = 10
-      @verifier.matches?.should be_true
+      expect(@verifier.matches?).to be_truthy
     end
 
-    it "should fail if request was not executed expected number of times" do
-      WebMock::RequestRegistry.instance.
-        should_receive(:times_executed).with(@request_pattern).and_return(10)
+    it "fails if request was not executed expected number of times" do
+      expect(WebMock::RequestRegistry.instance).
+        to receive(:times_executed).with(@request_pattern).and_return(10)
       @verifier.expected_times_executed = 5
-      @verifier.matches?.should be_false
+      expect(@verifier.matches?).to be_falsey
     end
 
   end
 
   describe "does_not_match?" do
 
-    it "should fail if request executed expected number of times" do
-      WebMock::RequestRegistry.instance.
-        should_receive(:times_executed).with(@request_pattern).and_return(10)
+    it "fails if request executed expected number of times" do
+      expect(WebMock::RequestRegistry.instance).
+        to receive(:times_executed).with(@request_pattern).and_return(10)
       @verifier.expected_times_executed = 10
-      @verifier.does_not_match?.should be_false
+      expect(@verifier.does_not_match?).to be_falsey
     end
 
-    it "should succeed if request was not executed at all and expected number of times was not set" do
-      WebMock::RequestRegistry.instance.
-        should_receive(:times_executed).with(@request_pattern).and_return(0)
-      @verifier.does_not_match?.should be_true
+    it "succeeds if request was not executed at all and expected number of times was not set" do
+      expect(WebMock::RequestRegistry.instance).
+        to receive(:times_executed).with(@request_pattern).and_return(0)
+      expect(@verifier.does_not_match?).to be_truthy
     end
 
-    it "should fail if request was executed and expected number of times was not set" do
-      WebMock::RequestRegistry.instance.
-        should_receive(:times_executed).with(@request_pattern).and_return(1)
-      @verifier.does_not_match?.should be_false
+    it "fails if request was executed and expected number of times was not set" do
+      expect(WebMock::RequestRegistry.instance).
+        to receive(:times_executed).with(@request_pattern).and_return(1)
+      expect(@verifier.does_not_match?).to be_falsey
     end
 
-    it "should succeed if request was not executed expected number of times" do
-      WebMock::RequestRegistry.instance.
-        should_receive(:times_executed).with(@request_pattern).and_return(10)
+    it "succeeds if request was not executed expected number of times" do
+      expect(WebMock::RequestRegistry.instance).
+        to receive(:times_executed).with(@request_pattern).and_return(10)
       @verifier.expected_times_executed = 5
-      @verifier.does_not_match?.should be_true
+      expect(@verifier.does_not_match?).to be_truthy
     end
 
   end