webmock 1.6.4 → 1.7.0

data/spec/net_http_spec.rb

@@ -2,13 +2,15 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 require 'webmock_shared'
 require 'ostruct'
 require 'net_http_spec_helper'
+require 'net_http_shared'
 
 include NetHTTPSpecHelper
 
 describe "Webmock with Net:HTTP" do
-
   it_should_behave_like "WebMock"
 
+  let(:port){ WebMockServer.instance.port }
+
   it "should work with block provided" do
     stub_http_request(:get, "www.example.com").to_return(:body => "abc"*100000)
     Net::HTTP.start("www.example.com") { |query| query.get("/") }.body.should == "abc"*100000
@@ -52,38 +54,18 @@ describe "Webmock with Net:HTTP" do
     }.should raise_error("both of body argument and HTTPRequest#body set")
   end
 
-  it "should handle real requests with readable body", :net_connect => true do
-    WebMock.allow_net_connect!
-    req = Net::HTTP::Post.new("/")
-    Net::HTTP.start("www.example.com") {|http|
-      http.request(req, StringIO.new("my_params"))
-    }.body.should =~ /^$/
-  end
-
-  it "should handle requests with block passed to read_body", :net_connect => true do
-    body = ""
-    WebMock.allow_net_connect!
-    req = Net::HTTP::Get.new("/")
-    Net::HTTP.start("www.example.com") do |http|
-      http.request(req) do |res|
-        res.read_body do |str|
-          body << str
-        end
-      end
-    end
-    body.should =~ /^$/
-  end
-
   it "should return a Net::ReadAdapter from response.body when a stubbed request is made with a block and #read_body" do
     WebMock.stub_request(:get, 'http://example.com/').to_return(:body => "the body")
     response = Net::HTTP.new('example.com', 80).request_get('/') { |r| r.read_body { } }
     response.body.should be_a(Net::ReadAdapter)
   end
 
-  it "should return a Net::ReadAdapter from response.body when a real request is made with a block and #read_body", :net_connect => true do
+  it "should have request 1 time executed in registry after 1 real request", :net_connect => true do
     WebMock.allow_net_connect!
-    response = Net::HTTP.new('example.com', 80).request_get('/') { |r| r.read_body { } }
-    response.body.should be_a(Net::ReadAdapter)
+    http = Net::HTTP.new('localhost', port)
+    http.get('/') {}
+    WebMock::RequestRegistry.instance.requested_signatures.hash.size.should == 1
+    WebMock::RequestRegistry.instance.requested_signatures.hash.values.first.should == 1
   end
 
   describe "connecting on Net::HTTP.start" do
@@ -107,6 +89,7 @@ describe "Webmock with Net:HTTP" do
           cert.should be_a(OpenSSL::X509::Certificate)
         }
       end
+
     end
 
     describe "when net http is disabled and allowed only for some hosts" do
@@ -127,8 +110,22 @@ describe "Webmock with Net:HTTP" do
     end
   end
 
+  describe "when net_http_connect_on_start is true" do
+    before(:each) do
+      WebMock.allow_net_connect!(:net_http_connect_on_start => true)
+    end
+    it_should_behave_like "Net::HTTP"
+  end
+
+  describe "when net_http_connect_on_start is false" do
+    before(:each) do
+      WebMock.allow_net_connect!(:net_http_connect_on_start => false)
+    end
+    it_should_behave_like "Net::HTTP"
+  end
+
   describe 'after_request callback support', :net_connect => true do
-    let(:expected_body_regex) { /^$/ }
+    let(:expected_body_regex) { /hello world/ }
 
     before(:each) do
       WebMock.allow_net_connect!
@@ -144,14 +141,14 @@ describe "Webmock with Net:HTTP" do
     end
 
     def perform_get_with_returning_block
-      http_request(:get, "http://www.example.com/") do |response|
+      http_request(:get, "http://localhost:#{port}/") do |response|
         return response.body
       end
     end
 
     it "should support the after_request callback on an request with block and read_body" do
       response_body = ''
-      http_request(:get, "http://www.example.com/") do |response|
+      http_request(:get, "http://localhost:#{port}/") do |response|
         response.read_body { |fragment| response_body << fragment }
       end
       response_body.should =~ expected_body_regex
@@ -167,9 +164,8 @@ describe "Webmock with Net:HTTP" do
     end
 
     it "should only invoke the after_request callback once, even for a recursive post request" do
-      Net::HTTP.new('example.com', 80).post('/', nil)
+      Net::HTTP.new('localhost', port).post('/', nil)
       @callback_invocation_count.should == 1
     end
   end
-
 end

data/spec/net_http_spec_helper.rb

@@ -8,14 +8,14 @@ module NetHTTPSpecHelper
     response = nil
     clazz = Net::HTTP.const_get("#{method.to_s.capitalize}")
     req = clazz.new("#{uri.path}#{uri.query ? '?' : ''}#{uri.query}", nil)
-    options[:headers].each do |k,v| 
+    options[:headers].each do |k,v|
       if v.is_a?(Array)
         v.each_with_index do |v,i|
           i == 0 ? (req[k] = v) : req.add_field(k, v)
         end
       else
         req[k] = v
-      end  
+      end
     end if options[:headers]
 
     req.basic_auth uri.user, uri.password if uri.user
@@ -34,11 +34,11 @@ module NetHTTPSpecHelper
     OpenStruct.new({
       :body => response.body,
       :headers => WebMock::Util::Headers.normalize_headers(headers),
-      :status => response.code, 
+      :status => response.code,
       :message => response.message
     })
   end
-  
+
   def client_timeout_exception_class
     Timeout::Error
   end
@@ -47,36 +47,6 @@ module NetHTTPSpecHelper
     Errno::ECONNREFUSED
   end
 
-  # Sets several expectations that a real HTTP request makes it
-  # past WebMock to the socket layer. You can use this when you need to check
-  # that a request isn't handled by WebMock
-  #This solution is copied from FakeWeb project
-  def setup_expectations_for_real_request(options = {})
-    # Socket handling
-    if options[:port] == 443
-      socket = mock("SSLSocket")
-      OpenSSL::SSL::SSLSocket.should_receive(:===).with(socket).at_least(:once).and_return(true)
-      OpenSSL::SSL::SSLSocket.should_receive(:new).with(socket, instance_of(OpenSSL::SSL::SSLContext)).at_least(:once).and_return(socket)
-      socket.stub!(:sync_close=).and_return(true)
-      socket.should_receive(:connect).at_least(:once).with()
-    else
-      socket = mock("TCPSocket")
-      Socket.should_receive(:===).with(socket).at_least(:once).and_return(true)
-    end
-
-    TCPSocket.should_receive(:open).with(options[:host], options[:port]).at_least(:once).and_return(socket)
-    socket.stub!(:closed?).and_return(false)
-    socket.stub!(:close).and_return(true)
-
-    # Request/response handling
-    request_parts = ["#{options[:method]} #{options[:path]} HTTP/1.1", "Host: #{options[:host]}"]
-    socket.should_receive(:write).with(/#{request_parts[0]}.*#{request_parts[1]}.*/m).and_return(100)
-    
-    read_method = RUBY_VERSION >= "1.9.2" ? :read_nonblock : :sysread
-    socket.should_receive(read_method).once.and_return("HTTP/1.1 #{options[:response_code]} #{options[:response_message]}\nContent-Length: #{options[:response_body].length}\n\n#{options[:response_body]}")
-    socket.should_receive(read_method).any_number_of_times.and_raise(EOFError)
-  end
-  
   def http_library
     :net_http
   end

data/spec/network_connection.rb

@@ -22,4 +22,4 @@ module NetworkConnection
       false
     end
   end
-end
+end

data/spec/patron_spec_helper.rb

@@ -11,15 +11,16 @@ module PatronSpecHelper
     sess.connect_timeout = 10
     sess.timeout = 10
     sess.max_redirects = 0
-   
-    response = sess.request(method, "#{uri.path}#{uri.query ? '?' : ''}#{uri.query}", options[:headers] || {}, {
+    uri = "#{uri.path}#{uri.query ? '?' : ''}#{uri.query}"
+    uri.gsub!(' ','+')
+    response = sess.request(method, uri, options[:headers] || {}, {
       :data => options[:body]
     })
     headers = {}
     if response.headers
       response.headers.each do |k,v|
         v = v.join(", ") if v.is_a?(Array)
-        headers[k] = v 
+        headers[k] = v
       end
     end
     OpenStruct.new({
@@ -38,10 +39,6 @@ module PatronSpecHelper
     Patron::ConnectionFailed
   end
 
-  def setup_expectations_for_real_request(options = {})
-    #TODO
-  end
-
   def http_library
     :patron
   end

data/spec/quality_spec.rb

@@ -0,0 +1,60 @@
+require "spec_helper"
+
+# Borrowed from Bundler
+# https://github.com/carlhuda/bundler/blob/1-0-stable/spec/quality_spec.rb
+describe "The library itself" do
+  def check_for_tab_characters(filename)
+    failing_lines = []
+    File.readlines(filename).each_with_index do |line,number|
+      failing_lines << number + 1 if line =~ /\t/
+    end
+
+    unless failing_lines.empty?
+      "#{filename} has tab characters on lines #{failing_lines.join(', ')}"
+    end
+  end
+
+  def check_for_extra_spaces(filename)
+    failing_lines = []
+    File.readlines(filename).each_with_index do |line,number|
+      next if line =~ /^\s+#.*\s+\n$/
+      failing_lines << number + 1 if line =~ /\s+\n$/
+    end
+
+    unless failing_lines.empty?
+      "#{filename} has spaces on the EOL on lines #{failing_lines.join(', ')}"
+    end
+  end
+
+  RSpec::Matchers.define :be_well_formed do
+    failure_message_for_should do |actual|
+      actual.join("\n")
+    end
+
+    match do |actual|
+      actual.empty?
+    end
+  end
+
+  it "has no malformed whitespace" do
+    error_messages = []
+    Dir.chdir(File.expand_path("../..", __FILE__)) do
+      `git ls-files`.split("\n").each do |filename|
+        next if filename =~ /\.gitmodules|fixtures/
+        error_messages << check_for_tab_characters(filename)
+        error_messages << check_for_extra_spaces(filename)
+      end
+    end
+    error_messages.compact.should be_well_formed
+  end
+
+  it "can still be built" do
+    Dir.chdir(File.expand_path('../../', __FILE__)) do
+      `gem build webmock.gemspec`
+      $?.should == 0
+
+      # clean up the .gem generated
+      system("rm webmock-#{WebMock.version}.gem")
+    end
+  end
+end

data/spec/rack_response_spec.rb

@@ -0,0 +1,33 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+describe WebMock::RackResponse do
+  before :each do
+    @rack_response = WebMock::RackResponse.new(MyRackApp)
+  end
+
+  it "should hook up to a rack appliance" do
+    request = WebMock::RequestSignature.new(:get, 'www.example.com')
+    response = @rack_response.evaluate(request)
+
+    response.status.first.should == 200
+    response.body.should include('This is my root!')
+  end
+
+  it "should send along params" do
+    request = WebMock::RequestSignature.new(:get, 'www.example.com/greet?name=Johnny')
+
+    response = @rack_response.evaluate(request)
+
+    response.status.first.should == 200
+    response.body.should include('Hello, Johnny')
+  end
+
+  it "should send along POST params" do
+    request = WebMock::RequestSignature.new(:post, 'www.example.com/greet',
+      :body => 'name=Jimmy'
+    )
+
+    response = @rack_response.evaluate(request)
+    response.body.should include('Good to meet you, Jimmy!')
+  end
+end

data/spec/real_net_http_spec.rb

@@ -0,0 +1,20 @@
+require 'rubygems'
+require 'rspec'
+require 'net/http'
+require 'net_http_shared'
+require 'net/https'
+require 'stringio'
+require 'support/webmock_server'
+
+describe "Real Net:HTTP without webmock", :without_webmock => true do
+  before(:all) do
+    raise "WebMock has no access here!!!" if defined?(WebMock::NetHTTPUtility)
+    WebMockServer.instance.start
+  end
+
+  after(:all) do
+    WebMockServer.instance.stop
+  end
+
+  it_should_behave_like "Net::HTTP"
+end

data/spec/request_execution_verifier_spec.rb

@@ -17,7 +17,7 @@ describe WebMock::RequestExecutionVerifier do
       @verifier.expected_times_executed = 2
       expected_text = "The request www.example.com was expected to execute 2 times but it executed 0 times"
       expected_text << @executed_requests_info
-      @verifier.failure_message.should == expected_text  
+      @verifier.failure_message.should == expected_text
     end
 
     it "should report failure message correctly when executed times is one" do
@@ -29,7 +29,7 @@ describe WebMock::RequestExecutionVerifier do
     end
 
   end
-  
+
   describe "negative failure message" do
 
     it "should report failure message if it executed number of times specified" do
@@ -66,26 +66,26 @@ describe WebMock::RequestExecutionVerifier do
     end
 
   end
-  
+
   describe "does_not_match?" do
 
     it "should fail if request executed expected number of times" do
       WebMock::RequestRegistry.instance.
         should_receive(:times_executed).with(@request_pattern).and_return(10)
       @verifier.expected_times_executed = 10
-      @verifier.does_not_match?.should be_false     
+      @verifier.does_not_match?.should be_false
     end
-    
+
     it "should succeed if request was not executed at all and expected number of times was not set" do
       WebMock::RequestRegistry.instance.
         should_receive(:times_executed).with(@request_pattern).and_return(0)
-      @verifier.does_not_match?.should be_true      
+      @verifier.does_not_match?.should be_true
     end
-    
+
     it "should fail if request was executed and expected number of times was not set" do
       WebMock::RequestRegistry.instance.
         should_receive(:times_executed).with(@request_pattern).and_return(1)
-      @verifier.does_not_match?.should be_false     
+      @verifier.does_not_match?.should be_false
     end
 
     it "should succeed if request was not executed expected number of times" do

data/spec/request_pattern_spec.rb

@@ -13,7 +13,7 @@ describe WebMock::RequestPattern do
       :body => "abc", :headers => {'A' => 'a', 'B' => 'b'}).with {|req| true}.to_s.should ==
     "GET http://www.example.com/ with body \"abc\" with headers {'A'=>'a', 'B'=>'b'} with given block"
   end
-  
+
   it "should report string describing itself with query params" do
     WebMock::RequestPattern.new(:get, /.*example.*/, :query => {'a' => ['b', 'c']}).to_s.should ==
     "GET /.*example.*/ with query params {\"a\"=>[\"b\", \"c\"]}"
@@ -140,12 +140,12 @@ describe WebMock::RequestPattern do
        WebMock::RequestPattern.new(:get, "www.example.com", :query => {"a" => ["b", "c"]}).
           should match(WebMock::RequestSignature.new(:get, "www.example.com?a[]=b&a[]=c"))
       end
-      
+
       it "should not match for query params are different than the declared in hash" do
        WebMock::RequestPattern.new(:get, "www.example.com", :query => {"a" => ["b", "c"]}).
           should_not match(WebMock::RequestSignature.new(:get, "www.example.com?x[]=b&a[]=c"))
       end
-      
+
       it "should match for query params are the same as declared as string" do
        WebMock::RequestPattern.new(:get, "www.example.com", :query => "a[]=b&a[]=c").
           should match(WebMock::RequestSignature.new(:get, "www.example.com?a[]=b&a[]=c"))

data/spec/request_stub_spec.rb

@@ -23,7 +23,7 @@ describe WebMock::RequestStub do
 
     it "should assign normalized headers to request pattern" do
       @request_stub.with(:headers => {'A' => 'a'})
-      @request_stub.request_pattern.to_s.should == 
+      @request_stub.request_pattern.to_s.should ==
         WebMock::RequestPattern.new(:get, "www.example.com", :headers => {'A' => 'a'}).to_s
     end
 
@@ -69,13 +69,13 @@ describe WebMock::RequestStub do
       @request_stub.response
       @request_stub.response.body.should == "def"
     end
-    
+
     it "should return responses in a sequence passed as comma separated params" do
       @request_stub.to_return({:body => "abc"}, {:body => "def"})
       @request_stub.response.body.should == "abc"
       @request_stub.response.body.should == "def"
     end
-    
+
     it "should return responses declared in multiple to_return declarations" do
       @request_stub.to_return({:body => "abc"}).to_return({:body => "def"})
       @request_stub.response.body.should == "abc"
@@ -92,7 +92,7 @@ describe WebMock::RequestStub do
         @request_stub.response.raise_error_if_any
       }.should raise_error(ArgumentError, "Exception from WebMock")
     end
-    
+
     it "should assign sequence of responses with response with exception to be thrown" do
       @request_stub.to_return(:body => "abc").then.to_raise(ArgumentError)
       @request_stub.response.body.should == "abc"
@@ -110,7 +110,7 @@ describe WebMock::RequestStub do
         @request_stub.response.raise_error_if_any
       }.should raise_error(IndexError, "Exception from WebMock")
     end
-    
+
     it "should raise exceptions declared in multiple to_raise declarations" do
        @request_stub.to_raise(ArgumentError).then.to_raise(IndexError)
         lambda {
@@ -122,7 +122,7 @@ describe WebMock::RequestStub do
     end
 
   end
-  
+
   describe "to_timeout" do
 
      it "should assign response with timeout" do
@@ -144,30 +144,30 @@ describe WebMock::RequestStub do
      end
 
    end
-  
-  
+
+
   describe "times" do
-    
+
     it "should give error if declared before any response declaration is declared" do
       lambda {
         @request_stub.times(3)
-       }.should raise_error("Invalid WebMock stub declaration. times(N) can be declared only after response declaration.")  
+       }.should raise_error("Invalid WebMock stub declaration. times(N) can be declared only after response declaration.")
     end
-    
+
     it "should repeat returning last declared response declared number of times" do
       @request_stub.to_return({:body => "abc"}).times(2).then.to_return({:body => "def"})
       @request_stub.response.body.should == "abc"
       @request_stub.response.body.should == "abc"
       @request_stub.response.body.should == "def"
     end
-    
+
     it "should repeat raising last declared exception declared number of times" do
       @request_stub.to_return({:body => "abc"}).times(2).then.to_return({:body => "def"})
       @request_stub.response.body.should == "abc"
       @request_stub.response.body.should == "abc"
       @request_stub.response.body.should == "def"
     end
-    
+
     it "should repeat returning last declared sequence of responses declared number of times" do
       @request_stub.to_return({:body => "abc"}, {:body => "def"}).times(2).then.to_return({:body => "ghj"})
       @request_stub.response.body.should == "abc"
@@ -176,23 +176,23 @@ describe WebMock::RequestStub do
       @request_stub.response.body.should == "def"
       @request_stub.response.body.should == "ghj"
     end
-    
+
     it "should return self" do
       @request_stub.to_return({:body => "abc"}).times(1).should == @request_stub
     end
-    
+
     it "should raise error if argument is not integer" do
       lambda {
          @request_stub.to_return({:body => "abc"}).times("not number")
-      }.should raise_error("times(N) accepts integers >= 1 only")  
+      }.should raise_error("times(N) accepts integers >= 1 only")
     end
-    
+
     it "should raise error if argument is < 1" do
       lambda {
         @request_stub.to_return({:body => "abc"}).times(0)
-      }.should raise_error("times(N) accepts integers >= 1 only")  
+      }.should raise_error("times(N) accepts integers >= 1 only")
     end
-    
+
   end
 
 end